Commits · 8b4c59fc8198624e4a1cb4e44814b7f40e1de91e · Linshizhi / V8

28 Feb, 2014 20 commits

Fix ARM/MIPS versions of r19607 · 8b4c59fc

jkummerow@chromium.org authored Feb 28, 2014

kNoCodeAgeSequenceLength is in bytes on ia32/x64, but in instructions on arm/mips.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/183893006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19617 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b4c59fc

Remove Script::SetData and the script_data parameter from Script::(Compile|New). · 55750b1c

marja@chromium.org authored Feb 28, 2014

This feature makes it possible to associate data with a script and get it back
when the script is compiled or when an event is handled. It was historically
used by Chromium Dev Tools, but not any more. It is not used by node.js.

Note: this has nothing to do with the preparse data, despite the confusing name.
The preparse data is passed as ScriptData*.

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/184403002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19616 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55750b1c

Remove bogus assertion regarding code marked for deopt. · 99c6ba13

yangguo@chromium.org authored Feb 28, 2014

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/178583003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99c6ba13

Fixed constant folding for Math.clz32. · e9273332

svenpanne@chromium.org authored Feb 28, 2014

LOG=y
BUG=347906
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/184353002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9273332

Make a64.release a quickcheck target · ba981e58

jochen@chromium.org authored Feb 28, 2014

I marked all tests as slow that take more than a minute on my machine.
With this, a64.release.quickcheck takes two minutes which is about as
fast as arm.optdebug.quickcheck.

BUG=none
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/183763008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19608 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ba981e58

Fail early when re-entering code that has been patched for lazy deopt · 85367a7d

jkummerow@chromium.org authored Feb 28, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/184373004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85367a7d

Update test262 to get test data from github · 6b23cd07

jochen@chromium.org authored Feb 28, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/184223002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19606 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b23cd07

When upgrading the test data twice, don't bail out because of an existing backup · 9d515242

jochen@chromium.org authored Feb 28, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/183853004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d515242

A JSArray may have a filler map in the elements pointer. · b1ffc790

mvstanton@chromium.org authored Feb 28, 2014

We already have code that expects this, but incorrectly asserted that the
filler map case would never happen when allocation folding is turned on.
However, even folding has it's limits, bailing out of continued folding
when the object size grows too large. Therefore, it's a general problem
when verifying JSArray objects, that we might encounter a filler map
in elements().

Discovered by ClusterFuzz crbug 347903.

R=hpayer@chromium.org
LOG=N
BUG=347903

Review URL: https://codereview.chromium.org/184493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19604 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b1ffc790

Evict from optimized code map in sync with removing from optimized functions list. · 5c186bb1

yangguo@chromium.org authored Feb 28, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/184443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19603 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c186bb1

parser: fix build on solaris · f524f51e

marja@chromium.org authored Feb 28, 2014

`FS` is defined in `regset.h` on solaris and smartos.

BUG=
R=ulan@chromium.org, danno@chromium.org

Review URL: https://codereview.chromium.org/176403004

Patch from Fedor Indutny <fedor.indutny@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19602 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f524f51e

Fix JSObject::PrintTransitions. · 70242fe3

bmeurer@chromium.org authored Feb 28, 2014

BUG=347912
LOG=y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/183683005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70242fe3

Fix representation generalization for doubles. · 38ca2629

hpayer@chromium.org authored Feb 28, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/184393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38ca2629

Delete the simulator when we don't need it anymore · 927e5605

jochen@chromium.org authored Feb 28, 2014

BUG=none
R=svenpanne@chromium.org, ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/180243010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19598 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

927e5605

The Array function must be looked up in the native context. · df988c7f

mvstanton@chromium.org authored Feb 28, 2014

Platforms x64, a64, arm and mips had the bug that the array function was looked
up in the global context instead of the native context. Fix this, restoring a
weakened assert in hydrogen along the way (by the fix for crbug 347528, which
helped find this case).

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/184383003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19597 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df988c7f

A64: fix cctest/test-assembler-a64 · 2aa5ac93

jochen@chromium.org authored Feb 28, 2014

The simulator now deletes its decoder in its dtor. Therefore, we must
always allocate the decoder on the heap.

BUG=none
R=ulan@chromium.org, jacob.bramley@arm.com
LOG=n

Review URL: https://codereview.chromium.org/183893005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aa5ac93

Get array_function from NativeContext · 98d1ceda

dcarney@chromium.org authored Feb 28, 2014

R=mvstanton@chromium.org
LOG=N
BUG=347528

Review URL: https://codereview.chromium.org/184173003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19595 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

98d1ceda

Fix handling of constant global variable assignments. · 5945f9eb

bmeurer@chromium.org authored Feb 28, 2014

BUG=347904
LOG=y
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/184303003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5945f9eb

Remove dead CompileOptimized() method from JSFunction. · 0a931631

titzer@chromium.org authored Feb 28, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/181253004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19593 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0a931631

Removed bogus ASSERT. · c4e90c15

svenpanne@chromium.org authored Feb 28, 2014

LOG=y
BUG=347542
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/183763007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c4e90c15

27 Feb, 2014 11 commits

HAllocate should never generate allocation code if the requested size does not... · 2ab83cf1

ishell@chromium.org authored Feb 27, 2014

HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included.

BUG=347543
LOG=N
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/180803005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19591 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ab83cf1

Runtime::RunMicrotask should silent return if no pending microtask work (rather than asserting) · d9a66ad9

rafaelw@chromium.org authored Feb 27, 2014

R=rossberg@chromium.org, rossberg
BUG=347532

Review URL: https://codereview.chromium.org/181013008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19588 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9a66ad9

Avoid normalizing global proxy for fuzzing purposes. · ce0f1b3d

verwaest@chromium.org authored Feb 27, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/183313002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19587 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce0f1b3d

Fix putting of prototype transitions. The length is also subject to GC, just like entry. · aa14020b

verwaest@chromium.org authored Feb 27, 2014

BUG=347536
LOG=n
R=danno@chromium.org

Review URL: https://codereview.chromium.org/183193003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19586 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aa14020b

Fix bogus assertion. · f1ad20d0

yangguo@chromium.org authored Feb 27, 2014

R=hpayer@chromium.org
BUG=347530

Review URL: https://codereview.chromium.org/183243002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f1ad20d0

Handle arguments objects in frame when materializing arguments · 05b98492

jarin@chromium.org authored Feb 27, 2014

R=mstarzinger@chromium.org
BUG=347262

Review URL: https://codereview.chromium.org/177293009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

05b98492

Fix bogus assertion in SetFastDoubleElements. · 6912a248

yangguo@chromium.org authored Feb 27, 2014

R=danno@chromium.org
BUG=347530
LOG=N

Review URL: https://codereview.chromium.org/181433016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6912a248

Fix for Clusterfuzz issue 343928. · b8f8cfab

mvstanton@chromium.org authored Feb 27, 2014

The problem was that the debugger didn't expect that a JSFunction could
have a GlobalContext, which it can with harmony scoping.

BUG=343928
R=yangguo@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/183103003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b8f8cfab

Revert "Better threaded fuzzing for TestFunctionCallOptimization" · 703536eb

dcarney@chromium.org authored Feb 27, 2014

This reverts commit 19567.

TBR=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/182893003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

703536eb

Implement and enable zapping of code space while sweeping. · 947a5e6b

mstarzinger@chromium.org authored Feb 27, 2014

R=danno@chromium.org, hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/181513004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

947a5e6b

Better threaded fuzzing for TestFunctionCallOptimization · 44da7452

dcarney@chromium.org authored Feb 27, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/182863002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19567 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44da7452

26 Feb, 2014 7 commits

Fix patch creation in merge-to-branch script. · f09b3db7

machenbach@chromium.org authored Feb 26, 2014

Patch white space got stripped, which lead to failures when applying the patch.

- Refine test to reveal the problem
- Create a separate method for retrieving the patch that doesn't strip white space

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/181603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19566 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f09b3db7

Refactoring: Deprecate optparse in push and merge scripts. · 2e01427c

machenbach@chromium.org authored Feb 26, 2014

- Deprecate optparse with argparse
- The tests include now options parsing by default: each test specifies the command-line args to parse rather than the options directly

This CL is split off from https://codereview.chromium.org/173983002/

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/181583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e01427c

A64: Hardwire the decoder and the simulator · 201436d4

jochen@chromium.org authored Feb 26, 2014

If one of --trace-sim --debug-sim or --log-instruction-stats flags is
given, we use the decoder dispatcher instead.

BUG=none
R=rodolph.perfetta@arm.com, ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/177533023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19564 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

201436d4

A64: Make the Decoder a template · 597a4b4d

jochen@chromium.org authored Feb 26, 2014

This will allow for replacing the dispatcher with a concrete decoder
visitor.

BUG=none
R=ulan@chromium.org, rodolph.perfetta@arm.com
LOG=n

Review URL: https://codereview.chromium.org/181253002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

597a4b4d

A64: Move the dispatching logic of the decoder to a separate class. · 662bb0cc

jochen@chromium.org authored Feb 26, 2014

BUG=none
R=ulan@chromium.org, rodolph.perfetta@arm.com
LOG=n

Review URL: https://codereview.chromium.org/181233002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19561 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

662bb0cc

A64: Decoder should not inherit from DecoderVisitor · 0d297e51

jochen@chromium.org authored Feb 26, 2014

BUG=none
R=ulan@chromium.org, rodolph.perfetta@arm.com
LOG=n

Review URL: https://codereview.chromium.org/177073013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d297e51

Add vi swap files to .gitignore · 5ce87611

jochen@chromium.org authored Feb 26, 2014

BUG=none
R=dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/181263002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19559 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5ce87611

25 Feb, 2014 2 commits

Fix for failing asserts in HBoundsCheck code generation on x64: index register... · 1ae7e8a1

ishell@chromium.org authored Feb 25, 2014

Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero extended.

BUG=345820
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/180013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1ae7e8a1

Revert "Use stability to only conditionally flush information from the CheckMaps table." · d5caeccc

verwaest@chromium.org authored Feb 25, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/180023002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19548 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5caeccc