- 20 May, 2019 8 commits
-
-
Yang Guo authored
Code that is being moved primarily deal with layout of a JSObject, accessing properties and elements, and map transitions. NOTREECHECKS=true NOTRY=true Bug: v8:9247 Change-Id: Ibce5d5926ac4021c8d40c4dd109948775ce1da58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613994 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61638}
-
Ujjwal Sharma authored
This is a reland of e7e512da Original change's description: > [turbofan] Add fast path for single-character String#startsWith() > > This CL adds a fast path to String#startsWith(s) if s is a > single character string. > > Bug: v8:8400 > Change-Id: Ibd6a9d1e46d98f41c198d2b579208e25003eedb0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525362 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61504} Bug: v8:8400 Change-Id: Ic2d60ccb8fdeb51373fcd025a7e970fda0c14d79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618342Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61637}
-
Benedikt Meurer authored
We disabled the `delete` optimization, where `delete` on a fast-mode object goes back in the transition tree, because that optimization didn't pay attention to constant field tracking. This change now does the proper fix, which is to invalidate the constness and properly deoptimize all code that depends on it. Drive-by-fix: Handlify the DeleteObjectPropertyFast helper. Bug: chromium:962588, chromium:963999, v8:9233 Change-Id: I5978c32a48d1635b3ce42dc08b00bb2654baa36a Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617251 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL also removes the ElementsAccessor "slice" implementation, as the runtime function is the last use site. R=verwaest@chromium.org Bug: v8:9183 Change-Id: If268e20120e7c7bb4a58d9560482b35896b0992f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617662Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61635}
-
Georg Neis authored
If speculation is disallowed, this change lets us still do the optimization if (a) the maps were already reliable or (b) we are able to take stability dependencies. Bug: v8:8820 Change-Id: I08340fc19ac87b80aa2b7ed77753dd642e89804f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617663Reviewed-by:
-
Benedikt Meurer authored
The --log-timer-events doesn't work anymore, since it cannot be enabled after the snapshot was created ever since the CallApiCallback stub was turned into a builtin. Bug: v8:9183 Change-Id: I6e0b92141f1986fc791943ffef42dd4961aea0a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617931 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:9183 Change-Id: I789295e5bbea682b2e46ccf5a55c69dc74f0ed72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617669 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61632}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/94dc55b..eaddee0 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1f329a6..9ea486b Rolling v8/buildtools/linux64: git_revision:64b846c96daeb3eaf08e26d8a84d8451c6cb712b..git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/aae7fec..5b1310e TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: If8fa5df7ce2c78a8eb0eb1753b84c96bef1cf262 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619147Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61631}
-
- 19 May, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0395ad5..94dc55b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2d0ea0b..aae7fec TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Icd2483f721844555c52d1212b8899b8971960020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618651Reviewed-by:
-
- 18 May, 2019 3 commits
-
-
Michael Achenbach authored
This reverts commit b9bfd006. Reason for revert: The updated formatter violates some existing files that now require new formatting: https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/4411 Original change's description: > [torque] Convert few class layout to torque and updated torque code formatter. > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > TemplateList, > JSStrictArgumentsObject to torque. > 2. Updated torque code formatter to now handle multi-line > declarations correctly. > > Bug: v8:8952 > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61624} TBR=jgruber@chromium.org,tebbi@chromium.org,surshar@microsoft.com,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8952 Change-Id: I98424deb8002ba9b92262c4b7a1f753bd7c4f7c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617927Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61629}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/747602a..0395ad5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fd64d5d..4d85003 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5737f02..cf6269b TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ie8a5530c9dd1598fbe11de0e3d834fd23fbaba62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618647Reviewed-by:
-
Johannes Henkel authored
New Revision: 8ec18cf0885bef0b5c2a922c5dc3813cbf63e962 Change-Id: I65e271066599ed1aa1f9f8281be5b76e424d548d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618159Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61627}
-
- 17 May, 2019 28 commits
-
-
Michael Lippautz authored
- Move generic pieces into MemoryController. - Keep V8's specific factor computations in HeapController. Bug: chromium:948807 Change-Id: I1c1fc0516a429b19ce6458f75888b3f9d51824ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617678 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61626}
-
Frank Tang authored
This is a reland of 3c2103bd The fix of the issue is in https://chromium-review.googlesource.com/c/v8/v8/+/1617674 Original change's description: > [Intl] Ship Intl.DateTimeFormat#formatRange > > Design Doc: https://goo.gl/PGUQ1d > Chrome Status: https://www.chromestatus.com/feature/5077134515109888 > I2S: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Nh-jMn8L8fQ/GQN6wQQVBQAJ > I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/WTAjjcXaraA/ZypbHTlEAQAJ > > Bug: v8:7729 > Change-Id: Ib3277c6a01546fd56418615087df497058edb8ae > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1604068 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61580} Bug: v8:7729 Change-Id: I1b556ca2aeff469c7655f89bd7813d86fcda8adf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617801 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61625}
-
Suraj Sharma authored
1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, TemplateList, JSStrictArgumentsObject to torque. 2. Updated torque code formatter to now handle multi-line declarations correctly. Bug: v8:8952 Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988Reviewed-by:Simon Zünd <szuend@chromium.org> Commit-Queue: Suraj Sharma <surshar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61624}
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:920557 Change-Id: If62b32188cadf1d0fa7b0809400462534c37acc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617925Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61623}
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:920557 Change-Id: I3d313959b9afa6116a0db3697ac1bd4382c0a82b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617924Reviewed-by:
-
Jakob Kummerow authored
deopt-unlinked.js: bytecode flushing destroys the information that %GetDeoptCount relies on, so turn that off for this test. cleanupsome-after-unregister.js: the function-local object {o} is assumed to be alive throughout the function, so make sure its live range (from the optimizing compiler's view) extends that far. Drive-by cleanup: drop some unnecessary casting boilerplate from Genesis::InitializeGlobal_harmony_intl_date_format_range(). Change-Id: I28617f842fe046dd0875a9a082cfc55a3a076bcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617674 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61621}
-
Johannes Henkel authored
New revision: 0aafd2876f7485db7b07c513c0457b7cbbbe3304 https://chromium.googlesource.com/deps/inspector_protocol/+/0aafd2876f7485db7b07c513c0457b7cbbbe3304 Change-Id: I6e9babc8401a5af3085cce81b963f288d0392c07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613478Reviewed-by:
-
Mythri A authored
es6/classes is slow to run in stress mode and times out on PPC. As a long term fix we should split this into multiple tests so each individual test runs faster. Bug: v8:9246 Change-Id: I95eed06d85f73cc66229dfbd83ac7521dcbbb54f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615252 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Mike Stanton authored
Fastpath failed to store the hole on the array left side. Bug: chromium:940274 Change-Id: I1eca7b241030474cf5aed6c68f155a1d22ae553e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617255 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61618}
-
Clemens Hammacher authored
This adds a counter for the time it takes per single code GC. It is sampled in all isolates whenever a GC finishes, and during regular JavaScript GC to also get samples for GCs that never finish (which we would need to fix). R=mstarzinger@chromium.org, mpearson@chromium.org Bug: v8:8217 Change-Id: I722d01b6bd7832c3af636362acfddeab7e8a485e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615250 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:9183 Change-Id: I773af2e44bbfb780a3cf375e6412274fe917d397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617250 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:9183 Change-Id: I392c7b7f90bf3025c726456237afdbf20f9ed3cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617666 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61615}
-
Michael Starzinger authored
This adds a constructor function to be used as the base class for all exported functions. With type reflection enabled exported functions are instances of this new constructor. Using the constructor directly as well as the 'type' property is still missing. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Id58359cf7866d24be0745abf36a839d3d86e5922 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617253 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
This is needed to build binaries for arm64 perf testers. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:920557 Change-Id: I77cea8389b62835a67f221ae26d6682a110ba609 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605947 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=jkummerow@chromium.org Change-Id: I961f77eb5e99a3d709aa5e948602a925f57ae090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617246Reviewed-by:
-
Clemens Hammacher authored
We currently have the problem that we trigger too many code GCs since {new_potentially_dead_code_size_} is never reset to zero. This CL adds a counter which tells us how many GCs we ran per native module. This counter is sampled on each code GC. It will give us a good understanding of the amount of GC work we are executing in the wild. The number should stay in the single-digits generally. R=mstarzinger@chromium.org, mpearson@chromium.org Bug: v8:8217 Change-Id: I978a98dff76e0f466ff51e067626886b58d52ded Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615246Reviewed-by: -
Simon Zünd authored
R=yangguo@chromium.org Bug: v8:9183 Change-Id: I0f06c9a32983f7131a36ace1fd6873e88e375fe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617259 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org Bug: v8:9247 Change-Id: I7ffc2bd4a5fdf7c20cc3283bb5545cbf9ffd4e53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617254Reviewed-by:
-
Santiago Aboy Solanes authored
Fixes the chromium bug 963891 Bug: chromium:963891 Change-Id: Ie90c9581044b7d10dd8fcd73d52bda5fdfead292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617248Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61608}
-
Sergiy Belozorov authored
The script does not have the shebang and apparently running it without 'python' on the command line produces some strange errors such as script trying to parse itself as a suite config. Making it non-executable will make it clear that users should prefix it with 'python' or 'vpython'. R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Change-Id: I1d4373b8846034cf28b5fd02e60e9ed682330706 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605942Reviewed-by:
-
Maya Lekova authored
NOTRY=true Bug: v8:9242, v8:9026 Change-Id: I4047d128913968c2e7d89f461881d84e0c22849c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617256 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 8e7945a6 Original Commit Message: Port 381a7f9e Original Commit Message: On Arm/64 the last return address is stored in a link register instead of being pushed to the top-of-stack like on x64/ia32. Extend the support in the tick sampler to check for samples in a frameless bytecode handler with support for checking the link register if it exists instead of top-of-stack. In addition, make the x64/ia32 check more robust by ensuring we only apply the change if the pc is a bytecode handler and the top frame isn't a bytecode handler (stub) frame. R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:9162 LOG=N Change-Id: I52c40f8d4ba1bb10049410417d1e60f95315489d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1614791Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
-
Benedikt Meurer authored
When TurboFan doesn't know anything about the receiver, it will generally insert a call via CallFunctionTemplate builtin, which does all the necessary checks. For this we don't need to be able to deoptimize, so there's no need to have the speculation bit available. This restores the performance in the case of calling API methods and accessors via `Function#call()`, i.e. like in this example: ```js const hasAttribute = Element.prototype.hasAttribute; // ... hasAttribute.call(element, "bar"); ``` Bug: v8:8820 Change-Id: Ic30719d7db75141023efc11d76180b001f871d28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615248 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61604}
-
Santiago Aboy Solanes authored
Skipping rather than reverting the CL that introduced the slowness, due to the fact that said CL is a Stable blocker fix. Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:9256 Change-Id: I8f8b57c415d2b54fe57c43a87e42990909295c57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615260Reviewed-by:
-
Simon Zünd authored
This CL extends Error.stack to include frames of functions declared with the C++ FunctionTemplate API. For example, "print" in d8. Two changes are necessary: - HandleApiCall and friends need to go through an BUILTIN_EXIT frame instead of an EXIT frame. The existing stack-trace machinery will then pick up FunctionTemplate frames without additional changes. - Turbofan doesn't go through HandleApiCall, but instead uses an ASM builtin to enter FunctionTemplate functions. A "marker" frame state is needed to include these frames in the stack trace. Note: This CL only includes these frames in Error.stack, but not (yet) in the stack-trace API (v8.h). Bug: v8:8742,v8:6802 Change-Id: Ic0631af883cf56e0d0122a2e0c54e36fed324d91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609835 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: -
Yang Guo authored
This reverts commit 5f285395. Reason for revert: presubmit failure Original change's description: > Move logging and diagnostics related source files > > This also introduces a COMMON_OWNERS file, which is derived from the > current top-level OWNERS file. It is to be used for parts of the > codebase that is not sensitive to domain-specific expertise. > > NOPRESUBMIT=true > TBR=verwaest@chromium.org > > Bug: v8:9247 > Change-Id: I34a5eaa7cb1509a80d15094a2aceedd62665b17c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613987 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61600} TBR=rmcilroy@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org Change-Id: I3827c3af4fd63b18aa48c49617f318a01746e813 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617247Reviewed-by:
-
Yang Guo authored
This also introduces a COMMON_OWNERS file, which is derived from the current top-level OWNERS file. It is to be used for parts of the codebase that is not sensitive to domain-specific expertise. NOPRESUBMIT=true TBR=verwaest@chromium.org Bug: v8:9247 Change-Id: I34a5eaa7cb1509a80d15094a2aceedd62665b17c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613987Reviewed-by:
-
Simon Zünd authored
The language server and unit tests pass in an empty output directory to signal that no C++ files should be generated. As these generation steps include some validations, they should also be included in language server and unit test compilation runs. This CL introduces a "dry run" flag on the ImplementationVisitor. Additionaly, the implementation visitor wraps the file writing functionality. In case of a dry-run, file writing becomes a no-op. R=sigurds@chromium.org Bug: v8:7793 Change-Id: Id699fdf0b35311ddd3c1f5419baa0237b40ddce4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617244Reviewed-by:
-
