- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 08 Sep, 2015 1 commit
-
-
jianghua.yjh authored
BUG= Review URL: https://codereview.chromium.org/1314253006 Cr-Commit-Position: refs/heads/master@{#30638}
-
- 12 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1289553002 Cr-Commit-Position: refs/heads/master@{#30126}
-
- 15 Jul, 2015 1 commit
-
-
epertoso authored
R=jochen@chromium.org LOG=y BUG= Review URL: https://codereview.chromium.org/1209403005 Cr-Commit-Position: refs/heads/master@{#29680}
-
- 25 Jun, 2015 1 commit
-
-
erikcorry authored
Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1204123003 Cr-Commit-Position: refs/heads/master@{#29290}
-
- 24 Jun, 2015 2 commits
-
-
machenbach authored
Revert of Extend big-disjunction optimization to case-independent regexps (patchset #5 id:80001 of https://codereview.chromium.org/1182783009/) Reason for revert: [Sheriff] Test times out now on msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2947 Original issue's description: > Extend big-disjunction optimization to case-independent regexps > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda > Cr-Commit-Position: refs/heads/master@{#29264} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1204013003 Cr-Commit-Position: refs/heads/master@{#29266}
-
erikcorry authored
R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1182783009 Cr-Commit-Position: refs/heads/master@{#29264}
-
- 10 Jun, 2015 1 commit
-
-
erikcorry authored
This change rewrites regexps like (ab|ac|z|ad|ae|af) into (a[b-f]|z). We can only reorder disjunctions like this for case-dependent regexps. For case-independent regexps, the disjunctions should be pre-sorted for best results. R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1180433003 Cr-Commit-Position: refs/heads/master@{#28902}
-
- 09 Jun, 2015 4 commits
-
-
erikcorry authored
Revert of Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (patchset #2 id:20001 of https://codereview.chromium.org/1174713002/) Reason for revert: Tree looks like a Christmas tree and this isn't helping Original issue's description: > Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 > > Original code review: https://codereview.chromium.org/1176453002/ > > TBR=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d > Cr-Commit-Position: refs/heads/master@{#28884} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1172893002 Cr-Commit-Position: refs/heads/master@{#28885}
-
erikcorry authored
Original code review: https://codereview.chromium.org/1176453002/ TBR=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1174713002 Cr-Commit-Position: refs/heads/master@{#28884}
-
erikcorry authored
Revert of Optimize trivial regexp disjunctions (patchset #10 id:180001 of https://codereview.chromium.org/1176453002/) Reason for revert: ASAN failure Original issue's description: > Optimize trivial regexp disjunctions > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/5f1f7c15b3207f6c51d187692690aeb09d3e36b5 > Cr-Commit-Position: refs/heads/master@{#28871} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1174603002 Cr-Commit-Position: refs/heads/master@{#28878}
-
erikcorry authored
R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1176453002 Cr-Commit-Position: refs/heads/master@{#28871}
-
- 24 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/663893004 Cr-Commit-Position: refs/heads/master@{#24868} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jul, 2014 1 commit
-
-
yangguo@chromium.org authored
This reverts r21960. R=jochen@chromium.org Review URL: https://codereview.chromium.org/422853005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/344513004 Patch from Jianghua Yang <jianghua.jhy@alibaba-inc.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21960 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
jochen@chromium.org authored
Verified that arm builds locally. BUG=none TBR=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/306473004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21512 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 2 commits
-
-
jochen@chromium.org authored
TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/297303004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21504 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Since both are jitted on some platforms and depend on codegen, they don't belong to the platform abstraction. At the same time, I can't put them to codegen.h, as this would introduce cyclic dependencies. BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/302563004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21502 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jan, 2014 1 commit
-
-
rossberg@chromium.org authored
Works around apparent scoping bug in VS, the only change to before being a method rename in the test suite: --- a/test/cctest/test-types.cc +++ b/test/cctest/test-types.cc @@ -153,7 +153,7 @@ struct ZoneRep { return reinterpret_cast<ZoneList<ZoneType*>*>(AsTagged(t)); } - static Zone* Region(Zone* zone, Isolate* isolate) { return zone; } + static Zone* ToRegion(Zone* zone, Isolate* isolate) { return zone; } }; @@ -168,7 +168,7 @@ struct HeapRep { static Object* AsConstant(Handle<Type> t) { return Box::cast(*t)->value(); } static FixedArray* AsUnion(Handle<Type> t) { return FixedArray::cast(*t); } - static Isolate* Region(Zone* zone, Isolate* isolate) { return isolate; } + static Isolate* ToRegion(Zone* zone, Isolate* isolate) { return isolate; } }; @@ -183,7 +183,7 @@ struct Tests : Rep { isolate(CcTest::i_isolate()), scope(isolate), zone(isolate), - T(Rep::Region(&zone, isolate), isolate) { + T(Rep::ToRegion(&zone, isolate), isolate) { } static void CheckEqual(TypeHandle type1, TypeHandle type2) { R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/143693003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jan, 2014 2 commits
-
-
rossberg@chromium.org authored
This reverts commit 4308974b16d1ee67d9f64d797c5ea64ffaab51df. TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/133353005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18545 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
More template magic FTW. R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/103743004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18543 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 May, 2013 1 commit
-
-
verwaest@chromium.org authored
InsertAt apparently inserts by moving the other elements... that does not work. Review URL: https://chromiumcodereview.appspot.com/14566007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Apr, 2013 1 commit
-
-
danno@chromium.org authored
std::sort is a template, so it can be inlined more aggressively. Also, it's O(n log n), while libc's qsort is O(n^2) BUG=2639 Review URL: https://codereview.chromium.org/14315005 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2013 1 commit
-
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/13932006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14280 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jan, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/11880018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
R=ulan@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11678006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13279 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:2340 Review URL: https://chromiumcodereview.appspot.com/11377158 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jun, 2012 1 commit
-
-
sanjoy@chromium.org authored
By passing around a Zone object explicitly we no longer need to do a TLS access at the sites that allocate memory from the current Zone. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10534006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jun, 2012 1 commit
-
-
sanjoy@chromium.org authored
This CL changes some parts of the code to explicitly pass around a Zone. Not passing in a zone is okay too (in fact most of v8 still doesn't), but that may incur a TLS lookup. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10443114 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 May, 2012 1 commit
-
-
alexeif@chromium.org authored
This allowed the following changes: - heap profiler now makes one pass less over the heap. - HeapEntriesMap does not allocate EntryInfo per each entry. - there's no need for an extra pass to set indexes before serialization. As a result snapshot taking time has reduced up to 2x times. Review URL: https://chromiumcodereview.appspot.com/10353010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11531 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2012 1 commit
-
-
yurys@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10006032 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Feb, 2012 1 commit
-
-
fschneider@chromium.org authored
For zone lists this avoids resizing and reduces overall allocation in most cases (especially for small lists). Review URL: https://chromiumcodereview.appspot.com/9323078 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10613 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Oct, 2011 1 commit
-
-
ulan@chromium.org authored
Handlified functions: CompileStoreField, CompileStoreGlobal, CompileStoreElement, CompileStorePolymorphic. Based on 8375053. R=kmillikin@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8393003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9791 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Oct, 2011 1 commit
-
-
ulan@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/8356041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9741 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Oct, 2011 1 commit
-
-
sgjesse@chromium.org authored
This is reapplying r9501 with this single change which seemed to be causing most (all) of the failures for r9501. --- a/src/debug.cc +++ b/src/debug.cc @@ -2230,6 +2230,7 @@ Debugger::Debugger(Isolate* isolate) compiling_natives_(false), is_loading_debugger_(false), never_unload_debugger_(false), + force_debugger_active_(true), message_handler_(NULL), debugger_unload_pending_(false), host_dispatch_handler_(NULL), R=kmillikin@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org//8337009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Oct, 2011 1 commit
-
-
sgjesse@chromium.org authored
TBR=kmillikin@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org//8101011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9502 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-