Commits · 8a6cbf0a8632f39bc5bf740db672aa543e3e0f88 · Linshizhi / V8

10 Dec, 2014 26 commits

Revert of Avoid number range holes in bitset types. (patchset #5 id:80001 of... · 8a6cbf0a

jarin authored Dec 10, 2014

Revert of Avoid number range holes in bitset types. (patchset #5 id:80001 of https://codereview.chromium.org/759013003/)

Reason for revert:
For breaking the waterfall (run-json-stringify test).

Original issue's description:
> Avoid number range holes in bitset types.
>
> BUG=

TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/794663002

Cr-Commit-Position: refs/heads/master@{#25756}

8a6cbf0a

Skip slow webkit/array-iterate-backwards in arm64.debug/gc-stress mode. · e51e86f4

ulan authored Dec 10, 2014

BUG=
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/795633002

Cr-Commit-Position: refs/heads/master@{#25755}

e51e86f4

Avoid number range holes in bitset types. · 4de4f74c

jarin authored Dec 10, 2014

BUG=

Review URL: https://codereview.chromium.org/759013003

Cr-Commit-Position: refs/heads/master@{#25754}

4de4f74c

Make d8 default to standard location for external snapshots. · a0a49f52

vogelheim authored Dec 10, 2014

This makes tests runnable with the external snapshot, and should be the
last step before enabling external snapshot on >=1 bots.

R=yangguo
BUG=

Review URL: https://codereview.chromium.org/780333004

Cr-Commit-Position: refs/heads/master@{#25753}

a0a49f52

Fix mirror-script and debug-script tests when using external natives. · 65006b85

vogelheim authored Dec 10, 2014

R=yangguo
BUG=

Review URL: https://codereview.chromium.org/792733003

Cr-Commit-Position: refs/heads/master@{#25752}

65006b85

Make loop assignment analysis a separate phase. · 0f9d98e0

mstarzinger authored Dec 10, 2014

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/770373003

Cr-Commit-Position: refs/heads/master@{#25751}

0f9d98e0

Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple... · 7d13ca27

ishell authored Dec 10, 2014

Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name."

Review URL: https://codereview.chromium.org/793453004

Cr-Commit-Position: refs/heads/master@{#25750}

7d13ca27

Disallow object/function templates when creating snapshots. · 25cfc5dc

yangguo authored Dec 10, 2014

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/791033002

Cr-Commit-Position: refs/heads/master@{#25749}

25cfc5dc

Consistently use "use strict" where possible. · f65a023f

yangguo authored Dec 10, 2014

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/789163002

Cr-Commit-Position: refs/heads/master@{#25748}

f65a023f

Extract non-IO part of mksnapshot into an API method. · d28b2a19

yangguo authored Dec 10, 2014

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/789213002

Cr-Commit-Position: refs/heads/master@{#25747}

d28b2a19

MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''. · 30f2578c

balazs.kilvady authored Dec 10, 2014

Fix d2e54925

In 'MIPS: Change CmpWeakValue to a more MIPS like GetWeakValue.'
a25003cf
we switched to use GetWeakValue.

BUG=

Review URL: https://codereview.chromium.org/782273004

Cr-Commit-Position: refs/heads/master@{#25746}

30f2578c

Use nobarrier load in store buffer duplicate removal to annotate harmless race. · 071a2860
hpayer authored Dec 10, 2014
```
BUG=

Review URL: https://codereview.chromium.org/787383002

Cr-Commit-Position: refs/heads/master@{#25745}
```
071a2860

fix gcmole warning after r25737 · 70caf05b

dcarney authored Dec 10, 2014

TBR=jkummerow@chromium.org

BUG=

Review URL: https://codereview.chromium.org/794563002

Cr-Commit-Position: refs/heads/master@{#25744}

70caf05b

[turbofan] Fix cycles introduced by pushing ToNumbers into phis. · f6849d9e

Benedikt Meurer authored Dec 10, 2014

TEST=cctest
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/790123002

Cr-Commit-Position: refs/heads/master@{#25743}

f6849d9e

[turbofan] update register allocator with auto, nullptr and ZoneVector · 59753fb9
dcarney authored Dec 10, 2014
```
BUG=

Review URL: https://codereview.chromium.org/789083005

Cr-Commit-Position: refs/heads/master@{#25742}
```
59753fb9
Reland "Use same blob format for internal and external snapshots." · 7cff32a9
yangguo authored Dec 10, 2014
```
Review URL: https://codereview.chromium.org/791723004

Cr-Commit-Position: refs/heads/master@{#25741}
```
7cff32a9

Reland "[turbofan] Fix control reducer bug with NTLs." · 9a823cf6

titzer authored Dec 10, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/789083004

Cr-Commit-Position: refs/heads/master@{#25740}

9a823cf6

Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs' · d2e54925

ulan authored Dec 10, 2014

BUG=v8:3663
LOG=N

Review URL: https://codereview.chromium.org/792543003

Cr-Commit-Position: refs/heads/master@{#25739}

d2e54925

Reland 'Do not embed constant functions in StoreTransition stub.' · 3834b784

ulan authored Dec 10, 2014

BUG=v8:3629
LOG=N

Review URL: https://codereview.chromium.org/787153002

Cr-Commit-Position: refs/heads/master@{#25738}

3834b784

ExecutableAccessorInfo::clear_setter should set a null foreign pointer · ea11ffc6

dcarney authored Dec 10, 2014

R=jkummerow@chromium.org
BUG=433458
LOG=N

Review URL: https://codereview.chromium.org/759683004

Cr-Commit-Position: refs/heads/master@{#25737}

ea11ffc6

[turbofan] delay inserting spill slots for parent ranges. · aae66586

dcarney authored Dec 10, 2014

R=jarin@chromium.org,

BUG=

Review URL: https://codereview.chromium.org/785993002

Cr-Commit-Position: refs/heads/master@{#25736}

aae66586

Add Array.prototype.includes · 4161b54d

d authored Dec 10, 2014

Requires adding a SameValueZero implementation.

LOG=Y
BUG=v8:3575
R=dslomov@chromium.org, arv@chromium.org
TEST=added to test262

Review URL: https://codereview.chromium.org/771863002

Cr-Commit-Position: refs/heads/master@{#25735}

4161b54d

Rename shadowing `pos` variable in ParseTemplateLiteral() · 017eace7

caitpotter88 authored Dec 10, 2014

LOG=N
R=dslomov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/785233005

Cr-Commit-Position: refs/heads/master@{#25734}

017eace7

Pass --noharmony-scoping to tests validating that we throw on 'const' in strict mode. · 008405f0

dslomov authored Dec 10, 2014

R=marja@chromium.org
BUG=v8:2198
LOG=N

Review URL: https://codereview.chromium.org/784323002

Cr-Commit-Position: refs/heads/master@{#25733}

008405f0

Fix messages tests. · 6751f043

dslomov authored Dec 10, 2014

Change tests so that message location is stable under --debug-code.

R=yangguo@chromium.org
BUG=v8:3744
LOG=N

Review URL: https://codereview.chromium.org/792563003

Cr-Commit-Position: refs/heads/master@{#25732}

6751f043

[x64] Fix optimization for certain checked load/stores. · 19418d76

Benedikt Meurer authored Dec 10, 2014

BUG=chromium:439743
LOG=y
TEST=mjsunit
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/733893008

Cr-Commit-Position: refs/heads/master@{#25731}

19418d76

09 Dec, 2014 14 commits

Revert "[turbofan] Fix control reducer bug with NTLs." · a068503b

Ben L. Titzer authored Dec 09, 2014

This reverts commit aeda76c5.

Reason: exposed other TurboFan bugs.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/785233003

Cr-Commit-Position: refs/heads/master@{#25730}

a068503b

Revert of Use same blob format for internal and external snapshots. (patchset... · da6dbe78

machenbach authored Dec 09, 2014

Revert of Use same blob format for internal and external snapshots. (patchset #2 id:20001 of https://codereview.chromium.org/787033002/)

Reason for revert:
[sheriff] breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1293

Original issue's description:
> Use same blob format for internal and external snapshots.
>
> R=vogelheim@chromium.org

TBR=vogelheim@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/792563002

Cr-Commit-Position: refs/heads/master@{#25729}

da6dbe78

Revert of Do not embed constant functions in StoreTransition stub. (patchset... · d9de2aaa

yangguo authored Dec 09, 2014

Revert of Do not embed constant functions in StoreTransition stub. (patchset #3 id:40001 of https://codereview.chromium.org/769733003/)

Reason for revert:
GC stress failure: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress%20-%201/builds/1038

Original issue's description:
> Do not embed constant functions in StoreTransition stub.
>
> BUG=v8:3629
> LOG=N

TBR=ishell@google.com,ishell@chromium.org,ulan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3629

Review URL: https://codereview.chromium.org/785253002

Cr-Commit-Position: refs/heads/master@{#25728}

d9de2aaa

Use same blob format for internal and external snapshots. · 03ba4bec

yangguo authored Dec 09, 2014

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/787033002

Cr-Commit-Position: refs/heads/master@{#25727}

03ba4bec

Do not embed constant functions in StoreTransition stub. · 876a1ddd

ulan authored Dec 09, 2014

BUG=v8:3629
LOG=N

Review URL: https://codereview.chromium.org/769733003

Cr-Commit-Position: refs/heads/master@{#25726}

876a1ddd

[turbofan] Fix control reducer bug with NTLs. · aeda76c5

titzer authored Dec 09, 2014

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/789773002

Cr-Commit-Position: refs/heads/master@{#25725}

aeda76c5

Fix a typo error. · 56f8ba13

chunyang.dai authored Dec 09, 2014

This error is introduced by baafb8f9.

BUG=

Review URL: https://codereview.chromium.org/791543003

Cr-Commit-Position: refs/heads/master@{#25724}

56f8ba13

Make it possible to turn on OBJECT_PRINT without DEBUG · 581747c8

jochen authored Dec 09, 2014

BUG=none
R=machenbach@chromium.org
LOG=n
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/771323006

Cr-Commit-Position: refs/heads/master@{#25723}

581747c8

[x86] Disable invalid checked load/store optimization. · 48a6766e

Benedikt Meurer authored Dec 09, 2014

TEST=mjsunit/compiler/regress-lena
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/784153006

Cr-Commit-Position: refs/heads/master@{#25722}

48a6766e

Really enable DEBUG code on android unless full debug is specified · 93f35310

jochen authored Dec 09, 2014

R=machenbach@chromium.rg
LOG=n
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/786203003

Cr-Commit-Position: refs/heads/master@{#25721}

93f35310

Also ignore NDEBUG for chromium code · 7216f37c

jochen authored Dec 09, 2014

BUG=none
R=machenbach@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/792513002

Cr-Commit-Position: refs/heads/master@{#25720}

7216f37c

Temporarily restore make dependencies · 8a7a8114

jochen authored Dec 09, 2014

We will remove dependencies in about a week again.

BUG=none
R=machenbach@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/733203008

Cr-Commit-Position: refs/heads/master@{#25719}

8a7a8114

[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators. · baafb8f9

bmeurer authored Dec 09, 2014

Also fix the pushing of JSToBoolean into Phis and generalize it to
also include pushing into Selects.

TEST=cctest,unittests

Review URL: https://codereview.chromium.org/792463003

Cr-Commit-Position: refs/heads/master@{#25718}

baafb8f9

Make --no-turbo-types work on all paths through the pipeline. · 8acf3876

mstarzinger authored Dec 09, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/785933002

Cr-Commit-Position: refs/heads/master@{#25717}

8acf3876