1. 24 Nov, 2017 1 commit
  2. 17 Nov, 2017 1 commit
    • Jakob Gruber's avatar
      Revert "[coverage] add coverage for binary expressions" · 9037639e
      Jakob Gruber authored
      This reverts commit 4d3bc552.
      
      Reason for revert: https://crbug.com/785778
      
      Original change's description:
      > [coverage] add coverage for binary expressions
      > 
      > Adds block-level coverage tracking for binary && and ||
      > expressions. Introduces a BinaryOperation source-range
      > for tracking the operations themselves and an Expression
      > source-range, used for tracking NaryLogical expressions.
      > 
      > This builds on work by jgruber@chromium.org in
      > the issue.
      > 
      > TBR=marja@chromium.org
      > R=​jgruber@chromium.org, rmcilroy@chromium.org
      > 
      > Bug: v8:6660
      > Change-Id: I83a81f13a3514a734c06948b2d3e91138fb00e18
      > Reviewed-on: https://chromium-review.googlesource.com/754564
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49304}
      
      TBR=rmcilroy@chromium.org,marja@chromium.org,jgruber@chromium.org,ben@npmjs.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:6660
      Change-Id: Ie017c528604b2e01400f527511413eaea5786198
      Reviewed-on: https://chromium-review.googlesource.com/776768Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49454}
      9037639e
  3. 10 Nov, 2017 1 commit
  4. 16 Oct, 2017 1 commit
  5. 30 Aug, 2017 1 commit
    • Adam Klein's avatar
      [ast] Make CaseClause a plain ZoneObject, not an Expression · de046f5f
      Adam Klein authored
      CaseClause never made sense as an Expression; this CL allows us to
      remove several UNREACHABLEs and slim down the representation of
      CaseClause by removing its source position (which was only used
      in prettyprinting).
      
      The only real fallout of this change is that SourceRangeMap now
      stores its keys as ZoneObject*, rather than AstNode*, but since
      there's already compile time typechecking for inserting items
      into the map this shouldn't cause any ill effects.
      
      While modifying CaseClause, also removed the dead body_target()
      accessor (and related member variable). Thus this CL overall
      reduces the memory needed for each CaseClause by two words.
      
      Bug: v8:6092
      Change-Id: I0021c0590a69e29305c41ec6105c8824ae0cc25b
      Reviewed-on: https://chromium-review.googlesource.com/639316Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47722}
      de046f5f
  6. 27 Jul, 2017 1 commit
  7. 26 Jul, 2017 1 commit
  8. 14 Jul, 2017 1 commit
  9. 13 Jul, 2017 1 commit
  10. 12 Jul, 2017 1 commit