- 01 Jun, 2016 1 commit
-
-
franzih authored
These functions call into C++ anyways, so there's no need to have the JavaScript wrapper around them. This commit removes uri.js completely. R=yangguo@chromium.org, bmeurer@chromium.org BUG=v8:4912 Review-Url: https://codereview.chromium.org/2027003002 Cr-Commit-Position: refs/heads/master@{#36629}
-
- 31 May, 2016 6 commits
-
-
machenbach authored
Revert of [heap] Do not invoke GC to make heap iterable. (patchset #3 id:40001 of https://codereview.chromium.org/1992913004/ ) Reason for revert: [Sheriff] Speculative revert for some flakes on the waterfall: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/7409 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/7983 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/4901 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > This reverts commit 0aa3707d. > > And removes the UnreachableObjectsFilter. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/132f89800f560190b4d655adcb4e0eeedd17fd82 > Cr-Commit-Position: refs/heads/master@{#36617} TBR=yangguo@chromium.org,ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Review-Url: https://codereview.chromium.org/2020363002 Cr-Commit-Position: refs/heads/master@{#36622}
-
littledan authored
Async functions are built out of generators, but the SharedFunctionInfo returns false for is_generator. is_resumable is the broader query. This patch fixes many parts of V8 to refer to is_resumable as appropriate. One incidental change is to remove a check for generators extending classes. This is part of a general check for constructors being the only thing which can extend classes, so it is removed here and the error message for the general case is made more accurate. BUG=v8:4483 Review-Url: https://codereview.chromium.org/1996943002 Cr-Commit-Position: refs/heads/master@{#36621}
-
hpayer authored
This reverts commit 0aa3707d. And removes the UnreachableObjectsFilter. BUG=chromium:580959 LOG=n Review-Url: https://codereview.chromium.org/1992913004 Cr-Commit-Position: refs/heads/master@{#36617}
-
bmeurer authored
When we moved the String.fromCharCode builtin to C++, we slightly regressed the fast single character code argument case. Recovered some of the performance by implementing the builtin using the TurboFan CodeStubAssembler. Drive-by-fix: Make sure the stack trace from the implicit ToNumber conversion in String.fromCharCode includes the builtin by adding a regression test for that. R=yangguo@chromium.org BUG=chromium:609831,chromium:613947,v8:5049 Review-Url: https://codereview.chromium.org/2021143003 Cr-Commit-Position: refs/heads/master@{#36611}
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2026643003 Cr-Commit-Position: refs/heads/master@{#36610}
-
yangguo authored
R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2026563002 Cr-Commit-Position: refs/heads/master@{#36604}
-
- 30 May, 2016 4 commits
-
-
cbruni authored
Expose more or less the full functionality of the KeyAccumulator in the API: - use the PropertyFilter introduced for GetOwnPropertyNames - use KeyCollectionLimit for OWN_ONLY or INLCUDE_PROTOS - use IndexFilter to eithe SKIP_INDICES or INCLUDE_INDICES Rewire Object::GetOwnPropertyNames to use GetPropertyNames. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2002203002 Cr-Commit-Position: refs/heads/master@{#36595}
-
clemensh authored
Before, it was possible to construct invalid CallSite objects, which would trigger a runtime assert when any function is called on it. This check ensures to throw a TypeError when invalid information is passed to the CallSite constructor. This reverts part of this CL: https://codereview.chromium.org/2006603002 R=ishell@chromium.org, titzer@chromium.org, yangguo@chromium.org BUG=chromium:614295 Review-Url: https://codereview.chromium.org/2010493002 Cr-Commit-Position: refs/heads/master@{#36578}
-
machenbach authored
Revert of [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. (patchset #2 id:20001 of https://codereview.chromium.org/2018983002/ ) Reason for revert: Please rebase blink first (if intended): https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7092 Original issue's description: > [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. > > These builtins always call into C++ anyways and so there's no point in > having the JavaScript wrapper around them, but instead they can be > implemented as C++ builtins directly. > > R=franzih@chromium.org > BUG=v8:5049 > > Committed: https://crrev.com/4e66888869bf04c73b41e5747e4595747a7b20df > Cr-Commit-Position: refs/heads/master@{#36569} TBR=franzih@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5049 Review-Url: https://codereview.chromium.org/2023753002 Cr-Commit-Position: refs/heads/master@{#36572}
-
bmeurer authored
These builtins always call into C++ anyways and so there's no point in having the JavaScript wrapper around them, but instead they can be implemented as C++ builtins directly. R=franzih@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2018983002 Cr-Commit-Position: refs/heads/master@{#36569}
-
- 27 May, 2016 5 commits
-
-
bmeurer authored
These builtins do call into C++ anyways, so there's no point in keeping the JavaScript wrappers for them. R=franzih@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2018963002 Cr-Commit-Position: refs/heads/master@{#36553}
-
bmeurer authored
This was initially used to special case some weird date.js behavior, but has since been abused in other areas. In case of the string character access, everything that is outside the Smi range cannot be a valid string index anyways, so %NumberToSmi is perfect here in either case, and for ToPositiveInteger it's better to just use ToInteger adding +0 to turn -0 into +0. R=ishell@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2010183003 Cr-Commit-Position: refs/heads/master@{#36545}
-
franzih authored
Rewrite decodeURI and decodeURIComponent as builtin functions and install them in the bootstrapper. Delete unused runtime functions: - TruncateString - NewString - OneByteSeqStringGetChar - OneByteSeqStringSetChar - TwoByteSeqStringGetChar - TwoByteSeqStringSetChar Add regression test for decoding large strings. Clusterfuzz detected a problem with %TruncateString, see https://bugs.chromium.org/p/chromium/issues/detail?id=612109#c6 This is automatically fixed by this rewrite because %TruncateString is deleted anyways. Crude benchmark on 585 decodeURI and decodeURIComponent tests averaged over five runs: * builtin functions real 0m9.69s user 2m39.8816s sys 0m12.6398s * JS functions calling into the runtime e.g., for %TruncateString real 0m11.0598s user 3m6.7026s sys 0m13.5756s By running: $ time tools/run-tests.py --arch=x64 --mode=Release --buildbot test262/built-ins/decodeURI* mjsunit/uri >>> Running tests for x64.Release BUG=v8:4912, chromium:612109 R=yangguo@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1994733003 Cr-Commit-Position: refs/heads/master@{#36543}
-
bmeurer authored
This intrinsic (and the matching runtime entry) are no longer used by now and can thereby be removed. BUG=v8:5049 Review-Url: https://codereview.chromium.org/2016993003 Cr-Commit-Position: refs/heads/master@{#36540}
-
mvstanton authored
We get less "pollution" of type feedback if we have one vector per native context, rather than one for the whole system. This CL moves the vector appropriately. BUG= Review-Url: https://codereview.chromium.org/1906823002 Cr-Commit-Position: refs/heads/master@{#36539}
-
- 25 May, 2016 4 commits
-
-
yangguo authored
R=cbruni@chromium.org Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb Cr-Commit-Position: refs/heads/master@{#36499} Review-Url: https://codereview.chromium.org/2010533002 Cr-Commit-Position: refs/heads/master@{#36514}
-
yangguo authored
Revert of [json] support replacer function in BasicJsonStringifier. (patchset #4 id:60001 of https://codereview.chromium.org/2010533002/ ) Reason for revert: Layout test failure: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7029 Original issue's description: > [json] support replacer function in BasicJsonStringifier. > > R=cbruni@chromium.org > > Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb > Cr-Commit-Position: refs/heads/master@{#36499} TBR=cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2008293002 Cr-Commit-Position: refs/heads/master@{#36512}
-
cbruni authored
Reland of [keys] Simplify KeyAccumulator (patchset #1 id:1 of https://codereview.chromium.org/2010593002/ ) Reason for revert: relanding, fixed handle dereferencing Original issue's description: > Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) > > Reason for revert: > https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 > > Original issue's description: > > [keys] Simplify KeyAccumulator > > > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > > - Revert KeyAccumulator to single OrderedHashSet implementation. > > - Convert the OrderedHashSet in-place to a FixedArray > > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > > > BUG= > > > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > > Cr-Commit-Position: refs/heads/master@{#36485} > > TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/893524b53d43df63bca6cb9b7244d21771fadb0b > Cr-Commit-Position: refs/heads/master@{#36486} TBR=jkummerow@chromium.org,verwaest@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2014523002 Cr-Commit-Position: refs/heads/master@{#36502}
-
yangguo authored
R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2010533002 Cr-Commit-Position: refs/heads/master@{#36499}
-
- 24 May, 2016 8 commits
-
-
machenbach authored
Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 Original issue's description: > [keys] Simplify KeyAccumulator > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > - Revert KeyAccumulator to single OrderedHashSet implementation. > - Convert the OrderedHashSet in-place to a FixedArray > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > BUG= > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > Cr-Commit-Position: refs/heads/master@{#36485} TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2010593002 Cr-Commit-Position: refs/heads/master@{#36486}
-
cbruni authored
- Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys - Revert KeyAccumulator to single OrderedHashSet implementation. - Convert the OrderedHashSet in-place to a FixedArray - IndexedInterceptor indices are no longer combined and sorted with the object indices BUG= Review-Url: https://codereview.chromium.org/1995263002 Cr-Commit-Position: refs/heads/master@{#36485}
-
mstarzinger authored
This fixes the SharedFunctionInfo::num_literals field for global builtin functions (e.g. {Object} and friends) to be accurate. The field was not being updated by Runtime_SetCode. It also removes the dangerous and by now obsolete JSFunction::NumberOfLiterals accessor. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2007943002 Cr-Commit-Position: refs/heads/master@{#36480}
-
yangguo authored
R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2004413002 Cr-Commit-Position: refs/heads/master@{#36478}
-
yangguo authored
R=franzih@chromium.org Review-Url: https://codereview.chromium.org/2006673002 Cr-Commit-Position: refs/heads/master@{#36470}
-
jgruber authored
Moved functionality of Script.{lineCount, lineFromPosition, sourceLine, locationFromLine, and sourceSlice} into runtime functions. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2003303002 Cr-Commit-Position: refs/heads/master@{#36469}
-
danno authored
BUG=chromium:608675 LOG=n Review-Url: https://codereview.chromium.org/1987183002 Cr-Commit-Position: refs/heads/master@{#36463}
-
jgruber authored
Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method. The line_ends accessor is still in use by chromium and thus cannot be removed yet. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2002993002 Cr-Commit-Position: refs/heads/master@{#36458}
-
- 23 May, 2016 2 commits
-
-
yangguo authored
This is in preparation of fully porting JSON.stringify to C++. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2006663002 Cr-Commit-Position: refs/heads/master@{#36449}
-
yangguo authored
This is a pure refactoring. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2002933002 Cr-Commit-Position: refs/heads/master@{#36435}
-
- 20 May, 2016 6 commits
-
-
pgorszkowski authored
In case of calling 'toLocaleString', 'toLocaleTimeString' and 'toLocaleDateString' functions of 'Date' with empty 'locales' and 'options', DateTimeFormat is cached inside 'defaultObjects'. If we change the timezone the cache is not invalidated. BUG=v8:5022 TEST=cctest:DateCacheVersion. See the bug CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/1985423003 Cr-Commit-Position: refs/heads/master@{#36420}
-
machenbach authored
Revert of Refactor script position calculation (patchset #3 id:40001 of https://codereview.chromium.org/2003483002/ ) Reason for revert: Crashes gc stress with custom snapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5763 Original issue's description: > Refactor script position calculation > > Script position calculation logic (i.e. line & column numbers for a > given code position) is now based on a single method > Script::GetPositionInfo(). Refactored related code in isolate.cc and > js/messages.js to use the new method. The line_ends accessor is still > in use by chromium and thus cannot be removed yet. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548 > Cr-Commit-Position: refs/heads/master@{#36398} TBR=yangguo@chromium.org,jgruber@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1995323002 Cr-Commit-Position: refs/heads/master@{#36403}
-
gdeepti authored
- Lane indices are no longer required to be integers. Add index coersion for loads/stores - Give shift operators masking shift count semantics - Throw type/range errors instead of runtime asserts. BUG=v8:4963 LOG=N R=bbudge@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1965443003 Cr-Commit-Position: refs/heads/master@{#36402}
-
jgruber authored
Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method. The line_ends accessor is still in use by chromium and thus cannot be removed yet. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2003483002 Cr-Commit-Position: refs/heads/master@{#36398}
-
neis authored
Introduce three new JS operators in Turbofan: - JSGeneratorStore is used in implementing Ignition's SuspendGenerator bytecode. - JSGeneratorRestoreContinuation and JSGeneratorRestoreRegister are used in implementing Ignition's ResumeGenerator bytecode. Remove the runtime functions that were used to implement these bytecodes before. BUG=v8:4907 Review-Url: https://codereview.chromium.org/1991203002 Cr-Commit-Position: refs/heads/master@{#36395}
-
yangguo authored
R=jochen@chromium.org, verwaest@chromium.org Review-Url: https://codereview.chromium.org/1922603006 Cr-Commit-Position: refs/heads/master@{#36392}
-
- 19 May, 2016 3 commits
-
-
machenbach authored
Revert of Refactor script position calculation (patchset #6 id:100001 of https://codereview.chromium.org/1986173002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6896 Original issue's description: > Refactor script position calculation > > Script position calculation logic (i.e. line & column numbers for a > given code position) is now based on a single method > Script::GetPositionInfo(). Refactored related code in isolate.cc and > js/messages.js to use the new method and removed the line_ends JS > accessor. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/c04d547298ce4fd425ef1eaa9b02ad1e177918dc > Cr-Commit-Position: refs/heads/master@{#36359} TBR=yangguo@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1994973002 Cr-Commit-Position: refs/heads/master@{#36368}
-
jgruber authored
Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method and removed the line_ends JS accessor. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/1986173002 Cr-Commit-Position: refs/heads/master@{#36359}
-
clemensh authored
Empty function names are allowed and are output as such, unnamed functions or functions with no valid UTF-8 name are output as "<WASM UNNAMED>", while the CallSite object returns null as the function name. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1970503004 Cr-Commit-Position: refs/heads/master@{#36348}
-
- 17 May, 2016 1 commit
-
-
jshin authored
1. Normalizer: Use ICU's normalizer2 API instead of deprecated normalizer. Also uses quick scan method in the API to speed up in the most common cases (almost normalized and the target is NFC) 2. In all three cases, replace |v8::Utils::ToLocal(..)| with a more efficient internal method. BUG=v8:4983 TEST=intl/string/normal*, intl/collator/*, intl/break-iterator/* TEST=test262/intl402/Collator/*, test262/built-ins/String/prototype/normalize/* CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/1971943002 Cr-Commit-Position: refs/heads/master@{#36298}
-