- 04 Mar, 2017 2 commits
-
-
Ross McIlroy authored
Adwords dominates the numbers and is flaky. Speedometer is measured elsewhere. Perf sheriffs: This will change the numbers on the RuntimeStats benchmarks. Change-Id: Id64863b41b95269987c95d48ce90f24cfa86b86d Reviewed-on: https://chromium-review.googlesource.com/449674Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43598}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ce7164..10e3929 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/7ef7617..9b85841 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Iabe50034cbccb6163ddd8699cf0498c601c18ec2 Reviewed-on: https://chromium-review.googlesource.com/449933Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43597}
-
- 03 Mar, 2017 36 commits
-
-
bakkot authored
A previous patch lifting the restriction on invalid escape sequences in tagged templates had a bug when two template tokens appeared immediately adject to each other. This moves invalid escape information from the tokenizer state proper into the TokenDesc, preventing the overwriting which caused this issue. Previous CL is at https://codereview.chromium.org/2665513002 BUG=v8:6029,v8:5546 Review-Url: https://codereview.chromium.org/2724003006 Cr-Commit-Position: refs/heads/master@{#43596}
-
luoe authored
BUG=chromium:686003 Review-Url: https://codereview.chromium.org/2705533002 Cr-Commit-Position: refs/heads/master@{#43595}
-
bmeurer authored
We don't need the JSStrictNotEqual operator in the compiler, because this is never generated by the BytecodeGraphBuilder, and the code in the AstGraphBuilder was dead code. Also remove the backing builtin StrictNotEqual. R=mstarzinger@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2727003006 Cr-Commit-Position: refs/heads/master@{#43594}
-
Ross McIlroy authored
Spinning up a new background task is expensive, and many times an existing task will finish it's work before a new task starts work on a job, so enable the existing tasks to do more than one background job. BUG=v8:5203 Change-Id: Ibbef317c8bb3921c36a096fed88d244716be9c42 Reviewed-on: https://chromium-review.googlesource.com/441706 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43593}
-
Michael Achenbach authored
BUG=chromium:673246 NOTRY=true TBR=marja@chromium.org Change-Id: I87faa32ae602a10b68a22fce46ee3bb39a7aa171 Reviewed-on: https://chromium-review.googlesource.com/449754Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43592}
-
Marja Hölttä authored
BUG=v8:5516 R=verwaest@chromium.org Change-Id: Ica04f74788a4812128bce1297aeee23f8c3bec3d Reviewed-on: https://chromium-review.googlesource.com/449675Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43591}
-
mvstanton authored
Also prevent division by zero. R=tebbi@chromium.org BUG= Review-Url: https://codereview.chromium.org/2731723002 Cr-Commit-Position: refs/heads/master@{#43590}
-
Peter Marshall authored
The callsite in ConstructByArrayBuffer could have a length that is above Smi range if the buffer had such a length. Check this before calling. Add a test too. BUG=v8:5977, chromium:698201 Change-Id: Ic22046a31607f1f85642c8caf7f5ed064edb3110 Reviewed-on: https://chromium-review.googlesource.com/449813 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43589}
-
littledan authored
This refactoring is preparatory work to enable ICU to be the backend for timezone information rather than system calls. In the process, a bit of code duplication that was inserted in the Solaris port patch is eliminated here among modern POSIX backends. One possible performance downside of this patch is that it introduces a virtual method call for operations which were previously not virtual methods. However, a couple factors mitigate this effect: - The DateCache minimizes the need for calls into the TimezoneCache - These calls were already not very high performance, as they included a system call which requires an RPC to get out of the sandbox, and they are surrounded by C++ builtins, which require a JS to C++ transition. - A future transition to ICU, enabled by this refactoring, may improve performance by eliminating the system call. BUG=v8:6031 Review-Url: https://codereview.chromium.org/2731463003 Cr-Commit-Position: refs/heads/master@{#43588}
-
tebbi authored
Following the design of https://codereview.chromium.org/2692753004, also compute the arguments length in the deoptimizer sucht that it does not have to be computed in optimized code. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2729163002 Cr-Commit-Position: refs/heads/master@{#43587}
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728113002 Cr-Commit-Position: refs/heads/master@{#43586}
-
Michael Achenbach authored
BUG=v8:6030 NOTRY=true TBR=hablich@chromium.org Change-Id: I28815078e1f3d27411fa985df35ff70ac49dbcb4 Reviewed-on: https://chromium-review.googlesource.com/449833Reviewed-by:
-
Toon Verwaest authored
BUG=v8:6039 Change-Id: I69bae9ed49d91b0bc67a8e66e469d57ea7799cca Reviewed-on: https://chromium-review.googlesource.com/449793Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#43584}
-
clemensh authored
If the imported wasm function is being debugged (i.e. redirects to the interpreter), call it via the JS_TO_WASM stub, such that we can disable the breakpoint later by patching the exported function. This also contains a drive-by fix in wasm-translation.cc (for the case that all known positions are bigger than the requested one). R=titzer@chromium.org, kozyatinskiy@chromium.org BUG=v8:5971, v8:5822 Review-Url: https://codereview.chromium.org/2720813002 Cr-Commit-Position: refs/heads/master@{#43583}
-
Peter Marshall authored
We should throw a RangeError for offset % elementSize before length.toPrimitive is observable. Adds a test that checks this, too. BUG=v8:6037 Change-Id: Ie9f2551c8e8fb0018b508762ac93cdc470e15dde Reviewed-on: https://chromium-review.googlesource.com/449792Reviewed-by:
-
franzih authored
The parameters for ConstructWithSpread and CallWithSpread both contain the arity for JavaScript calls with a spread as the last parameter and have the same functionality. Simplify them as one parameter. BUG= Review-Url: https://codereview.chromium.org/2729143002 Cr-Commit-Position: refs/heads/master@{#43581}
-
Michael Lippautz authored
Second part of relanding d2c093bc. BUG=chromium:651354 Change-Id: I4d48e870ac3a630ee1c286a86e630b8cf52cadf9 Reviewed-on: https://chromium-review.googlesource.com/449712Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43580}
-
Marja Hölttä authored
Materialized literal removal is a follow up to https://chromium-review.googlesource.com/443246 In addtion, remove ParserBase::Checkpoint; it was for restoring materialized literal counts and expected property counts, but actually the expected property count tracking was incorrect ("this" in arrow function param list binds to the outside, so it's correct without the checkpoint): (a, b = this.c = 0) => { } BUG= Change-Id: Ic097f6d2e7cb235166fb3a76af3bf5584bc167f0 Reviewed-on: https://chromium-review.googlesource.com/449733Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43579}
-
Camillo Bruni authored
Change-Id: Ib2a0a0ae56f68c865ab1602b3f6c36bc2e66b304 Reviewed-on: https://chromium-review.googlesource.com/448224Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#43578}
-
jgruber authored
This should improve generated code. It is also one step in preparation for LoadIC inlining - explicitly deferred blocks are currently necessary to help the scheduler omit frame construction. BUG=v8:5917 Review-Url: https://codereview.chromium.org/2732613002 Cr-Commit-Position: refs/heads/master@{#43577}
-
Michael Achenbach authored
NOTRY=true TBR=jarin@chromium.org Change-Id: If1b42341798f890dab5d45235ae93efe069b8309 Reviewed-on: https://chromium-review.googlesource.com/449772Reviewed-by:
-
Michael Achenbach authored
BUG=chromium:691589,chromium:691587 NOTRY=true TBR=marja@chromium.org Change-Id: I769af6472caa38f0a5d383cb8d5e30540f7c988a Reviewed-on: https://chromium-review.googlesource.com/449713Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43575}
-
Georg Neis authored
The pattern of creating a hidden catch scope occurs several times, so define a helper for it. BUG= Change-Id: I5831378341d86d41bfb015bd3e687183cc79ac20 Reviewed-on: https://chromium-review.googlesource.com/448559 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#43574}
-
clemensh authored
In lazy compilation, we only compile one function at a time, and we might not have the wire bytes of the whole module available. This CL prepares the WasmCompilationUnit for this setting. It will also be helpful for streaming compilation. Also, the ErrorThrower (which might heap-allocate) is not stored in the WasmCompilationUnit any more. Instead, it is passed to the FinishCompilation method which is allowed to heap-allocate. R=titzer@chromium.org, ahaas@chromium.org BUG=v8:5991 Review-Url: https://codereview.chromium.org/2726553003 Cr-Commit-Position: refs/heads/master@{#43573}
-
bmeurer authored
We can compile a !== a and Number.isNaN(a) to ObjectIsNaN. The former is commonly used to check for NaN, i.e. in case of equals in AngularJS. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2722483003 Cr-Commit-Position: refs/heads/master@{#43572}
-
Georg Neis authored
This is always the single variable declared in the catch scope. BUG= Change-Id: I05ccc48f57394268432c9b5b8c76f9db1b3b6312 Reviewed-on: https://chromium-review.googlesource.com/448041Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Later manipulation of Array.prototype.concat could lead to calling the Date constructor with empty arguments list. This let a non-mocked date slip in. BUG=chromium:698097 NOTRY=true TBR=yangguo@chromium.org,mstarzinger@chromium.org Change-Id: Ib4bd97e06ea7be8c32d0057d42943f9f82ea6b5f Reviewed-on: https://chromium-review.googlesource.com/449732Reviewed-by:
-
Michael Achenbach authored
The old proxy only mocked out constructor calls and didn't intercept function application. It also kept the original constructor property, through which non-mocked dates could be constructed again. BUG=chromium:697870 NOTRY=true R=mstarzinger@chromium.org,yangguo@chromium.org Change-Id: Icb4ef22342424f95463a7a9c57fa0bb8d910ac19 Reviewed-on: https://chromium-review.googlesource.com/448564Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43569}
-
ivica.bogosavljevic authored
WASM interpreter requires that parameters are stored in big-endian natural memory order (higher bits on lower addresses and lower bits on higher address). On the other hand, WASM compiled code naturally stores data in memory in little-endian order. This CL implements big-endian support for passing double and int64 parameters to WASM interpreter. TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_int64, cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes Review-Url: https://codereview.chromium.org/2721053002 Cr-Commit-Position: refs/heads/master@{#43568} -
kozyatinskiy authored
BUG=chromium:698077 R=lushnikov@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2730813002 Cr-Commit-Position: refs/heads/master@{#43567}
-
loorongjie authored
Original issue: https://codereview.chromium.org/2724833002/ BUG=v8:6005 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel R=bmeurer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2725053007 Cr-Commit-Position: refs/heads/master@{#43566}
-
cwhan.tunz authored
- No callbacks for std::sort of integer typed arrays when user-defined comparison is not given - Use template function, instead of macro, for comparison function - Do not sort if the array size is less than or equal to 1 BUG=v8:5953 Review-Url: https://codereview.chromium.org/2726153003 Cr-Commit-Position: refs/heads/master@{#43565}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2930f01..8ce7164 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/b068264..7ef7617 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/37d701b..c9f2fc0 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I39deed72065ec038bc8852c4383d2f1f4746d43e Reviewed-on: https://chromium-review.googlesource.com/449572Reviewed-by:
-
Andreas Haas authored
R=bradnelson@chromium.org Change-Id: Ifc492b2c2d361ebde5b143b599175b13860781ca Reviewed-on: https://chromium-review.googlesource.com/448576 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#43563}
-
aseemgarg authored
R=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org BUG=v8:6020 Review-Url: https://codereview.chromium.org/2728823005 Cr-Commit-Position: refs/heads/master@{#43562}
-
aseemgarg authored
This fixes and relands https://codereview.chromium.org/2718323003. R=bbudge@chromium.org,titzer@chromium.org,ahaas@chromium.org,machenbach@chromium.org,bradnelson@chromium.org BUG=v8:6020 Review-Url: https://codereview.chromium.org/2724973003 Cr-Commit-Position: refs/heads/master@{#43561}
-
- 02 Mar, 2017 2 commits
-
-
hpayer authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2728723004 Cr-Commit-Position: refs/heads/master@{#43560}
-
Toon Verwaest authored
BUG= Change-Id: I3d85ad84f5069f7fe349dcd82092696d0360cc94 Reviewed-on: https://chromium-review.googlesource.com/448225Reviewed-by:
-
