- 01 Dec, 2015 9 commits
-
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1480243003 Cr-Commit-Position: refs/heads/master@{#32434}
-
mbrandy authored
Port 7ceaf727 R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:1543, v8:3330, v8:3931 LOG=n Review URL: https://codereview.chromium.org/1480423002 Cr-Commit-Position: refs/heads/master@{#32433}
-
mbrandy authored
Port 81e131ce R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1482153005 Cr-Commit-Position: refs/heads/master@{#32432}
-
bradnelson authored
SIMD.js potentially adds to the standard library passed into asm.js modules. Splitting off the point where the SIMD object would be referenced to allow work on SIMD typing to occur orthogonally. Adding VariableInfo to allow tracking of simd constructors / check functions. Using this for fround. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Looking at simd.js Review URL: https://codereview.chromium.org/1473513004 Cr-Commit-Position: refs/heads/master@{#32431}
-
mbrandy authored
Port d3e5db04 Original commit message: Up until now we sometimes pass Smi 0 around as closure and expect the runtime to translate that appropriately. But we need to be careful in some places to not confuse the Smi 0 with a real closure. However, we could instead just pass the correct closure extracted from the native context. This addresses three long-standing TODOs in the JSTypedLowering pass. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1490553002 Cr-Commit-Position: refs/heads/master@{#32430}
-
adamk authored
This fixes a corner-case in redeclaration handling, where the ES2015 early error case got mixed up with legacy const handling in the parser. Redeclaration using ES2015 'let' and 'const' should be early errors, but legacy 'const' redeclaration has historically been a runtime error, and should stay that way until legacy 'const' is gone. The fix here is uglier than it might be due to https://code.google.com/p/v8/issues/detail?id=4577, which keeps us from simplifying the mess of if/else-if in the current code. BUG=v8:4576 LOG=n Review URL: https://codereview.chromium.org/1485943002 Cr-Commit-Position: refs/heads/master@{#32429}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1490513004 Cr-Commit-Position: refs/heads/master@{#32428}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1480213003 Cr-Commit-Position: refs/heads/master@{#32427}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1484143002 Cr-Commit-Position: refs/heads/master@{#32426}
-
- 30 Nov, 2015 31 commits
-
-
mbrandy authored
Port 3d004eea Original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. The interpreter entry trampoline stores this value in a bytecode register so that it can be accessed directly by the interpreter. The size of the interpreter stack frame hence grows by one slot. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4544 LOG=n Review URL: https://codereview.chromium.org/1487863002 Cr-Commit-Position: refs/heads/master@{#32425}
-
bradnelson authored
The Type::Print method requires an explict zone, even for basic types on arm debug. This change introduced debug mode printing when types don't match: https://codereview.chromium.org/1471073003/ Adding the zone parameter to make the arm build go green. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=local arm build TBR=bbudge@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1490593002 Cr-Commit-Position: refs/heads/master@{#32424}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1488563003 Cr-Commit-Position: refs/heads/master@{#32423}
-
mbrandy authored
Port 51e992f1 Original commit message: Restore frame pointer directly from stack rather than copying it and restoring. Also restore return address register directly on platforms that support it. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1490563002 Cr-Commit-Position: refs/heads/master@{#32422}
-
mbrandy authored
R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1485653003 Cr-Commit-Position: refs/heads/master@{#32421}
-
mbrandy authored
Port 51669873 Original commit message: Some highlights of this CL: * Refactor the mutable state out of Frame into FrameAccessState, which is maintained and updated during code generation to record whether sp- or fp-based frame access is currently active and how deep the stack on top of the frame is. * The operand resultion in linkage.cc now uses FrameAccessState to determine how to generate frame-accessing operands. * Update all platforms to accurately track additionally pushed stack slots (e.g. arguments for calls) in the FrameAccessState. * Add a flag, --turbo_sp_frame_access, which forces all frame access to be sp-based whenever possible. This will likely never be used in production, but for testing it's useful in verifying that the stack-tracking of each platform maintained in the FrameAccessState is correct. * Use sp-based frame access for gap resolving before tail calls. This will allow for slightly more efficient restoration of the frame pointer in the tail call in a later CL. * Remove most ad hoc groping into CallDescriptors to determine if a frame is needed, instead consistently use predicates like needs_frame(), IsCFunctionCall() and IsJSFunctionCall(). R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1484913003 Cr-Commit-Position: refs/heads/master@{#32420}
-
bradnelson authored
Shifts of integer values are in some contexts collapsed by the parser into single literal AST nodes, rather than a direct representation of the parse tree. Confirming this behavior in tests. Integer TypedArrays are assumed to load and store "intish" values rather than more fine-grained type information. Reducing the precision of the typing information to match the spec and simplify the wasm generator. The asm spec requires load and store values of various "float?", "floatish", "double?" and "intish" types to ensure undefined values are not visible and that float32 rounding occurs at the right time. More closely matching this. Adding additional testing around unsigned / signed comparisons, loads and stores. Adding addition debug mode printing when asserting about types fail. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator, wasm side tests R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1471073003 Cr-Commit-Position: refs/heads/master@{#32419}
-
alan.li authored
BUG= Review URL: https://codereview.chromium.org/1453373002 Cr-Commit-Position: refs/heads/master@{#32418}
-
alan.li authored
BUG= Review URL: https://codereview.chromium.org/1481493002 Cr-Commit-Position: refs/heads/master@{#32417}
-
mstarzinger authored
Revert of [heap] Aggressive code flushing in GC stress mode. (patchset #1 id:1 of https://codereview.chromium.org/1483993002/ ) Reason for revert: This breaks (surprise) GC stress with custom snapshot, cannot reproduce, will need to investigate further. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2909/steps/Mjsunit/logs/deopt-inlined-from-call Original issue's description: > [heap] Aggressive code flushing in GC stress mode. > > This disregards the code age heuristic when deciding whether to flush > code so that GC stress mode is more likely to flush out potential races > between our various "invariants". > > R=hpayer@chromium.org > > Committed: https://crrev.com/28a3f23e50f1847dd1152e6bb4aa0579acbdaaab > Cr-Commit-Position: refs/heads/master@{#32414} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1485823002 Cr-Commit-Position: refs/heads/master@{#32416}
-
danno authored
BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1483053002 Cr-Commit-Position: refs/heads/master@{#32415}
-
mstarzinger authored
This disregards the code age heuristic when deciding whether to flush code so that GC stress mode is more likely to flush out potential races between our various "invariants". R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1483993002 Cr-Commit-Position: refs/heads/master@{#32414}
-
thechargingvolcano authored
In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1443963004 Cr-Commit-Position: refs/heads/master@{#32413}
-
mstarzinger authored
This removes an overly complex predicate from the IsFlushable check within the marking visitor. By now all JSFunction objects reference a valid Context object, also builtin functions can be recognized without looking at the JSFunction object. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1482363002 Cr-Commit-Position: refs/heads/master@{#32412}
-
oth authored
BUG= LOG=N Review URL: https://codereview.chromium.org/1486613002 Cr-Commit-Position: refs/heads/master@{#32411}
-
danno authored
Restore frame pointer directly from stack rather than copying it and restoring. Also restore return address register directly on platforms that support it. BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1488553002 Cr-Commit-Position: refs/heads/master@{#32410}
-
hablich authored
R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1480323002 Cr-Commit-Position: refs/heads/master@{#32409}
-
mythria authored
an optomization to remove redundant cast operations. 1. Adds an optimization to remove redundant ToBoolean and ToName operations. 2. Adds implementation and tests for cast operatorts to bytecode graph builder. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1468003002 Cr-Commit-Position: refs/heads/master@{#32408}
-
bmeurer authored
This way we avoid the %_IsSmi magic that is required in TurboFan to (efficiently) check abitrary context slots for smi 0. Checking against "the hole" is common in the AstGraphBuilder and "the hole" is also used to mark other context slots as not initialized. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1484723003 Cr-Commit-Position: refs/heads/master@{#32407}
-
hpayer authored
Revert of Do not remove write barriers for stores of old space references in most recent old space allocation. (patchset #1 id:1 of https://codereview.chromium.org/1478113002/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Do not remove write barriers for stores of old space references in most recent old space allocation. > > BUG=chromium:561449 > LOG=n > > Committed: https://crrev.com/369778ec55a63ebe51e8fa8497edb5b681069b9b > Cr-Commit-Position: refs/heads/master@{#32368} TBR=ulan@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:561449 Review URL: https://codereview.chromium.org/1482973003 Cr-Commit-Position: refs/heads/master@{#32406}
-
hpayer authored
Revert of Tenure transition array. (patchset #1 id:1 of https://codereview.chromium.org/1472363007/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Tenure transition array. > > BUG= > > Committed: https://crrev.com/c88d7cd1e09d921e8a9a2930cfe6f2dfbea3dc90 > Cr-Commit-Position: refs/heads/master@{#32378} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:563378 Review URL: https://codereview.chromium.org/1485613003 Cr-Commit-Position: refs/heads/master@{#32405}
-
hpayer authored
Revert of Introduce instance type for transition arrays. (patchset #6 id:100001 of https://codereview.chromium.org/1480873003/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Introduce instance type for transition arrays. > > The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. > > BUG=chromium:554488 > LOG=NO > > Committed: https://crrev.com/026095a3c7932573e1810b8064ec3008ed696601 > Cr-Commit-Position: refs/heads/master@{#32396} TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:554488 Review URL: https://codereview.chromium.org/1483003002 Cr-Commit-Position: refs/heads/master@{#32404}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1483933002 Cr-Commit-Position: refs/heads/master@{#32403}
-
neis authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1488493002 Cr-Commit-Position: refs/heads/master@{#32402}
-
neis authored
This depends on issue 1476403004. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1479293002 Cr-Commit-Position: refs/heads/master@{#32401}
-
vogelheim authored
R=bmeurer@chromium.org, mstarzinger@chromium.org BUG=chromium:508898 LOG=Y Review URL: https://codereview.chromium.org/1477413002 Cr-Commit-Position: refs/heads/master@{#32400}
-
mythria authored
Adds support and tests for throw to bytecode graph builder. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1481763002 Cr-Commit-Position: refs/heads/master@{#32399}
-
neis authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1476403004 Cr-Commit-Position: refs/heads/master@{#32398}
-
mstarzinger authored
This switches several builtin methods to use the ES6 new.target value when determined whether being called as a constructor or not. This is prepatory work for fully deprecating the aforementioned intrinsic. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1477073005 Cr-Commit-Position: refs/heads/master@{#32397}
-
ulan authored
The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. BUG=chromium:554488 LOG=NO Review URL: https://codereview.chromium.org/1480873003 Cr-Commit-Position: refs/heads/master@{#32396}
-
neis authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1480273002 Cr-Commit-Position: refs/heads/master@{#32395}
-