- 08 Feb, 2016 1 commit
-
-
verwaest authored
Generally we only care whether the next object is a hidden prototype. It's simpler to check whether the current object has a hidden prototype instead of walking to the next prototype and checking its map. BUG= Review URL: https://codereview.chromium.org/1675223002 Cr-Commit-Position: refs/heads/master@{#33816}
-
- 04 Jan, 2016 1 commit
-
-
jkummerow authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1559923002 Cr-Commit-Position: refs/heads/master@{#33087}
-
- 22 Dec, 2015 1 commit
-
-
cbruni authored
Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 Review URL: https://codereview.chromium.org/1542583003 Cr-Commit-Position: refs/heads/master@{#33007}
-
- 16 Dec, 2015 1 commit
-
-
cbruni authored
We can no longer just walk the prototype chain without doing proper access-checks. When installing a proxy as the __proto__ of the global object we might accidentally end up invoking cross-realm code without access-checks (see proxies-cross-realm-ecxeption.js). Review URL: https://codereview.chromium.org/1521953002 Cr-Commit-Position: refs/heads/master@{#32903}
-
- 04 Dec, 2015 1 commit
-
-
machenbach authored
Reland of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (patchset #1 id:1 of https://codereview.chromium.org/1494283002/ ) Reason for revert: Did not help... Original issue's description: > Revert of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (patchset #2 id:20001 of https://codereview.chromium.org/1492863002/ ) > > Reason for revert: > [Sheriff] Speculative revert for: > https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 > > Can just be relanded if it doesn't get green. > > Original issue's description: > > [proxies] Make Object.prototype.isPrototypeOf step into proxies. > > > > R=rossberg, verwaest@chromium.org > > BUG=v8:1543 > > LOG=n > > > > Committed: https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573 > > Cr-Commit-Position: refs/heads/master@{#32569} > > TBR=rossberg@chromium.org,verwaest@chromium.org,neis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:1543 > > Committed: https://crrev.com/48fba9439f291edd5929e19951262dc7e8a09609 > Cr-Commit-Position: refs/heads/master@{#32588} TBR=rossberg@chromium.org,verwaest@chromium.org,neis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Review URL: https://codereview.chromium.org/1491743010 Cr-Commit-Position: refs/heads/master@{#32598}
-
- 03 Dec, 2015 2 commits
-
-
machenbach authored
Revert of [proxies] Make Object.prototype.isPrototypeOf work with proxies. (patchset #2 id:20001 of https://codereview.chromium.org/1492863002/ ) Reason for revert: [Sheriff] Speculative revert for: https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 Can just be relanded if it doesn't get green. Original issue's description: > [proxies] Make Object.prototype.isPrototypeOf step into proxies. > > R=rossberg, verwaest@chromium.org > BUG=v8:1543 > LOG=n > > Committed: https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573 > Cr-Commit-Position: refs/heads/master@{#32569} TBR=rossberg@chromium.org,verwaest@chromium.org,neis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Review URL: https://codereview.chromium.org/1494283002 Cr-Commit-Position: refs/heads/master@{#32588}
-
neis authored
R=rossberg, verwaest@chromium.org BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1492863002 Cr-Commit-Position: refs/heads/master@{#32569}
-
- 10 Sep, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1330153003 Cr-Commit-Position: refs/heads/master@{#30676}
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none R=verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/390323002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22442 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
The new pattern is that we first get the map of the root of the prototype chain using Object::GetMapRoot() and then walk up the prototype chain using Map::prototype(). BUG=??? R=verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/376233002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-