- 08 Apr, 2022 1 commit
-
-
Camillo Bruni authored
Bug: chromium:1297451 Change-Id: I3c33eea5ef457f1c82c6a7681fb64c9a10572dee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576128Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79871}
-
- 14 Dec, 2021 1 commit
-
-
Camillo Bruni authored
Multiple threads can modify async_wraps_ in parallel, which is not ok. Drive-by-fix: - Use normal constructor/destructor for AsyncHooksWrap - Use unique_ptr for storing AsyncHooksWrap Bug: chromium:1278276 Change-Id: I667980151c775be29e603790e589b1de76fae05a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338257Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78375}
-
- 24 Aug, 2021 1 commit
-
-
Dan Elphick authored
This is a reland of d1b27019 Fixes include: Adding missing file to bazel build Forward-declaring classing before friend-classing them to fix win/gcc Add missing v8-isolate.h include for vtune builds Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit Bug: v8:11965 Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76460}
-
- 23 Aug, 2021 2 commits
-
-
Dan Elphick authored
This reverts commit d1b27019. Reason for revert: Broke vtune build, tsan build and possibly others Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Bug: v8:11965 Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76428}
-
Dan Elphick authored
This moves every single class/function out of include/v8.h into a separate header in include/, which v8.h then includes so that externally nothing appears to have changed. Every include of v8.h from inside v8 has been changed to a more fine-grained include. Previously inline functions defined at the bottom of v8.h would call private non-inline functions in the V8 class. Since that class is now in v8-initialization.h and is rarely included (as that would create dependency cycles), this is not possible and so those methods have been moved out of the V8 class into the namespace v8::api_internal. None of the previous files in include/ now #include v8.h, which means if embedders were relying on this transitive dependency then it will give compile failures. v8-inspector.h does depend on v8-scripts.h for the time being to ensure that Chrome continue to compile but that change will be reverted once those transitive #includes in chrome are changed to include it directly. Full design: https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing Bug: v8:11965 Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76424}
-
- 27 May, 2019 1 commit
-
-
Clemens Hammacher authored
This replaces all typedefs that define types and not functions by the equivalent "using" declaration. This was done mostly automatically using this command: ag -l '\btypedef\b' src test | xargs -L1 \ perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg' Patchset 2 then adds some manual changes for typedefs for pointer types, where the regular expression did not match. R=mstarzinger@chromium.org TBR=yangguo@chromium.org, jarin@chromium.org Bug: v8:9183 Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61849}
-
- 23 May, 2019 1 commit
-
-
Yang Guo authored
TBR=bmeurer@chromium.org,leszeks@chromium.org Bug: v8:9247 Change-Id: I8d14d0192ea8c705f8274e8e61a162531826edb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624220Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61769}
-
- 15 May, 2019 1 commit
-
-
Yang Guo authored
Bug: v8:9247 Change-Id: I404e34a013b95c6a7cf03dd9ec0732d9ad796bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613238 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61531}
-
- 23 Jul, 2018 1 commit
-
-
Maya Lekova authored
Bug: chromium:866315 Change-Id: I83074475185c0646d575282d24679e18ec0628c7 Reviewed-on: https://chromium-review.googlesource.com/1146645 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54612}
-
- 04 Jul, 2018 3 commits
-
-
Maya Lekova authored
This is a reland of ade7f55b Previously landed as: ade7f55b / 1125679 Previously landed as: 3c4d0316 / 1065818 Previously landed as: 8e0f67be / 1088890 Original change's description: > Reland ^2 "[async] Expose async hooks to d8" > > This is a reland of 8e0f67be > Bug: chromium:850530 Change-Id: I536cfb9443d80d62937d9c3dc6a53b52b209d5c7 Reviewed-on: https://chromium-review.googlesource.com/1125683 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54218}
-
Yang Guo authored
This reverts commit ade7f55b. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/25706 Original change's description: > Reland ^2 "[async] Expose async hooks to d8" > > This is a reland of 8e0f67be > > Previously landed as: 3c4d0316 / 1065818 > Previously landed as: 8e0f67be / 1088890 > > Original change's description: > > [async] Expose async hooks to d8 > > > > This implementation follows the Node.js API as a guideline. > > Bug: chromium:850530 > Change-Id: I8ba22b11c80328108b197d687826ce0198420c9c > Reviewed-on: https://chromium-review.googlesource.com/1125679 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54191} TBR=ofrobots@google.com,sergiyb@chromium.org,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: Id751136aee175bb3ba75edc780d62cfc9d60ed24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1125682Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54195}
-
Maya Lekova authored
This is a reland of 8e0f67be Previously landed as: 3c4d0316 / 1065818 Previously landed as: 8e0f67be / 1088890 Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. Bug: chromium:850530 Change-Id: I8ba22b11c80328108b197d687826ce0198420c9c Reviewed-on: https://chromium-review.googlesource.com/1125679Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#54191}
-
- 21 Jun, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 8e0f67be. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/20949 Original change's description: > Reland "[async] Expose async hooks to d8" > > This is a reland of 3c4d0316 > > Original change's description: > > [async] Expose async hooks to d8 > > > > This implementation follows the Node.js API as a guideline. > > > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > > Reviewed-on: https://chromium-review.googlesource.com/1065818 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53551} > > Change-Id: If2114db2ff179c6b07a40bc0c2dac3a41f37aea9 > Bug: chromium:850530 > Reviewed-on: https://chromium-review.googlesource.com/1088890 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53901} TBR=ofrobots@google.com,sergiyb@chromium.org,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: Id55809a46bc5118103391fdbdfb52415182d3fd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1109038Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53902}
-
Maya Lekova authored
This is a reland of 3c4d0316 Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > Reviewed-on: https://chromium-review.googlesource.com/1065818 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53551} Change-Id: If2114db2ff179c6b07a40bc0c2dac3a41f37aea9 Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1088890 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53901}
-
- 06 Jun, 2018 2 commits
-
-
Bill Budge authored
This reverts commit 3c4d0316. Reason for revert: Breaks MSAN on ARM64 https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21425 'enabled' field not initialized in constructor? Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > Reviewed-on: https://chromium-review.googlesource.com/1065818 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53551} TBR=ofrobots@google.com,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: I8b2bedb51cba18c77578d4e223474015d819e428 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1088811Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53555}
-
Maya Lekova authored
This implementation follows the Node.js API as a guideline. Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 Reviewed-on: https://chromium-review.googlesource.com/1065818 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53551}
-