1. 28 Jan, 2021 3 commits
    • Benedikt Meurer's avatar
      Reland "[debug][api] Move debugger support to debug-interface.cc." · 9d3cd57f
      Benedikt Meurer authored
      Previously we had the debugger / inspector support declared in
      debug-interface.h, but the implementation was sprinkled all across
      api.cc, which was quite messy. This moves the relevant macros and
      other bits into api-macros.h (with api-macros-undef.h to support
      jumbo builds), and moves the debugger interface implementation to
      src/debug/debug-interface.cc.
      
      Bug: chromium:1162229
      Change-Id: If2698cba7bcc0b54b0f889220588ec214405848b
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656256
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72402}
      9d3cd57f
    • Marja Hölttä's avatar
      Revert "[debug][api] Move debugger support to debug-interface.cc." · ab7c7c78
      Marja Hölttä authored
      This reverts commit 1b4811f7.
      
      Reason for revert: makes "git cl upload" fail (the change related to files_to_skip)
      
      Original change's description:
      > [debug][api] Move debugger support to debug-interface.cc.
      >
      > Previously we had the debugger / inspector support declared in
      > debug-interface.h, but the implementation was sprinkled all across
      > api.cc, which was quite messy. This moves the relevant macros and
      > other bits into api-macros.h (with api-macros-undef.h to support
      > jumbo builds), and moves the debugger interface implementation to
      > src/debug/debug-interface.cc.
      >
      > Bug: chromium:1162229
      > Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154
      > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#72392}
      
      TBR=yangguo@chromium.org,bmeurer@chromium.org
      
      Change-Id: Ib9460709df799cd63b221f9f30dc33dff53075bd
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1162229
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655508Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72393}
      ab7c7c78
    • Benedikt Meurer's avatar
      [debug][api] Move debugger support to debug-interface.cc. · 1b4811f7
      Benedikt Meurer authored
      Previously we had the debugger / inspector support declared in
      debug-interface.h, but the implementation was sprinkled all across
      api.cc, which was quite messy. This moves the relevant macros and
      other bits into api-macros.h (with api-macros-undef.h to support
      jumbo builds), and moves the debugger interface implementation to
      src/debug/debug-interface.cc.
      
      Bug: chromium:1162229
      Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72392}
      1b4811f7