1. 14 May, 2014 1 commit
  2. 30 Apr, 2014 2 commits
  3. 29 Apr, 2014 1 commit
  4. 04 Apr, 2014 1 commit
    • marja@chromium.org's avatar
      Update tests to use the new compilation API + related fixes. · 3d1a17c2
      marja@chromium.org authored
      Esp. get rid of PreCompile in tests, as it's going to be removed.
      
      Notes:
      - The new compilation API doesn't have a separate precompilation phase, so there
      is no separate way to check for errors except checking the compilation
      errors. Removed some tests which don't make sense any more.
      - test-api/Regress31661 didn't make sense as a regression test even before the
      compilation API changes, because Blink doesn't precompile this short scripts. So
      detecting this kind of errors (see crbug.com/31661 for more information) cannot rely
      on precompilation errors.
      - test-parsing/PreParserStrictOctal has nothing to do with PreParser, and the comment
      about "forcing preparsing" was just wrong.
      - test-api/PreCompile was supposed to test that "pre-compilation (aka
      preparsing) can be called without initializing the whole VM"; that's no longer
      true, since there's no separate precompilation step in the new compile
      API. There are other tests (test-parsing/DontRegressPreParserDataSizes) which
      ensure that we produce cached data.
      - Updated tests which test preparsing to use PreParser directly (not via the
       preparsing API).
      - In the new compilation API, the user doesn't need to deal with ScriptData
      ever. It's only used internally, and needed in tests that test internal aspects
      (e.g., modify the cached data before passing it back).
      - Some tests which used to test preparse + parse now test first time parse +
        second time parse, and had to be modified to ensure we don't hit the
        compilation cache.
      
      BUG=
      R=ulan@chromium.org
      
      Review URL: https://codereview.chromium.org/225743002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3d1a17c2
  5. 19 Mar, 2014 1 commit
  6. 14 Mar, 2014 1 commit
  7. 13 Mar, 2014 2 commits
  8. 10 Mar, 2014 1 commit
    • marja@chromium.org's avatar
      Refactor script compilation / running & use of helper funcs in test-api.cc. · 8bd37cb7
      marja@chromium.org authored
      The tests were using different kind of constructs for achieving the same
      thing. This makes refactoring the compilation API more difficult than it should
      be.
      
      cctest.h already contained helpers for compiling and running scripts, but they
      were not used consistently.
      
      For example, all these were used for running scripts:
      
      v8::Script::Compile(v8_str("foo"))->Run();
      v8::Script::Compile(v8::String::NewFromUtf8(isolate, "foo))->Run();
      CompileRun(v8_str("foo"));
      CompileRun(v8::String::NewFromUtf8(some_way_to_get_isolate(), "foo"));
      v8::Local<v8::Script> script = any_of_the_above; script->Run();
      
      Most of the tests just want to run a script (which is in const char*) and don't
      care about how the v8::String is constructed or passed to the compiler API. Using
      the helpers makes the test more readable and reduces boilerplate code which is
      unrelated to what the test is testing.
      
      R=dcarney@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/190503002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      8bd37cb7
  9. 20 Feb, 2014 1 commit
    • marja@chromium.org's avatar
      Re-enable Parser::symbol_cache_ (after a long time!) · 0a01afda
      marja@chromium.org authored
      The Parser never used the symbol stream produced by the PreParser for anything
      useful, due to a bug introduced 3.5 years ago by
      https://codereview.chromium.org/3356010/diff/7001/src/parser.cc.
      
      The bug is that calling Initialize on symbol_cache_ doesn't change its
      length. So the length remains 0, and the "if" in Parser::LookupSymbol is always
      true, and Parser::LookupCachedSymbol is never called and symbol_cache_ never
      filled.
      
      This bug also masked a bug that the symbol stream produced by PreParser doesn't
      match what Parser wants to consume. The repro case is the following:
      
      var myo = {if: 4}; print(myo.if);
      
      PreParser doesn't log a symbol for the first "if", but in the corresponding
      place, Parser consumes one symbol from the symbol stream. Since the consumed
      symbols were never really used, this mismatch went unnoticed.
      
      This CL also fixes that bug.
      
      BUG=
      R=ulan@chromium.org
      
      Review URL: https://codereview.chromium.org/172753002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19505 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      0a01afda
  10. 04 Feb, 2014 3 commits
  11. 31 Jan, 2014 1 commit
  12. 17 Jan, 2014 1 commit
  13. 03 Jan, 2014 3 commits
  14. 20 Dec, 2013 2 commits
  15. 03 Dec, 2013 1 commit
  16. 02 Dec, 2013 1 commit
  17. 22 Nov, 2013 1 commit
  18. 14 Nov, 2013 1 commit
  19. 14 Oct, 2013 1 commit
  20. 23 Sep, 2013 1 commit
  21. 20 Sep, 2013 1 commit
  22. 19 Sep, 2013 5 commits
  23. 11 Sep, 2013 1 commit
  24. 05 Sep, 2013 1 commit
  25. 02 Sep, 2013 1 commit
  26. 14 Aug, 2013 1 commit
  27. 05 Aug, 2013 1 commit
  28. 13 Jun, 2013 1 commit
  29. 08 May, 2013 1 commit