1. 06 May, 2020 1 commit
    • Jakob Gruber's avatar
      [snapshot] Clear reconstructable data prior to d8 stress_snapshot run · 3c422d1c
      Jakob Gruber authored
      The serializer currently cannot handle a heap state containing
      arbitrary compiled Code objects. As a quick fix for the
      --stress-snapshot d8 flag, we clear compiled data from the isolate
      prior to the serialize-deserialize-verify pass.
      
      With this change, mjsunit tests pass on x64.
      
      The %SerializeDeserializeNow() runtime function would require more
      work, since it is not possible to mutate the heap to this extent while
      still preserving a runnable host context and isolate. We will need
      another solution there.
      
      Drive-by: Skip the stress_snapshot variant except for the mjsunit
      suite.
      
      Tbr: machenbach@chromium.org
      Bug: v8:10493,v8:10416
      Change-Id: Ie110da8b51613fcd69c7f391d3cf8589d6b04dd8
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182429Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67585}
      3c422d1c
  2. 20 Feb, 2020 1 commit
    • Paolo Severini's avatar
      Add initial support for Wasm debugging with LLDB: implements a GDB-remote stub · 03fc4149
      Paolo Severini authored
      This is the first piece of the wasm debugging prototype (besides the changes to
      add/remove breakpoints in WasmModuleObject made with
      https://chromium.googlesource.com/v8/v8.git/+/e699f39caed9a23f8e20bd3a0386a3236e272737).
      
      This changelist adds the infrastructure for a GDB-remote stub that will be used
      to manage debugging sessions via the gdb-remote protocol.
      It enables the creation and termination of debugging sessions over TCP
      connections that are managed in a separate thread.
      The logic to actually send, receive and decode GDB-remote packets will be part
      of a future changelist.
      
      Build with: v8_enable_wasm_gdb_remote_debugging = true
      Run with:
        --wasm-gdb-remote                  Enables Wasm debugging with LLDB
                                           (default: false)
        --wasm-gdb-remote-port             TCP port to be used for debugging
                                           (default: 8765)
        --wasm-pause-waiting-for-debugger  Pauses the execution of Wasm code waiting
                                           for a debugger (default: false)
        --trace-wasm-gdb-remote            Enables tracing of Gdb-remote packets
                                           (default: false)
      
      Note that most of this code is "borrowed" from the code of the Chromium NaCL
      GDB-remote stub (located in Chromium in src\native_client\src\trusted\debug_stub).
      
      Implementation details:
      - class GdbServer acts as a singleton manager for the gdb-remote stub. It is
        instantiated as soon as the first Wasm module is loaded in the Wasm engine.
      - class GdbServerThread spawns the worker thread for the TCP connection.
      - class Transport manages the socket connection, in a portable way.
      - class Session represents a remote debugging session.
      - class Target represents a debugging target and it’s the place where the
        debugging packets will be processed and will implement the logic to debug
        a Wasm engine.
      
      Bug: chromium:1010467
      Change-Id: Ib2324e5901f5ae1d855b96b99ef0995d407322b6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1923407Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Paolo Severini <paolosev@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#66379}
      03fc4149
  3. 11 Jan, 2019 1 commit
    • Tamer Tas's avatar
      [testrunner] fix leaky abstraction in TestSuite loading process · 234f27b5
      Tamer Tas authored
      TestSuite has a static method LoadTestSuite that should properly configure the
      TestSuite instance (i.e. loaded status files and tests), however the method
      leaves some configuration logic to the caller.
      
      The leaky abstraction causes the caller to do a bunch of loading operations (see
      the removed methods in base_runner.py).
      
      This CL isolates the TestSuite loading logic to the static method only.
      
      This is a refactoring only change without any intended logical changes.
      
      R=machenbach@chromium.org
      CC=​​​yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174
      Change-Id: I105059c9c9e050f03bb584174e2bd7ceeae2b228
      Reviewed-on: https://chromium-review.googlesource.com/c/1396417
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarSergiy Belozorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58744}
      234f27b5
  4. 16 Jan, 2018 1 commit
    • Michael Achenbach's avatar
      Reland "[test] Add test runner system tests for flaky tests" · 6c72df9e
      Michael Achenbach authored
      This is a reland of 96f55796
      Original change's description:
      > [test] Add test runner system tests for flaky tests
      >
      > This uses a temporary file in the mocked d8 script to let d8 flip
      > between FAIL and PASS on rerun.
      >
      > This adds a separate test root with dedicated test suite for testing
      > flakes to no interfere with existing status file configs.
      >
      > NOTRY=true
      >
      > Bug: v8:6917
      > Change-Id: Id43753650195fb74cceb2a3ee9014100cabad546
      > Reviewed-on: https://chromium-review.googlesource.com/867917
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50621}
      
      TBR=sergiyb@chromium.org
      NOTRY=true
      
      Bug: v8:6917
      Change-Id: I4e7bca272dfd8778fbb8d012fcd6fd8406158e43
      Reviewed-on: https://chromium-review.googlesource.com/868433Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50625}
      6c72df9e
  5. 08 Jan, 2018 1 commit
  6. 04 Jan, 2018 1 commit
    • Michal Majewski's avatar
      [test] Check output on the worker process. · 9f7d440e
      Michal Majewski authored
      I added additional exception logging in the execution.py since
      errors in processing results were really difficult to debug.
      
      There is a problem on Windows with class serialization when
      it comes from dynamically loaded module. To fix it I moved all
      output processors to the tools/testrunner/outproc/ and import
      them in test/*/testcfg.py.
      
      Bug: v8:6917
      Change-Id: Ida604641d659b006e91faf1d56a37769ec47f5f3
      Reviewed-on: https://chromium-review.googlesource.com/842784
      Commit-Queue: Michał Majewski <majeski@google.com>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50361}
      9f7d440e
  7. 10 Nov, 2017 1 commit
  8. 18 Jul, 2017 1 commit
  9. 28 Mar, 2017 1 commit
  10. 28 Nov, 2016 1 commit
  11. 21 Nov, 2016 1 commit
    • zhengxing.li's avatar
      X87:[test] Disables 2 test cases for x87. · b94b53a2
      zhengxing.li authored
        The reason:
        The CL #40862 (https://codereview.chromium.org/2433093002 ) caused 2 test cases failed for X87.
        Because Both 2 test cases (MoveOptimizerTest.RemovesRedundantExplicit and RegisterAllocatorTest.CanAllocateFPRegisters)
        needs 2 allocatable Float/Double registers.
        But there's only 1 allocatable Float/Double register in x87 turbofan compiler, i.e.: register index 0.
      
        This CL disables MoveOptimizerTest.RemovesRedundantExplicit and RegisterAllocatorTest.CanAllocateFPRegisters test cases for x87.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2520623005
      Cr-Commit-Position: refs/heads/master@{#41131}
      b94b53a2
  12. 17 Nov, 2016 1 commit
  13. 22 Sep, 2016 1 commit
  14. 19 Sep, 2016 1 commit
  15. 05 Jul, 2016 1 commit
    • zhengxing.li's avatar
      X87: disable Acosh/ASinh test cases for x87. · f310a829
      zhengxing.li authored
          The reason:
          same as the CL #37371 (Issue 2111493002: X87: disable some sin/cos/expm1/tan test cases for x87.), please
          refer https://codereview.chromium.org/2111493002 for more details.
      
          For Acosh/ASinh test cases, the expected values are pre-defined double precision values, the results
          generated by C++ function are extended double precision as the extended double precision is default for x87
          Gcc compiler and std lib on linux platform. The comparison of different precisons caused some of those test
          cases failed.
      
          This CL disables Acosh/ASinh test cases for x87.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2122593002
      Cr-Commit-Position: refs/heads/master@{#37516}
      f310a829
  16. 29 Jun, 2016 1 commit
    • zhengxing.li's avatar
      X87: disable some sin/cos/expm1/tan test cases for x87. · 9a9ffd13
      zhengxing.li authored
        The reason:
        All RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases
        use the C++ function to generate the expected value or result. So for x87, all those expected value or result are
        extended double precision as the extended double precision is default for x87 Gcc compiler and std lib on linux platform.
      
        The issue is:
        For RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan test cases, the expected values generated by C++ function
        are extended double precision, the results generated by X87 jitted code are double precision according to the ECMA standard.
        The comparison of different precisons caused some of those test cases failed.
      
        For Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases, the expected values are pre-defined double precision values, the results
        generated by C++ function are extended double precision. The comparison of different precisons caused some of those test cases
        failed too.
      
        This CL disables RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases for x87.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2111493002
      Cr-Commit-Position: refs/heads/master@{#37371}
      9a9ffd13
  17. 09 May, 2016 1 commit
  18. 06 May, 2016 1 commit
  19. 13 Apr, 2016 1 commit
    • Miran.Karic's avatar
      Adjust bytecode operand values for big endian. · 3b416c67
      Miran.Karic authored
      Operand values in Bytecodes.DecodeBytecodeAndOperands test are encoded
      in little endian format. The test calls Bytecodes::Decode function which
      reads the operands but the values are byte swapped on big endian
      machines. Added big endian encoded data which decodes correctly on BE
      machines.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/1881423002
      
      Cr-Commit-Position: refs/heads/master@{#35447}
      3b416c67
  20. 05 Apr, 2016 1 commit
  21. 24 Mar, 2016 1 commit
  22. 23 Mar, 2016 1 commit
  23. 19 Mar, 2016 1 commit
  24. 12 Jan, 2016 1 commit
  25. 11 Jan, 2016 1 commit
  26. 25 Nov, 2014 1 commit
    • Benedikt Meurer's avatar
      Fix platform unittests. · 9a5ec9c5
      Benedikt Meurer authored
      Follow-up to 87db4ff1, which added
      suppressions to unittests.status and a special case for Android to the
      ThreadLocalStorageTest, both of which are unneccessary and should be
      handled differently for the GTest based unittests.
      
      BUG=v8:3706
      LOG=n
      R=svenpanne@chromium.org
      
      Review URL: https://codereview.chromium.org/757913002
      
      Cr-Commit-Position: refs/heads/master@{#25495}
      9a5ec9c5
  27. 24 Nov, 2014 1 commit
    • cullinan's avatar
      Fix/suppress unittests broken on Android · 87db4ff1
      cullinan authored
      cctest/test-threads/ThreadJoinSelf is suppressed for Android, but the
      test has since been moved to unittests/Thread.SelfJoin. Move the
      suppression to unittests.status.
      
      unittests/ThreadLocalStorageTest.DoTest fails on older Android devices
      as it assumes the availability of more TLS slots than many devices
      implement. Test a smaller number of slots (32) on Android. Remove old
      suppression of test-platform-tls/FastTLS (which no longer exists).
      
      cctest/test-mark-compact/RegressJoinThreadsOnIsolateDeinit can't deal
      with shared mappings. Check for 's' instead of '-'.
      
      BUG=v8:3706
      LOG=
      
      Review URL: https://codereview.chromium.org/735863003
      
      Cr-Commit-Position: refs/heads/master@{#25492}
      87db4ff1
  28. 01 Oct, 2014 1 commit
  29. 06 Aug, 2014 1 commit