Skip to content

V
V8
Switch branch/tag
  1. 02 May, 2016 1 commit
  3. 29 Apr, 2016 1 commit
  5. 28 Apr, 2016 2 commits
    • machenbach's avatar
      Revert of [Ignition] Test ignition on all bots. (patchset #4 id:60001 of... · af419971
      machenbach authored 
      Revert of [Ignition] Test ignition on all bots. (patchset #4 id:60001 of https://codereview.chromium.org/1804003002/ )

Reason for revert:
Will resubmit with proper fix and more test skips.

Original issue's description:
> [Ignition] Test ignition on all bots.
>
> This adds ignition to the testing variants that are run on all
> bots.
>
> Failing tests can only be skipped with the NO_IGNITION
> keyword in status files. Existing expectations for the
> ignition_turbofan variant are all duplicated and use the
> NO_IGNITION keyword as well now.
>
> BUG=v8:4280
> LOG=N
> NOTRY=true

TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,mythria@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4280

Review-Url: https://codereview.chromium.org/1930943002
Cr-Commit-Position: refs/heads/master@{#35871}
      af419971
    • machenbach's avatar
      [Ignition] Test ignition on all bots. · 132c09ed
      machenbach authored 
      This adds ignition to the testing variants that are run on all
bots.

Failing tests can only be skipped with the NO_IGNITION
keyword in status files. Existing expectations for the
ignition_turbofan variant are all duplicated and use the
NO_IGNITION keyword as well now.

BUG=v8:4280
LOG=N
NOTRY=true

Review-Url: https://codereview.chromium.org/1804003002
Cr-Commit-Position: refs/heads/master@{#35865}
      132c09ed
  7. 26 Apr, 2016 1 commit
  9. 11 Apr, 2016 1 commit
    • machenbach's avatar
      [test] Simplify progress indicators. · af1f78b8
      machenbach authored 
      This removes the "AboutToRun" callback. It makes not much
sense as it is not actually called before a test is run,
but just before the results are retrieved from the results
queue. Therefore, from an information-value p-o-v it is
redundant to the "HasRun" callback.

This also reduces log size on the bots by 50%, in order to
reduce buildbot slowness, which is tied to the amount
of logs.

Review URL: https://codereview.chromium.org/1874973003

Cr-Commit-Position: refs/heads/master@{#35382}
      af1f78b8
  11. 08 Apr, 2016 1 commit
  13. 31 Mar, 2016 1 commit
    • machenbach's avatar
      [test] Fix deterministic test shards. · a0aac3cb
      machenbach authored 
      Test case objects were sorted without key function, resulting
in random sort order. On sharded builds, the shards are
determined by the sort order and rely on a deterministic
sorting. This led to random cctest and unittest cases being
dropped or executed twice on sharded testers.

TBR=jkummerow@chromium.org, hablich@chromium.org

Review URL: https://codereview.chromium.org/1842673002

Cr-Commit-Position: refs/heads/master@{#35151}
      a0aac3cb
  15. 21 Mar, 2016 1 commit
  17. 16 Mar, 2016 1 commit
    • machenbach's avatar
      [test] Remove feature to mark flaky tests. · 7f363d5d
      machenbach authored 
      The feature was removed from the bots a while ago. It was
superseeded by the flaky-test detection which reruns tests.

Remaining tests still marked as flaky most certainly pass
since a while.

Referencing all the bugs whose expectations lines get
removed by this.

BUG=v8:3838,v8:3525,v8:3125
LOG=n

Review URL: https://codereview.chromium.org/1802983002

Cr-Commit-Position: refs/heads/master@{#34804}
      7f363d5d
  19. 15 Mar, 2016 1 commit
  21. 14 Mar, 2016 1 commit
    • littledan's avatar
      Make test262 test runner check for which exception is thrown · f3568ca4
      littledan authored 
      test262 "negative" test expectations list which exception is thrown. The ES2017
draft specification is very specific about which exception class is thrown
from which path, and V8 works hard to be correct with respect to that spec.

Previously, the test262 test runner would accept any nonzero status code,
such as from a crash, or a FAIL printed out, for a negative test. This
patch makes negative tests check for the right answer using a quick-and-dirty
parsing of the exception printing from d8 to find the exception class.
It invokes d8 in a way to get a status code of 0 from thrown exceptions
so that 'negative' tests aren't actually implemented by negating the output.

Amazingly, this didn't catch any test262 failures, but I verified the extra
checking interactively by changing a negative test to expect a different type
and saw it fail.

BUG=v8:4803
R=machenbach
LOG=Y

Review URL: https://codereview.chromium.org/1766503002

Cr-Commit-Position: refs/heads/master@{#34763}
      f3568ca4
  23. 10 Mar, 2016 1 commit
  25. 08 Mar, 2016 1 commit
    • machenbach's avatar
      [coverage] Enable sanitizer coverage. · 33ffced5
      machenbach authored 
      This adds sanitizer-coverage compilation, test-runner
features and post processing.

Sanitizer coverage is expected to be used together with
asan.

During test runner execution, the produced sancov files
are disambiguated and match the pattern:
<executable name>.test.<test id>.sancov.

Two additional scripts are added for merging raw sancov
files and for generating json data containing all
instrumented lines + all covered lines from merged sancov
files. Both scripts use multiprocessing for speed.

The json data will later be uploaded to google storage
for further use, e.g. to show coverage data in rietveld.

Sancov documentation:
http://clang.llvm.org/docs/SanitizerCoverage.html

BUG=chromium:568949
LOG=n
NOTRY=true
TEST=python -m unittest sancov_formatter_test
TEST=python -m unittest sancov_merger_test

Review URL: https://codereview.chromium.org/1737263003

Cr-Commit-Position: refs/heads/master@{#34578}
      33ffced5
  27. 02 Mar, 2016 1 commit
  29. 12 Feb, 2016 1 commit
  31. 02 Feb, 2016 1 commit
  33. 26 Jan, 2016 1 commit
  35. 25 Jan, 2016 1 commit
  37. 20 Jan, 2016 1 commit
  39. 19 Jan, 2016 1 commit
  41. 04 Jan, 2016 1 commit
  43. 27 Nov, 2015 2 commits
  45. 25 Nov, 2015 3 commits
  47. 23 Nov, 2015 1 commit
  49. 06 Nov, 2015 1 commit
  51. 03 Nov, 2015 1 commit
    • machenbach's avatar
      [Swarming] Let test runner exit gracefully after test failures. · efcc7fb2
      machenbach authored 
      The flake detection is done on the infra-side according to
the contents of the json test results. We don't want the
runner to fail after flakes.

This was controlled on the infra side by accepting any exit
codes so far. After the swarming switch, this is more
difficult, because the runner is wrapped by the swarming
collect script. There, failing exit codes can mean many
things, including network failures. Therefore, we now
force exit code 0 with test failures if those failures
are reported in the formal test results json.

The infrastructure will take care of reporting the flakes
and failures accordingly.

BUG=chromium:535160
LOG=n

Review URL: https://codereview.chromium.org/1416373005

Cr-Commit-Position: refs/heads/master@{#31740}
      efcc7fb2
  53. 20 Oct, 2015 1 commit
  55. 06 Oct, 2015 1 commit
  57. 01 Oct, 2015 1 commit
    • machenbach's avatar
      [Swarming] Presort tests - slowest first. · 366dc811
      machenbach authored 
      Swarming won't support an incremental data file. By just
sorting the lowest hanging fruits to the beginning we
already get a big bang for the buck (>80% of the improvement
we get otherwise).

This will require semi-regular manual updates of the
slowest tests.

BUG=chromium:535160
LOG=n

Review URL: https://codereview.chromium.org/1385443002

Cr-Commit-Position: refs/heads/master@{#31061}
      366dc811
  59. 29 Sep, 2015 2 commits
  61. 17 Sep, 2015 3 commits
  63. 07 Sep, 2015 1 commit
  65. 07 Aug, 2015 1 commit