- 15 Oct, 2018 23 commits
-
-
Maya Lekova authored
Split the runtime function for initializing a promise into AwaitPromisesInit and AwaitPromisesInitOld, the former not firing the INIT hook and being used by the AwaitOptimized builtin. In addition to this the AsyncHooks now caches all the previously inited promises and checks that the init hook is not fired twice for the same promise. Modified test expectations for the new async ids in the async hooks tests. Bug: v8:8300 Change-Id: If4a17e501b2a233578fa70b6442f219473f001d9 Reviewed-on: https://chromium-review.googlesource.com/c/1280442 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56642}
-
Igor Sheludko authored
This reverts commit 6ec90ece. Reason for revert: causes a lot of Canary crashes (chromium:895208). GC relies on an the fact that the transition array stays alive while it's owner map is alive (this is needed in order to properly transfer descriptor array ownership to the parent map when the map owning a shared descriptor array dies). We need to rethink a way of caching the migration target shortcut. Original change's description: > Reland "Create a fast path to get migration target when updating map" > > This is a reland of c285380c > > Original change's description: > > Create a fast path to get migration target when updating map > > > > During map updating, store the pointer to new map in the > > raw_transitions slot of the old map that is deprecated from map > > transition tree. Thus, we can get the migration target directly > > instead of TryReplayPropertyTransitions when updating map. > > > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM > > Chromebook and ~9% on big-core Ubuntu. > > > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db > > Reviewed-on: https://chromium-review.googlesource.com/1233433 > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#56303} > > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137 > Reviewed-on: https://chromium-review.googlesource.com/c/1270261 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Cr-Commit-Position: refs/heads/master@{#56588} TBR=ishell@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie7e9b98395b041a1095da549d1cd71d7180a4888 Bug: chromium:895208 Reviewed-on: https://chromium-review.googlesource.com/c/1280223 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56641}
-
Predrag Rudic authored
Port commit 23dbb81d. Original CL message: >This CL uses pc-relative jumps and calls (B/BL) for calls from embedded >builtins to embedded builtins. To make this work, the code range size is >limited to 32MB on arm during mksnapshot, which ensures that all builtin >to builtin offsets for jumps/calls fit into the B/BL immediate. At code >generation time, we put a placeholder into the instruction offset which >we resolve to the right code object when the code is copied to the heap. >We use a new relocation mode RELATIVE_CODE_TARGET for these relative jumps. >The relocation mode RELATIVE_CODE_TARGET should never appear after >generating the snapshot. > >We modify the target_address/set_target_address methods of RelocInfo >such that they return the absolute target addresses for pc-relative B/BL >instructions. This ensures that the GC can treat RELATIVE_CODE_TARGET in >the same way as code targets. This, however, only matters during >snapshot creation time, and production code never contains >RELATIVE_CODE_TARGET relocations. > >Bug: v8:6666 >Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng >Change-Id: If7eab83ad588859ca87c654a5ddc3e37caea884c >Reviewed-on: https://chromium-review.googlesource.com/1117181 >Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> >Reviewed-by: Ulan Degenbaev <ulan@chromium.org> >Reviewed-by: Jakob Gruber <jgruber@chromium.org> >Commit-Queue: Sigurd Schneider <sigurds@chromium.org> >Cr-Commit-Position: refs/heads/master@{#54320} This CL is completed Miran's draft without MIPS64 port. (https://chromium-review.googlesource.com/c/v8/v8/+/1136640/3). Change-Id: I979378ac445548641755968d890f7f4a82dc7986 Reviewed-on: https://chromium-review.googlesource.com/c/1221313 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56640}
-
Jakob Gruber authored
Irregexp code spills and restores ebx at boundaries, and clobbers it inbetween. Root-relative loads are disabled in this region. Bug: v8:6666 Change-Id: I9c68bc8ef88d324da609996a8457ac9e30a9b6fc Reviewed-on: https://chromium-review.googlesource.com/c/1280762Reviewed-by:
-
Michael Lippautz authored
Callers of the ConcurrentMarking API should check the flags, which they were already mostly doing. Change-Id: Ie273bb740fe6d2b36dfb924ce813670ebd47bf3f Reviewed-on: https://chromium-review.googlesource.com/c/1280307Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56638}
-
Ross McIlroy authored
Some jobs might need to be aborted, e.g., if a function is a default parameter in an arrow function it will be re-scoped and won't have a SFI to register. Adds support to abort jobs without having to block if the job is currently running on the background thread. BUG=v8:8041 Change-Id: I9149740401cbaaa31c21be9d79d4e3f5c450bfcf Reviewed-on: https://chromium-review.googlesource.com/c/1278497 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#56637}
-
Sigurd Schneider authored
Change-Id: I5804585565acfabc110b019c5fcecdcabbaf022e Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1276428 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is the first CL in a series that removes the StaticVariable operand. Change-Id: I2acdbf4a7481af43321b8af10dbe38f8f481bea8 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1276365 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ic2c9f22517153dc5bf41f3d6c78fa06dd7cc4f84 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1280306 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Toon Verwaest authored
- use a token-range to quickly identify LHS continuation - queue binding pattern errors only once - outline LHS continuation to reduce memory overhead from aggressive inlining (30kb) Change-Id: Ic0f3cfc3ea0bd6cedb6cea991a69f55f2bada14a Reviewed-on: https://chromium-review.googlesource.com/c/1280207 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56633}
-
Clemens Hammacher authored
{IsAligned} is defined twice with exactly the same signature and implementation: once in base/macros.h, once in utils.h. This CL removes the definition from utils.h. Note that utils.h includes macros.h, so no further changes are needed. R=mlippautz@chromium.org Bug: v8:8238 Change-Id: I589b00c01619d054ff39c717f728a2351b6c32ea Reviewed-on: https://chromium-review.googlesource.com/c/1280206 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56632}
-
Clemens Hammacher authored
Since {Address} is just {uintptr_t}, we can just use the standard {IsAligned} function. R=mlippautz@chromium.org Bug: v8:8238 Change-Id: I260591e88b50855cf327096a07b2c18f0c1e4508 Reviewed-on: https://chromium-review.googlesource.com/c/1280204Reviewed-by: -
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:891314 Change-Id: Iaab09ac543b0928f6a81275f529df73949693c83 Reviewed-on: https://chromium-review.googlesource.com/c/1276425Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56630}
-
Andreas Haas authored
In the existing implementation, the structured cloning flag is only set at the startup of the renderer process. In other words, if structured cloning or wasm threads are turned on when the renderer process starts up, then structured cloning is enabled. However, with the origin trial for wasm threads it's possible that wasm threads get turned on only later when the webpages loads. With this CL we now always also check the wasm threads flag in addition to checking the structured cloning flag. R=mstarzinger@chromium.org Bug: v8:8304 Change-Id: I49da6bd76a4cc38abc01fbe0c9707c6b17a8de3f Reviewed-on: https://chromium-review.googlesource.com/c/1280444Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#56629}
-
Toon Verwaest authored
Change-Id: I448110b10bb4dafdfb05983db92e06383c2913a3 Reviewed-on: https://chromium-review.googlesource.com/c/1280203Reviewed-by:
-
Jakob Gruber authored
With this CL we finally actually set the root register to the correct value. Verification is still preserved by keeping a magic number in IsolateData. Bug: v8:6666 Change-Id: I89cb7cb36f977ac677ec33a814a2798baab4cec4 Reviewed-on: https://chromium-review.googlesource.com/c/1278277Reviewed-by:
-
Georg Neis authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I37c67adc857ce7dec1a06f580d981a35c474df1c Reviewed-on: https://chromium-review.googlesource.com/c/1280322Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56626}
-
Clemens Hammacher authored
There were a lot of tweaks and optimizations to chromium's {base::Optional} implementation. This CL brings us back in sync with that. Some changes were needed to make this compatible with C++11 and with GCC 4.8: 1) Types like std::decay_t and std::enable_if_t were rewritten to use std::decay and std::enable_if. 2) Some conditional no_except declarations were removed. 3) std::is_trivially_copy_constructible and std::is_trivially_move_constructible are assumed to be false on gcc 4 because it's unimplemented there. R=neis@chromium.org Bug: v8:8238 Change-Id: Ia0542c0d4d2fd43a2454f639ec5201ad8d8201cd Reviewed-on: https://chromium-review.googlesource.com/c/1275824 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
With the flag enabled, that phase runs in the background as part of OptimizeGraph. Bug: v8:7790 Change-Id: I313578c113be1fb76dfc315522906178bee1027d Reviewed-on: https://chromium-review.googlesource.com/c/1268156Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
There's no ambiguity and the shorter name makes things easier to read. Bug: v8:7790 Change-Id: Ibcf3fd7f38a91e26a83cd335fad0ec80a5fe9be1 Reviewed-on: https://chromium-review.googlesource.com/c/1278392 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Properly handle the case where the CheckFloat64Hole becomes a no-op after RETYPE (because the feedback type is already Number). We always need to pass the Number restriction type here. Bug: chromium:895199 Change-Id: I96a949ba35db1e6d35abedddc4507c101d95b716 Reviewed-on: https://chromium-review.googlesource.com/c/1278804Reviewed-by:
-
Jaroslav Sevcik authored
This fixes the typing for the case when the call is not lowered to the simplified operator. Bug: chromium:880207 Change-Id: Icecf12de77ece0fe9ffec2777874f5f0004a1e97 Reviewed-on: https://chromium-review.googlesource.com/c/1278642 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e270920..9578c43 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I67c5cb1f4f781605098e106289061d4f4e449236 Reviewed-on: https://chromium-review.googlesource.com/c/1279935 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56620}
-
- 14 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e4c7352..e270920 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/94faf32..dd78844 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7a2eedb4f0271ce281c9722c384add7195e0e38a Reviewed-on: https://chromium-review.googlesource.com/c/1279925 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 13 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dbb4fad..e4c7352 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c8b97e3..5aac72d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/066e110..94faf32 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I73f0237a1799d01c5dec0df65763300626b19de6 Reviewed-on: https://chromium-review.googlesource.com/c/1279922Reviewed-by:
-
- 12 Oct, 2018 15 commits
-
-
Bill Budge authored
- Adds embedder callback to notify fully tiered compilation is finished, returning a WasmCompiledModule for serialization. - Adds function to pass previously compiled bytes into WASM streaming compilation, for deserialization. - Plumbs this API through StreamingDecoder. Bug: chromium:719172 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ibe376f3a8ccfa90fda730ef4ff6628a1532da45c Reviewed-on: https://chromium-review.googlesource.com/c/1252884Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#56617}
-
Michaël Zasso authored
The dependency is not required to build V8 but Node.js needs it for running mjsunit tests. Refs: https://github.com/nodejs/node-v8/issues/83 Change-Id: Ieb37acb73e5e2fe417c7d9a16c498565839b7a45 Reviewed-on: https://chromium-review.googlesource.com/c/1278166Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56616}
-
Jakob Kummerow authored
This makes it possible for handles.h to #include objects.h, which upcoming changes will need. Bug: v8:3770 Change-Id: I4f500736028668749bb73fb24f9732df757e97d0 Reviewed-on: https://chromium-review.googlesource.com/c/1278487Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#56615}
-
Maya Lekova authored
Bug:v8:8303 NOTRY=true Change-Id: I45da1a1f0f16488610ddabfd0bb88408571fa161 Reviewed-on: https://chromium-review.googlesource.com/c/1278279 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
For the --async-stack-traces we can also look through initial parts of the promise chain that were created by regular Promise#then() calls to walk up to the first async function frame. This addresses the missing support for aforementioned example ```js (async function() { await Promise.resolve().then(() => console.log(new Error().stack)); })(); ``` which now also works. Bug: v8:7522 Change-Id: I574943c1fc6ee4a1bd56f208dce78eb7506c5c4f Reviewed-on: https://chromium-review.googlesource.com/c/1278276Reviewed-by: -
Clemens Hammacher authored
LockGuard is mostly used with Mutex. Since both are defined outside the internal namespace, we often have to write {base::LockGuard<base::Mutex>}. This CL shortens this to {base::MutexGuard} across the code base R=mlippautz@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I020d5933b73aafb98c4b72e3bb2dfd07c979ba73 Reviewed-on: https://chromium-review.googlesource.com/c/1278796Reviewed-by: -
Sathya Gunasekaran authored
When trying to print the scope information for the class fields initializer function, the debugger asks the parser to parse the class literal as a function literal (to get the scope info) ... which doesn't quite work. Instead of adding support for parsing the class literal, we just short cicruit this parsing step by just returning an empty context. This works fine because initializer function doesn't have any variables in it's local scope. The one caveat is that the objects in the scope above this function (like the global) are now missing. This trade off is possibly fine for now, as adding parsing support for class literal to only produce would be a lot of code for not enough use. As a follow up to this change, the devtools UI needs to be updated to handle this empty context cleanly. Currently, it doesn't show the `this` object if no context exists even if the `this` object is correctly passed to the UI from the backend. Bug: v8:5367, v8:8122 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I52965f26241bbf6abdc988783aa0fc44bb36901f Reviewed-on: https://chromium-review.googlesource.com/c/1274268 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56611}
-
Maya Lekova authored
This reverts commit b5800a63. Reason for revert: Proper fix has already landed, see https://chromium-review.googlesource.com/c/v8/v8/+/1278386 Original change's description: > [test] Skpping flaky object-seal test on TSAN > > NOTRY=true > > TBR=machenbach@chromium.org > > Bug: v8:8294 > Change-Id: Ib235139087bd6a651dc8bd43c5f9990e0513c7a5 > Reviewed-on: https://chromium-review.googlesource.com/c/1276627 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56573} TBR=machenbach@chromium.org,mslekova@chromium.org Change-Id: I641aa14c2a5c4a4d1db3cde6048cf355b59e4f7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8294 Reviewed-on: https://chromium-review.googlesource.com/c/1278795Reviewed-by:
-
Ross McIlroy authored
The memory pressure notification logic wasn't correct and given the current users of the compiler dispatcher aren't posting speculative tasks, it isn't particularly useful. After removing this, the abort logic can also be simplified significantly by removing the non-blocking abort logic. BUG=v8:8041 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I584533b58fb717fdca46cc620822914d6bdb28b8 Reviewed-on: https://chromium-review.googlesource.com/c/1278495Reviewed-by:
-
Maya Lekova authored
Updated the test so that it uses assertPromiseResult, which makes sure that a promise rejection is not swallowed. The change is reflected in the actual async ids, checked in the test. Bug: v8:8300 Change-Id: Ie227ca74a8cf4e0e079809b21c3abc5a5f87c11a Reviewed-on: https://chromium-review.googlesource.com/c/1278388 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Ross McIlroy authored
There was a small race where an idle task could be posted after the compiler dispatcher had aborted and the CancellableTaskRunner had been cancelled. This was causing flakyness on the bots. This fixes this by moving the idle task posting into the same lock block as the notification to the main thread that the background task has completed. BUG=v8:8041 Change-Id: I43ca4cea807bfdfeb13f6d1c4a67a4d8a4f6291f Reviewed-on: https://chromium-review.googlesource.com/c/1278494Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=unittests/WasmOpcodeLengthTest.Statements BUG=v8:8091 Change-Id: Ia2a01d5c35ace33c9c8a29a8df7b30e3f1e119cc Reviewed-on: https://chromium-review.googlesource.com/c/1278728Reviewed-by:
-
Clemens Hammacher authored
We generally try to use the most specific type, but sometimes we still used LiftoffRegister even though it's statically known that it always holds a GP register. Make these uses use Register directly. Note that the conversion between Register and LiftoffRegister is a noop in Release builds. R=titzer@chromium.org Bug: v8:6600 Change-Id: I1cf9aa727fb6fd71bbc1eed77df5e9d01e35ddee Reviewed-on: https://chromium-review.googlesource.com/c/1278727Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56605}
-
Ulan Degenbaev authored
This fixes a potential data race that can happen when a freshly allocated layout descriptor is set on an existing map while the concurrent marker is using the map to visit an object. Change-Id: If8ff1c9368b24beb15fefe4a78a21e0f0784d2e8 Reviewed-on: https://chromium-review.googlesource.com/c/1278726Reviewed-by:
-
Hai Dang authored
Change-Id: Iec5e6baff16260317f693188b01230ab0c2bb86f Reviewed-on: https://chromium-review.googlesource.com/c/1278809Reviewed-by:
-
