- 10 Nov, 2017 25 commits
-
-
Pierre Langlois authored
Turn cases where we are multiplying with a power of two into a left shift. We hit this optimisation roughly 500 times in the snapshot. Bug: Change-Id: Ibd3104a3dbe49f247a2d84db94891f6e3a897026 Reviewed-on: https://chromium-review.googlesource.com/763229Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#49306}
-
Bill Budge authored
- Eliminates OS::ReleaseRegion, replacing with calls to OS::Free. - Adds bool return value to OS::Free. - Cleans up types of flags, protection on Windows and Cygwin. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6a642374e33876966a5552fb0cdf552dc6d79aaa Reviewed-on: https://chromium-review.googlesource.com/762345 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49305}
-
Benjamin authored
Adds block-level coverage tracking for binary && and || expressions. Introduces a BinaryOperation source-range for tracking the operations themselves and an Expression source-range, used for tracking NaryLogical expressions. This builds on work by jgruber@chromium.org in the issue. TBR=marja@chromium.org R=jgruber@chromium.org, rmcilroy@chromium.org Bug: v8:6660 Change-Id: I83a81f13a3514a734c06948b2d3e91138fb00e18 Reviewed-on: https://chromium-review.googlesource.com/754564 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49304}
-
Jakob Gruber authored
This reverts commit 22932d6b. Reason for revert: TSAN https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/18232 Original change's description: > Reland "[runtime] Slightly optimize creation of class literals." > > Bug: v8:5799 > Change-Id: I782ec131c7194aef20942a19750168a974913c3f > Reviewed-on: https://chromium-review.googlesource.com/757337 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49291} TBR=ulan@chromium.org,rmcilroy@chromium.org,jarin@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I0742d25b0e2364efc696d19492ba20614a3821fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5799 Reviewed-on: https://chromium-review.googlesource.com/763458Reviewed-by:
-
Mike Stanton authored
We introduce nodes with control output during intrinsic IsInstanceType lowering, and must carefully connect them to subsequent control inputs. Bug: v8:7002 Change-Id: I2e3066943b8f7e36652438ae6ca560932188203e Reviewed-on: https://chromium-review.googlesource.com/763633Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49302}
-
Daniel Clifford authored
Bug: chromium:778668 Change-Id: Ie75f2ecb9e6134b6eb57c7d7fb6ea33cbb2fc2bf Reviewed-on: https://chromium-review.googlesource.com/753324 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Mike Stanton authored
This is a reland of ba76ad68 Original change's description: > [Turbofan] Introduce AllocateRaw node > > In order to simplify and verify the TurboFan graph, we > need to wire allocations into the control chain after > effect control linearization. > > Bug: v8:7002 > Change-Id: I4c5956c8d16773d721482d46a0b407bee01a9597 > Reviewed-on: https://chromium-review.googlesource.com/738139 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49209} TBR=jarin@chromium.org Bug: v8:7002 Change-Id: Iba588c498bb5de113abfba7f9e40cfe4325dea4a Reviewed-on: https://chromium-review.googlesource.com/758436 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49300}
-
Ivica Bogosavljevic authored
MIPS team has recently migrated to @mips.com e-mail address. Dusan Simicic is no longer part of MIPS V8 team, therefore his name is removed from OWNERS. TBR=mstarzinger@chromium.org NOTRY=true Bug: Change-Id: I67fde24a5b9214fa3fca05c0399888b8d18fc699 Reviewed-on: https://chromium-review.googlesource.com/758639 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49299}
-
Michael Starzinger authored
R=petermarshall@chromium.org Change-Id: I6901ddcd1ca1fda474e8d2766fbfc60d2f5a9bec Reviewed-on: https://chromium-review.googlesource.com/763628Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49298}
-
Michael Achenbach authored
We'll use one generic isolate for all number fuzzers. The previous deopt isolate will be deleted, once the infra hooks have changed. Bug: v8:6917 Change-Id: I809613548cd935a0208febb002572cc063697324 Reviewed-on: https://chromium-review.googlesource.com/763534Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49297}
-
Michal Majewski authored
Temporary implementation of GC fuzzer based on the deopt fuzzer. It will be merged with the deopt fuzzer to create more general numfuzzer. Webkit test suite updated to ignore trace_incremental_marking flag output. Bug: v8:6917 Change-Id: I053ae32f3cd3f74ba8b71fc5bdfc7264f54dca11 Reviewed-on: https://chromium-review.googlesource.com/758437 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:7012 Change-Id: I5895fcda768696c90f3f766d4beef6f75ec9f79f Reviewed-on: https://chromium-review.googlesource.com/763530 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
Speculative revert due to canary crashes. I'll begin relanding these one-by-one next week. This bundles two reverts: Revert "[snapshot] Lazy-deserialize bytecode handlers" This reverts commit b4587369. Revert "[interpreter] Remove mechanism for bytecode handler reuse" This reverts commit 07fc87a2. TBR: rmcilroy@chromium.org,mlippautz@chromium.org,yangguo@chromium.org Bug: chromium:783708 Change-Id: I6f8314b9eeafd9412a1c69843bc242e7da240eee Reviewed-on: https://chromium-review.googlesource.com/763428 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Keep separate track of isolate cache hits that conflict with producing/consuming the code cache, so that we can see how many code cache hits are "stolen" by the isolate cache, and how many isolate cache entries are "wasted" by recompiling for cache production. Bug: chromium:769203 Change-Id: I3d8dbfc6a8981b779eb073176454ad43dfbcbaaf Reviewed-on: https://chromium-review.googlesource.com/763368Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49293}
-
Clemens Hammacher authored
This is a reland of 6c613288 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} Bug: v8:6600, chromium:782280 Change-Id: I82a75bfeaf83dc63a2917da3ccdc4721c5d689e7 Reviewed-on: https://chromium-review.googlesource.com/763387Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49292}
-
Igor Sheludko authored
Bug: v8:5799 Change-Id: I782ec131c7194aef20942a19750168a974913c3f Reviewed-on: https://chromium-review.googlesource.com/757337 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 9664d017. Reason for revert: Planned revert, this is on Canary 3264 and V8 branch 6.4.245. Original change's description: > [snapshot] Flip --lazy-handler-deserialization > > Flip this for a day or two to gather perf bot results & stability > issues. Results will be collected in https://crbug.com/782637. > > TBR=hablich@chromium.org > > Bug: v8:6624, chromium:782637 > Change-Id: I70eb5d6287d4723f935715ef80d9ba129dc282f0 > Reviewed-on: https://chromium-review.googlesource.com/758375 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49222} TBR=hablich@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6624, chromium:782637 Change-Id: I2a6ee63f7191d186810d7352ee63b6b664e74157 Reviewed-on: https://chromium-review.googlesource.com/763427 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 6c613288. Reason for revert: breaks compilation on win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/69 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} TBR=titzer@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I386983da7f9f03d54cef2190b01fd2cc5785966e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:782280 Reviewed-on: https://chromium-review.googlesource.com/763367Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49289}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1c66ba1..3dd2b5f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I345def7a1ade64accc9570b8c8af6f0514058da1 Reviewed-on: https://chromium-review.googlesource.com/763130Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49288}
-
Michael Starzinger authored
R=hpayer@chromium.org BUG=v8:6792 Change-Id: Iba360a83c8c1d929c29c0a4e0c5f32cef8755c85 Reviewed-on: https://chromium-review.googlesource.com/758650Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49287}
-
Clemens Hammacher authored
This was not implemented so far, leading to lots of clusterfuzz issues. Testing this feature would require complicating the interface a lot and exposing more implementation details in the header file, hence we just go with regression tests for now. R=ahaas@chromium.org, titzer@chromium.org Bug: v8:6600, chromium:782280 Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee Reviewed-on: https://chromium-review.googlesource.com/758772Reviewed-by:
-
Camillo Bruni authored
- Implement exchangeable timer clock for RuntimeCallStats for testing - Rewrite RuntimeCAllStatsTest to overwrite the default RCS timer This gets rid of the previous flakiness for these tests due to using the real platform timer. Bug: v8:5677 Change-Id: Iff312c7f79ab97407ba1c0c2c72fb0b35a5efdf1 Reviewed-on: https://chromium-review.googlesource.com/760416Reviewed-by:
-
Mathias Bynens authored
The DEPS roll in f3a2e34d updated ICU to a version that includes a fix for https://ssl.icu-project.org/trac/ticket/13462. As a result, our Script_Extension data is now correct again. This patch re-enables the Test262 tests that were failing due to this ICU data bug. BUG=v8:4743 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: If0f08693ed0355c59b9c02aa6d941dab1588431c Reviewed-on: https://chromium-review.googlesource.com/761616Reviewed-by:
-
Georg Neis authored
There were some places left where that could happen. Bug: chromium:782754 Change-Id: I1db1f5b361cdf443b730a220c0e569ad48dd298d Reviewed-on: https://chromium-review.googlesource.com/758841Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1cfb9fe..1c66ba1 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/73ddd64..93a751e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I05cc6e607da1ae1f7afbd147735a5ccb83e9d6e6 Reviewed-on: https://chromium-review.googlesource.com/762988Reviewed-by:
-
- 09 Nov, 2017 15 commits
-
-
Sergiy Byelozyorov authored
This came up in https://crrev.com/c/758410 R=machenbach@chromium.org Change-Id: Ia6849a34962628fb17ef61b803f10a1e7c334cd9 Reviewed-on: https://chromium-review.googlesource.com/758852Reviewed-by:
-
Myles Borins authored
Fixes .gyp scaffolding for building on Windows. Patch from Refael Ackermann <refack@gmail.com>. https://github.com/nodejs/node/pull/16848/commits/5528afd073efe3fe4f5019887f30134d649abc16 Bug=v8:7061 Change-Id: I4faaf3f488b6725942746d74838ef7ce73b1e8d0 Reviewed-on: https://chromium-review.googlesource.com/761477Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49280}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cfed275..1cfb9fe Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/af046c5..f83c79a Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/b318966..5ed2698 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I03094c38301d65ce0795f9fbc0d8660ffce47f49 Reviewed-on: https://chromium-review.googlesource.com/761321Reviewed-by:
-
Michael Starzinger authored
R=mlippautz@chromium.org BUG=v8:6792 Change-Id: I4b148b4bcb6e3cb73bc58eaad61d52a14da19a35 Reviewed-on: https://chromium-review.googlesource.com/760739Reviewed-by:
-
Michael Lippautz authored
Removes the handling of the flag independent. The flag will be removed in a followup. The patch changes handling of V8::PersistentBase that are set to Weak: - The Scavenger ignores the flag independent. - The Scavenger keeps alive anything that is marked as Active. - The Scavenger is free to drop weak handles of non-Active object if they are otherwise dead. Active: - Any JSObject will always be marked Active. - Any JSApiObject will be marked Active if it has been modified (=has elements, properties, etc.) CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:780749 Change-Id: If1f547f2419930ad9400bd3b11bdbf609cb57649 Reviewed-on: https://chromium-review.googlesource.com/741801 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Converts the ast prettyprinter to printing literals from the raw values rather than internalized on-heap strings. This enables ast printing before internalizing, and means we can avoid use of the isolate in the interpreter's off-thread phase. Also removes --print-builtin-ast and relies on just --print-ast to print everything. Finally, converts FunctionLiteral's debug_name function to return a char[] which is created from the raw name literal where it exists, rather than relying on the value having been internalized. BUG=v8:5203 Change-Id: Ib69f754e254736f415db38713e6209465817e6f1 Reviewed-on: https://chromium-review.googlesource.com/758681Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49276}
-
Martyn Capewell authored
Align the claimed arguments in Generate_JSConstructStubGeneric by pushing an extra copy of the receiver as padding. Bug: v8:6644 Change-Id: I77e92624ff32c21c8f3f310176aa2576c756b56c Reviewed-on: https://chromium-review.googlesource.com/757098 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Id13b0d84ee255d12ecaf4a30479e7c7173462d5c Reviewed-on: https://chromium-review.googlesource.com/760360Reviewed-by:
-
Bill Budge authored
This is a reland of 7e78506f Original change's description: > [Memory] Use OS::Allocate for all OS memory allocations. > > - Eliminates OS::ReserveRegion and OS::ReserveAlignedRegion. > - Changes OS::Allocate to take alignment parameter, reorders parameters > to match page_allocator. > - Since the size of memory allocation can be deduced, don't return the > amount of memory allocated. > - Changes reservation of aligned address space. Before we would reserve > (size + alignment) rounded up to page size. This is too much, because > maximum misalignment is (alignment - page_size). > - On Windows and Cygwin, we release an oversize allocation and > immediately retry at the aligned address in the allocation. If we > lose the address due to a race, we just retry. > - Clean up all the calls to OS::Allocate in codegen and tests by adding > helper AllocateSystemPage function (allocation.h) and > AllocateAssemblerBuffer (cctest.h). > - Changes 'assm' to 'masm' in some targets for consistency when using > a macro-assembler. > > Bug: chromium:756050 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I306dbe042cc867670fdc935abca29db074b0da71 > Reviewed-on: https://chromium-review.googlesource.com/749848 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49235} Bug: chromium:756050 Change-Id: I333f7a6aea0bcb608d01cafb43e94893a4625b15 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/758509Reviewed-by:
-
Ulan Degenbaev authored
Bug: Change-Id: Ice28172e75a9fce1bad199b13e3fc0c123aaf42f Reviewed-on: https://chromium-review.googlesource.com/758588Reviewed-by:
-
Igor Sheludko authored
This is necessary in order to support class literals boilerplates which will contain descriptor arrays not attached to maps. This CL introduces Heap::descriptor_array_map() which will be used only for descriptor arrays templates created as a part of class literal boilerplate. We don't use the new map for all descriptors for now because in order to handle chicken-egg problem in deserializer which can be solved in a clean and readable way only if introduce a DESCRIPTOR_ARRAY_TYPE instance type which we can't currently do because the InstanceType enum is already "full". Bug: v8:5799 Change-Id: I732d236b0dda2c436ab3ce3ac5967f6c66162df3 Reviewed-on: https://chromium-review.googlesource.com/758360 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Eric Holk authored
This was meant to be included in https://crrev.com/c/757129 but got missed somehow. The fuzzer was generating i64.store instructions with an i32 value argument instead of i64 like it should be. Bug: Change-Id: I5b5bcdb22b2ac3abe872e7ff0ab0019b5ecb9c98 Reviewed-on: https://chromium-review.googlesource.com/759148Reviewed-by:
-
Michael Starzinger authored
R=mvstanton@chromium.org Change-Id: Iff5a3741ba93ea2cc9d4b9f9907b22ce768b1cb3 Reviewed-on: https://chromium-review.googlesource.com/758840 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
jgruber authored
Move block coverage logic for TryCatchStatement and TryFinallyStatement nodes into builder classes. Bug: v8:6000 Change-Id: I0402ef78a54d6ba1bae62214f16aabfebbd7c581 Reviewed-on: https://chromium-review.googlesource.com/758645 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds test coverage for write-protected code pages by adding the feature to the existing "stress_incremental_marking" variant. Since this is considered a temporary state, the variant has not been renamed. R=machenbach@chromium.org BUG=v8:6792 Change-Id: I62fa5aa15bf5309b12fbc269fcf81069845755f9 Reviewed-on: https://chromium-review.googlesource.com/753388Reviewed-by:
-
