1. 14 Feb, 2019 1 commit
  2. 07 Jun, 2018 1 commit
  3. 23 May, 2017 2 commits
    • machenbach's avatar
      Revert of [es2015] Precompute the descriptive string for symbols. (patchset #3... · 3d40a47a
      machenbach authored
      Revert of [es2015] Precompute the descriptive string for symbols. (patchset #3 id:40001 of https://codereview.chromium.org/2900703002/ )
      
      Reason for revert:
      Speculative revert for:
      https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/8901
      
      Original issue's description:
      > [es2015] Precompute the descriptive string for symbols.
      >
      > Previously the String constructor and the Symbol.prototype.toString
      > methods had to compute the descriptive string for a Symbol on the fly,
      > which can produce a lot of garbage when this happens a lot, i.e. when
      > the String representation of a Symbol is used often. Now instead of
      > doing this on-demand we can just do it upfront when creating the Symbol.
      >
      > That way we also ensure that we won't throw an exception when accessing
      > the descriptive string of a Symbol, due to potential String length
      > overflow, but have the exception during Symbol creation upfront, which
      > is a lot less surprising behavior.
      >
      > BUG=v8:6278,v8:6344,v8:6350
      > TBR=mlippautz@chromium.org
      > R=ishell@chromium.org
      >
      > Review-Url: https://codereview.chromium.org/2900703002
      > Cr-Commit-Position: refs/heads/master@{#45479}
      > Committed: https://chromium.googlesource.com/v8/v8/+/e87573822e1c0c041c03f2b60599b0ab9256422f
      
      TBR=ishell@chromium.org,mlippautz@chromium.org,bmeurer@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:6278,v8:6344,v8:6350
      
      Review-Url: https://codereview.chromium.org/2903533002
      Cr-Commit-Position: refs/heads/master@{#45483}
      3d40a47a
    • bmeurer's avatar
      [es2015] Precompute the descriptive string for symbols. · e8757382
      bmeurer authored
      Previously the String constructor and the Symbol.prototype.toString
      methods had to compute the descriptive string for a Symbol on the fly,
      which can produce a lot of garbage when this happens a lot, i.e. when
      the String representation of a Symbol is used often. Now instead of
      doing this on-demand we can just do it upfront when creating the Symbol.
      
      That way we also ensure that we won't throw an exception when accessing
      the descriptive string of a Symbol, due to potential String length
      overflow, but have the exception during Symbol creation upfront, which
      is a lot less surprising behavior.
      
      BUG=v8:6278,v8:6344,v8:6350
      TBR=mlippautz@chromium.org
      R=ishell@chromium.org
      
      Review-Url: https://codereview.chromium.org/2900703002
      Cr-Commit-Position: refs/heads/master@{#45479}
      e8757382
  4. 21 Mar, 2017 1 commit
  5. 16 Mar, 2017 1 commit