- 14 Nov, 2018 1 commit
-
-
Leszek Swirski authored
Moves the unicode predicate cache tables out of the unicode cache, and turns them into generic predicates in char-predicates.h which use static constexpr tables. This drops the per-isolate cost of unicode caches, and removes the need for accessing the unicode cache from most files. It does remove the mutability of the cache, which means that there may be regressions when parsing non-ASCII identifiers. Most likely the benefits to ASCII identifiers/keywords will outweigh any non-ASCII costs. Change-Id: I9a7a8b7c9b22d3e9ede824ab4e27f133ce20a399 Reviewed-on: https://chromium-review.googlesource.com/c/1335564Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57506}
-
- 09 Nov, 2018 1 commit
-
-
Leszek Swirski authored
Change the keyword/identifier scan to a single loop that branchlessly collects information on whether this is a possible keyword, identifier terminator or slow path (i.e. escapes) by looking up the value in a flags table (as long as the character is ascii). Also rewrites that loop as an AdvanceUntil, and sprinkles in some V8_LIKELY magic which is 'likely' to improve things. Change-Id: If06b0fff23630e7593b515308e5ffeca2d65daa8 Reviewed-on: https://chromium-review.googlesource.com/c/1328943Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57391}
-
- 05 Sep, 2018 1 commit
-
-
Camillo Bruni authored
Bug: v8:7926 Change-Id: I62e05240fd2bb165ddf8965b77763ec11a40a609 Reviewed-on: https://chromium-review.googlesource.com/1202543 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55636}
-
- 29 Aug, 2018 1 commit
-
-
Toon Verwaest authored
This CL additionally uses IsInRange for token range checks. That only uses one branch rather than two. Change-Id: I52c6759ba195b55cb50c2ce9afbdc9b397495633 Reviewed-on: https://chromium-review.googlesource.com/1193875Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#55494}
-
- 06 Mar, 2018 1 commit
-
-
Taketoshi Aono authored
Revert "Revert "[parser] Implements proposal-numeric-separator."" This reverts commit 782f6401. Original CL is https://chromium-review.googlesource.com/c/v8/v8/+/923441 Bug: v8:7317 Change-Id: I6f541c038bad0cff625094ba84aebe582bdeb12f Reviewed-on: https://chromium-review.googlesource.com/945034Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51749}
-
- 01 Mar, 2018 2 commits
-
-
Deepti Gandluri authored
This reverts commit 517df524. Reason for revert: Fails MSAN tests - https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/20030 Original change's description: > [parser] Implements proposal-numeric-separator. > > https://github.com/tc39/proposal-numeric-separator > > This proposal-numeric-separator extends NumericLiteral and > allows developers to insert underscore(_) inside numeric literal. > > Bug: v8:7317 > Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 > Reviewed-on: https://chromium-review.googlesource.com/923441 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51671} TBR=adamk@chromium.org,jkummerow@chromium.org,hablich@chromium.org,gsathya@chromium.org,mathias@chromium.org,goto@google.com,brn@b6n.ch Change-Id: I6dcf46820caf20f28fbc11d94a5e8ced3cbbc78d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7317 Reviewed-on: https://chromium-review.googlesource.com/944767Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51672}
-
Taketoshi Aono authored
https://github.com/tc39/proposal-numeric-separator This proposal-numeric-separator extends NumericLiteral and allows developers to insert underscore(_) inside numeric literal. Bug: v8:7317 Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 Reviewed-on: https://chromium-review.googlesource.com/923441 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51671}
-
- 09 Mar, 2016 1 commit
-
-
yangguo authored
As described in unicode database file PropertyValueAliases.txt R=littledan@chromium.org BUG=v8:4743 LOG=N Review URL: https://codereview.chromium.org/1776953002 Cr-Commit-Position: refs/heads/master@{#34638}
-
- 07 Mar, 2016 3 commits
-
-
yangguo authored
R=littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655 Cr-Commit-Position: refs/heads/master@{#34553} Review URL: https://codereview.chromium.org/1774513002 Cr-Commit-Position: refs/heads/master@{#34562}
-
yangguo authored
Revert of [regexp] extend property classes by script category. (patchset #1 id:1 of https://codereview.chromium.org/1774513002/ ) Reason for revert: wrong noi18n expectations Original issue's description: > [regexp] extend property classes by script category. > > R=littledan@chromium.org > BUG=v8:4743 > LOG=N > > Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655 > Cr-Commit-Position: refs/heads/master@{#34553} TBR=littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4743 Review URL: https://codereview.chromium.org/1772563003 Cr-Commit-Position: refs/heads/master@{#34554}
-
yangguo authored
R=littledan@chromium.org BUG=v8:4743 LOG=N Review URL: https://codereview.chromium.org/1774513002 Cr-Commit-Position: refs/heads/master@{#34553}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 03 Mar, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/969353003 Cr-Commit-Position: refs/heads/master@{#26962}
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Jul, 2013 1 commit
-
-
rossberg@chromium.org authored
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-7.8.3 ES6 extends the numeric literals to support explicit support for binary and octal literals using the following syntax: 0b10101 0o777 This is currently behind the flag, --harmony-numeric-literals BUG=2783 R=rossberg@chromium.org Review URL: https://codereview.chromium.org/19300002 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15772 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Nov, 2011 1 commit
-
-
kmillikin@chromium.org authored
This shaves 416+ KB, just under 1% off the size of the debug d8 executable on Linux (mostly because the CheckHelper functions for assertions were getting separate copies for each compilation unit). The difference in release builds is negligible---a size reduction of 0.1%. Also, change namespace-level 'static const' variables to remove the static storage class as it's the default. R=danno@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8680013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Sep, 2010 1 commit
-
-
erik.corry@gmail.com authored
Add and use AsciiAlphaToLower. Move RemoveLast test. Add Clear test. This is a commit of http://codereview.chromium.org/3307003/show http://codereview.chromium.org/3312007/show and http://codereview.chromium.org/3341002/show for tfarina git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 May, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact. Review URL: http://codereview.chromium.org/115756 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Mar, 2009 1 commit
-
-
lrn@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1525 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Dec, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
- Splitting of character classes into word and non-word parts. - A bunch of refactorings. - Made dispatch table construction lazy. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-