- 09 Nov, 2018 2 commits
-
-
Clemens Hammacher authored
Implement similar functionality in the unit test which used this field. One test gets slightly weaker by this. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I0b047ff54f08a4549a2f78af30e21296bb1ee63f Reviewed-on: https://chromium-review.googlesource.com/c/1327042 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57403}
-
Clemens Hammacher authored
1) Use own test fixture {CancelableTaskManagerTest}. 2) Avoid base::AtomicWord. 3) Use unique_ptr. 4) Fix order of expected and actual values in EXPECT_EQ. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I3d29785864bbf3de58c5d9d5384b9e0065255e99 Reviewed-on: https://chromium-review.googlesource.com/c/1325967 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57378}
-
- 08 Nov, 2018 1 commit
-
-
Clemens Hammacher authored
It's too easy to implicitly cast it to bool, as we did in several tests. Also, move TryAbortResult out of CancelableTaskManager to avoid too much typing when referencing one of the enum values. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: Ia3fa8597428876217bc86f9b8b31c21ae4846fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1326027 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57363}
-
- 17 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6bd8e0c8c1965f22a3429fda12bc70ae454c39c2 Reviewed-on: https://chromium-review.googlesource.com/1226978Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55930}
-
- 02 Aug, 2017 1 commit
-
-
Michael Lippautz authored
They were only limited to 32 bit when using the internal Hashmap. Since this has changed alreay some time ago, we can switch to 64 bit ids and check that we never overflow. Bug: Change-Id: Ia6c6d02d6b5e555c6941185a79427dc4aa2a1d62 Reviewed-on: https://chromium-review.googlesource.com/598229 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47085}
-
- 04 Jan, 2017 1 commit
-
-
jochen authored
BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2615603002 Cr-Commit-Position: refs/heads/master@{#42068}
-
- 15 Nov, 2015 1 commit
-
-
paul.lind authored
From 60e7ea8a / https://codereview.chromium.org/1409993012 BUG= Review URL: https://codereview.chromium.org/1442143003 Cr-Commit-Position: refs/heads/master@{#31999}
-
- 14 Nov, 2015 1 commit
-
-
mlippautz authored
This change binds each {Cancelable} task to a so-called {CancelableTaskManager}, which is then used to handle concurrent cancelation as well as synchronizing shutdown for already running tasks. Since ownership of tasks is transferred to the platform executing a task (destructor), handling in the manager uses integer ids. Note that this also mitigates (modulo integer size) the ABA problem. All handling of {Cancelable} tasks is now encapsulated into the corresponding manager, which is instantiated for each isolate. R=hpayer@chromium.org BUG=chromium:524425 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg;tryserver.v8:v8_linux_gc_stress_dbg;tryserver.v8:v8_mac_gc_stress_dbg;tryserver.v8:v8_linux64_msan_rel;tryserver.v8:v8_linux64_tsan_rel;tryserver.v8:v8_mac64_asan_rel Review URL: https://codereview.chromium.org/1409993012 Cr-Commit-Position: refs/heads/master@{#31997}
-