1. 18 Sep, 2019 1 commit
    • Mike Stanton's avatar
      [Turbofan] Wiser zone allocation for child serializers · 3c3bd147
      Mike Stanton authored
      The serialization step in the pipeline gets an initial zone, and thus
      far, it's allocated all of it's hinting information in that zone.
      However, much of this comes from stepping into calls and
      walking the bytecode of the called function. Once we finished
      recursing into a call, we should be able to throw all those
      hints away -- they've served their purpose, and the "output"
      of their work is a set of new objects made visible to the broker.
      
      Therefore, we should create and destroy a child zone.
      
      On a run of typescript, this reduces absolute max (high water mark)
      allocation of the serialization phase from 10 MB to 5 MB.
      
      Bug: v8:7790
      Change-Id: Icbb35abed28b1a924328541df82be23594152a8f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800570Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63872}
      3c3bd147
  2. 24 May, 2019 1 commit
  3. 29 Mar, 2019 1 commit
  4. 20 Jun, 2017 3 commits
    • Mircea Trofin's avatar
      [wasm] Throttle the amount of unfinished work to avoid OOM (non-blocking) · 70090151
      Mircea Trofin authored
      It is possible that the foreground task is unable to clear the
      scheduled unfinished work, eventually leading to an OOM.
      
      We use either code_range on 64 bit, or the capacity of the code space,
      as a heuristic for how much memory to use for compilation.
      
      The change avoids blocking the background threads while we're over
      the memory threshold. This is to avoid starving the GC.
      
      Bug: v8:6492, chromium:732010
      Change-Id: Ic2647d9fa71af4f8cdd2149a434b107cbed3a6c3
      Reviewed-on: https://chromium-review.googlesource.com/540763
      Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46029}
      70090151
    • Mircea Trofin's avatar
      Revert "Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM""" · 3a0704f7
      Mircea Trofin authored
      This reverts commit 1835b4b1.
      
      Reason for revert: This has a perf regression, wasn't ready just yet.
      
      Original change's description:
      > Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM""
      > 
      > This reverts commit 4ee49181.
      > 
      > Reason for revert: Fix: in d8, blocking all the bg threads starves the GC.
      > 
      > Original change's description:
      > > Revert "[wasm] Throttle the amount of unfinished work to avoid OOM"
      > > 
      > > This reverts commit 1280954d.
      > > 
      > > Reason for revert: Speculative, GC stress bots started taking much longer after this change.
      > > 
      > > Original change's description:
      > > > [wasm] Throttle the amount of unfinished work to avoid OOM
      > > > 
      > > > It is possible that the foreground task is unable to clear the
      > > > scheduled unfinished work, eventually leading to an OOM.
      > > > 
      > > > We use either code_range on 64 bit, or the capacity of the code space,
      > > > as a heuristic for how much memory to use for compilation.
      > > > 
      > > > Bug: v8:6492, chromium:732010
      > > > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d
      > > > Reviewed-on: https://chromium-review.googlesource.com/535017
      > > > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      > > > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#46017}
      > > 
      > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      > > 
      > > Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2
      > > No-Presubmit: true
      > > No-Tree-Checks: true
      > > No-Try: true
      > > Bug: v8:6492, chromium:732010
      > > Reviewed-on: https://chromium-review.googlesource.com/540270
      > > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#46020}
      > 
      > TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      > 
      > Change-Id: I1e7a1d0202c3161f9a7139e8895eebf472473ad3
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:6492, chromium:732010
      > Reviewed-on: https://chromium-review.googlesource.com/540841
      > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
      > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
      > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46022}
      
      TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,mtrofin@google.com,ahaas@chromium.org
      
      Change-Id: Ic1351325173b233be3972ff3c159c035838fa963
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6492, chromium:732010
      Reviewed-on: https://chromium-review.googlesource.com/540842Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
      Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46023}
      3a0704f7
    • Mircea Trofin's avatar
      Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM"" · 1835b4b1
      Mircea Trofin authored
      This reverts commit 4ee49181.
      
      Reason for revert: Fix: in d8, blocking all the bg threads starves the GC.
      
      Original change's description:
      > Revert "[wasm] Throttle the amount of unfinished work to avoid OOM"
      > 
      > This reverts commit 1280954d.
      > 
      > Reason for revert: Speculative, GC stress bots started taking much longer after this change.
      > 
      > Original change's description:
      > > [wasm] Throttle the amount of unfinished work to avoid OOM
      > > 
      > > It is possible that the foreground task is unable to clear the
      > > scheduled unfinished work, eventually leading to an OOM.
      > > 
      > > We use either code_range on 64 bit, or the capacity of the code space,
      > > as a heuristic for how much memory to use for compilation.
      > > 
      > > Bug: v8:6492, chromium:732010
      > > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d
      > > Reviewed-on: https://chromium-review.googlesource.com/535017
      > > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      > > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#46017}
      > 
      > TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      > 
      > Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:6492, chromium:732010
      > Reviewed-on: https://chromium-review.googlesource.com/540270
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46020}
      
      TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      
      Change-Id: I1e7a1d0202c3161f9a7139e8895eebf472473ad3
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6492, chromium:732010
      Reviewed-on: https://chromium-review.googlesource.com/540841Reviewed-by: 's avatarBrad Nelson <bradnelson@chromium.org>
      Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
      Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46022}
      1835b4b1
  5. 19 Jun, 2017 2 commits
    • Bill Budge's avatar
      Revert "[wasm] Throttle the amount of unfinished work to avoid OOM" · 4ee49181
      Bill Budge authored
      This reverts commit 1280954d.
      
      Reason for revert: Speculative, GC stress bots started taking much longer after this change.
      
      Original change's description:
      > [wasm] Throttle the amount of unfinished work to avoid OOM
      > 
      > It is possible that the foreground task is unable to clear the
      > scheduled unfinished work, eventually leading to an OOM.
      > 
      > We use either code_range on 64 bit, or the capacity of the code space,
      > as a heuristic for how much memory to use for compilation.
      > 
      > Bug: v8:6492, chromium:732010
      > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d
      > Reviewed-on: https://chromium-review.googlesource.com/535017
      > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46017}
      
      TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      
      Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6492, chromium:732010
      Reviewed-on: https://chromium-review.googlesource.com/540270Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46020}
      4ee49181
    • Mircea Trofin's avatar
      [wasm] Throttle the amount of unfinished work to avoid OOM · 1280954d
      Mircea Trofin authored
      It is possible that the foreground task is unable to clear the
      scheduled unfinished work, eventually leading to an OOM.
      
      We use either code_range on 64 bit, or the capacity of the code space,
      as a heuristic for how much memory to use for compilation.
      
      Bug: v8:6492, chromium:732010
      Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d
      Reviewed-on: https://chromium-review.googlesource.com/535017
      Commit-Queue: Brad Nelson <bradnelson@chromium.org>
      Reviewed-by: 's avatarBrad Nelson <bradnelson@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46017}
      1280954d
  6. 17 Oct, 2016 2 commits
  7. 10 Oct, 2016 1 commit
  8. 07 Oct, 2016 1 commit
  9. 06 Oct, 2016 1 commit
  10. 23 Sep, 2016 1 commit
  11. 22 Sep, 2016 1 commit
  12. 20 Sep, 2016 1 commit
  13. 01 Apr, 2016 1 commit
  14. 11 Jan, 2016 1 commit
  15. 20 Apr, 2015 1 commit
  16. 09 Feb, 2015 1 commit
  17. 23 Jan, 2015 1 commit
    • danno's avatar
      Remove the dependency of Zone on Isolate · c7b09aac
      danno authored
      Along the way:
      - Thread isolate parameter explicitly through code that used to
        rely on getting it from the zone.
      - Canonicalize the parameter position of isolate and zone for
        affected code
      - Change Hydrogen New<> instruction templates to automatically
        pass isolate
      
      R=mstarzinger@chromium.org
      LOG=N
      
      Review URL: https://codereview.chromium.org/868883002
      
      Cr-Commit-Position: refs/heads/master@{#26252}
      c7b09aac
  18. 23 Oct, 2014 1 commit
  19. 21 Oct, 2014 1 commit