- 18 Sep, 2019 1 commit
-
-
Mike Stanton authored
The serialization step in the pipeline gets an initial zone, and thus far, it's allocated all of it's hinting information in that zone. However, much of this comes from stepping into calls and walking the bytecode of the called function. Once we finished recursing into a call, we should be able to throw all those hints away -- they've served their purpose, and the "output" of their work is a set of new objects made visible to the broker. Therefore, we should create and destroy a child zone. On a run of typescript, this reduces absolute max (high water mark) allocation of the serialization phase from 10 MB to 5 MB. Bug: v8:7790 Change-Id: Icbb35abed28b1a924328541df82be23594152a8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800570Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#63872}
-
- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 29 Mar, 2019 1 commit
-
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in compiler code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I3baf3ecbfe2c853cb17bb479ebbf140382193b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545896 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60527}
-
- 20 Jun, 2017 3 commits
-
-
Mircea Trofin authored
It is possible that the foreground task is unable to clear the scheduled unfinished work, eventually leading to an OOM. We use either code_range on 64 bit, or the capacity of the code space, as a heuristic for how much memory to use for compilation. The change avoids blocking the background threads while we're over the memory threshold. This is to avoid starving the GC. Bug: v8:6492, chromium:732010 Change-Id: Ic2647d9fa71af4f8cdd2149a434b107cbed3a6c3 Reviewed-on: https://chromium-review.googlesource.com/540763 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#46029}
-
Mircea Trofin authored
This reverts commit 1835b4b1. Reason for revert: This has a perf regression, wasn't ready just yet. Original change's description: > Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM"" > > This reverts commit 4ee49181. > > Reason for revert: Fix: in d8, blocking all the bg threads starves the GC. > > Original change's description: > > Revert "[wasm] Throttle the amount of unfinished work to avoid OOM" > > > > This reverts commit 1280954d. > > > > Reason for revert: Speculative, GC stress bots started taking much longer after this change. > > > > Original change's description: > > > [wasm] Throttle the amount of unfinished work to avoid OOM > > > > > > It is possible that the foreground task is unable to clear the > > > scheduled unfinished work, eventually leading to an OOM. > > > > > > We use either code_range on 64 bit, or the capacity of the code space, > > > as a heuristic for how much memory to use for compilation. > > > > > > Bug: v8:6492, chromium:732010 > > > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d > > > Reviewed-on: https://chromium-review.googlesource.com/535017 > > > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > > > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#46017} > > > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org > > > > Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:6492, chromium:732010 > > Reviewed-on: https://chromium-review.googlesource.com/540270 > > Reviewed-by: Bill Budge <bbudge@chromium.org> > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#46020} > > TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,ahaas@chromium.org > > Change-Id: I1e7a1d0202c3161f9a7139e8895eebf472473ad3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:6492, chromium:732010 > Reviewed-on: https://chromium-review.googlesource.com/540841 > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46022} TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,mtrofin@google.com,ahaas@chromium.org Change-Id: Ic1351325173b233be3972ff3c159c035838fa963 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6492, chromium:732010 Reviewed-on: https://chromium-review.googlesource.com/540842Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46023}
-
Mircea Trofin authored
This reverts commit 4ee49181. Reason for revert: Fix: in d8, blocking all the bg threads starves the GC. Original change's description: > Revert "[wasm] Throttle the amount of unfinished work to avoid OOM" > > This reverts commit 1280954d. > > Reason for revert: Speculative, GC stress bots started taking much longer after this change. > > Original change's description: > > [wasm] Throttle the amount of unfinished work to avoid OOM > > > > It is possible that the foreground task is unable to clear the > > scheduled unfinished work, eventually leading to an OOM. > > > > We use either code_range on 64 bit, or the capacity of the code space, > > as a heuristic for how much memory to use for compilation. > > > > Bug: v8:6492, chromium:732010 > > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d > > Reviewed-on: https://chromium-review.googlesource.com/535017 > > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#46017} > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org > > Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:6492, chromium:732010 > Reviewed-on: https://chromium-review.googlesource.com/540270 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46020} TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,ahaas@chromium.org Change-Id: I1e7a1d0202c3161f9a7139e8895eebf472473ad3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6492, chromium:732010 Reviewed-on: https://chromium-review.googlesource.com/540841Reviewed-by: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#46022}
-
- 19 Jun, 2017 2 commits
-
-
Bill Budge authored
This reverts commit 1280954d. Reason for revert: Speculative, GC stress bots started taking much longer after this change. Original change's description: > [wasm] Throttle the amount of unfinished work to avoid OOM > > It is possible that the foreground task is unable to clear the > scheduled unfinished work, eventually leading to an OOM. > > We use either code_range on 64 bit, or the capacity of the code space, > as a heuristic for how much memory to use for compilation. > > Bug: v8:6492, chromium:732010 > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d > Reviewed-on: https://chromium-review.googlesource.com/535017 > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46017} TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6492, chromium:732010 Reviewed-on: https://chromium-review.googlesource.com/540270Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#46020}
-
Mircea Trofin authored
It is possible that the foreground task is unable to clear the scheduled unfinished work, eventually leading to an OOM. We use either code_range on 64 bit, or the capacity of the code space, as a heuristic for how much memory to use for compilation. Bug: v8:6492, chromium:732010 Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d Reviewed-on: https://chromium-review.googlesource.com/535017 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#46017}
-
- 17 Oct, 2016 2 commits
-
-
heimbuef authored
This adds more useful information to the v8-heap-stats tool. BUG=v8:5489 Review-Url: https://codereview.chromium.org/2394213003 Cr-Commit-Position: refs/heads/master@{#40361}
-
jochen authored
R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe Review-Url: https://codereview.chromium.org/2416243002 Cr-Commit-Position: refs/heads/master@{#40350}
-
- 10 Oct, 2016 1 commit
-
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f Review-Url: https://codereview.chromium.org/2348303002 Cr-Original-Original-Commit-Position: refs/heads/master@{#39633} Cr-Original-Commit-Position: refs/heads/master@{#40048} Cr-Commit-Position: refs/heads/master@{#40138}
-
- 07 Oct, 2016 1 commit
-
-
hablich authored
Revert of Replaced different means of zone pooling/reusing by one zone segment pool (patchset #5 id:160001 of https://codereview.chromium.org/2348303002/ ) Reason for revert: related to roll blocker: https://codereview.chromium.org/2400343002/ Original issue's description: > Replaced different means of zone pooling/reusing by one zone segment pool > > BUG=v8:5409 > > Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f > Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f > Cr-Original-Commit-Position: refs/heads/master@{#39633} > Cr-Commit-Position: refs/heads/master@{#40048} TBR=mstarzinger@chromium.org,verwaest@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2401163002 Cr-Commit-Position: refs/heads/master@{#40099}
-
- 06 Oct, 2016 1 commit
-
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f Review-Url: https://codereview.chromium.org/2348303002 Cr-Original-Commit-Position: refs/heads/master@{#39633} Cr-Commit-Position: refs/heads/master@{#40048}
-
- 23 Sep, 2016 1 commit
-
-
hablich authored
Revert of Replaced different means of zone pooling/reusing by one zone segment pool (patchset #3 id:120001 of https://codereview.chromium.org/2348303002/ ) Reason for revert: Blocks Roll https://codereview.chromium.org/2366733002/ Original issue's description: > Replaced different means of zone pooling/reusing by one zone segment pool > > BUG=v8:5409 > > Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f > Cr-Commit-Position: refs/heads/master@{#39633} TBR=mstarzinger@chromium.org,verwaest@chromium.org,heimbuef@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2360403003 Cr-Commit-Position: refs/heads/master@{#39651}
-
- 22 Sep, 2016 1 commit
-
-
heimbuef authored
BUG=v8:5409 Review-Url: https://codereview.chromium.org/2348303002 Cr-Commit-Position: refs/heads/master@{#39633}
-
- 20 Sep, 2016 1 commit
-
-
heimbuef authored
This is some initial cleanup to keep /src clean. The AccountingAllocator is actually exclusively used by zones and this common subfolder makes that more clear. BUG=v8:5409 Review-Url: https://codereview.chromium.org/2344143003 Cr-Commit-Position: refs/heads/master@{#39558}
-
- 01 Apr, 2016 1 commit
-
-
jochen authored
We expect that the majority of malloc'd memory held by V8 is allocated in Zone objects. Introduce an Allocator class that is used by Zones to manage memory, and allows for querying the current usage. BUG=none R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org LOG=n TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1847543002 Cr-Commit-Position: refs/heads/master@{#35196}
-
- 11 Jan, 2016 1 commit
-
-
titzer authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1578723002 Cr-Commit-Position: refs/heads/master@{#33202}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 09 Feb, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org TEST=presubmit Review URL: https://codereview.chromium.org/905293002 Cr-Commit-Position: refs/heads/master@{#26525}
-
- 23 Jan, 2015 1 commit
-
-
danno authored
Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate R=mstarzinger@chromium.org LOG=N Review URL: https://codereview.chromium.org/868883002 Cr-Commit-Position: refs/heads/master@{#26252}
-
- 23 Oct, 2014 1 commit
-
-
dcarney@chromium.org authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/669053002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Oct, 2014 1 commit
-
-
dcarney@chromium.org authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/665893006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-