1. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  2. 18 Oct, 2017 1 commit
  3. 22 May, 2017 1 commit
  4. 14 May, 2016 1 commit
  5. 05 Oct, 2015 1 commit
    • karl's avatar
      Fix compilation with GCC 5.2 · e28183b5
      karl authored
      Fixes:
      
      ../../test/cctest/compiler/test-js-typed-lowering.cc:224:14:
       error: ‘kJSTypes’ defined but not used [-Werror=unused-variable]
        static Type* kJSTypes[] = {Type::Undefined(), Type::Null(),   Type::Boolean(),
      
      ../../src/bignum.cc: In member function
       ‘void v8::internal::Bignum::AssignDecimalString(Vector<const char>)’:
        ../../src/bignum.cc:80:6: error: assuming signed overflow does not occur when
        assuming that (X + c) < X is always false [-Werror=strict-overflow]
      
      ../../src/compiler/ia32/code-generator-ia32.cc:1366:3:
        required from here ../../src/base/logging.h:123:26:
         error: comparison between signed and unsigned integer expressions
         [-Werror=sign-compare] DEFINE_CHECK_OP_IMPL(EQ, ==)
      
      BUG=
      
      Review URL: https://codereview.chromium.org/1371823002
      
      Cr-Commit-Position: refs/heads/master@{#31095}
      e28183b5
  6. 14 Aug, 2015 1 commit
  7. 01 Jun, 2015 1 commit
  8. 04 Aug, 2014 1 commit
  9. 20 Jun, 2014 1 commit
  10. 03 Jun, 2014 1 commit
  11. 29 Apr, 2014 1 commit
  12. 05 Jul, 2013 1 commit
  13. 08 Apr, 2013 1 commit
  14. 05 Jul, 2011 1 commit
  15. 09 Feb, 2011 1 commit
  16. 08 Nov, 2010 1 commit