1. 14 Aug, 2018 1 commit
  2. 27 Jul, 2018 1 commit
    • Peter Marshall's avatar
      [cpu-profiler] Use instruction start as the key for the CodeMap · ba752ea4
      Peter Marshall authored
      Previously we used the start address of the AbstractCode object. This
      doesn't make sense for off-heap builtins, where the code isn't contained
      in the object itself. It also hides other potential problems - sometimes
      the sample.pc is inside the AbstractCode object header - this is
      never valid.
      
      There were a few changes necessary to make this happen:
        - Change the interface of CodeMoveEvent. Now 'to' and 'from' are both
          AbstractCode objects, which is nice because many users were taking
          'to' and adding the header offset to it to try and find the
          instruction start address. This isn't valid for off-heap builtins.
        - Fix a bug in CodeMap::MoveCode where we didn't update the CodeEntry
          object to reflect the new instruction_start.
        - Rename the 'start' field in all of the CodeEventRecord sub-classes
          to make it clear that this is the address of the first instruction.
        - Fix the confusion in RecordTickSample between 'tos' and 'pc' which
          caused pc_offset to be calculated incorrectly.
      
      Bug: v8:7983
      Change-Id: I3e9dddf74e4b2e96a5f031d216ef7008d6f184d1
      Reviewed-on: https://chromium-review.googlesource.com/1148457
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54749}
      ba752ea4
  3. 16 Jul, 2018 2 commits
  4. 03 Jul, 2018 1 commit
    • Camillo Bruni's avatar
      [tools] parse-processor improvements · a8582eb2
      Camillo Bruni authored
      - display script size overview
      - color scripts in overview depending on eval, streaming or other scripts
      - fix stats to always take own-bytes into accout
      - rename all *Time properties to *Duration for consistency
      - extract ScriptSource log event into separate method
      - support script source events in parse-processor
      
      Bug: chromium:757467, chromium:850038
      Change-Id: I227d1d5952ae9e508ab1a01146fcf47f74a3f7ea
      Reviewed-on: https://chromium-review.googlesource.com/1117195
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54159}
      a8582eb2
  5. 27 Jun, 2018 1 commit
  6. 26 Jun, 2018 1 commit
  7. 25 Jun, 2018 1 commit
    • Camillo Bruni's avatar
      Reland "[parser][log] Log script id during background compilation" · e7f5c5cc
      Camillo Bruni authored
      This reverts commit a800e050.
      
      Original change's description:
      > Revert "[parser][log] Log script id during background compilation"
      >
      > This reverts commit aafd5c52.
      >
      > Reason for revert: Tentative revert for
      >
      > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
      > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
      >
      > Original change's description:
      > > [parser][log] Log script id during background compilation
      > >
      > > - Add separate script-create, script-reserve-id and script-details log events
      > > - Add log events for CompilationCache hits and puts
      > > - Simplify function event logging by only pass along the script id
      > > - Explicitly create Scripts in parse-processor.js on script events only
      > > - Create a temporary script id in the ParseInfo for use during background
      > >   parsing and compilation
      > > - Clean up ParseInfo initialization to centralize creation and use of
      > >   script ids
      > > - Allow creating Scripts with predefined script ids
      > >
      > > Bug: chromium:757467, chromium:850038
      > > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
      > > Reviewed-on: https://chromium-review.googlesource.com/1097131
      > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
      > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#53978}
      >
      > TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
      >
      > Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: chromium:757467, chromium:850038
      > Reviewed-on: https://chromium-review.googlesource.com/1112538
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53984}
      
      TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:757467, chromium:850038
      Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
      Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53994}
      e7f5c5cc
  8. 22 Jun, 2018 3 commits
  9. 13 Jun, 2018 1 commit
  10. 11 Jun, 2018 1 commit
    • Matheus Marchini's avatar
      [log] fix ExistingCodeLogger behavior on edge case · b20faffb
      Matheus Marchini authored
      ExistingCodeLogger was behaving incorrectly when the CodeEventHandler
      API was used in combination with --interpreted-frames-native-stack.
      Instead of collecting copied trampolines as InterpretedFunction:functionName,
      they were being collected as Builtin:IntepreterEntryTrampolines.
      This patch adds special handling for copied trampolines when
      using ExistingCodeLogger.
      
      R=yangguo@google.com
      
      Change-Id: I3ee4be03800122d28d53b51b20c60dcf6263e4c1
      Reviewed-on: https://chromium-review.googlesource.com/1087813Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53624}
      b20faffb
  11. 28 May, 2018 1 commit
  12. 11 May, 2018 1 commit
  13. 04 May, 2018 1 commit
  14. 18 Apr, 2018 1 commit
  15. 17 Apr, 2018 2 commits
  16. 23 Mar, 2018 1 commit
  17. 22 Mar, 2018 1 commit
  18. 09 Mar, 2018 1 commit
  19. 20 Feb, 2018 1 commit
  20. 05 Feb, 2018 1 commit
  21. 20 Dec, 2017 2 commits
  22. 08 Dec, 2017 1 commit
  23. 29 Nov, 2017 1 commit
  24. 17 Nov, 2017 2 commits
  25. 14 Nov, 2017 2 commits
  26. 07 Nov, 2017 2 commits
  27. 03 Nov, 2017 2 commits
  28. 30 Oct, 2017 1 commit
  29. 27 Oct, 2017 1 commit
  30. 24 Oct, 2017 2 commits