- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112 Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48138}
-
- 28 Aug, 2017 1 commit
-
-
Mateusz Czeladka authored
As part of J2V8 development (https://github.com/eclipsesource/J2V8), we realized that we had a subtle bug in how Isolate scope was created and it's lifetime managed, see: https://github.com/eclipsesource/J2V8/issues/313. Mentioned above bug was fixed, however, what we also noticed is that V8 API has been constantly and slowly moving to such an API, in which one has to pass Isolate explicitly to methods and/or constructors. We found two more places that might have been overlooked. This contribution adds passing of Isolate pointer explicitly to constructors of String::Utf8Value and String::Value classes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I61984285f152aba5ca922100cf3df913a9cb2cea Reviewed-on: https://chromium-review.googlesource.com/593309 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47656}
-
- 22 May, 2017 2 commits
-
-
dgozman authored
- reduce boilerplate; - encapsulate V8Inspector inside IsolateData; - remove extra interfaces and classes. BUG=none Review-Url: https://codereview.chromium.org/2901523003 Cr-Commit-Position: refs/heads/master@{#45470}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2894773003 Cr-Commit-Position: refs/heads/master@{#45441}
-
- 18 May, 2017 1 commit
-
-
dgozman authored
- moved all extensions to inspector_test.cc; - properly supported multiple context groups and sessions; - better isolation between components; - better infrastructure in protocol-test. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2890463004 Cr-Commit-Position: refs/heads/master@{#45409}
-
- 17 May, 2017 1 commit
-
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2887013002 Cr-Commit-Position: refs/heads/master@{#45356}
-
- 16 May, 2017 2 commits
-
-
dgozman authored
This brings clear separation to tasks vs isolate management. BUG=none Review-Url: https://codereview.chromium.org/2885253002 Cr-Commit-Position: refs/heads/master@{#45355}
-
dgozman authored
This will make it easier to create more connections/context groups. BUG=none Review-Url: https://codereview.chromium.org/2886903003 Cr-Commit-Position: refs/heads/master@{#45352}
-
- 26 Apr, 2017 1 commit
-
-
yangguo authored
V8 can bundle user scripts in the start up snapshot. These are shared across contexts, and do not work well context groups. R=kozyatinskiy@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2836623002 Cr-Original-Commit-Position: refs/heads/master@{#44847} Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 Review-Url: https://codereview.chromium.org/2836623002 Cr-Commit-Position: refs/heads/master@{#44897}
-
- 25 Apr, 2017 2 commits
-
-
yangguo authored
Revert of [inspector] always include user scripts in the snapshot. (patchset #3 id:40001 of https://codereview.chromium.org/2836623002/ ) Reason for revert: So that https://codereview.chromium.org/2841993002/ can be reverted. Original issue's description: > [inspector] always include user scripts in the snapshot. > > V8 can bundle user scripts in the start up snapshot. These are > shared across contexts, and do not work well context groups. > > R=kozyatinskiy@chromium.org > BUG=v8:6274 > > Review-Url: https://codereview.chromium.org/2836623002 > Cr-Commit-Position: refs/heads/master@{#44847} > Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 TBR=kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6274 Review-Url: https://codereview.chromium.org/2840923002 Cr-Commit-Position: refs/heads/master@{#44868}
-
yangguo authored
V8 can bundle user scripts in the start up snapshot. These are shared across contexts, and do not work well context groups. R=kozyatinskiy@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2836623002 Cr-Commit-Position: refs/heads/master@{#44847}
-
- 21 Apr, 2017 1 commit
-
-
kozyatinskiy authored
.. replace all of them with prepared global object template. + bonus: wrap inspector related methods with inspector namespace. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2832723004 Cr-Commit-Position: refs/heads/master@{#44785}
-
- 23 Mar, 2017 1 commit
-
-
kozyatinskiy authored
BUG=none TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2773723002 Cr-Commit-Position: refs/heads/master@{#44064}
-
- 22 Mar, 2017 1 commit
-
-
kozyatinskiy authored
Indisputable profit: - correct break location in next task (see tests), - stepOver with async await never lands in random code (see related test and issue), - inspector doesn't store current stepping state in debugger agent and completely trust V8 - step to new inspector-V8 design (I will finish design doc soon). - willExecuteScript and didExecuteScript instrumentation could be removed from code base - reduce probability of future errors. - finally - less code, - stepping implementation in V8 makes another step to follow our stepping strategy (stepOut should do stepInto and break when exit current frame) (another one one page design doc based on @aandrey comment is coming), - knowledge about existing of context groups is still inspector-only. Disputable part is related to super rare scenario when in single isolate we have more then one context group id with enabled debugger agent: - if one agent request break in own context (stepping, pause, e.t.c.) then we ignore all breaks in another agent. From one hand it looks like good: user clicks stepInto and they don't expect that execution could be paused by another instance of DevTools in unobservable from current DevTools way (second DevTools will get paused notification and run nested message loop). From another hand we shouldn't ignore breakpoints or debugger statement never. In general, I think that proposed behavior is rathe feature then issue. - and disadvantage, on attempt to break in non-target context group id we just call StepOut until reach target context group id, step out call could deoptimize code in non related to current debugger agent context. But break could happens only in case of debugger stmt or breakpoint - sound like minor issue. Ignoring break on exception sounds like real issue but by module of rareness of this case I think we can ignore this. Implementation details: - when debugger agent request break for any reason it passes target context group id to V8Debugger - last agent requesting break is preferred. - when V8Debugger gets BreakProgramRequested notification from V8, it checks current context group id against target context group id, if they match then just process break as usual otherwise makes StepOut action, - debug.cc at the end of microtask if last_scheduled_action is StepOut, schedules StepIn and will break on first instruction in next task. BUG=chromium:654022 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2748503002 Cr-Commit-Position: refs/heads/master@{#44034}
-
- 07 Mar, 2017 1 commit
-
-
kozyatinskiy authored
BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2737603006 Cr-Commit-Position: refs/heads/master@{#43657}
-
- 03 Feb, 2017 1 commit
-
-
kozyatinskiy authored
V8DebuggerAgentImpl::m_skipAllPaused is moved to V8Debugger. V8DebuggerAgentImpl::didPaused doesn't return shouldBreak flag and called only when break is required and stack trace presented. V8DebuggerAgentImpl doesn't store paused context. Logic of conversion step-next at return into step-in is moved to debug.cc. BUG=none R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2668763003 Cr-Commit-Position: refs/heads/master@{#42907}
-
- 31 Jan, 2017 1 commit
-
-
kozyatinskiy authored
Test just checks that all basic features are working correctly with modules. BUG=v8:1569 R=dgozman@chromium.org,alph@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2663743002 Cr-Commit-Position: refs/heads/master@{#42796}
-
- 13 Dec, 2016 1 commit
-
-
kozyatinskiy authored
BUG=v8:5738 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2574803002 Cr-Commit-Position: refs/heads/master@{#41680}
-
- 04 Nov, 2016 1 commit
-
-
kozyatinskiy authored
This method iterates through all shared function info which are related to passed script, compiles debug code for SFI in range if needed and returns possible break locations. BUG=chromium:566801 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2465553003 Cr-Commit-Position: refs/heads/master@{#40783}
-
- 19 Oct, 2016 1 commit
-
-
kozyatinskiy authored
.. to make windows bot happy. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428213002 Cr-Commit-Position: refs/heads/master@{#40415}
-
- 07 Oct, 2016 1 commit
-
-
kozyatinskiy authored
String16 is not public part of src/inspector. All usage are replaced with vector of char/unit16_t to avoid potential linker problems. BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2403493002 Cr-Commit-Position: refs/heads/master@{#40098}
-
- 05 Oct, 2016 2 commits
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2389133004 Cr-Commit-Position: refs/heads/master@{#40003}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2384373002 Cr-Commit-Position: refs/heads/master@{#39998}
-
- 02 Oct, 2016 1 commit
-
-
kozyatinskiy authored
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b Review-Url: https://codereview.chromium.org/2372793002 Cr-Original-Commit-Position: refs/heads/master@{#39891} Cr-Commit-Position: refs/heads/master@{#39929}
-
- 30 Sep, 2016 3 commits
-
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/dc1c71c0dc8a5c4ade4aa291f2ddcd02e90c64b2 Review-Url: https://codereview.chromium.org/2361623006 Cr-Original-Commit-Position: refs/heads/master@{#39866} Cr-Commit-Position: refs/heads/master@{#39918}
-
machenbach authored
Revert "[inspector] added inspector test runner [part 1]" This reverts commit dc1c71c0. Revert "[inspector] added inspector test runner [part 2]" This reverts commit cceaa122. Blocks the roll: https://codereview.chromium.org/2379053003/ In particular android debug: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/137605 BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2387603002 Cr-Commit-Position: refs/heads/master@{#39909}
-
machenbach authored
Revert "[inspector] added inspector test runner [part 3]" This reverts commit f3f9f444. Revert "[inspector] added inspector test runner [part 4]" This reverts commit 4a5f5d09. Revert "[inspector] added inspector test runner [part 5]" This reverts commit 9ddbdab1. Reverting this in order to revert parts 1-2 which block the roll: https://codereview.chromium.org/2379053003/ BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2379303002 Cr-Commit-Position: refs/heads/master@{#39908}
-
- 29 Sep, 2016 2 commits
-
-
kozyatinskiy authored
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2372793002 Cr-Commit-Position: refs/heads/master@{#39891}
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2361623006 Cr-Commit-Position: refs/heads/master@{#39866}
-