1. 25 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Fix (D)CHECK macros in src/{debug,inspector} · 8d38c15e
      Clemens Hammacher authored
      Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an
      embedded comparison. This gives better error messages and also does the
      right comparison for signed/unsigned mismatches.
      
      This will allow us to reenable the readability/check cpplint check.
      
      R=yangguo@chromium.org
      
      Bug: v8:6837
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112
      Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48138}
      8d38c15e
  2. 28 Aug, 2017 1 commit
  3. 22 May, 2017 2 commits
  4. 18 May, 2017 1 commit
  5. 17 May, 2017 1 commit
  6. 16 May, 2017 2 commits
  7. 26 Apr, 2017 1 commit
  8. 25 Apr, 2017 2 commits
  9. 21 Apr, 2017 1 commit
  10. 23 Mar, 2017 1 commit
  11. 22 Mar, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] changed a way of preserving stepping between tasks · 760c56bd
      kozyatinskiy authored
      Indisputable profit:
      - correct break location in next task (see tests),
      - stepOver with async await never lands in random code (see related test and issue),
      - inspector doesn't store current stepping state in debugger agent and completely trust V8 - step to new inspector-V8 design (I will finish design doc soon).
      - willExecuteScript and didExecuteScript instrumentation could be removed from code base - reduce probability of future errors.
      - finally - less code,
      - stepping implementation in V8 makes another step to follow our stepping strategy (stepOut should do stepInto and break when exit current frame) (another one one page design doc based on @aandrey comment is coming),
      - knowledge about existing of context groups is still inspector-only.
      
      Disputable part is related to super rare scenario when in single isolate we have more then one context group id with enabled debugger agent:
      - if one agent request break in own context (stepping, pause, e.t.c.) then we ignore all breaks in another agent. From one hand it looks like good: user clicks stepInto and they don't expect that execution could be paused by another instance of DevTools in unobservable from current DevTools way (second DevTools will get paused notification and run nested message loop). From another hand we shouldn't ignore breakpoints or debugger statement never. In general, I think that proposed behavior is rathe feature then issue.
      - and disadvantage, on attempt to break in non-target context group id we just call StepOut until reach target context group id, step out call could deoptimize code in non related to current debugger agent context. But break could happens only in case of debugger stmt or breakpoint - sound like minor issue. Ignoring break on exception sounds like real issue but by module of rareness of this case I think we can ignore this.
      
      Implementation details:
      - when debugger agent request break for any reason it passes target context group id to V8Debugger - last agent requesting break is preferred.
      - when V8Debugger gets BreakProgramRequested notification from V8, it checks current context group id against target context group id, if they match then just process break as usual otherwise makes StepOut action,
      - debug.cc at the end of microtask if last_scheduled_action is StepOut, schedules StepIn and will break on first instruction in next task.
      
      BUG=chromium:654022
      R=dgozman@chromium.org,yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2748503002
      Cr-Commit-Position: refs/heads/master@{#44034}
      760c56bd
  12. 07 Mar, 2017 1 commit
  13. 03 Feb, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] V8DebuggerAgent cleanup · 3a4f5faf
      kozyatinskiy authored
      V8DebuggerAgentImpl::m_skipAllPaused is moved to V8Debugger.
      V8DebuggerAgentImpl::didPaused doesn't return shouldBreak flag and called only when break is required and stack trace presented.
      V8DebuggerAgentImpl doesn't store paused context.
      Logic of conversion step-next at return into step-in is moved to debug.cc.
      
      BUG=none
      R=dgozman@chromium.org,yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2668763003
      Cr-Commit-Position: refs/heads/master@{#42907}
      3a4f5faf
  14. 31 Jan, 2017 1 commit
  15. 13 Dec, 2016 1 commit
  16. 04 Nov, 2016 1 commit
  17. 19 Oct, 2016 1 commit
  18. 07 Oct, 2016 1 commit
  19. 05 Oct, 2016 2 commits
  20. 02 Oct, 2016 1 commit
  21. 30 Sep, 2016 3 commits
  22. 29 Sep, 2016 2 commits