1. 12 Jul, 2011 1 commit
  2. 10 Jun, 2011 1 commit
    • mikhail.naganov@gmail.com's avatar
      "Deiceolate" Thread classes. · 508b22c4
      mikhail.naganov@gmail.com authored
      Thread class was receiving an isolate parameter by default.
      This approact violates the assumption that only VM threads
      can have an associated isolate, and can lead to troubles,
      because accessing the same isolate from different threads
      leads to race conditions.
      
      This was found by investigating mysterious failures of the
      CPU profiler layout test on Linux Chromium. As almost all
      threads were associated with some isolate, the sampler was
      trying to sample them.
      
      As a side effect, we have also fixed the DebuggerAgent test.
      
      Thanks to Vitaly for help in fixing isolates handling!
      
      R=vitalyr@chromium.org
      BUG=none
      TEST=none
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      508b22c4
  3. 06 May, 2011 1 commit
  4. 28 Apr, 2011 1 commit
  5. 05 Apr, 2011 1 commit
    • mikhail.naganov@gmail.com's avatar
      Simplify isolates access during stack iteration (WAS: Move... · c9904976
      mikhail.naganov@gmail.com authored
      Simplify isolates access during stack iteration (WAS: Move SafeStackFrameIterator::active_count_...)
      
      While trying to fix Mac and Windows versions for this change:
      http://codereview.chromium.org/6771047/, I figured out, that we
      already store an isolate in StackFrameIterator, so we can use it in
      frame objects, instead of requiring it from caller.
      
      I've changed iterators usage to the following scheme: whenever a
      caller maintains an isolate pointer, it just passes it to stack
      iterator, and no more worries about passing it to frame content
      accessors.  If a caller uses current isolate, it can omit passing it
      to iterator, in this case, an iterator will use the current isolate,
      too.
      
      There was a special case with LiveEdit, which creates
      detached copies of frame objects.
      
      R=vitalyr@chromium.org
      BUG=none
      TEST=none
      
      Review URL: http://codereview.chromium.org/6794019
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7499 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      c9904976
  6. 30 Mar, 2011 1 commit
  7. 18 Mar, 2011 3 commits
  8. 06 Jan, 2011 1 commit
    • sgjesse@chromium.org's avatar
      Misc debugger enhancements and bug fixes. · 2957881a
      sgjesse@chromium.org authored
      1. Added gdb style debugger commands (and their shortcuts) for d8.
      These include:
      - s[tep] : step into the current statement.
      - s[tep]i[n]: step into the current statement with the minimum step.
      - n[ext] : step to the next statement.
      - fin[ish] : step out of the current function.
      - cond : setting conditions on breakpoints.
      - d[elete] : deletes breakpoints.
      - en[able]|dis[able]: enables/disables breakpoints including
      exception breakpoints.
      - ignore : ignores a breakpoint for a specified period.
      - inf[o] ar[gs] : info on arguments of the current function.
      - inf[o] lo[cals] : info on local vars of the current function.
      - inf[o] br[eakpoints] : info on breakpoints.
      - l[ist] : similar to source, but allows the user to continually
      dump subsequent lines of source code either in the
      forward or backward direction.
      - quit / exit / disconnect : terminates the remote debugger
      session.
      
      NOTE: Active breakpoints will automatically be disabled when
      the remote debugger detaches. This allows v8 to continue to
      run without worrying about a loss of a debugger session.
      
      2. Added support for breaking the debugger by simply typing ENTER.
      The break command is now optional.
      
      3. Once the debugger is broken, the user can now just type ENTER
      to repeat the last command. This is useful to functionality that
      needs to be invoked repeatedly e.g. step, list.
      
      4. Added more verbose descriptions in d8's help.
      
      5. Fixed a line and column number offset bug in the listing of breakpoint
      line and column numbers.
      
      6. Added a gc command to allow GCs to be requested from the debugger
      interface. The plumbing for requesting different types of GCs is
      there, but the underlying implementation currently only triggers a
      full mark-compact GC. The command also returns the before and after
      sizes of the heap.
      
      7. Added trace json, and flags commands that are not published in help.
      trace json is used for tracing the debugger packets send from and
      received by d8. flags is for setting v8 flags. These are useful for
      people debugging v8 itself, but not necessarily users of v8.
      
      8. Added the ability to enable and disable break on all / uncaught
      exceptions in to d8.
      
      9. Added a fix to prevent the Debugger Agent from being re-instantiated
      if one already exists.
      
      10. Added the ability to filter results of the script command by matching
      text or numbers on the results.
      
      11. Added v8 flags to enable/disable the sending of debugger BeforeCompile,
      AfterCompile, and ScriptCollected events.
      
      12. Fixed some undefined value bugs that resulted in v8 or the debugger
      failing.
      
      13. Added a few minor WEBOS__ customizations (analogous to ANDROID
      customizations).
      
      Patch by Mark Lam from Hewlett-Packard Development Company, LP
      
      Review URL: http://codereview.chromium.org/5980006
      Review URL: http://codereview.chromium.org/6086010
      
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      2957881a
  9. 05 Jan, 2011 2 commits
    • sgjesse@chromium.org's avatar
      Revert r6180 as it caused test failures · 3c2c1d21
      sgjesse@chromium.org authored
      TBR=ricow@chromium.org
      Review URL: http://codereview.chromium.org/6080009
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3c2c1d21
    • sgjesse@chromium.org's avatar
      Misc debugger enhancements and bug fixes. · 8669f630
      sgjesse@chromium.org authored
      1. Added gdb style debugger commands (and their shortcuts) for d8.
      These include:
      - s[tep] : step into the current statement.
      - s[tep]i[n]: step into the current statement with the minimum step.
      - n[ext] : step to the next statement.
      - fin[ish] : step out of the current function.
      - cond : setting conditions on breakpoints.
      - d[elete] : deletes breakpoints.
      - en[able]|dis[able]: enables/disables breakpoints including
      exception breakpoints.
      - ignore : ignores a breakpoint for a specified period.
      - inf[o] ar[gs] : info on arguments of the current function.
      - inf[o] lo[cals] : info on local vars of the current function.
      - inf[o] br[eakpoints] : info on breakpoints.
      - l[ist] : similar to source, but allows the user to continually
      dump subsequent lines of source code either in the
      forward or backward direction.
      - quit / exit / disconnect : terminates the remote debugger
      session.
      
      NOTE: Active breakpoints will automatically be disabled when
      the remote debugger detaches. This allows v8 to continue to
      run without worrying about a loss of a debugger session.
      
      2. Added support for breaking the debugger by simply typing ENTER.
      The break command is now optional.
      
      3. Once the debugger is broken, the user can now just type ENTER
      to repeat the last command. This is useful to functionality that
      needs to be invoked repeatedly e.g. step, list.
      
      4. Added more verbose descriptions in d8's help.
      
      5. Fixed a line and column number offset bug in the listing of breakpoint
      line and column numbers.
      
      6. Added a gc command to allow GCs to be requested from the debugger
      interface. The plumbing for requesting different types of GCs is
      there, but the underlying implementation currently only triggers a
      full mark-compact GC. The command also returns the before and after
      sizes of the heap.
      
      7. Added trace json, and flags commands that are not published in help.
      trace json is used for tracing the debugger packets send from and
      received by d8. flags is for setting v8 flags. These are useful for
      people debugging v8 itself, but not necessarily users of v8.
      
      8. Added the ability to enable and disable break on all / uncaught
      exceptions in to d8.
      
      9. Added a fix to prevent the Debugger Agent from being re-instantiated
      if one already exists.
      
      10. Added the ability to filter results of the script command by matching
      text or numbers on the results.
      
      11. Added v8 flags to enable/disable the sending of debugger BeforeCompile,
      AfterCompile, and ScriptCollected events.
      
      12. Fixed some undefined value bugs that resulted in v8 or the debugger
      failing.
      
      13. Added a few minor WEBOS__ customizations (analogous to ANDROID
      customizations).
      
      Patch by Mark Lam from Hewlett-Packard Development Company, LP
      
      Review URL: http://codereview.chromium.org/5980006
      
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      8669f630
  10. 16 Sep, 2010 1 commit
  11. 30 Aug, 2010 1 commit
  12. 27 Aug, 2010 2 commits
  13. 13 Aug, 2010 1 commit
  14. 30 Jul, 2010 1 commit
  15. 29 Jul, 2010 2 commits
  16. 28 Jul, 2010 1 commit
  17. 14 Jul, 2010 1 commit
  18. 30 Jun, 2010 1 commit
  19. 16 Jun, 2010 1 commit
  20. 10 Jun, 2010 1 commit
  21. 08 Jun, 2010 1 commit
    • sgjesse@chromium.org's avatar
      More precise break points and stepping when debugging · 634fb915
      sgjesse@chromium.org authored
      Added support for more precise break points when debugging and stepping. To achieve that additional nop instructions are inserted where breaking would otherwise be impossible. The number of nop instructions inserted are sufficient to make place for patching with a call to a debug break code stub. On Intel that is 5 nop's for 32-bit and 13 for 64-bit. Om ARM 3 nop instructions (12 bytes) are required.
      
      In order to avoid inserting nop's in to many places a simple ast checker have been added to check whether there are breakable code in a statement or expression. If it is possible to break in an expression no additional break enabeling code is inserted.
      
      Added break locations to the true and false part of a conditional expression.
      
      Added stepping tests to cover more constructs.
      
      These changes are only in the full compiler.
      
      Changed the default value for the option --debugger in teh d8 shell from true to false. The reason for this is that with --debugger turned on the full compiler will be used for all code in when running d8, which can be unexpeceted.
      
      Review URL: http://codereview.chromium.org/2693002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      634fb915
  22. 20 May, 2010 1 commit
  23. 19 May, 2010 1 commit
  24. 28 Apr, 2010 2 commits
  25. 06 Apr, 2010 1 commit
  26. 05 Mar, 2010 1 commit
  27. 29 Jan, 2010 2 commits
  28. 18 Jan, 2010 1 commit
  29. 15 Jan, 2010 1 commit
  30. 18 Dec, 2009 1 commit
  31. 14 Dec, 2009 1 commit
  32. 13 Dec, 2009 1 commit
  33. 30 Nov, 2009 1 commit