- 07 Oct, 2014 7 commits
-
-
machenbach@chromium.org authored
The script will poll the remote branch until the git updater has replicated the commit to tag. The tag will then be directly pushed to git. BUG=chromium:410721 LOG=n TEST=script_test.py R=agable@chromium.org, tandrii@chromium.org TBR=tandrii@chromium.org Review URL: https://codereview.chromium.org/607893004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24431 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=none R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/632903003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
Instead of using an integer value and manual bit-fiddling, use C++'s support for specifying bit sizes for integral types. This way the bits used to describe a PreParserExpression are handled by the compiler. BUG= LOG= R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/422363002 Patch from Adrian Perez <aperez@igalia.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/638523002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Also make sure that the appropriate functions are inlined properly (using V8_INLINE instead of inline to enforce it even with GCC), and improve the HashIsOkish unittest. TEST=unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/635733002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Only JSLoadProperty/JSStoreProperty nodes with external typed arrays can be lowered to LoadElement/StoreElement, because lowering of non-external typed arrays would require a map check. TEST=cctest,unittests,mjsunit R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/631093003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24426 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
The implementation is not yet complete, it doesn't support blocking yet, and doesn't collect statistics. This things will be fixed in follow-up CLs. BUG=v8:3608 R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/620093003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Oct, 2014 21 commits
-
-
titzer@chromium.org authored
On platforms without TurboFan (PowerPC) the CompareWrapper test was failing. It appears the line RawMachineAssemblerTester<int32_t> m; was causing the issue, and does not appear to be required for the test to operate correctly. Removing it resolves the crash on non TurboFan platforms BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/618043002 Patch from Andrew Low <andrew_low@ca.ibm.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24424 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
erikcorry@chromium.org authored
This relands https://codereview.chromium.org/619913002/ The test has been fixed to do a GC so it does not appear to leak in ASAN. In addition the test has been fixed to work in the no-i18n build, by incorporating the change from https://codereview.chromium.org/631743002/ R=ishell@chromium.org BUG= Review URL: https://codereview.chromium.org/628223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
balazs.kilvady@imgtec.com authored
Port r24403 (891eb62) BUG=v8:3330 LOG=N R=dusan.milosavljevic@imgtec.com Review URL: https://codereview.chromium.org/630003002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
BUG= R=rossberg@chromium.org Review URL: https://codereview.chromium.org/626153002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Also slightly improve hashing of floats/doubles. TEST=unittests R=jarin@chromium.org Review URL: https://codereview.chromium.org/632713002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG= R=ishell@chromium.org, jkummerow@chromium.org Review URL: https://codereview.chromium.org/631763003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/636543002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24418 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
It has been turned on by default for a long time, and hydrogenized BinaryOpStubs actually depend on it being turned on. BUG=v8:3487 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/630023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24415 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=bmeurer@chromium.org, jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/623313003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Around 200MB less peak memory usage in the bug mentioned below. BUG=417697 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/629983002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24413 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Implement NodeCache in terms of base::hash and std::equal_to in preparation for HeapConstant caching. TEST=cctest,unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/624153003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
Adds a MonotonicallyIncreasingTime() function to the Platform API to enable the embedder to provide a time API to V8 which will be used for IdleNotification deadlines. BUG=417668 LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/632663002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
HLoadRoot doesn't participate in representation inference, and its represenation is not Tagged at code generation, which leads to incorrect pointer map assignment and eventual stale pointer access after GC. BUG=chromium:419036 LOG=Y R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/626383003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
https://codereview.chromium.org/619913002/erikcorry@chromium.org authored
This is due to breakage on the ASAN memory leak bot, possibly due to pre-existing leaks in v8BreakIterator(). R=ishell@chromium.org BUG= Review URL: https://codereview.chromium.org/636493004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=chromium:420538 R=dcarney@chromium.org LOG=n Review URL: https://codereview.chromium.org/634493002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
m.m.capewell@googlemail.com authored
Add ARM64 instruction selector support for negating the sense of an arithmetic instruction when its immediate is negative. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/610323004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
This reverts commit r24386 for tanking asm.js benchmarks. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/634473002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/630773002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Forgot to add a file... TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/634463002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=arv@chromium.org, ishell@chromium.org BUG=v8:3330 LOG=N Review URL: https://codereview.chromium.org/622523004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Patch from JF Bastien <jfb@google.com>. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/631703002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
R=rmcilroy@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/623993002 Patch from Andre Baixo <baixo@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24401 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Oct, 2014 1 commit
-
-
erikcorry@chromium.org authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/619913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24400 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Oct, 2014 10 commits
-
-
paul.lind@imgtec.com authored
BUG= R=bmeurer@chromium.org, dusan.milosavljevic@imgtec.com Review URL: https://codereview.chromium.org/601723002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Again 50MB less peak memory usage in the bug mentioned below... BUG=417697 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/620113002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/619903005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Revert of Extend CPU profiler with mapping ticks to source lines (patchset #3 id:40001 of https://codereview.chromium.org/616963005/) Reason for revert: It broke layout test fast/events/window-onerror-02.html, error column reported by window.onerror is now wrong (I believe it is because of the change in full-codegen): http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/652 Original issue's description: > Extend CPU profiler with mapping ticks to source lines > > The idea behind of this solution is to use the existing "relocation info" instead of consumption the CodeLinePosition events emitted by the V8 compilers. > During generation code and relocation info are generated simultaneously. > When code generation is done you each code object has associated "relocation info". > Relocation information lets V8 to mark interesting places in the generated code: the pointers that might need to be relocated (after garbage collection), > correspondences between the machine program counter and source locations for stack walking. > > This patch: > 1. Add more source positions info in reloc info to make it suitable for source level mapping. > The amount of data should not be increased dramatically because (1) V8 already marks interesting places in the generated code and > (2) V8 does not write redundant information (it writes a pair (pc_offset, pos) only if pos is changed and skips other). > I measured it on Octane benchmark - for unoptimized code the number of source positions may achieve 2x ('lin_solve' from NavierStokes benchmark). > > 2. When a sample happens, CPU profiler finds a code object by pc, then use its reloc info to match the sample to a source line. > If a source line is found that hit counter is increased by one for this line. > > 3. Add a new public V8 API to get the hit source lines by CDT CPU profiler. > Note that it's expected a minor patch in Blink to pack the source level info in JSON to be shown. > > 4.Add a test that checks how the samples are distributed through source lines. > It tests two cases: (1) relocation info created during code generation and (2) relocation info associated with precompiled function's version. > > Patch from Denis Pravdin <denis.pravdin@intel.com> > BUG=None > LOG=Y > R=svenpanne@chromium.org > > Committed: https://code.google.com/p/v8/source/detail?r=24389 TBR=svenpanne@chromium.org,danno@chromium.org,alph@chromium.org,denis.pravdin@intel.com,weiliang.lin@intel.com BUG=None LOG=N Review URL: https://codereview.chromium.org/624443005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Again 112MB less peak memory usage in the bug mentioned below. :-) Routed all writes to to_boolean_types_ through its setter on the way. BUG=417697 LOG=y R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/615423006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
Bonus: fix bitrot in (disabled) Hydrogen-BCH R=yangguo@chromium.org Review URL: https://codereview.chromium.org/623513002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/604373008 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This tiny change shaves off 112MB from the peak memory usage in the bug mentioned below, more to come... BUG=417697 LOG=y R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/611393004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
The idea behind of this solution is to use the existing "relocation info" instead of consumption the CodeLinePosition events emitted by the V8 compilers. During generation code and relocation info are generated simultaneously. When code generation is done you each code object has associated "relocation info". Relocation information lets V8 to mark interesting places in the generated code: the pointers that might need to be relocated (after garbage collection), correspondences between the machine program counter and source locations for stack walking. This patch: 1. Add more source positions info in reloc info to make it suitable for source level mapping. The amount of data should not be increased dramatically because (1) V8 already marks interesting places in the generated code and (2) V8 does not write redundant information (it writes a pair (pc_offset, pos) only if pos is changed and skips other). I measured it on Octane benchmark - for unoptimized code the number of source positions may achieve 2x ('lin_solve' from NavierStokes benchmark). 2. When a sample happens, CPU profiler finds a code object by pc, then use its reloc info to match the sample to a source line. If a source line is found that hit counter is increased by one for this line. 3. Add a new public V8 API to get the hit source lines by CDT CPU profiler. Note that it's expected a minor patch in Blink to pack the source level info in JSON to be shown. 4.Add a test that checks how the samples are distributed through source lines. It tests two cases: (1) relocation info created during code generation and (2) relocation info associated with precompiled function's version. Patch from Denis Pravdin <denis.pravdin@intel.com> BUG=None LOG=Y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/616963005 Patch from Denis Pravdin <denis.pravdin@intel.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/615223005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-