- 23 Sep, 2016 2 commits
-
-
sashab authored
Revert of Fix bitfield enums to not trigger upcoming Clang warning (patchset #3 id:40001 of https://codereview.chromium.org/2349153002/ ) Reason for revert: Causes warning in GCC. Original issue's description: > Fix bitfield enums to not trigger upcoming Clang warning > > Fix bitfield enums to not trigger upcoming Clang warning regarding > non-unsigned enum bitfields producing non-portable code. > > For more details, see the patch here: https://reviews.llvm.org/D24289 > > BUG=648462 > > Committed: https://crrev.com/a81e00d533454a7179f8f954505a8f033e941a8a > Cr-Commit-Position: refs/heads/master@{#39649} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648462 Review-Url: https://codereview.chromium.org/2361013003 Cr-Commit-Position: refs/heads/master@{#39663}
-
sashab authored
Fix bitfield enums to not trigger upcoming Clang warning regarding non-unsigned enum bitfields producing non-portable code. For more details, see the patch here: https://reviews.llvm.org/D24289 BUG=648462 Review-Url: https://codereview.chromium.org/2349153002 Cr-Commit-Position: refs/heads/master@{#39649}
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
Now that we have ASSERT() macro in src/base/logging.h we can use it in safe_conversions_impl.h, re-enable this assertion and fix the TODO there. BUG=None TEST=None R=jochen@chromium.org LOG=n Review URL: https://codereview.chromium.org/369483003 Patch from Thiago Farina <tfarina@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jun, 2014 1 commit
-
-
jkummerow@chromium.org authored
Not used for anything yet. R=jochen@chromium.org Review URL: https://codereview.chromium.org/336183003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-