Skip to content

V
V8
Switch branch/tag
  1. 05 Feb, 2014 1 commit
    • marja@chromium.org's avatar
      Make strict more error messages about "eval" and "arguments" less specific. · 81504642
      marja@chromium.org authored 
      We used to have error messages which provide context, like "Variable name may
not be eval or arguments in strict mode", but for other illegal words we only
have non-context specific error messages like "Unexpected reserved word".

Providing the context makes the code unnecessarily complex, since every
individual place must remember to check for eval or arguments. This CL produces
a unified error message ("Unexpected eval or arguments in strict mode"), and puts
the error reporting to (Pre)Parser::ParseIdentifier.

Notes:

- The module feature is so experimental, that I decided to not allow "eval" or
"arguments" as module-related identifiers in the strict mode (even though this
check wasn't there before).

- Unfortunately, there were some inconsistencies, since it was the
responsibility of the caller of ParseIdentifier to check "eval" and "arguments"
and some places didn't have the check for no good reason. This CL is supposed to
keep backward compatibility and *not* introduce any new errors.

- ECMA allows "eval" and "arguments" as labels even in strict mode. (Syntax:
"LabelledStatement: Identifier : Statement", and no strict mode restrictions on
Identifier are listed.)

- Tests which compare error message strings will fail, and need to be updated.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/152813005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      81504642
  3. 04 Feb, 2014 1 commit
  5. 31 Jan, 2014 4 commits
  7. 30 Jan, 2014 1 commit
    • plind44@gmail.com's avatar
      Skip webkit/function-apply-aliased.js when running on simulators. · 51107bad
      plind44@gmail.com authored 
      The webkit/function-apply-aliased.js test fails on simulators (both MIPS
and ARM) as the printed output does not match to the expected. The
failing test forces a stack overflow exception and the ToString()
operation of the exception object fails because of an other stack
overflow and returns an empty string.

The problem is that on hardware a common JS and C stack is used so the
stack overflow can be caught in C functions also while on simulator
separated JS and C stacks are used.

This patch adds a "sim" condition to test .status files to skip tests
only on simulator.

LOG=N
BUG=v8:3124
R=jkummerow@chromium.org, plind44@gmail.com

Review URL: https://codereview.chromium.org/139233005

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18959 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      51107bad
  9. 22 Jan, 2014 1 commit
  11. 08 Jan, 2014 1 commit
  13. 22 Nov, 2013 1 commit
  15. 13 Nov, 2013 2 commits
  17. 08 Nov, 2013 2 commits
  19. 06 Nov, 2013 1 commit
  21. 24 Sep, 2013 1 commit
  23. 12 Aug, 2013 1 commit
  25. 31 Jul, 2013 1 commit
  27. 30 Jul, 2013 3 commits
  29. 26 Jul, 2013 2 commits
  31. 25 Jul, 2013 1 commit
    • machenbach@chromium.org's avatar
      Migrate more tests from blink repository. · 3c9efdee
      machenbach@chromium.org authored 
      The stand-alone test driver is changed a bit:
- Don't use the errorMessage list. It is used differently in the embedded driver. There it collects parser errors - instead of failure messages.
- Remove html links in description texts. Some test descriptions print a web reference.

The migrated tests fall into 3 categories:
1. Tests outside fast/js
2. Tests that print FAIL messages (and also expect those) - these tests should be examined later if they make sense at all
3. Tests with html links in the test description

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/20280003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3c9efdee
  33. 01 Jul, 2013 1 commit
  35. 28 Jun, 2013 3 commits
  37. 27 Jun, 2013 2 commits
  39. 26 Jun, 2013 1 commit