1. 29 Apr, 2019 2 commits
    • Clemens Hammacher's avatar
      [cleanup] Remove {StrLength} function · 423b357b
      Clemens Hammacher authored
      The {Vector} class does not use it any more. External uses should be
      converted to {size_t} instead of {int}.
      This CL removes the function from vector.h and updates all users to
      either use {size_t}, or cast to {int} explicitly. In tests, no further
      checks are needed if the string is a constant.
      
      R=mstarzinger@chromium.org
      
      Bug: v8:9183
      Change-Id: I60f99302504c74d8a7c79b147ca01d8ba61b6879
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587393Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61092}
      423b357b
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  2. 25 Apr, 2019 1 commit
  3. 03 Apr, 2019 1 commit
  4. 28 Mar, 2019 1 commit
  5. 07 Mar, 2019 1 commit
  6. 06 Mar, 2019 1 commit
    • zhiguo's avatar
      Fix a crash due to enabling VTune JIT support · f044f91d
      zhiguo authored
      When VTune JIT support is enabled, the WasmEngine of an Isolate tries to
      enable code logging by EnableCodeLogging() method. This multithreaded
      method requires a Mutex for safety. However, as the WasmEngine is not
      created, the Mutex of it is not initialized. An attempt of acquiring
      this Mutex results in an error. The bug is fixed by creating WasmEngine
      before it enables code logging.
      
      Change-Id: I59e749190288ec412f6661233e8f62b0dff3cd7f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1337376Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60060}
      f044f91d
  7. 27 Feb, 2019 1 commit
  8. 15 Feb, 2019 1 commit
  9. 06 Feb, 2019 1 commit
  10. 04 Feb, 2019 1 commit
  11. 31 Jan, 2019 1 commit
  12. 22 Jan, 2019 1 commit
  13. 21 Jan, 2019 2 commits
    • Peter Marshall's avatar
      [logger] Start cleaning up Logger class · 7da7c0bd
      Peter Marshall authored
      - Use unique ptrs for owned objects
      - Remove friendship with CpuProfiler and replace with public API
      - Remove unused method LogFailure()
      - Remove StopProfiler() which was only used by LogFailure() (removed)
        and one test, which can use StopProfilerThread() instead
      - Remove 'paused' state which was only used by the above
      - Remove 'engage' state. There is no reason we need this as along as
        users keep track of Engage/Disengage calls
      
      Drive-by cleanup:
      - Remove import of log.h from profile-generator.h
      - Remove unnecessary includes of log.h
      
      Change-Id: Ifc4ca156bef038c40953f8361ffea17788e3a59b
      Reviewed-on: https://chromium-review.googlesource.com/c/1424338
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58957}
      7da7c0bd
    • Peter Marshall's avatar
      [cpu-profiler] Remove registration and sampling depth from Sampler · 1f1bd71d
      Peter Marshall authored
      Simplify the internal state of Sampler a bit. There are basically two
      users of Sampler - the CpuSampler used by the CpuProfiler and the
      Ticker used by log.cc. Ticker calls Start/Stop to manage the Sampler
      lifetime, but CpuProfiler does not. This leads to much confusion and
      overlap of functionality.
      
      Fix that here by removing the distinction between active, registered
      and isProfiling states. These are now all the same thing and are
      represented by IsActive(). The state is set to active when Start is
      called, and set inactive when Stop is called. Both users of Sampler
      now call Start and Stop at appropriate times.
      
      The concept of profiling depth was not used - each Sampler would
      only ever have a sampling depth of 1. We still need to call
      SignalHandler::IncreaseSamplerCount(), so we do that in Start
      and the corresponding DecreaseSamplerCount() in Stop.
      
      Change-Id: I16a9435d26169a7dd00b1c7876e66af45f12e4b0
      Reviewed-on: https://chromium-review.googlesource.com/c/1424337
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58955}
      1f1bd71d
  14. 11 Jan, 2019 2 commits
  15. 26 Dec, 2018 1 commit
  16. 20 Dec, 2018 1 commit
  17. 17 Dec, 2018 3 commits
  18. 14 Dec, 2018 1 commit
  19. 08 Dec, 2018 1 commit
  20. 07 Dec, 2018 3 commits
  21. 29 Nov, 2018 1 commit
  22. 28 Nov, 2018 1 commit
  23. 27 Nov, 2018 2 commits
  24. 25 Nov, 2018 1 commit
  25. 24 Nov, 2018 2 commits
  26. 16 Nov, 2018 1 commit
  27. 13 Nov, 2018 1 commit
  28. 12 Nov, 2018 1 commit
  29. 31 Oct, 2018 3 commits