- 09 Mar, 2018 1 commit
-
-
Erik Luo authored
- Label as "bigint" in DevTools heap snapshot viewer - Treat as new primitive in injected-script-source - Show primitive value as property for BigIntObject - Adds the "n" suffix onto description, both with/without inspector being present Bug: v8:7486 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I47a02e32f9bdd9124a6c91056965574ecd443867 Reviewed-on: https://chromium-review.googlesource.com/940804 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51855}
-
- 10 Jan, 2018 1 commit
-
-
Timothy Gu authored
Before this, only the [[ProxyHandler]] was set to null during revocation of the Proxy through either the v8::Proxy::Revoke() or the Proxy.revocable() API. To be consistent with the spec, the Proxy's target is set to null as well. This change should not be observable through JS, since the check for if the Proxy is revoked should always use the handler. But the changed value is exposed through the public v8::Proxy::GetTarget() API, which is used by the inspector API and Node.js. Also included is a much more comprehensive test for Inspector's support for Proxy, which prior to this commit did not work as intended. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I727607ec2b3cea8642cd636573932c1e6bb5cc07 Reviewed-on: https://chromium-review.googlesource.com/854676 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50476}
-
- 28 Dec, 2017 1 commit
-
-
Eugene Ostroukhov authored
Add an easy way to preview ArrayBuffer as a typed array. This change will always allow previewing ArrayBuffer instances as Uint8Array and Int8Array. ArrayBuffer instances that have even length will allow Int16Array preview and ArrayBuffers that have length divisible by 4 will allow Int32Array previews. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07440147cc9e83c8a987f9316bd8d1b936db2717 Reviewed-on: https://chromium-review.googlesource.com/842472 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50315}
-
- 06 Nov, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
In current implementation Object.getOwnPropertyDescriptor calls native getter. It can produce side effects. We can avoid calling it. DevTools frontend will show clickable dots and on click returns value. This CL does not affect Blink and only affect several Node.js properties, e.g. process.title. R=yangguo@chromium.org Bug: v8:6945 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5764c779ceed4d50832edf68b2b4c6ee2c2dd65c Reviewed-on: https://chromium-review.googlesource.com/754223 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49152}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112 Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48138}
-
- 25 Aug, 2017 1 commit
-
-
Erik Luo authored
Currently, injected script source adds natural object properties before internal properties. This can result in important ones such as "[[PrimitiveValue]]" being left out. This CL - makes sure internal properties are always added to preview - removes unused "[[Iterator*]]" properties from preview - boxed strings (e.g. new String("foo")) will not send unnecessary properties 0:"f", 1:"o", 2:"o" if the [[PrimitiveValue]] is sent. Bug: chromium:567265 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd5c7410351f371055277ce471226cc6fb5a861f Reviewed-on: https://chromium-review.googlesource.com/634584Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#47622}
-
- 02 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js. There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs. Drive by: debugger-script.js and usage of debugger context in inspector code base. R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: v8:5510,chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7 Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47091}
-
- 25 Jul, 2017 1 commit
-
-
Erik Luo authored
This CL adds support for ArrayBuffer and SharedArrayBuffer subtypes for injected script source. It also adds the byteLength/size to the description of these objects and for the upcoming "blob" subtype when appropriate. This is dependent on a DevTools frontend patch to accept these new subtypes: https://chromium-review.googlesource.com/c/582427/ Bug: chromium:653620 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: If8f612b54e82e6fd2f056545bd521868ba7349fd Reviewed-on: https://chromium-review.googlesource.com/582233 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46851}
-
- 02 Jun, 2017 1 commit
-
-
dgozman authored
This is just a cleanup patch. BUG=none Review-Url: https://codereview.chromium.org/2921623006 Cr-Commit-Position: refs/heads/master@{#45669}
-
- 10 Apr, 2017 1 commit
-
-
kozyatinskiy authored
It's possible to get undefined as a result of Object.getOwnPropertyDescriptor. We should be ready for this. BUG=chromium:707670 R=alph@chromium.org Review-Url: https://codereview.chromium.org/2801763002 Cr-Commit-Position: refs/heads/master@{#44532}
-
- 24 Mar, 2017 3 commits
-
-
kozyatinskiy authored
Methods on Object can be overriden by user, we should be prepared. BUG=chromium:595206 R=dgozman@chromium.org,luoe@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2772093002 Cr-Commit-Position: refs/heads/master@{#44128}
-
kozyatinskiy authored
We should never check existing of the property by typeof obj.name check. BUG=chromium:693338 R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2767323002 Cr-Commit-Position: refs/heads/master@{#44113}
-
kozyatinskiy authored
- added InspectorTest.setupInjectedScriptEnvironment method which mutates current context, - clear prototype of InjectedScript function and domAttributesWithObservableSideEffectOnGet. Second point increases chances that injected-script-source would be successfully compiled. BUG=chromium:693338 R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2770823003 Cr-Commit-Position: refs/heads/master@{#44081}
-
- 22 Mar, 2017 1 commit
-
-
kozyatinskiy authored
These JS objects don't have size property. BUG=none R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2770583002 Cr-Commit-Position: refs/heads/master@{#44048}
-
- 07 Oct, 2016 1 commit
-
-
kozyatinskiy authored
Only subset of internal properties can be useful in preview, report only them. BUG=chromium:653610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2399003003 Cr-Commit-Position: refs/heads/master@{#40064}
-
- 21 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
- 19 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2332243002 Cr-Commit-Position: refs/heads/master@{#39506}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 01 Sep, 2016 1 commit
-
-
dgozman authored
Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39107}
-
- 31 Aug, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ ) Reason for revert: Presubmit Original issue's description: > [inspector] Initial import of v8_inspector. > > BUG=chromium:635948 > NOPRESUBMIT=true (for code style) > > Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee > Cr-Commit-Position: refs/heads/master@{#39057} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2300823002 Cr-Commit-Position: refs/heads/master@{#39058}
-
dgozman authored
BUG=chromium:635948 NOPRESUBMIT=true (for code style) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39057}
-