1. 09 Mar, 2018 1 commit
  2. 10 Jan, 2018 1 commit
    • Timothy Gu's avatar
      [proxy] Set [[ProxyTarget]] to null during revocation · 5b9adade
      Timothy Gu authored
      Before this, only the [[ProxyHandler]] was set to null during revocation
      of the Proxy through either the v8::Proxy::Revoke() or the
      Proxy.revocable() API. To be consistent with the spec, the Proxy's
      target is set to null as well. This change should not be observable
      through JS, since the check for if the Proxy is revoked should always
      use the handler. But the changed value is exposed through the public
      v8::Proxy::GetTarget() API, which is used by the inspector API and
      Node.js.
      
      Also included is a much more comprehensive test for Inspector's support
      for Proxy, which prior to this commit did not work as intended.
      
      Bug: 
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I727607ec2b3cea8642cd636573932c1e6bb5cc07
      Reviewed-on: https://chromium-review.googlesource.com/854676
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50476}
      5b9adade
  3. 28 Dec, 2017 1 commit
    • Eugene Ostroukhov's avatar
      [inspector] provide ArrayBuffer previews · 86abfd35
      Eugene Ostroukhov authored
      Add an easy way to preview ArrayBuffer as a typed array. This change
      will always allow previewing ArrayBuffer instances as Uint8Array and
      Int8Array. ArrayBuffer instances that have even length will allow
      Int16Array preview and ArrayBuffers that have length divisible by 4 will
      allow Int32Array previews.
      
      Bug: 
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I07440147cc9e83c8a987f9316bd8d1b936db2717
      Reviewed-on: https://chromium-review.googlesource.com/842472
      Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
      Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50315}
      86abfd35
  4. 06 Nov, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] do not call native accessor in Rumtime.getProperties · ea04c667
      Alexey Kozyatinskiy authored
      In current implementation Object.getOwnPropertyDescriptor calls native
      getter. It can produce side effects. We can avoid calling it.
      DevTools frontend will show clickable dots and on click returns value.
      This CL does not affect Blink and only affect several Node.js
      properties, e.g. process.title.
      
      R=yangguo@chromium.org
      
      Bug: v8:6945
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I5764c779ceed4d50832edf68b2b4c6ee2c2dd65c
      Reviewed-on: https://chromium-review.googlesource.com/754223
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49152}
      ea04c667
  5. 25 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Fix (D)CHECK macros in src/{debug,inspector} · 8d38c15e
      Clemens Hammacher authored
      Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an
      embedded comparison. This gives better error messages and also does the
      right comparison for signed/unsigned mismatches.
      
      This will allow us to reenable the readability/check cpplint check.
      
      R=yangguo@chromium.org
      
      Bug: v8:6837
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112
      Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48138}
      8d38c15e
  6. 25 Aug, 2017 1 commit
  7. 02 Aug, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] move breakpoint management to native · cd9e86a5
      Alexey Kozyatinskiy authored
      My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js.
      
      There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs.
      
      Drive by: debugger-script.js and usage of debugger context in inspector code base.
      
      R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org
      
      Bug: v8:5510,chromium:652939
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7
      Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47091}
      cd9e86a5
  8. 25 Jul, 2017 1 commit
  9. 02 Jun, 2017 1 commit
  10. 10 Apr, 2017 1 commit
  11. 24 Mar, 2017 3 commits
  12. 22 Mar, 2017 1 commit
  13. 07 Oct, 2016 1 commit
  14. 21 Sep, 2016 1 commit
  15. 19 Sep, 2016 1 commit
  16. 06 Sep, 2016 1 commit
  17. 01 Sep, 2016 1 commit
  18. 31 Aug, 2016 2 commits