- 21 May, 2015 6 commits
-
-
dslomov authored
Also support patterns in ``for (var p in/of ...)`` This CL extends the rewriting we used to do for ``for (let p in/of...)`` to ``for (var p in/of ...)``. For all for..in/of loop declaring variable, we rewrite for (var/let/const pattern in/of e) b into for (x' in/of e) { var/let/const pattern = e; b } This adds a small complication for debugger: for a statement for (var v in/of e) ... we used to have var v; for (v in/of e) ... and there was a separate breakpoint on ``var v`` line. This breakpoint is actually useless since it is immediately followed by a breakpoint on evaluation of ``e``, so this CL removes that breakpoint location. Similiraly, for let, it used to be that for (let v in/of e) ... became for (x' in/of e) { let v; v = x'; ... } ``let v``generetaed a useless breakpoint (with the location at the loop's head. This CL removes that breakpoint as well. R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1149043005 Cr-Commit-Position: refs/heads/master@{#28565}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1152503002 Cr-Commit-Position: refs/heads/master@{#28547}
-
jarin authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1148133002 Cr-Commit-Position: refs/heads/master@{#28536}
-
arv authored
This allows you to put iterables into your array literals and the will get spread into the array. let x = [0, ...range(1, 3)]; // [0, 1, 2] This is done by treating the array literal up to the first spread element as usual, including using a boiler plate array, and then appending the remaining expressions and rest expressions. BUG=v8:3018 LOG=N Review URL: https://codereview.chromium.org/1125183008 Cr-Commit-Position: refs/heads/master@{#28534}
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28533}
-
dehrenberg authored
Previously this patch was attempted with reduce and reduceRight included; however, some of those tests crashed in the trybots. This version has just map, fiter and some, together with their tests. R=arv@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1145013002 Cr-Commit-Position: refs/heads/master@{#28529}
-
- 20 May, 2015 10 commits
-
-
verwaest authored
BUG=v8:4130 LOG=n Review URL: https://codereview.chromium.org/1148863002 Cr-Commit-Position: refs/heads/master@{#28526}
-
jkummerow authored
Revert of Use shared container to manage imports/exports. (patchset #2 id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1144163002 Cr-Commit-Position: refs/heads/master@{#28523}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1151503002 Cr-Commit-Position: refs/heads/master@{#28522}
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28521}
-
ishell authored
BUG=chromium:489597 LOG=N Review URL: https://codereview.chromium.org/1123153005 Cr-Commit-Position: refs/heads/master@{#28518}
-
dslomov authored
(everything except Spread is implemeneted) R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1139603005 Cr-Commit-Position: refs/heads/master@{#28500}
-
rossberg authored
(patchset #4 id:60001 of https://codereview.chromium.org/1134333005/)" This reverts commit 81c080ef. Patchset #1 is the original CL. Patchset #2 fixes a handlification bug that caused the crash. R=dslomov@chromium.org BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1143813002 Cr-Commit-Position: refs/heads/master@{#28497}
-
Daniel Ehrenberg authored
This patch adds the two TypedArray methods indexOf and lastIndexOf, which are similar to the methods on Arrays. Tests are ported from arrays as well. BUG=v8:3578 LOG=Y R=arv@chromium.org Review URL: https://codereview.chromium.org/1141763004 Patch from Daniel Ehrenberg <dehrenberg@chromium.org>. Cr-Commit-Position: refs/heads/master@{#28495}
-
Daniel Ehrenberg authored
The sort method of TypedArrays sorts in numerical order by default. This patch implements sorting based on Arrays and adds a test. The length of %TypedArray%.prototype.sort, like Array.prototype.sort, seems to be unspecified in ES6, so this patch lets it have the value 1, to match our interpretation for Array.prototype.sort (though 0 would also be a sensible length). R=arv@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1148513002 Patch from Daniel Ehrenberg <dehrenberg@chromium.org>. Cr-Commit-Position: refs/heads/master@{#28494}
-
Daniel Ehrenberg authored
This patch adds the reverse method to TypedArrays, together with a test. The test also runs for normal Arrays, since I didn't see a test for reversing dense arrays. BUG=v8:3578 LOG=Y R=arv@chromium.org Review URL: https://codereview.chromium.org/1132723008 Patch from Daniel Ehrenberg <dehrenberg@chromium.org>. Cr-Commit-Position: refs/heads/master@{#28493}
-
- 19 May, 2015 14 commits
-
-
arv authored
Also check whether the arguments count is smaller than the number of required parameters which is the same as the SharedFunctionInfo length. BUG=v8:4102 LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1133933003 Cr-Commit-Position: refs/heads/master@{#28491}
-
machenbach authored
Revert of Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} (patchset #2 id:20001 of https://codereview.chromium.org/1139663005/) Reason for revert: [Sheriff] Breaks win nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6872 Original issue's description: > Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} > > This patch adds implementations for additional TypedArray methods > from the ES6 spec, together with tests adapted from array code. > > R=arv@chromium.org > BUG=v8:3578 > LOG=Y > > Committed: https://crrev.com/59ef8c5f3282f01b5990b3a46a2a3a829b699a13 > Cr-Commit-Position: refs/heads/master@{#28488} TBR=arv@chromium.org,dehrenberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Review URL: https://codereview.chromium.org/1143833002 Cr-Commit-Position: refs/heads/master@{#28489}
-
dehrenberg authored
This patch adds implementations for additional TypedArray methods from the ES6 spec, together with tests adapted from array code. R=arv@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1139663005 Cr-Commit-Position: refs/heads/master@{#28488}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1129083009 Cr-Commit-Position: refs/heads/master@{#28487}
-
mstarzinger authored
R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-489293 BUG=chromium:489293 LOG=n Review URL: https://codereview.chromium.org/1142873005 Cr-Commit-Position: refs/heads/master@{#28486}
-
wingo authored
This reapplies https://codereview.chromium.org/1136073002, along with the followups: Remove Scope::scope_uses_this_ flag https://codereview.chromium.org/1128963005 and PPC: Resolve references to "this" the same way as normal variables https://codereview.chromium.org/1134073003 R=rossberg@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1136883006 Cr-Commit-Position: refs/heads/master@{#28458} Review URL: https://codereview.chromium.org/1140633003 Cr-Commit-Position: refs/heads/master@{#28484}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1146683002 Cr-Commit-Position: refs/heads/master@{#28482}
-
ishell authored
BUG=chromium:487105 LOG=N Review URL: https://codereview.chromium.org/1136123010 Cr-Commit-Position: refs/heads/master@{#28480}
-
machenbach authored
BUG=v8:4127 LOG=n TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/1146683003 Cr-Commit-Position: refs/heads/master@{#28479}
-
wingo authored
Revert of Reapply "Resolve references to "this" the same way as normal variables"" (patchset #2 id:20001 of https://codereview.chromium.org/1136883006/) Reason for revert: Something is deserializing "this" declarations as Variable::NORMAL and not Variable::THIS https://codereview.chromium.org/1136123010/ Original issue's description: > Reapply "Resolve references to "this" the same way as normal variables"" > > This reapplies https://codereview.chromium.org/1136073002, along with > the followups: > > Remove Scope::scope_uses_this_ flag > https://codereview.chromium.org/1128963005 > > and > > PPC: Resolve references to "this" the same way as normal variables > https://codereview.chromium.org/1134073003 > > R=yangguo@chromium.org, rossberg@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099 > Cr-Commit-Position: refs/heads/master@{#28458} TBR=rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1146733002 Cr-Commit-Position: refs/heads/master@{#28473}
-
titzer authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/1133113004 Cr-Commit-Position: refs/heads/master@{#28465}
-
machenbach authored
Revert of [strong] Object literals create strong objects (patchset #4 id:60001 of https://codereview.chromium.org/1134333005/) Reason for revert: [Sheriff] Segmentation fault on arm64 with nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1990 Original issue's description: > [strong] Object literals create strong objects > > R=dslomov@chromium.org > BUG=v8:3956 > LOG=N > > Committed: https://crrev.com/fe6598cffb82ec4180dcc2e2310e77d07a803f96 > Cr-Commit-Position: refs/heads/master@{#28444} TBR=dslomov@chromium.org,arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1135493006 Cr-Commit-Position: refs/heads/master@{#28464}
-
jkummerow authored
BUG=chromium:487608 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1133343003 Cr-Commit-Position: refs/heads/master@{#28463}
-
yangguo authored
Clearing stepping was originally introduced in http://codereview.chromium.org/7889039 But DebugEvaluate now also uses a DisableBreak scope, which makes sure we don't step inside the evaluated code. R=yurys@chromium.org BUG=chromium:467180 LOG=N Review URL: https://codereview.chromium.org/1129363003 Cr-Commit-Position: refs/heads/master@{#28461}
-
- 18 May, 2015 6 commits
-
-
wingo authored
This reapplies https://codereview.chromium.org/1136073002, along with the followups: Remove Scope::scope_uses_this_ flag https://codereview.chromium.org/1128963005 and PPC: Resolve references to "this" the same way as normal variables https://codereview.chromium.org/1134073003 R=yangguo@chromium.org, rossberg@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1136883006 Cr-Commit-Position: refs/heads/master@{#28458}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1139773005 Cr-Commit-Position: refs/heads/master@{#28457}
-
dehrenberg authored
This function creates a new way to make TypedArrays based on existing iterable or Array-like objects, analogous to Array.from. The patch implements the function and adds tests. R=arv@chromium.org BUG=v8:3578 LOG=Y Review URL: https://codereview.chromium.org/1132163011 Cr-Commit-Position: refs/heads/master@{#28456}
-
arv authored
The functions of strong classes are born non extensible. But, when the class is created we need to add an own private symbol representing the [[HomeObject]] slot in the spec. Like for the hidden_string property, we allow adding private own symbols to non extensible objects. BUG=v8:4077 LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1138603003 Cr-Commit-Position: refs/heads/master@{#28447}
-
rossberg authored
R=dslomov@chromium.org BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1134333005 Cr-Commit-Position: refs/heads/master@{#28444}
-
verwaest authored
This reverts commit ac5336ba. BUG= Review URL: https://codereview.chromium.org/1138483005 Cr-Commit-Position: refs/heads/master@{#28442}
-
- 17 May, 2015 2 commits
-
-
machenbach authored
Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #2 id:20001 of https://codereview.chromium.org/1123163005/) Reason for revert: [Sheriff] Blocks current roll: https://codereview.chromium.org/1124403007/ Bisection (https://codereview.chromium.org/1142753002/) points to this CL. Original issue's description: > Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling. > > BUG= > > Committed: https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d > Cr-Commit-Position: refs/heads/master@{#28369} TBR=rossberg@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1142763002 Cr-Commit-Position: refs/heads/master@{#28437}
-
machenbach authored
Revert of Debugger: preserve stepping state after evaluating breakpoint condition. (patchset #1 id:1 of https://codereview.chromium.org/1132643004/) Reason for revert: [Sheriff] This breaks TSAN (makes some tests marked as flaky permanently fail): http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/3882 Original issue's description: > Debugger: preserve stepping state after evaluating breakpoint condition. > > R=ulan@chromium.org, yurys@chromium.org > BUG=chromium:467180 > LOG=N TBR=ulan@chromium.org,yurys@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:467180 Review URL: https://codereview.chromium.org/1130123007 Cr-Commit-Position: refs/heads/master@{#28436}
-
- 15 May, 2015 2 commits
-
-
yangguo authored
R=ulan@chromium.org, yurys@chromium.org BUG=chromium:467180 LOG=N Review URL: https://codereview.chromium.org/1132643004 Cr-Commit-Position: refs/heads/master@{#28432}
-
arv authored
All the builtin iterators as well as the generator objects have an object called %IteratorPrototype% in the spec between them and %ObjectPrototype%. BUG=v8:3568 LOG=N Review URL: https://codereview.chromium.org/1128233008 Cr-Commit-Position: refs/heads/master@{#28426}
-