- 08 Jan, 2020 10 commits
-
-
Leszek Swirski authored
Remove the explicit script handle from ParseInfo, and make it either a Handle that is passed around where needed, or one inferred from the SharedFunctionInfo. This will be useful for compilation finalization using the off-thread factory, which will not generate real Handles since it has no access to the Isolate. Bug: chromium:1011762 Change-Id: I5d9564009ec83bb9fc74191b4aa69735d132c2f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977861Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65629}
-
jing.bao authored
Currently, the code does not take hint register in preference. This CL initializes current_free according to initial reg (which maybe hint_reg), to ensure that any candidate that equals this one won't replace hint register. Contributed by yolanda.chen@intel.com Change-Id: I6acc1d031e6b130e69d650667dbf98551c52ff7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973671 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65628}
-
Mythri A authored
Skip test-cpu-profiler/Inlining2 and test-cpu-profiler/CrossScriptInliningCallerLineNumbers2 on win debug build. Bug: v8:10107 Change-Id: If4382db8ae79d6f59dcafefc4ba3c4e93bb2fa22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981158Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#65627}
-
Michael Achenbach authored
Bug: v8:8170 Change-Id: I4b4a2919f6cf613779eeabc6c2cec1b08fa4d80f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981152Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65626}
-
Tobias Tebbi authored
The code in TurboAssembler::LoadFromConstantsTable uses special code to avoid clobbering the scratch register ip by giving different argument registers to ldr. This used to be motivated by DirectCEntryStub::GenerateCall relying on LookupConstant not clobbering ip (see https://crrev.com/c/1070980). Now that this code is gone, there is no more reason for preserving ip and it's fragile, so it's better to remove this special handling. Bug: v8:10077 Change-Id: I683d7c63e2a3c8ba554cd99299206ed9e5df835d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981160Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65625}
-
Clemens Backes authored
Background threads are not supposed to use any handles, so this handle scope is not needed. R=ahaas@chromium.org Change-Id: I2f4776b897256684205c35633fbe1e1365abab91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981151Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65624}
-
Leszek Swirski authored
AllocateScopeInfos should only be called for not-yet unallocated scopes, so we can DCHECK for nullness rather than having a branch for it. Change-Id: I65767c22d6fd7b12c4564c5ecc52f9486229affa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981159Reviewed-by:
-
Leszek Swirski authored
Most dead variable warnings in GCMole are false positives, either from failing to detect that TryEvacuateObject returning false means it didn't allocate, or a regex error thinking that GarbageCollectionReasonToString causes garbage collection (because the mangled version is something like GarbageCollectionReasonToString[...]GarbageCollectionReason, and that matches /Collect.*Garbage/). Update the whitelist and fix the "Collect.*Garbage" regex to only look at the function name. Bug: v8:9985 Change-Id: I62284e97e4975a6a87616d1d535b2ac7958d17bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989829 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ddd521..6e49eef Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3543506..a209c4d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a814502..3a797af TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8644df0de721110e89df0df1dd474bf9861e5f74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65621}
-
Frank Tang authored
I2S https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/vE4i42C2MUs/Sb804J3fBQAJ I2I https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/muRQBwyzzPw/FgdwgcbnAgAJ Design Doc: https://shorturl.at/emEHW Chrome Status: https://www.chromestatus.com/feature/4965112605573120 Latest spec: https://tc39.es/proposal-intl-displaynames/ Spec Github: https://github.com/tc39/proposal-intl-displaynames LGTMs: bratell.d@gmail.com / chrishtr@chromium.org / yoav@yoav.ws Bug: v8:8703 Change-Id: Iaf4f94d813fa742989ab149420d07f6f6f523443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982802 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65620}
-
- 07 Jan, 2020 30 commits
-
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Iffa5613f0d4226a25519feab8c2246be8e462cc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981073 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65619}
-
Ng Zhi An authored
Bug: v8:10039 Change-Id: I3568bd3d01508e8bca81959341c75369c5bdf700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958051Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ie3231038312495c2d8f77062ee5b81b2b55ab4d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980502Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9415 Bug: v8:10021 Change-Id: I77c24b58f575b612e5422bfcb9bb7ab83986659a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986249Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10039 Change-Id: If7c9668821a1cdfd5968f1533c3412247567bf3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955550Reviewed-by:
-
Z Nguyen-Huu authored
This is reland of 6ce3046e Skip the test in multi-isolates config. Bug: v8:9654 Change-Id: I035c867c99219bbf8d4fa25b58c734306e25fa63 Original change's description: > [wasm] Add support to tier down/up Wasm NativeModule > > This is the first part of switching between Liftoff and Turbofan in > debugging Wasm. In this CL, we implemented the logic to tier down/up all > functions in module. > > Bug: v8:9654 > Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65529} Change-Id: I035c867c99219bbf8d4fa25b58c734306e25fa63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985032 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Joshua Litt authored
Fixes clusterfuzz bug. This is a reland of 15ec4a09 Original change's description: > [promises] Port Promise.race to Torque. > > Bug: v8:9838 > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919 > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65562} Bug: v8:9838 Change-Id: Id295a12023195511289d92517936733ab22cdf4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65613}
-
Leszek Swirski authored
PerformSideEffectCheckAtBytecode calls Isolate::TerminateExecution on failure, which can allocate. We can avoid Handles by only accessing the frame's function object after the side effect check. Bug: v8:9991 Change-Id: Iac74f8cf5ff0840a18c59faab4c256a3fa9d5b25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989825 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Backes authored
Instead of having both a templatized and a parameter-based method, just have the parameter-based one, but make it constexpr. DCHECKs in these constexpr methods need to be guarded because GCC 5 does not support them yet. R=thibaudm@chromium.org Bug: v8:10021 Change-Id: If362de42f1a4c2cda4435fce63beb9244795d008 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986001Reviewed-by:
-
Seth Brenith authored
This change updates GetObjectProperties to list all of the bitfields within a class field, if that class field's type is a bitfield struct. The representation of bitfields in the GetObjectProperties response is very similar to the representation of struct fields, but with two extra bytes of data specifying the shift and size of the bitfield. Bug: v8:9376 Change-Id: I40a22169f3d01652a7f2db8cface43c2a1e30cfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960835Reviewed-by:
-
Michael Lippautz authored
Change-Id: Ifc3100595c88a374ac41cb0d90825c23c1cae756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980704 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65609}
-
Tobias Tebbi authored
This reverts commit a3039123. Reason for revert: https://crrev.com/c/1985990 should fix the root-cause now. Original change's description: > [regalloc] temporarily disable control-flow aware allocation > > Bug: v8:10077 > > Change-Id: I4b76d62462658dfa54f351ba10e52e57f63f3493 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977857 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65536} TBR=tebbi@chromium.org,thibaudm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10077 Change-Id: I356f1cc8d70f1f9efdbc72e3398cc830c51b664d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986002Reviewed-by:
-
Joshua Litt authored
Currently, the implementation of Call throws if the property is non-callable. This CL just updates the torque type signature to reflect this. Change-Id: I3f8626ba96f41e6d52564df8d481fba52b05a3fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989572 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
{LoadFromConstantsTable} uses r7 as a temporary register. This can conflict with the load destination register, so use another register in this case. R=jgruber@chromium.org CC=tebbi@chromium.org Bug: v8:10077 Change-Id: I3359f31ab4b17838464ee9bf0828308161fb9c0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985990 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Dan Elphick authored
Converts StoreObjectField, StoreMapNoWriteBarrier and StoreObjectFieldRoot to use TNode parameters and convert all of their uses. Bug: v8:10021 Change-Id: Ic0511e43677f6aaaeac20df58a69be74156d390f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980581Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65605}
-
Dan Elphick authored
Makes the Node* versions private so they can still be called from the inlined TNode versions. Also changes to LoadFromParentFrame to return TNode<Object> since its uses don't require anything looser. Bug: v8:10021 Change-Id: I84e3831d444a7787e0b03ff2f9e665181a9caa06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980578 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65604}
-
Leszek Swirski authored
LogWriteDebugInfo can allocate when calculating line ends for source positions, so make its called, LogRecordedBuffer, take Handles rather than raw Objects. This also improves its API, as we can change the maybe-null SharedFunctionInfo argument into a MaybeHandle. Bug: chromium:1037872 Change-Id: Ifa3e2d9be7aa7de3b05e5c1e107406004b8963c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985995 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Leszek Swirski authored
During conflict detection, we want to early exit the scope loop when we find a non-conflict, but continue looking at the other declarations in the scope. Bug: chromium:1038588 Change-Id: Ia2a19b02222fbd13cec70d3a60d2f5bae4ce245b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985991 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Anna Henningsen authored
The error messages previously gave the impression that a cast in the sense of a JS type conversion may have been attempted. Clarify the error messages to a) indicate that the type mismatched (rather than using the term “conversion”) and b) always use the C++ class name to clarify that the check refers to the actual class hierarchy, rather than conceptual types. Change-Id: I28c1b8a265f3d96f344bc2e00ac24bd9b9b6d269 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1987247Reviewed-by:
-
Huáng Jùnliàng authored
When "await" is referenced in a part of an async arrow function head, we will walk up the active ambiguous expression stack and mark the ambiguous arrow head scope. However the class member initializer is always non-ambiguous so we should reset the stack and stop walking up. Bug: v8:10094 Change-Id: Iac35889158ef46c851888993b6081f8ff8610c43 Fixed: v8:10094 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1987620 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:1031909 Change-Id: Ibf120d722a8cb6eb9b9eaa15163cb7846dab64ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981507Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65599}
-
Maya Lekova authored
The current value of 200 is fine with the TypeScript run time (less than 8s) as long as the limit is checked at an earlier stage, which was overlooked in the initial implementation. Fixed: chromium:1038292 Change-Id: Ia512e709a79450eed631f03129ddbbff65fd81b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985992Reviewed-by:
-
Zhao Jiazhong authored
port 9dfe6359 https://crrev.com/c/1829220 [mips][builtins] Tweak optimized check in InterpreterEntryTrampoline port 7177d87f https://crrev.com/c/1833683 Bug: v8:9771 Change-Id: I1d5214fd6d6b5bf3f6c30003c616054ce4e4ee15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1892471Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65597}
-
Clemens Backes authored
They are generated by running d8 with the '--perf-prof' flag. We never want to commit them. R=machenbach@chromium.org No-Try: true Change-Id: I1e249142b893b4f4a9c09cc75eb6623680be12f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985994Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65596}
-
Thibaud Michaud authored
Set the wasm engine in the {PipelineData} constructor used for JS to Wasm wrapper compilation, so that the code tracer can be accessed independently from the isolate. R=mvstanton@chromium.org Bug: chromium:1032677 Change-Id: Id26d1695446251e310fe7dbd9cc7b04f8f1ad175 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973738Reviewed-by: -
Dan Elphick authored
Converts NodeGenerator and SelectImpl to return TNode<T>. Also removes redundant PromiseBuiltinsAssembler::SetForwardingHandlerIfTrue overload. Bug: v8:10021 Change-Id: I65e23fb208e4d9bf041e0f9c9b2ea113aeac58a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980576Reviewed-by:
-
Sigurd Schneider authored
This CL improves whitespace precision of coverage around try blocks; previously a small portion of whitespace could be reported as uncovered between try blocks and catch and/or finally blocks. Change-Id: I763ae3d15106c88f2278cf8893c12b0869a62528 Fixed: v8:10030 Bug: v8:10030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962265Reviewed-by:
-
Simon Zünd authored
This CL introduces a CHECK to narrow down the cause for a crash happening in the wild, but that currently has no reproduction case. Bug: chromium:1035651 Change-Id: I61c0658d4b753f2c7d12aa8e20d5a2ff69594d1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985989Reviewed-by:
-
Pierre Langlois authored
Change-Id: I1cdd6e7f761d7fa75fd4ca5331ca2475a4384c30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985988 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/5e4fce1..81c050f Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9e12430..8ddd521 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d3a10a0..3543506 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf50f77..a814502 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia9999ac71e4d89673216ed63ae8f0353563c1076 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988074Reviewed-by:
-
