- 05 Jan, 2021 1 commit
-
-
Benedikt Meurer authored
Consistently use InspectorTest.runAsyncTestSuite() in wasm inspector tests to make tests easier to debug (they'll fail instead of timing out in case of errors). Bug: chromium:1162229, chromium:1071432 Change-Id: I7aada196f9e34071aa1bb059bb45f85f75226060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609414 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71908}
-
- 16 Oct, 2020 1 commit
-
-
Clemens Backes authored
It makes inspector tests a lot more readable if the opcode of the pause location is being printed. Since we already have a list of all opcodes available in wasm-module-builder.js, we can just reuse that to build a reverse lookup map. This CL implements this for single-byte opcodes only, which is enough for all tests that we currently have. It will have to be extended for prefixed opcodes once that is being used. R=thibaudm@chromium.org, kimanh@chromium.org Change-Id: I085fea99d2f5f2dc6cc084448e5f7444cce5c78b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474789 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70578}
-
- 15 Oct, 2020 1 commit
-
-
Clemens Backes authored
... at function start. Otherwise we run into a position mismatch: In a non-flooded function, we add the function-entry breakpoint (for "hook on function call") with the position of the first opcode. In the flooded function though, we skip that special breakpoint because we will stop at the first instruction anyway. But then the first instruction is non-breakable, so we don't actually emit a breakpoint for it. Hence during OSR we do not find a corresponding position in the new code. This CL fixes this by postponing the function-entry breakpoint until the first breakable opcode is found, and only emits it if that position does not have a breakpoint anyway. This way, we can also move the handling for function-entry breakpoints from {StartFunctionBody} to {EmitDebuggingInfo}, where it fits much better. R=thibaudm@chromium.org Bug: chromium:1137710 Change-Id: Idfa658fa0897cca89ba5ee3066cd414f68864d06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474774Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70529}
-