- 18 Jun, 2021 16 commits
-
-
Dan Elphick authored
The adding of base:: was mostly prepared using git grep and sed: git grep -l <pattern> | grep -v base/vector.h | \ xargs sed -i 's/\b<pattern>\b/base::<pattern>/ with lots of manual clean-ups due to the resulting v8::internal::base::Vectors. #includes were fixed using: git grep -l "src/utils/vector.h" | \ axargs sed -i 's!src/utils/vector.h!src/base/vector.h!' Bug: v8:11879 Change-Id: I3e6d622987fee4478089c40539724c19735bd625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968412Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75243}
-
Leszek Swirski authored
We were gating baseline compilation on FBV allocation, but in some cases, the feedback vector may be allocated eagerly (notably, if we are logging function events). Instead, unconditionally try baseline compilation after ensuring the feedback vector exists. Bug: v8:11420 Change-Id: I1264a1d541a74d4eccb5caf65c360ac23836a1a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953161 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75242}
-
Santiago Aboy Solanes authored
After the last CL on TSAN support for generated loads, we are seeing timeouts in one of our TSAN bots. Bug: v8:7790, v8:11600 Change-Id: I90924540c5ddcf9902f936849df28aff0f7bd3d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972724Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75241}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Ia86bab21851e8ff2f2317495a9f0e19140b0de2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969827 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75240}
-
Victor Gomes authored
Bug: chromium:1220810 Change-Id: Ibb016b42c8acf91b2ad38b7d360dfaf1dc185cdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972723Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75239}
-
Lu Yahan authored
Change-Id: Ic73b5414e62de76a3d4d604c52686c273d9a1b44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2970813 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#75238}
-
Camillo Bruni authored
- Dynamically adjust timeline-tracks height - Use CSS-vars for timeline view and data heights - Introduce syncronous File.read for FireFox again - Prepare for fixed-scaled SVG text Bug: v8:10644 Change-Id: I3a6815df49e57eb49c55a8498ce7b8f49e5fd0ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968945 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75237}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id94edd934ff57a722012fabb729046dc7a8bc29c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968944Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#75236}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I6a0b6bc1b4a7c75bfca2e4f611f45012474309a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968414Reviewed-by:
-
Igor Sheludko authored
Namely, - StackFrameInfo::code_object - DependentCode's code entries - OSROptimizedCodeCache's code entries Bug: v8:11880 Change-Id: I49bc28f2935dd1561901932a2dfe0bf01bc6836e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969824Reviewed-by:
-
Igor Sheludko authored
This CL migrates BaselineData::baseline_code field and InterpreterData::interpreter_trampoline field to CodeT. Bug: v8:11880 Change-Id: Ibd202f0dcd4266e5b98aa5c46754ba8a4fadff43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968415Reviewed-by:
-
Victor Gomes authored
Bug: v8:7834 Change-Id: I6ea4b67841104ba438b1b07b9e85bf955c152d34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967465 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#75232}
-
Maya Lekova authored
Bug: v8:11905 Change-Id: Ie43c7240383ceae522d715970615286aaeff7379 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2971744 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#75231}
-
Daniel Lehmann authored
Currently, we have two different classes for switching the WebAssembly generated code space to writable (e.g., before patching jump tables, or when adding or removing code): `CodeSpaceWriteScope` (with the macro `CODE_SPACE_WRITE_SCOPE`) and `NativeModuleModificationScope`. The former was introduced for Apple Silicon ARM64 hardware ("Apple M1"), which uses `MAP_JIT` + `pthread_jit_write_protect_np()` to change memory permissions. The latter uses either Intel PKU (aka. memory protection keys) to switch permissions (fast and thread-local, like on M1), and alternatively `mprotect()`, on systems that do not have PKU support. Since both classes serve the same purpose just with different implementations on different platforms, we want to merge them in follow-up CLs. As a first step, here we align all uses of `CODE_SPACE_WRITE_SCOPE` with existing `NativeModuleModificationScope`s. The two had diverged due to optimization work, where we moved `NativeModuleModificationScope`s around (pulling them out of loops and across function boundaries) to lower the amount of mprotect switches. This should have none, or at best a very small positive performance impact on Apple M1, since we now also switch less often (even though switching should be very cheap). In terms of security, this in theory makes the code space writable for longer time spans, but this is probably not a large effect because (1) we often moved the scope outside of loops, where it was open for every iteration anyway, or (2) in some cases a CODE_SPACE_WRITE_SCOPE was open somewhere on the call stack already. R=jkummerow@chromium.org CC=clemensb@chromium.org Bug: v8:11714 Change-Id: Id8744429e1183e118ab5e078750d294a99c9dce0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968946Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1a575de..11f1e3d Rolling v8/third_party/aemu-linux-x64: D99f9rA6SsUg1U4VGdh-MSQQX94eeW2Mi8I_xw6-ccwC..R61GnhotR5EpRE5ZeVtRvIQPRz8z-LSXnxN1ighigqMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/96bc38d..2573cff Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/74ef838..59140d4 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/e2239ee..7153098 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I0fafb6e0e25119a87669352d188850459c9ec8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2970788Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75229}
-
Frank Tang authored
https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd Bug: v8:7051 Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481Reviewed-by:
-
- 17 Jun, 2021 24 commits
-
-
Milad Fa authored
Note that `kFixedFrameSizeFromFp` is hard coded to include space for Simd registers however it is only used when Wasm is enabled so adding V8_ENABLE_WEBASSEMBLY guards under MultiPushF64AndV128 and MultiPushF64OrV128 will be safe, more detail are in the comment section of this CL: https://crrev.com/c/2656857 Port b0eb59fb Original Commit Message: Note that Arm32 is already saving the full register in https://source.chromium.org/chromium/chromium/src/+/main:v8/src/codegen/arm/macro-assembler-arm.cc;l=2250;drc=ec4fd32cf7f945923fa6bb332c061ecbdaaaa405 R=solanes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ica4230f31b207e5933ed5c891b091a2f32782284 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969823Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75227}
-
Igor Sheludko authored
Namely, - WasmFunctionData::wrapper_code - WasmJSFunctionData::wasm_to_js_wrapper_code - exported JS-to-Wasm wrappers Bug: v8:11880 Change-Id: I85f60daea22b8b1270f813f903ebdea1249b4de1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969826Reviewed-by:
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Idf23521d6cb1885922f92e1050937daa2d29acd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968409Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75225}
-
Camillo Bruni authored
- Add tests and fix Chunk calculations in Timeline class - Cache DOM nodes directly as properties in TimelineTrackBase - Keep track of last focused entry in timeline tracks and reuse it to position the tooltip when the view is locked Bug: v8:10644 Change-Id: I356dcf7eed220df89f6a7ff926f00f78b119160e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968943 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Milad Fa authored
This reverts commit 9caf26b9. Reason for revert: Needed to be changed to kNumCallerSavedDoubles Original change's description: > S390: fix byte count when pushing/popping doubles > > `NumRegs` runs a `population count` and must be used with > a `RegList` and not with a regular integer value. > > kCallerSavedDoubles is a regular integer and should be used as is. > > Change-Id: Id9535134ad4ea02bebed9b506012084d93acc2c2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965159 > Reviewed-by: Junliang Yan <junyan@redhat.com> > Commit-Queue: Milad Fa <mfarazma@redhat.com> > Cr-Commit-Position: refs/heads/master@{#75213} Change-Id: Ifae6ee99b698f5a1f68a7c42cda1743fd1cbf0d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2969623 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Andreas Haas authored
The test was a bit out-dated, the expected file did not match the test or the data delivered by V8 anymore. However, all the expected data was available, so I just adjusted the test accordingly. R=clemensb@chromium.org Bug: v8:10356 Change-Id: I1d94f2a295038a4320e07706d46258a278a6dee5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968410Reviewed-by:
-
Maya Lekova authored
Bug: v8:11780 Change-Id: I646092d7e54893ff065db0cf1ce72533617ea38d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968408 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This isn't used outside of tests, so let's just remove it. Change-Id: I06b7ec11911fd8ebc3bbabcba16d0c2a3fafddab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968413Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75220}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I08b9eb182a42ca612a60fdafc0a059f97a3f0d87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968411Reviewed-by:
-
Andreas Haas authored
At the moment deserialization happens synchronously on the main thread. This is fine at the moment because deserialization is fast. However, future refactorings may affect deserialization time, and may force us to deserialize in the background. This CL adds a timer to monitor deserialization time, so that we get a signal if deserialization time regresses. R=clemensb@chromium.org Bug: v8:11862 Change-Id: I18b52c19106b92158cd986492926a24d0d57e6ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966389Reviewed-by:
-
Toon Verwaest authored
This also removes intrinsics that were just used in tests. It keeps InlineIncBlockCounter for now because it's a less straightforward. Change-Id: I77e55d7a746294892d0fd7ab577ebf8eb42f1f08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953195 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Dan Elphick authored
Replace all uses of NewArray/DeleteArray with new[]/delete[] in utils/vector.h which allows removing the dependency on utils/allocation.h. As a result allocation failures here will not call FatalProcessOutOfMemory any more, but it's likely it wouldn't have been called anyway. Also adds some missing includes that were being previously being brought in via vector.h depending on allocation.h. Bug: v8:11879 Change-Id: I5055b49fad0d06642a9bd3eebb93a6a0e4acca60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968405Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Dominik Inführ authored
MemoryChunkLayout::MaxRegularCodeObjectSize() can be cached in a global variable on process initialization. This should help to increase code object allocation performance, since this method was called on each code object allocation. Bug: v8:11891 Change-Id: I870bd37202370aec89ef2db24264e363099bf8a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966387 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
WebAssembly.Exception is the static representation of a wasm exception. It holds the signature and the tag of the exception, can be imported and exported from a wasm module, and will eventually allow inspecting a wasm-thrown exception from JS. R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ided352777e1217e6f873b84a2fc21c3acf59ff6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966384Reviewed-by:
-
Milad Fa authored
`NumRegs` runs a `population count` and must be used with a `RegList` and not with a regular integer value. kCallerSavedDoubles is a regular integer and should be used as is. Change-Id: Id9535134ad4ea02bebed9b506012084d93acc2c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965159Reviewed-by:
-
Igor Sheludko authored
Bug: v8:11804 Change-Id: Ief0ade232c4f120b62a6d83f75ed0095abbe797a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966388Reviewed-by:
-
Lu Yahan authored
Change-Id: Ic36d34ca928b2dbc7427f60818dbd612b386e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967709Reviewed-by:
-
QiuJi authored
Change-Id: I541973c5b0570c1a1c23ce8e09cd20d3904df749 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966198Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#75210}
-
Mike Stanton authored
Mark the write of the property as relaxed atomic. The compiler thread is examining the value. It is fine if the value is stale or new, we simply need to let TSAN know we are aware of the race. BUG=v8:11896 Change-Id: I42505a6e12c7eb3c1ef8d9376d7a420567646d62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968403Reviewed-by:
-
Mike Stanton authored
The PropertyArray may store the hash of it's parent object. This hash can be installed at various points. Meanwhile, the background compiler thread inspects the length field. BUG=chromium:1220974 Change-Id: I7b13fd4546fb48e649fcbf67dee02d7c668393f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967471 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This CL adds - CodeT type - an alias for CodeDataContainer or Code depending on whether the v8_enable_external_code_space is enabled or not, - a set of conversion functions from CodeT to Code or CodeDataContainer and back (both in C++ and CodeStubAssembler), - masm support for calling/tailcalling via CallDataContainer which contain the code entry point address, - masm support for calling/tailcalling via CodeT. Bug: v8:11880 Change-Id: Ib36f4c6db69ec49aaea29412647e59ada95da19b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967463 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:11234 Change-Id: I5fa2d97e01df25171c2a80aafb265b508176b334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967470 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:11234 Change-Id: I6b3d3a72ad272b8b98e58c0de02b6a9b3dcfb5a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967466 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75205}
-
Santiago Aboy Solanes authored
This finishes the TSAN support for loads as we do not use movb or movw to load from memory Bug: v8:7790, v8:11600 Change-Id: I3c319da95c24cfa03f4de2367e007fd4cf7dd355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953321Reviewed-by:
-
