- 21 Nov, 2017 5 commits
-
-
Marja Hölttä authored
This code was confusing, since "target" declared in one of the subscopes shadowed a parameter with the same name. Change-Id: Ibf694c94f0a26ca65609cb80d22c40a8fa98f4f3 Reviewed-on: https://chromium-review.googlesource.com/779261Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#49518}
-
Michael Starzinger authored
R=jarin@chromium.org BUG=v8:6792 Change-Id: Id97c7a9911eb2c0606f8ea25d0a2c8ebcb4c8ccd Reviewed-on: https://chromium-review.googlesource.com/753729Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49517}
-
Camillo Bruni authored
Not resetting the ticks regresses optimization time without substantial performance benenfits on twitter, facebook, youtube, linkedin and wikipedia. There was no net positive effect visible otherwise. Bug: chromium:786908 Change-Id: I98237dee170e7a387f09ccfbad178793361d4a67 Reviewed-on: https://chromium-review.googlesource.com/779435Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49516}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5718716..6167734 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/509676b..bd3b137 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I70c12249d7946044d7049f5cf03357c5a2d1fbaf Reviewed-on: https://chromium-review.googlesource.com/780865Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49515}
-
Alexei Filippov authored
BUG=v8:7070 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I92d7c61afa88e0a52c8eed0c2a44a4e49847e83b Reviewed-on: https://chromium-review.googlesource.com/767618Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#49514}
-
- 20 Nov, 2017 35 commits
-
-
Ben Smith authored
The strex (Store Exclusive) instruction has the form: strex rd, rt, [rn] It stores the value in register rt at the address in register rn. If the store succeeds, then 0 is stored in rd, otherwise 1 is stored. The ARM manual says that behavior is "unpredictable" if d == n || d == t (i.e. those registers are aliased). We were not checking for this behavior in the assembler or simulator, and as a result were generating output where it occurred. This didn't always break; the tests we run on ARM hardware run this instruction and pass. BUG: chromium:786168 Change-Id: I57fe3a1db406eac96eb04ef2246f6970548d3cf9 Reviewed-on: https://chromium-review.googlesource.com/777777Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#49513}
-
Mircea Trofin authored
This is a reland of c71fd20c Original change's description: > [wasm] Data structures for JIT-ing wasm to native memory. > > This CL introduces the structures for JIT-ing wasm on the native heap. > They are described in detail at go/wasm-on-native-heap-stage-1 > > Briefly: > - WasmCodeManager manages memory for modules and offers an interior > pointer lookup (i.e. PC -> WasmCode) > - WasmCode represents code, including reloc info. It holds wasm > specific data, like function index, and runtime information, like trap > handler info. > - NativeModule manages memory for one module. > > Tests cover the allocation and lookup aspects, following that current > regression tests cover the JITed code. A separate CL will enable > JITing using the new data structures. > > Bug: v8:6876 > Change-Id: I1731238409001fe97c97eafb7a12fd3922da6a42 > Reviewed-on: https://chromium-review.googlesource.com/767581 > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49501} Bug: v8:6876 Change-Id: Ifd1a4c23de8150dbdc75f059cd657e9670b15c9b Reviewed-on: https://chromium-review.googlesource.com/779680 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#49512}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: chromium:786938,v8:7106 Change-Id: Id60354be899187e4c09d53434ad70019c857f9e9 Reviewed-on: https://chromium-review.googlesource.com/779725 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49511}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:7106,chromium:786938 Change-Id: Iddd573013cb9322d1df06038f10f0e49a6497110 Reviewed-on: https://chromium-review.googlesource.com/779721 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49510}
-
Georg Neis authored
This adds a bigint branch to the typed-optimization of the TypeOf bytecode. The implementation of the TestTypeOf bytecode already supports bigints, as does the Typeof stub. R=jarin@chromium.org Bug: v8:6791 Change-Id: Ib9a21f3fc48d57873b014a01c68a143bfb8ac6c6 Reviewed-on: https://chromium-review.googlesource.com/778880 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49509}
-
Clemens Hammacher authored
This is a reland of 236298ac. Original change's description: > [wasm] Unify deoptimization data > > Add methods to add deoptimization data and use them from all the places > where we currently add them manually. Also add them to wasm-to-wasm > wrappers compiled on table set, which was missing before, leading to > the referenced bug. > > R=ahaas@chromium.org > > Bug: chromium:779292 > Change-Id: Ib9132d9faeb1092c46e22dd8196d201ce5c0942f > Reviewed-on: https://chromium-review.googlesource.com/774838 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49452} Bug: chromium:779292 Change-Id: I8219305fc894c50904db57e51245733f6613dcd3 Reviewed-on: https://chromium-review.googlesource.com/778159Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49508}
-
Michael Achenbach authored
This reverts commit 712fa675. Reason for revert: Infra side change was reverted. Please reland after it stays in for a bot cycle... Original change's description: > [test] Add Liftoff variant > > Add a variant for testing the current state of the Liftoff > implementation. > This variant will only run on a subset of the bots, just like the > --future variant. > > R=machenbach@chromium.org, hablich@chromium.org > > Bug: v8:7088, v8:6600 > Change-Id: If49fad3a8ed579356504b821a787326754f24e78 > Reviewed-on: https://chromium-review.googlesource.com/779420 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49504} TBR=machenbach@chromium.org,hablich@chromium.org,clemensh@chromium.org Change-Id: Ib6b2e79cea5d9f99f8933c72bbb9d9dddbd6ae07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7088, v8:6600 Reviewed-on: https://chromium-review.googlesource.com/779719Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49507}
-
Brad Nelson authored
BUG=chromium:786021 R=titzer@chromium.org Change-Id: I188ea4d639ef9d5ceeab5052e043ec1c9150bd77 Reviewed-on: https://chromium-review.googlesource.com/778282Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#49506}
-
Peter Marshall authored
Free ArrayBuffer backing stores on a background thread, rather than blocking the main thread after processing. Could potentially cause contention with the array buffer allocator once JS execution resumes. The new ArrayBufferCollector class tracks these dead allocations. Later, the processing of array buffers can happen in parallel. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux64_tsan_rel;master.tryserver.v8:v8_linux64_tsan_concurrent_marking_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: v8:6992 Change-Id: I2b74f008f79521414374f607ed510f66508af160 Reviewed-on: https://chromium-review.googlesource.com/779182 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49505}
-
Clemens Hammacher authored
Add a variant for testing the current state of the Liftoff implementation. This variant will only run on a subset of the bots, just like the --future variant. R=machenbach@chromium.org, hablich@chromium.org Bug: v8:7088, v8:6600 Change-Id: If49fad3a8ed579356504b821a787326754f24e78 Reviewed-on: https://chromium-review.googlesource.com/779420 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49504}
-
Mircea Trofin authored
This reverts commit c71fd20c. Reason for revert: msvc is unhappy (https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/208) Original change's description: > [wasm] Data structures for JIT-ing wasm to native memory. > > This CL introduces the structures for JIT-ing wasm on the native heap. > They are described in detail at go/wasm-on-native-heap-stage-1 > > Briefly: > - WasmCodeManager manages memory for modules and offers an interior > pointer lookup (i.e. PC -> WasmCode) > - WasmCode represents code, including reloc info. It holds wasm > specific data, like function index, and runtime information, like trap > handler info. > - NativeModule manages memory for one module. > > Tests cover the allocation and lookup aspects, following that current > regression tests cover the JITed code. A separate CL will enable JITing > using the new data structures. > > Bug: v8:6876 > Change-Id: I1731238409001fe97c97eafb7a12fd3922da6a42 > Reviewed-on: https://chromium-review.googlesource.com/767581 > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49501} TBR=bradnelson@chromium.org,ulan@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mlippautz@chromium.org Change-Id: Id54deb74782c6f0fd06c61ddcabb727eb7010333 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6876 Reviewed-on: https://chromium-review.googlesource.com/779679Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49503}
-
Toon Verwaest authored
Bug: v8:7067 Change-Id: Ie9c0a84492965d08f67c910c489e59cbc50a5918 Reviewed-on: https://chromium-review.googlesource.com/778819Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#49502}
-
Mircea Trofin authored
This CL introduces the structures for JIT-ing wasm on the native heap. They are described in detail at go/wasm-on-native-heap-stage-1 Briefly: - WasmCodeManager manages memory for modules and offers an interior pointer lookup (i.e. PC -> WasmCode) - WasmCode represents code, including reloc info. It holds wasm specific data, like function index, and runtime information, like trap handler info. - NativeModule manages memory for one module. Tests cover the allocation and lookup aspects, following that current regression tests cover the JITed code. A separate CL will enable JITing using the new data structures. Bug: v8:6876 Change-Id: I1731238409001fe97c97eafb7a12fd3922da6a42 Reviewed-on: https://chromium-review.googlesource.com/767581 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49501}
-
Andreas Haas authored
R=clemensh@chromium.org Change-Id: Ie66315bc3fdb44387f4dc8e4dd6e1058c173b786 Reviewed-on: https://chromium-review.googlesource.com/779123 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49500}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: Change-Id: Ic95d5fc96fd6546709c024f6f772fb3308e93887 Reviewed-on: https://chromium-review.googlesource.com/779459 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49499}
-
Andreas Haas authored
I just pass a pointer of the platform to the task runner so that the task runners can put tasks directly into the platform data structures. R=rmcilroy@chromium.org Change-Id: I7c1c56c3b9f550c0fe80012abcd31011e69f3d5d Reviewed-on: https://chromium-review.googlesource.com/771751Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49498}
-
Michael Lippautz authored
Bug: Change-Id: Ia3e42c8bfc8773fbd160f4200337617afd54d445 Reviewed-on: https://chromium-review.googlesource.com/779196Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49497}
-
Michal Majewski authored
Test suite contract changes: - support * only at the end of the rule. - loading status file is mandatory before filtering by status file. Bug: v8:6917 Change-Id: Ia345ebfa7827c50f13f20e5cb7489e62c53f3357 Reviewed-on: https://chromium-review.googlesource.com/779185 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49496}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ida8594caead9119b7b5dad6209017e2eae9cd3aa Reviewed-on: https://chromium-review.googlesource.com/776799 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49495}
-
Andreas Haas authored
Streaming compilation started the compilation of a module at the beginning of the code section. However, there exist valid modules which do not contain a code section. In this CL we check for the existence of a code section when we finish the stream. We do this by checking if the module compiler in the AsyncCompileJob exists, because the module compiler gets initialized at the beginning of the code section. If we detect that compilation has not been started because there was no code section, then we start compilation when the stream finishes. R=clemensh@chromium.org Bug: chromium:771973 Change-Id: I7c95a7a791d02254f086961e7cd81885eec27382 Reviewed-on: https://chromium-review.googlesource.com/778541 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49494}
-
Michael Achenbach authored
Bug: chromium:786938 Change-Id: Ib8041c3cfe2237922824d783ebf8f0bb4d967a53 Reviewed-on: https://chromium-review.googlesource.com/779259Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49493}
-
Georg Neis authored
We should only ever call value() on a variable while we are inside a block. This CL adds a DEBUG check to this effect. Bug: Change-Id: Ic85fae70e2c3543ff79e3234ba26e1daa234f7e3 Reviewed-on: https://chromium-review.googlesource.com/772233Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49492}
-
Michael Lippautz authored
Bug: chromium:750084 Change-Id: I3d449ab76101100866b18db776b9f282154a77d9 Reviewed-on: https://chromium-review.googlesource.com/768679 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49491}
-
Mike Stanton authored
Bug: v8:7002 Change-Id: Id8a7362f199ee776c0eade4cdbb9d3e413c17ead Reviewed-on: https://chromium-review.googlesource.com/778164Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49490}
-
Michael Achenbach authored
This reverts commit b6658ade. Reason for revert: TSAN detects data race when running mksnapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/18354 Original change's description: > [heap] Concurrently free ArrayBuffer allocations. > > Free ArrayBuffer backing stores on a background thread, rather than > blocking the main thread after processing. Could potentially cause > contention with the array buffer allocator once JS execution resumes. > > The new ArrayBufferCollector class tracks these dead allocations. > > Later, the processing of array buffers can happen in parallel. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > > Bug: v8:6992 > Change-Id: I49ae4db12ed62d8400ba2bbafeda05a11479d904 > Reviewed-on: https://chromium-review.googlesource.com/739829 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49485} TBR=hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org Change-Id: I293440b5f2602ca1c8ad120003f551bc8db6b75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6992 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/779199Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49489}
-
Peter Marshall authored
This reverts commit b6658ade. Reason for revert: Breaks TSAN :( Original change's description: > [heap] Concurrently free ArrayBuffer allocations. > > Free ArrayBuffer backing stores on a background thread, rather than > blocking the main thread after processing. Could potentially cause > contention with the array buffer allocator once JS execution resumes. > > The new ArrayBufferCollector class tracks these dead allocations. > > Later, the processing of array buffers can happen in parallel. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > > Bug: v8:6992 > Change-Id: I49ae4db12ed62d8400ba2bbafeda05a11479d904 > Reviewed-on: https://chromium-review.googlesource.com/739829 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49485} TBR=hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org Change-Id: If6743b83f871c0fd0d6e83a3083dce0eecd99021 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6992 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/779159Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49488}
-
Michael Achenbach authored
This updates the V8 side MB fork with all upstream changes until: https://chromium.googlesource.com/chromium/src/+/f4d92a15f/tools/mb/mb.py This includes a required feature for mapping isolate targets to runtime deps. Bug: chromium:669910 Change-Id: I22244455b22737cfbfc45adef93581ef44cf4151 Reviewed-on: https://chromium-review.googlesource.com/778879Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49487}
-
Benedikt Meurer authored
Avoid the stupid newline when the name is a String, which is automatically appended by the Object::Print() method. Just use the Name::NamePrint() method instead. Bug: v8:5267 Change-Id: I12ec878325b6f6ecdd8633a5ac8129b2398ddf9a Reviewed-on: https://chromium-review.googlesource.com/778823Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49486}
-
Peter Marshall authored
Free ArrayBuffer backing stores on a background thread, rather than blocking the main thread after processing. Could potentially cause contention with the array buffer allocator once JS execution resumes. The new ArrayBufferCollector class tracks these dead allocations. Later, the processing of array buffers can happen in parallel. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Bug: v8:6992 Change-Id: I49ae4db12ed62d8400ba2bbafeda05a11479d904 Reviewed-on: https://chromium-review.googlesource.com/739829 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49485}
-
jgruber authored
When collecting source ranges for conditionals (`a ? b : c`), include the '?' and ':' tokens in the then- and else ranges, respectively. Bug: v8:7098 Change-Id: I22315e2040c96c977e0b49e1fafe4228a6558471 Reviewed-on: https://chromium-review.googlesource.com/778321Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49484}
-
Ross McIlroy authored
This moves the logging of the RCS event for background parsing tasks out of the parser and performs it at the end of the background parsing task. This is necessary in order to log background compile RCS events which happen after parsing. BUG=v8:5203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie216eeade0279d8243818a8eb59309969775823c Reviewed-on: https://chromium-review.googlesource.com/776669Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49483}
-
Benedikt Meurer authored
For the fast case we can avoid the instance type check, since the map check covers that. We also don't need to call out to the ToBoolean builtin in general, but just use the BranchIfToBooleanIsTrue logic. Plus in the fast case, we don't know that the JSIteratorResult::done is a boolean, since the map doesn't guard this assumption, so we also need to do a proper BranchIfToBooleanIsTrue in that case. Bug: v8:5269 Change-Id: I36f0d0841472c02f8030f9ce067d20326c9388bd Reviewed-on: https://chromium-review.googlesource.com/778882Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49482}
-
Daniel Clifford authored
Bug: chromium:785804 Change-Id: I1a65e2007438ac009d961e0e2c0425212216fcf1 Reviewed-on: https://chromium-review.googlesource.com/776696Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#49481}
-
Benedikt Meurer authored
We can just use the same trick here that we use with TurboFan and load the (signaling) NaN value out of the canonical tagged root. This improves the loop for initializing double backing stores by hoisting the load of the constant value out of the loop. Bug: v8:5267 Change-Id: Idcf07c0e910ecc085a8b89225613f0a8fb50a414 Reviewed-on: https://chromium-review.googlesource.com/778979Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#49480}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:748000 Change-Id: I383a1203b094d1e17453ee5aabca3267132df363 Reviewed-on: https://chromium-review.googlesource.com/778540Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49479}
-