- 16 Oct, 2019 7 commits
-
-
Clemens Backes authored
It turns out that because we are *subtracting* from fp, we need to *subtract less* to get a higher address. Who knew. R=jkummerow@chromium.org Bug: v8:9830, chromium:1014798 Change-Id: I5b9782dd0be27f4c3efbd306ec6c3450b249cb55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864933Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64321}
-
Sathya Gunasekaran authored
Updates CSA::TryToIntptr to handle array indices that are less than INT_MAX which allows to handle string keys in the ICs. Updates ICs to go monomorphic for string keys that are array indices. Updates Turbofan to handle array indices when lowering element access. Change-Id: Ibdde20130e075d0d645ab4a8266a968335eaad84 Bug: v8:9449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1813018Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64320}
-
Joshua Litt authored
This cl modifies RegExp.prototype.matchAll to throw on non-global regexps. Relevant pull request: https://github.com/tc39/ecma262/pull/1716 Bug: v8:9800 Change-Id: Ie963c1c00441f1c4e2b975c3bab77cca902c7ebc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846067Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64318}
-
Thibaud Michaud authored
This prevents the branch table iterator's has_next() method to trigger a DCHECK when the decoder fails before the end of table decoding. R=clemensb@chromium.org Change-Id: I2258886501b77cd4c8fe98bc8a4ed0b66fb23066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864931Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#64312}
-
Thibaud Michaud authored
R=ahaas@chromium.org Change-Id: I0405abbd8fc047653758ac41d185bf0f44e33d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859617 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64309}
-
Sigurd Schneider authored
This fixes a bug where coverage for the inline script <script>function foo() {}<script> started to get deterministically reported as covered after crrev.com/c/1771776, while before it, we most of the time reported it as uncovered (depending on heap order of SFIs). The correct result is to report `foo` as uncovered as it is never called. The problem arose from the fact that v8:9212 needed to handle extra-wrappers around scripts correctly. Those wrappers have the same source range as the wrapped script and a call count of zero even if the wrapped script is executed. To filter them out, we previously determined nesting for identical source ranges by ascending call count. However, in the script case above, the script has call count one, while `foo` (which has the same source range) has call count zero. In this case, nesting is decreasing order of call counts. This CL is a minimal change that sorts SFIs which are top-level to the front, only then considers call counts in descending order. This preserves the behavior that node's extra wrappers are sorted to the front (and then filtered out by existing logic), but also ensures that for the example above, we report the script's coverage before the coverage for `foo`. Bug: v8:9857, v9:9212 Change-Id: Id224b0d8f12028b1f586ee5039e126bb5b8d8d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863197Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64307}
-
Jakob Gruber authored
Named capture properties on the groups object should be ordered by the capture index (and not alpha-sorted). This was accidentally broken in https://crrev.com/c/1687413. Bug: v8:9822,v8:9423 Change-Id: Iac6f866f077a1b7ce557ba47e8ba5d7e7014b3ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864829 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#64306}
-
- 15 Oct, 2019 2 commits
-
-
Ulan Degenbaev authored
AsmJs does not support SharedArrayBuffers. This CL adds a check in instantiation and reports a proper error. Bug: chromium:1013920 Change-Id: Id7159f23ddcc2bde139c4c97bdb67ef3dc7f0e22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862563Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64291}
-
Leszek Swirski authored
Fix uses of cached descriptors arrays used in loops that map-check to ensure validity of the cache to also reload the descriptor in case there are missed in-place representation updates. As a drive-by, introduce inner HandleScopes for these loops. Bug: chromium:1012301 Change-Id: I17273caf629a181b846d3c09777b5c08fd8cbb0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859621Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#64287}
-
- 14 Oct, 2019 2 commits
-
-
Thibaud Michaud authored
R=ahaas@chromium.org Change-Id: Iea0fe775eb8c101200fe41e5e188bbdc85c03df7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1856000Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#64272}
-
Michael Starzinger authored
With exception handling enabled new call paths open up, which will perform environment merging while a "call" or "call_indirect" is currently being emitted. This will lead to double-use of the buffer returned by calls to {Buffer} or {Realloc}. In general we should transition away from this optimization to safer constructs such as {base::SmallVector} to avoid such bugs. R=clemensb@chromium.org TEST=mjsunit/regress/regress-9832 BUG=v8:9832 Change-Id: I4c862ac1bc7dc34ad62279c82f6414153e8cbddb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1856006 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64271}
-
- 11 Oct, 2019 2 commits
-
-
Ng Zhi An authored
Increase the embedded vector size to 91 as that is the max size needed to print a s128 as a 32x4. - max value of uint32_t has 10 digits in decimal, 1 for a potential sign, 3 spaces in between 4 of them -> 3 + 4 * 11 = 47 - max value of uint32_t has 8 digits in hex, 3 spaces in between -> 3 + 4 * 8 = 35 - the prefix "v128:" -> 5 - " / " to separate the decimal and hex representation -> 3 - null byte 47 + 35 + 5 + 3 + 1 = 91 Bug: v8:9754 Change-Id: I153c30738fa8862b44fb5103cbe62ea0bcea9718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1814885 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64256}
-
Leszek Swirski authored
Bug: chromium:1012301 Change-Id: I805affc8b18130d9d4de995eed8a905d7fcd4d75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1856005 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64249}
-
- 10 Oct, 2019 3 commits
-
-
Joyee Cheung authored
This patch implements https://github.com/tc39/proposal-class-fields/pull/269 and makes sure we always throw TypeError when there is invalid private name access in computed property keys. Before this patch, private name variables of private fields and methods are initialized together with computed property keys in the order they are declared. Accessing undefined private names in the computed property keys thus fail silently. After this patch, we initialize the private name variables of private fields before we initialize the computed property keys, so that invalid access to private fields in the computed keys can be checked in the IC. We now also initialize the brand early, so that invalid access to private methods or accessors in the computed keys throw TypeError during brand checks - and since these accesses are guarded by brand checks, we can create the private methods and accessors after the class is defined, and merge the home object setting with the creation of the closures. Bug: v8:8330, v8:9611 Change-Id: I01363f7befac6cf9dd28ec229b99a99102bcf012 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846571 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64225}
-
Joshua Litt authored
While removing dead code, v8 currently removes jump targets, but leaves suspend points, resulting in bytecode analysis issues. This cl simply removes the suspend point if the remainder of the block is dead. Bug: v8:9825 Change-Id: Ib147ca01cf64c695c0316017852d61f52fd10cf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1849197 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#64223}
-
Joyee Cheung authored
This patch refactors the declaration and allocation of the class variable, and implements static private methods: - The class variable is declared in the class scope with an explicit reference through class_scope->class_variable(). Anonymous classes whose class variable may be accessed transitively through static private method access use the dot string as the class name. Whether the class variable is allocated depending on whether it is used. Other references of the class variable in the ClassLiteral AST node and the ClassInfo structure are removed in favor of the reference through the class scope. - Previously the class variable was always (stack- or context-) allocated if the class is named. Now if the class variable is only referenced by name, it's stack allocated. If it's used transitively by access to static private methods, or may be used through eval, it's context allocated. Therefore we now use 1 less context slots in the class context if it's a named class without anyone referencing it by name in inner scopes. - Explicit access to static private methods or potential access to static private methods through eval results in forced context allocation of the class variables. In those cases, we save its index in context locals in the ScopeInfo and deserialize it later, so that we can check that the receiver of static private methods is the class constructor at run time. This flag is recorded as HasSavedClassVariableIndexField in the scope info. - Classes that need the class variable to be saved due to access to static private methods now save a ShouldSaveClassVariableIndexField in the preparse data so that the bits on the variables can be updated during a reparse. In the case of anonymous classes that need the class variables to be saved, we also re-declare the class variable after the reparse since the inner functions are skipped and we need to rely on the preparse data flags to remember declaring it. Design doc: https://docs.google.com/document/d/1rgGRw5RdzaRrM-GrIMhsn-DLULtADV2dmIdh_iIZxlc/edit Bug: v8:8330 Change-Id: Idd07803f47614e97ad202de3b7faa9f71105eac5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781011 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64219}
-
- 09 Oct, 2019 1 commit
-
-
Santiago Aboy Solanes authored
CheckedInt32ToTaggedSigned -> ChangeTaggedSignedToCompressedSigned was being simplified to CheckedInt32ToCompressedSigned. However, sometimes the effect chain is not propagated correctly. Since we have plans to remove the Compressed MachineRepresentation, we can remove this optimization now. Bug: v8:7703, chromium:1011980 Change-Id: I9198c73666848f89db96928259af68400d442229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847363Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64178}
-
- 08 Oct, 2019 6 commits
-
-
Jakob Kummerow authored
Tbr: clemensb@chromium.org No-Tree-Checks: true No-Try: true Change-Id: Id4ca5f618d035de13174e54ff4d617b03d839033 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847364Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64164}
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set)Global' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set)Global\b/kExprGlobal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I064a6448cd95bc24d31a5931b5b4ef2464ea88b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847355 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64163}
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64161}
-
Jakob Kummerow authored
The particular combination of (1) having callee-saved registers in the stub per the C++ calling convention, (2) passing arguments to the callee on the stack, and (3) that callee throwing an exception, caused the saved registers to be restored to bogus values. To fix this, the stack unwinder needs to compute the stub's frame size correctly (i.e. without stack parameters). Bug: chromium:1007608 Change-Id: Iadd99f10764f49f9e3c620c05723e09172c73cf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847352Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64160}
-
Mythri A authored
Empty slow element dictionary had the sticky bit set. This bit was used to indicate that the dictionary cannot go to the fast mode either because the dictionary had elements with attributed or elements at large indices. There is no reason for the empty dictionary to have this bit set. This causes bugs in some corner cases. Bug: chromium:1003732 Change-Id: Ib29e1cda784869b9deb9361d8e6b5539f7154a38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833686Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#64158}
-
Clemens Backes authored
The test creates 10000 modules, which runs in less then one second in release builds, but can take much longer with stress flags and on special bots. It timed out on the tsan isolates bot in a variant passing --stress-wasm-code-gc. Since the test should only verify that we support more than 1000 modules in a single isolate, we do not need to run it in that variant. Thus just skip it. R=fgm@chromium.org Bug: v8:9814 Change-Id: Ie3a4f62a053b1f7cff2c2206f39ddd71a533ae3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1845229Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64153}
-
- 07 Oct, 2019 3 commits
-
-
Thibaud Michaud authored
R=mstarzinger@chromium.org Bug: v8:9492 Change-Id: Ie404eb6cb07ea033a10d29dd1b9aba6cb1f03b69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826663 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64134}
-
Santiago Aboy Solanes authored
... and make sure that the arm64 ptr-compr bots proceed testing V8 without pointer compression in order to keep testing the other config. Bug: v8:7703 Change-Id: I0017345273d5328d95a338064dd80b44974c1c53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844780Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64132}
-
Dan Elphick authored
Fixes spurious DCHECK triggering due to bug introduced in https://chromium-review.googlesource.com/c/v8/v8/+/1836258. Bug: chromium:1011596 Change-Id: Ia3b1eb25d326e465b3239f191aad11d90a2e56a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844777Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64125}
-
- 04 Oct, 2019 2 commits
-
-
Dan Elphick authored
This deletes unresolved VariableProxy objects created for labels in the preparser which prevents shadowed variables in enclosing scopes from being context-allocated. Previously this was only done in the full parser, which leads to bytecode mismatches with lazy source positions. Bug: chromium:1009728, v8:8510 Change-Id: If2d0c345346116a7f5aacbcd0cf3638e9f7e04cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836258Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64104}
-
Maya Lekova authored
This reverts commit f47706a7. Reason for revert: Breaks V8 Linux bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/34070 Original change's description: > [wasm] Add tests for SIMD JS-API errors > > Change-Id: I7fc2eb95f9a2d1ea45bc84543a05c84e32bb6d31 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838924 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64098} TBR=gdeepti@chromium.org,ahaas@chromium.org,zhin@chromium.org Change-Id: I6640ba207e30200e6846a16cab0bd522cabf3108 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1839651Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64099}
-
- 03 Oct, 2019 1 commit
-
-
Deepti Gandluri authored
Change-Id: I7fc2eb95f9a2d1ea45bc84543a05c84e32bb6d31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838924Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64098}
-
- 02 Oct, 2019 2 commits
-
-
Michael Lippautz authored
Fix corner case where we would try to read a property when having a pending or scheduled exception. Re-add tests. Bug: chromium:1006640 Change-Id: I2fc84ee0f6145db2d200a8b9abf57fdc4b12a5a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835531Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#64083}
-
Michael Lippautz authored
Bug: chromium:1006640 Change-Id: I0f38ed9c44b6a2a6cfd52fdd9e177768f57beb11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833692 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#64077}
-
- 01 Oct, 2019 1 commit
-
-
Ana Peško authored
This is a reland of cfb60d43 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} Bug: v8:9566 Change-Id: I81a10728c64ce3b35258c31eb8178e458d3de205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832167Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64063}
-
- 30 Sep, 2019 6 commits
-
-
Suraj Sharma authored
Since slow handler was previously not a Smi. The DCHECK assumed any Smi Handler on this path should be a proxy handler. Now it Checks for both, and should continue if the current handler is a slow handler. Bug: chromium:1008632 Change-Id: I079960894d7320d8d658d0990e8c32db51703206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828480Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Suraj Sharma <surshar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#64052}
-
Z Nguyen-Huu authored
Bug: v8:9781 Change-Id: I1f82a828f103cc2aa3f9553214f6b4867ffc3b17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829897 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64049}
-
Ana Pesko authored
This reverts commit cfb60d43. Reason for revert: Several bots timing out, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24717 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} TBR=yangguo@chromium.org,petermarshall@chromium.org,anapesko@google.com TBR=yangguo@chromium.org Change-Id: Id8dd362617988c8c5efa87ae157ee91c96cb1fdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832163Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64047}
-
Ana Peško authored
For very long subject strings, the regexp interpreter is currently much slower than the native machine code execution. This CL implements eager tier-up to the compiler to avoid the performance penalty for subject strings of length greater than 1000. Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64046}
-
Dan Elphick authored
This is a short-term fix to prevent any merging of feedback slots for dynamic globals, while we work on a longer term solution to make it consistent between eager and lazy compilation. Bug: chromium:1008414, v8:8510 Change-Id: I4a5977046f53454d6f8a6ea2f41046abdf73418f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829270 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64041}
-
Georg Neis authored
This fixes a bug in the optimization concerning detached or re-attached global proxies. Bug: v8:7790 Change-Id: Ifd30b88361914430bb373d4b64a76e33ccde37e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1809361Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64035}
-
- 26 Sep, 2019 2 commits
-
-
Ross McIlroy authored
This is a reland of c70de45c Original change's description: > [TurboProp] Add MidTierMachineLoweringPhase to avoid Late/MemoryOptimizationPhases > > Adds a MidTierMachineLoweringPhase which does select and memory lowering to machine > nodes. This allows TurboProp to avoid the LateOptimizationPhase and > MemoryOptimizationPhase phases while still lowering all simplified nodes to > machine nodes before instruction selection. > > BUG=v8:9684 > > Change-Id: I60533db93152ff044a2fa8c1c31adedeb3747856 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815130 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63981} TBR=neis@chromium.org Bug: v8:9684 Change-Id: I9cf3d087b81bb81a09a725168da9dc19238da91f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826726 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64003}
-
Thibaud Michaud authored
The current implementation only supports arrays and proxies as multi-return values in Wasm to JS calls. This adds support for any iterable including generators, as specified by the multi-value proposal (https://github.com/WebAssembly/multi-value/). R=mstarzinger@chromium.org Bug: v8:9492 Change-Id: I2c9be1f7e03824b1aabba525244e5b7f76a98f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1824938 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63996}
-