- 28 Sep, 2020 1 commit
-
-
Frank Tang authored
Bug: chromium:1132641 Change-Id: Ifa005f9c901ccc865159b618e5145b6d83293b2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436078 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70182}
-
- 11 Sep, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10880 Change-Id: I7a9ba96e4b0c83565c4749101082c661e21d5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400598Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69844}
-
- 27 Aug, 2020 1 commit
-
-
Frank Tang authored
Move fractionalSecondsDigits between second and timeZoneName Change order of reading options. To sync with the July 20 PR change in https://github.com/tc39/ecma402/commit/ba085a91117d4da403b8ece9cb59589091806e59 Latest ECMA402 PR https://github.com/tc39/ecma402/pull/347 Bug: v8:10836 Change-Id: Ia414e0c7cc18502ccabaf02abd19861410b87cae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2378460Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69591}
-
- 24 Jul, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10753 Change-Id: Icbdc6d7ee0634d32b262860dd64c4bfccebdcc00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317064Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69053}
-
- 22 Jul, 2020 2 commits
-
-
Frank Tang authored
Bug: chromium:1107661 Change-Id: I6c55fb74bc009d2af2ae00e34fee9e1ee709a805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311352 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69009}
-
Frank Tang authored
DateTimeFormat's fractionalSecondDigits shipped in M84, so we can drop the --harmony_intl_dateformat_fractional_second_digits flag now. Bug: v8:10485 Change-Id: If7a1a8599722073d7382635219a6fb46cdc47474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311410Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69007}
-
- 17 Jul, 2020 1 commit
-
-
Frank Tang authored
Support more 3 letters timezones and SystemV/XXX timezones Bug: chromium:364374 Change-Id: I710eeee62ba65f7e30203a44a4bd2d95365cc6fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2303896 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68925}
-
- 13 Jul, 2020 1 commit
-
-
Frank Tang authored
Sync the implementation with the latest version of https://github.com/tc39/ecma402/pull/347 Bug: v8:10692 Change-Id: I4e2144da9f770607b4d79e7ce32f079dd2eef54c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290627Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68827}
-
- 09 Jul, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10686 Change-Id: I5a7b47dd4ed10142a795de56c4739ab072e63421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286814 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68773}
-
- 12 Jun, 2020 1 commit
-
-
Frank Tang authored
https://tc39.es/proposal-intl-datetime-style/ (Jun 10, 2020) fix extra s in message Bug: v8:10613 Change-Id: I2ef4f4004c1e8f0a58bf4409578876d1553de59b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242258 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68329}
-
- 04 Jun, 2020 2 commits
-
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ifb818b8aca4c5f148a3fd21acc2d1d4a2b5c43be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227624Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68184}
-
Frank Tang authored
This reverts commit 3b1d24cf. Reason for revert: The problem is fixed Original change's description: > Revert "[Intl] Use new getDefaultHourCycle to replace old hack" > > This reverts commit 611e4127. > > Reason for revert: https://crbug.com/1080367 > > Original change's description: > > [Intl] Use new getDefaultHourCycle to replace old hack > > > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle > > to replace a hack which get the pattern of "jjmm" to find out the > > default hour cycle of a locale > > Bump the required API version from 65 to 67 > > > > Bug: v8:10225 > > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875 > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67549} > > TBR=jkummerow@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: v8:10225 > Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67929} TBR=jkummerow@chromium.org,zhin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10225 Change-Id: I386cf0347a0fa5403fb196bb46ac77f48c9c0a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229470Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68165}
-
- 20 May, 2020 1 commit
-
-
Zhi An Ng authored
This reverts commit 611e4127. Reason for revert: https://crbug.com/1080367 Original change's description: > [Intl] Use new getDefaultHourCycle to replace old hack > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle > to replace a hack which get the pattern of "jjmm" to find out the > default hour cycle of a locale > Bump the required API version from 65 to 67 > > Bug: v8:10225 > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67549} TBR=jkummerow@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10225 Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67929}
-
- 12 May, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:9934 Change-Id: I8e4c0bb647913b703c01fd0d11329fba254e5350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195491Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67760}
-
- 04 May, 2020 1 commit
-
-
Frank Tang authored
Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle to replace a hack which get the pattern of "jjmm" to find out the default hour cycle of a locale Bump the required API version from 65 to 67 Bug: v8:10225 Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67549}
-
- 24 Apr, 2020 1 commit
-
-
Frank Tang authored
Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377}
-
- 23 Apr, 2020 1 commit
-
-
Frank Tang authored
1. read and output into option after timeZoneName 2. Not output into resolvedOptions if dateStyle or timeStyle is presented. 3. Add unit test Spec: https://github.com/tc39/ecma402/pull/347 Bug: v8:10438 Change-Id: Ie7fecdb5b6dc83dc9a6dfd8ced26679a4051c833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161509 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67344}
-
- 15 Apr, 2020 1 commit
-
-
Frank Tang authored
Bug: chromium:364374 Change-Id: I361403b26529860c4240d06766a82937ee8ca115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150070 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67158}
-
- 28 Feb, 2020 1 commit
-
-
Frank Tang authored
We need to track misc features launched in 2019 to understand the impact. Also we need to measure the v8BreakIterator usage of 'word' and 'line' to lobby the need for 'line' in the replacement standard Intl.Segmenter which an Apple engineer opposed to include. Bug: v8:10251 Change-Id: I5d4cbe6ccf458c9ec4adfebad235f9c6dcd2ac37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067512Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66506}
-
- 24 Feb, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10224 Change-Id: Ief05b93d71f6da53b0bcfd68719fa79fc2b59e51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068903Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66410}
-
- 21 Feb, 2020 2 commits
-
-
Frank Tang authored
Move functions into anonymous namespce. Remove dead code. Move GetCaseFirst into JSCollator Move HourCycle, ToHourCycle and GetHourCycle into JSDateTimeFormat Change-Id: Ie6089e7f33677dd40169c56198b52d87ba490b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067689 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66395}
-
Frank Tang authored
Bug: v8:10224 Change-Id: I852d3b1e3468086b36e357aceeb0167951205bcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067695 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66394}
-
- 15 Nov, 2019 1 commit
-
-
Dan Elphick authored
utils.h itself is fairly large and contains lots of unrelated functions as well as having a fair number of dependencies itself, so this splits bounds checking and bit field operations into their own headers in base and replaces uses of utils.h with the more appropriate header where possible. (Also fixes some cases where other headers were previously brought in transitively). Bug: v8:9810, v8:8912 Change-Id: I76c53f953848a57e2c5bfad6ce45abcd6d2a4f1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916604Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64983}
-
- 31 Oct, 2019 1 commit
-
-
Frank Tang authored
Afer the getBestPattern, replace the HhKk by the hour cycle char. Not fix formatRange yet. Bug: v8:9930 Change-Id: I0833539ba308d4b2f58f20ae1a137f782a82fe49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1892126Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64691}
-
- 30 Oct, 2019 1 commit
-
-
Frank Tang authored
Remove unicode keyword/value "ca" and "nu" from the resolvedOptions().locale, if it does not match the option "calendar" / "numberingSystem". Bug: v8:9887 Change-Id: Idabc7e266e8e5f847f919324a93e39df4df440c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877708Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64663}
-
- 29 Oct, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:9912 Change-Id: Ib9deba176f7aaa2ffca2db811c5273af673028ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1884955Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64621}
-
- 21 Oct, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:9849 Change-Id: Ib7812e27dcacb30fd2610badbf79dee190fdec15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869078Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64436}
-
- 11 Oct, 2019 1 commit
-
-
Frank Tang authored
* Change the logic to reflect the spec change of https://github.com/tc39/proposal-intl-datetime-style/pull/37/ * Move enum value of kUndefined to 0 to make unset behavior the same as kUndefined. * Change the expectation of existing tests * Additional tests - https://github.com/tc39/test262/pull/2385 Bug: v8:9826 Change-Id: Ic437b5f6414aa641ae73766d8c5fd5b9d352a230 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846722Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64255}
-
- 01 Oct, 2019 1 commit
-
-
Frank Tang authored
* Throws RangeError only when the calendar and numberingSystem is ill-formed. * Set the calendar and numberingSystem to the locale only if the values are valid. * Fix the order of GetOption of "localeMatcher". * Add more unit tests. See https://github.com/tc39/ecma402/pull/175 for details. Bug: v8:9786, v8:9787, v8:9788 Change-Id: Ic0f918ad7d9afb0b7c8df39caa0f44ef07ca10c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1830345 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64070}
-
- 26 Sep, 2019 1 commit
-
-
Frank Tang authored
ECMA402 decided to abandon https://github.com/tc39/ecma402/pull/345 so we should remove the code here. Bug: v8:9282 Change-Id: I05cbad429ae01bf3debebfed07160b5f53f98a21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825827 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64004}
-
- 25 Sep, 2019 1 commit
-
-
Frank Tang authored
It is controlled by flag harmony_intl_other_calendars. But this is also pretty intern-dependent with harmony_intl_add_calendar_numbering_system and should be launched all together to be meaningful. https://github.com/tc39/ecma402/pull/349/ #349 Normative: Allow calendar to determine choice of pattern https://github.com/tc39/ecma402/pull/351 #351 Normative: Permit relatedYear and yearName in output Bug: v8:9155 Change-Id: I67cd6bba6276bbb995186a9fe6202429d724ba61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588401Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63972}
-
- 12 Sep, 2019 2 commits
-
-
Frank Tang authored
harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736}
-
Frank Tang authored
Bug: v8:9464 Change-Id: I3252de850bbaa5fdb15f5fc2103f1ebb7be3e1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799396 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63734}
-
- 10 Sep, 2019 1 commit
-
-
Bill Budge authored
- Eliminates non-const reference parameters in src/objects. Bug: v8:9429 Change-Id: Ic39a59d54bda26c622db29f07143055c3cc6c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1794683Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63650}
-
- 26 Aug, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:9642 Change-Id: I2dcd1c0e3c208b15b5c0ec0f08880744134f7474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1769479Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63404}
-
- 08 Jul, 2019 1 commit
-
-
Clemens Hammacher authored
Cpplint usually checks for non-const reference arguments. They are forbidden in the style guide, and v8 does not explicitly make an exception here. This CL re-enables that warning, and fixes all current violations by adding an explicit "NOLINT(runtime/references)" comment. In follow-up CLs, we should aim to remove as many of them as possible. TBR=mlippautz@chromium.org Bug: v8:9429 Change-Id: If7054d0b366138b731972ed5d4e304b5ac8423bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687891Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62551}
-
- 17 Jun, 2019 1 commit
-
-
Seth Brenith authored
This change removes the special case in the Torque compiler for types that descend from JSObject: they will no longer get implicit "| Undefined" appended to their types for verification purposes. It removes any additional custom verification steps in objects-debug that are made redundant by that change. In order to do so safely, I categorized all cases where we were implicitly adding "| Undefined" to the field type, as follows: 1. Classes that aren't using the generated verifier function (we should probably revisit these, but for now we at least know they're safe): - JSGlobalObject - JSFinalizationGroup - JSFinalizationGroupCleanupIterator 2. Classes where the existing verifier is already at least as strict as what we would get after removing the implicit "| Undefined": - JSDate - JSPromise - JSRegExp - JSRegExpStringIterator - WasmMemoryObject - JSWeakRef - JSStringIterator - WasmExceptionObject - JSListFormat (fixed in part 1) - JSPluralRules (fixed in part 1) - JSRelativeTimeFormat (fixed in part 1) - JSSegmenter (fixed in part 1) - JSArrayBufferView (fixed in part 1) - JSTypedArray (fixed in part 1) 3. Classes where, to the best of my knowledge based on code inspection, we already initialize the object correctly to pass the new stricter generated verifier: - JSFunction - JSArrayIterator - JSMessageObject - JSBoundFunction - JSAsyncFromSyncIterator - WasmModuleObject - JSAsyncFunctionObject 4. Classes that needed some adjustment to their initialization order to avoid exposing uninitialized state to the GC: - JSArray (only in Factory::NewJSArray; Runtime_NewArray and CodeStubAssembler::AllocateJSArray already behave fine) - WasmTableObject - JSDateTimeFormat - JSNumberFormat - JSCollator - JSV8BreakIterator - JSLocale - JSSegmentIterator - JSModuleNamespace 5. Classes that had incorrect type definitions in Torque: - WasmGlobalObject (category 4 after correction) 6. Classes that weren't fully initialized due to bugs: - JSGeneratorObject - JSAsyncGeneratorObject Bug: v8:9311 Change-Id: I99ab303d3352423f50a3d0abb6eb0c9b463e7552 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1654980 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62228}
-
- 06 Jun, 2019 1 commit
-
-
Frank Tang authored
quarter option- see https://github.com/tc39/ecma402/pull/345 dayPeriod option- see https://github.com/tc39/ecma402/pull/346 fractionalSecondDigits option- see https://github.com/tc39/ecma402/pull/347 2019-6-5 TC39 presentation- http://shorturl.at/mtB12 test262: https://github.com/tc39/test262/pull/2194 I2I: http://shorturl.at/beCNV (for quarter) I2I: http://shorturl.at/bekrZ (for dayPeriod) I2I: http://shorturl.at/flwF5 (for fractionalSecondDigits) Bug: v8:9282,v8:9283,v8:9284 Change-Id: I99f4c0f861507c7451497b735a276780bb8aead6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621445 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62041}
-
- 23 May, 2019 1 commit
-
-
Clemens Hammacher authored
This CL was generated by an automatic clang AST rewriter using this matcher expression: callExpr( callee( cxxMethodDecl( hasName("operator->"), ofClass(isSameOrDerivedFrom("v8::internal::Object")) ) ), argumentCountIs(1) ) The "->" at the expression location was then rewritten to ".". R=jkummerow@chromium.org TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org Bug: v8:9183, v8:3770 No-Try: true No-Tree-Checks: true Change-Id: I0a7ecabdeafe51d0cf427f5280af0c7cab96869e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624209Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61764}
-
- 22 May, 2019 1 commit
-
-
Yang Guo authored
Bug: v8:9247 Change-Id: I79e0553e8a0d6dac2aa16b94a6c0e05b6ccde4a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621934 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61725}
-