- 11 Jan, 2021 1 commit
-
-
Michael Achenbach authored
Bug: chromium:1164276 Change-Id: I5c257d407ed8c14037555cfcfd1550923bb79af2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621079 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#72011}
-
- 11 May, 2020 1 commit
-
-
Sami Kyostila authored
We are currently porting Chromium over to use the Perfetto client library for tracing[1]. When this mode is enabled, V8 should also use the Perfetto library built by Chromium instead of building an indepedendent copy. This patch enables that behavior, gated by the |use_perfetto_client_library| flag set by Chromium. We also roll Perfetto to the latest version, add a couple of missing dependencies on v8_tracing and add a missing tracing category group. [1] https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/ (Internal) Bug: 155075662 Change-Id: I76d9626b1c83cb7a278dc3281b3a1db653ab8733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182637Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#67706}
-
- 17 Apr, 2020 1 commit
-
-
Sami Kyostila authored
This patch replaces V8's tracing implementation (i.e., the TRACE_EVENT macros) with the track event base implementation from Perfetto. The advantages of doing this are: 1) This allows us to remove most tracing-related backend code from V8. 2) V8 can start writing strongly typed trace event arguments, which are more compact, easier to process and more extensible than legacy JSON-based trace arguments. For the time being, we still support the old trace macros when V8 is embedded into Chrome and other embedders. Design doc: https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/edit#heading=h.398p6b4eaen2 Bug: chromium:1006766 Change-Id: Ie71474fbe065821772b13d851487ebbca680c4ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947688 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67217}
-
- 12 Aug, 2019 1 commit
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: chromium:992584 Change-Id: I301013731a502689f2edd5c90e5e7bf2136198c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745337Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63159}
-
- 29 Jul, 2019 1 commit
-
-
Michael Achenbach authored
This enables the recipe to set FORCE_MAC_TOOLCHAIN and decide if hermetic or system xcode is used. TBR=tmrts@chromium.org Bug: chromium:986701 Change-Id: I2c1ba75d5d62e493bd9dc7a5ec5f7e40465d8f98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1722557Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62947}
-
- 15 May, 2019 1 commit
-
-
Yang Guo authored
R=tmrts@chromium.org Bug: v8:9247 Change-Id: I9b34ee96e03d3cbca165452fc8427679cf6e7582 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612900 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#61518}
-
- 28 Mar, 2019 1 commit
-
-
Peter Marshall authored
This adds dependencies on Perfetto and Protobuf and the required configs to build them. The build configs are behind a gn flag (v8_use_perfetto) and are disabled by default. Actual implementation of Perfetto will follow. Based on Primiano's prototype: https://chromium-review.googlesource.com/c/v8/v8/+/1290549 Bug: v8:8339 TBR: yangguo@chromium.org Change-Id: I2b7462d567bfb0a5a3ffbbb8b6fcbf41c824e285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517876Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60502}
-
- 11 Jan, 2018 1 commit
-
-
Shenghua Zhang authored
Because of the android sdk managed by CIPD (see go/use-adjective-apis), its deps repo ndk needs to be relocated to third_party/android_ndk. This CL changes the ndk root path in files in v8. Bug: chromium:659808 Change-Id: I78d534cbb81eebd1dc631293d54764f027ed0567 Reviewed-on: https://chromium-review.googlesource.com/861182Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50493}
-
- 14 Jul, 2017 1 commit
-
-
erikchen authored
v8 now uses the same SDK as Chromium, even when built as a standalone project. The deployment target override has no effect. Bug: chromium:740693 Change-Id: I089f74d5ad1590ff7167564f83b0110620a92ef9 Reviewed-on: https://chromium-review.googlesource.com/565887Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#46686}
-
- 26 Jan, 2017 1 commit
-
-
brettw authored
Chrome now uses the default_args system for specifying its own definitions of these variables so the separate file in build_overrides is no longer necessary. BUG=684096 Review-Url: https://codereview.chromium.org/2652263003 Cr-Commit-Position: refs/heads/master@{#42712}
-
- 25 Jan, 2017 1 commit
-
-
brettw authored
We're converting the build_overrides system to the new default_args list of overrides that can be listed in the toplevel .gn file. This will allow args to be set on a per-repo basis. This change conditionally adds the variables currently defined in build_overrides/v8.gni to build args. This allows V8's build to be used in both the new and old systems. Once all Chrome and pdfium have been updated, v8's build overrides and the conditional checks around the new args can be removed. BUG=684096 Review-Url: https://codereview.chromium.org/2654663003 Cr-Commit-Position: refs/heads/master@{#42639}
-
- 29 Nov, 2016 1 commit
-
-
machenbach authored
This also ports some build overrides including: https://codereview.chromium.org/2512043002/ BUG=chromium:659726 Review-Url: https://codereview.chromium.org/2532043002 Cr-Commit-Position: refs/heads/master@{#41347}
-
- 28 Nov, 2016 1 commit
-
-
machenbach authored
BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2373783002 Cr-Commit-Position: refs/heads/master@{#41304}
-
- 21 Nov, 2016 1 commit
-
-
thestig authored
Instead of directly using v8_enable_inspector_override from build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector variable based on v8_enable_inspector_override and use that everywhere. This is the more common pattern seen in over projects, and reduces the need to include //build_overrides/v8.gni in many files. Review-Url: https://codereview.chromium.org/2520683002 Cr-Commit-Position: refs/heads/master@{#41156}
-
- 25 Oct, 2016 1 commit
-
-
kozyatinskiy authored
To achieve this: - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else. - fixed asan for d8 - unique_ptr on array has single element type. - force Debugger.disable at the end of test. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2450653002 Cr-Commit-Position: refs/heads/master@{#40546}
-
- 19 Oct, 2016 1 commit
-
-
machenbach authored
Revert of [inspector] Turn on inspector by default (patchset #1 id:1 of https://codereview.chromium.org/2395763002/ ) Reason for revert: Has test failures on windows and blocks landing a test driver fix. Original issue's description: > [inspector] Turn on inspector by default > > BUG=chromium:635948 > > Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312 > Cr-Commit-Position: refs/heads/master@{#40380} TBR=kozyatinskiy@chromium.org,dgozman@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:635948 Review-Url: https://chromiumcodereview.appspot.com/2430223003 Cr-Commit-Position: refs/heads/master@{#40422}
-
- 18 Oct, 2016 1 commit
-
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2395763002 Cr-Commit-Position: refs/heads/master@{#40380}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 31 Aug, 2016 1 commit
-
-
machenbach authored
Ports https://codereview.chromium.org/2293853002 to unblock deps roller. BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2290233005 Cr-Commit-Position: refs/heads/master@{#39034}
-
- 30 Aug, 2016 1 commit
-
-
machenbach authored
Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2290213002 Cr-Commit-Position: refs/heads/master@{#39009}
-
- 26 Jul, 2016 1 commit
-
-
machenbach authored
BUG=chromium:629806 Review-Url: https://codereview.chromium.org/2187433002 Cr-Commit-Position: refs/heads/master@{#38054}
-
- 25 Jul, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2182443002 Cr-Commit-Position: refs/heads/master@{#38011}
-
- 18 Jul, 2016 1 commit
-
-
machenbach authored
Broke in https://codereview.chromium.org/2116913002/ due to rebase. BUG=chromium:474921 NOTRY=true TBR=jochen@chromium.org, dpranke@chromium.org Review-Url: https://codereview.chromium.org/2156993002 Cr-Commit-Position: refs/heads/master@{#37841}
-
- 15 Jul, 2016 2 commits
-
-
dpranke authored
This change makes the architecture that we target generated v8 code for a property of the current toolchain, rather than a global setting that applies to every toolchain. This will allow us to properly build two snapshots for two different architectures in a single build, which is needed for android webview/monochrome builds. R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org BUG=625383 Review-Url: https://codereview.chromium.org/2116913002 Cr-Commit-Position: refs/heads/master@{#37805}
-
machenbach authored
This sets default values for v8_enable_gdbjit and v8_imminent_deprecation_warnings, while allowing to override them as gn args. Without this patch the project-specific overrides have no effect. BUG=chromium:474921, chromium:626064 Review-Url: https://codereview.chromium.org/2153753002 Cr-Commit-Position: refs/heads/master@{#37797}
-
- 12 Jul, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921,chromium:626064 Review-Url: https://codereview.chromium.org/2134223003 Cr-Commit-Position: refs/heads/master@{#37679}
-
- 17 Jun, 2016 2 commits
-
-
machenbach authored
BUG=chromium:619503 TBR=jochen@chromium.org, vogelheim@chromium.org, dpranke@chromium.org, thakis@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2072203002 Cr-Commit-Position: refs/heads/master@{#37052}
-
dpranke authored
R=jochen@chromium.org, machenbach@chromium.org, thakis@chromium.org BUG=chromium:619503 Review-Url: https://codereview.chromium.org/2074003002 Cr-Commit-Position: refs/heads/master@{#37048}
-
- 15 Jun, 2016 1 commit
-
-
machenbach authored
Fix after: https://codereview.chromium.org/2042253002/ https://codereview.chromium.org/2049743002/ Using the data file is the default now and it shouldn't be overridden in v8's build_overrides. Also the isolate logic now needs to include the gni file specifying the flag. BUG=chromium:616033 TBR=jochen@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2062363002 Cr-Commit-Position: refs/heads/master@{#36998}
-
- 07 Jun, 2016 2 commits
-
-
machenbach authored
This declares v8_enable_slow_dchecks and v8_optimized_debug as gn args. It adds support for dcheck_always_on and debugging with v8_optimized_debug = false. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2024833002 Cr-Commit-Position: refs/heads/master@{#36789}
-
machenbach authored
BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2046683003 Cr-Commit-Position: refs/heads/master@{#36777}
-
- 01 Jun, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e Cr-Commit-Position: refs/heads/master@{#36510} Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c Cr-Commit-Position: refs/heads/master@{#36582} Committed: https://crrev.com/378a26c03efc74bda401daa5accda223cb266177 Cr-Commit-Position: refs/heads/master@{#36606} Review-Url: https://codereview.chromium.org/2011853002 Cr-Commit-Position: refs/heads/master@{#36642}
-
- 31 May, 2016 3 commits
-
-
machenbach authored
Revert of [gn] Add unittests (patchset #7 id:120001 of https://codereview.chromium.org/2011853002/ ) Reason for revert: Still http://crbug.com/615890 Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} > > Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c > Cr-Commit-Position: refs/heads/master@{#36582} > > Committed: https://crrev.com/378a26c03efc74bda401daa5accda223cb266177 > Cr-Commit-Position: refs/heads/master@{#36606} TBR=vogelheim@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2026713002 Cr-Commit-Position: refs/heads/master@{#36616}
-
machenbach authored
BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e Cr-Commit-Position: refs/heads/master@{#36510} Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c Cr-Commit-Position: refs/heads/master@{#36582} Review-Url: https://codereview.chromium.org/2011853002 Cr-Commit-Position: refs/heads/master@{#36606}
-
machenbach authored
Revert of [gn] Add unittests (patchset #6 id:100001 of https://codereview.chromium.org/2011853002/ ) Reason for revert: http://crbug.com/615890 Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} > > Committed: https://crrev.com/143b3d167d7014525d049d3ab53c73cf2592243c > Cr-Commit-Position: refs/heads/master@{#36582} TBR=vogelheim@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2022893002 Cr-Commit-Position: refs/heads/master@{#36605}
-
- 30 May, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e Cr-Commit-Position: refs/heads/master@{#36510} Review-Url: https://codereview.chromium.org/2011853002 Cr-Commit-Position: refs/heads/master@{#36582}
-
- 25 May, 2016 2 commits
-
-
https://codereview.chromium.org/2011853002/hablich authored
Reason for revert: Speculative revert because of roll block: https://codereview.chromium.org/2004203004/ Original issue's description: > [gn] Add unittests > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/67e549ec5b34ad02506abb2720c6a0851ae31f5e > Cr-Commit-Position: refs/heads/master@{#36510} TBR=vogelheim@chromium.org,bmeurer@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2004373005 Cr-Commit-Position: refs/heads/master@{#36521}
-
machenbach authored
BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2011853002 Cr-Commit-Position: refs/heads/master@{#36510}
-
- 24 May, 2016 1 commit
-
-
machenbach authored
There are bots on the chromium.lkgr waterfall that need to be able to set v8_target_arch to "arm" while the rest of the target build is "x86". This CL makes that argument a declare_arg(), so that we can do that. BUG=chromium:605732,chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2007843002 Cr-Commit-Position: refs/heads/master@{#36464}
-
- 19 May, 2016 1 commit
-
-
altimin authored
use_icu_data_file from //third_party/icu should be used. //third_party/icu also defines ICU_UTIL_DATA_IMPL. BUG=chromium:610673,chromium:474921 Review-Url: https://codereview.chromium.org/1996033002 Cr-Commit-Position: refs/heads/master@{#36371}
-