- 18 Sep, 2018 2 commits
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: If912b9d43f577ca3e9f3b8b27acf957c49e269dc Reviewed-on: https://chromium-review.googlesource.com/1224113Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55979}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I46b96899f0a5973f2fbf8af94eb43d14955a3f45 Reviewed-on: https://chromium-review.googlesource.com/1227072Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55978}
-
- 04 Jul, 2018 1 commit
-
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: I631fa1e44d2b9998a5567c96c6977955ac86d5a1 Reviewed-on: https://chromium-review.googlesource.com/1125931Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54215}
-
- 22 Jun, 2018 1 commit
-
-
Georg Neis authored
Use V8_INLINE and V8_NOINLINE instead. R=sigurds@chromium.org TBR=yangguo@chromium.org TBR=hpayer@chromium.org Change-Id: I1ccfcdc2178ded15ec730ab0577c4fc96a76a4f9 Reviewed-on: https://chromium-review.googlesource.com/1111840 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53966}
-
- 01 Jun, 2018 1 commit
-
-
Dan Elphick authored
Remove all uses of GetIsolate/GetHeap by passing Isolate in from all call sites. Bug: v8:7786 Change-Id: I64ff8d5796db9d602e86bff4d0b9297cbe700d0d Reviewed-on: https://chromium-review.googlesource.com/1080819Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53467}
-
- 09 Apr, 2018 1 commit
-
-
Clemens Hammacher authored
MUST_USE_RESULT was deprecated for some time. This removes it and replaces all uses by the equivalent V8_WARN_UNUSED_RESULT. R=mstarzinger@chromium.org Bug: v8:7570 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I86883218638e64eeeb7a5891904319ed0844a004 Reviewed-on: https://chromium-review.googlesource.com/999533 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#52486}
-
- 21 Mar, 2018 3 commits
-
-
jgruber authored
This is a reland of 25207bf8 Original change's description: > Remove isolate.h include from external-reference.h > > This triggers a bunch of other necessary include tweaks for files that > used to work until now because they indirectly included isolate.h > through external-reference.h. > > Bug: v8:6666 > Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 > Reviewed-on: https://chromium-review.googlesource.com/972042 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52103} TBR=petermarshall@chromium.org Bug: v8:6666 Change-Id: Ibbcf2c116dc3b202d325fd7644e8755ffe583ef1 Reviewed-on: https://chromium-review.googlesource.com/973062Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52108}
-
Clemens Hammacher authored
This reverts commit 25207bf8. Reason for revert: Mips compile failure: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/16061 Original change's description: > Remove isolate.h include from external-reference.h > > This triggers a bunch of other necessary include tweaks for files that > used to work until now because they indirectly included isolate.h > through external-reference.h. > > Bug: v8:6666 > Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 > Reviewed-on: https://chromium-review.googlesource.com/972042 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52103} TBR=jgruber@chromium.org,petermarshall@chromium.org Change-Id: I2e867d3c82b020b4fd5201aaa5cf6ed65b081ca2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/973061Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52104}
-
jgruber authored
This triggers a bunch of other necessary include tweaks for files that used to work until now because they indirectly included isolate.h through external-reference.h. Bug: v8:6666 Change-Id: I8d48db44dcc321fa32a6279f3ddacb41ab58f975 Reviewed-on: https://chromium-review.googlesource.com/972042 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52103}
-
- 09 Nov, 2017 1 commit
-
-
Erik authored
R=yangguo@chromium.org This is a reland of for the no-i18n configuration. https: //chromium-review.googlesource.com/c/v8/v8/+/571746 with a fix Bug: Change-Id: I3e654791267b20fb3703ad4220404d8078f43440 Reviewed-on: https://chromium-review.googlesource.com/758999Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Corry <erikcorry@chromium.org> Cr-Commit-Position: refs/heads/master@{#49251}
-
- 06 Nov, 2017 2 commits
-
-
Georg Neis authored
This reverts commit e83ee945. Reason for revert: Check failure in regress-v8-6940.js Original change's description: > RegExp: Add the ability to switch flags on and off within the regexp. > > This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/752522 > which was itself a reupload of > https://chromium-review.googlesource.com/c/v8/v8/+/571746 where reviews took > place. > > R=yangguo@chromium.org > > Bug: > Change-Id: Ia4dbdd6e9a362e272753ff10dc66b7f72d81ee20 > Reviewed-on: https://chromium-review.googlesource.com/753596 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Erik Corry <erikcorry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49129} TBR=yangguo@chromium.org,erikcorry@chromium.org Change-Id: I5ee94c47606101d06010c9e6b4b78ca51566b60a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/754682Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49130}
-
Erik authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/752522 which was itself a reupload of https://chromium-review.googlesource.com/c/v8/v8/+/571746 where reviews took place. R=yangguo@chromium.org Bug: Change-Id: Ia4dbdd6e9a362e272753ff10dc66b7f72d81ee20 Reviewed-on: https://chromium-review.googlesource.com/753596Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Corry <erikcorry@chromium.org> Cr-Commit-Position: refs/heads/master@{#49129}
-
- 03 Nov, 2017 2 commits
-
-
Benedikt Meurer authored
This reverts commit 68212c80. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/17200 Original change's description: > RegExp: Add the ability to switch flags on and off within the regexp > > R=yangguo@chromium.org > > This is a reupload of https://chromium-review.googlesource.com/c/v8/v8/+/571746 > with a different user, since the other one was not allowed to commit to V8 any > more. > > Bug: > Change-Id: I6171afd44e514f6c934390faab6f9bee3953ac77 > Reviewed-on: https://chromium-review.googlesource.com/752522 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49098} TBR=erik.corry@gmail.com,yangguo@chromium.org,erikcorry@chromium.org,jgruber@chromium.org Change-Id: I651c5618f09f43104af50cb1319ab7b49011573e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/752802Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49099}
-
Erik authored
R=yangguo@chromium.org This is a reupload of https://chromium-review.googlesource.com/c/v8/v8/+/571746 with a different user, since the other one was not allowed to commit to V8 any more. Bug: Change-Id: I6171afd44e514f6c934390faab6f9bee3953ac77 Reviewed-on: https://chromium-review.googlesource.com/752522 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49098}
-
- 17 Oct, 2017 1 commit
-
-
Marja Hölttä authored
BUG=v8:5402,v8:6921 Change-Id: Iab2509554718a6beca73217f80cafedf650bd066 Reviewed-on: https://chromium-review.googlesource.com/718741Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48629}
-
- 13 Oct, 2017 1 commit
-
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 19 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=jgruber@chromium.org Bug: v8:6837 Change-Id: I9c489ac0e1b15fd4789c37fd32c9d3c76121a288 Reviewed-on: https://chromium-review.googlesource.com/671343 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48079}
-
- 10 Feb, 2017 1 commit
-
-
mlippautz authored
BUG= Review-Url: https://codereview.chromium.org/2684233004 Cr-Commit-Position: refs/heads/master@{#43094}
-
- 14 Oct, 2016 1 commit
-
-
jgruber authored
Now that all accesses to the last match info are in C++ and TF code, we can finally turn the last match info into a FixedArray. Similar to the ArrayList, it uses its first field to store its length and grows dynamically in amortized O(1) time. Unlike previously, this means that the last match info pointer stored on the context can actually change (in case the FixedArray needs to grow). BUG=v8:5339 Review-Url: https://codereview.chromium.org/2415103002 Cr-Commit-Position: refs/heads/master@{#40308}
-
- 05 Oct, 2016 1 commit
-
-
mlippautz authored
BUG=chromium:652721 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2395563002 Cr-Commit-Position: refs/heads/master@{#39986}
-
- 26 Sep, 2016 1 commit
-
-
jgruber authored
V8 is collecting a growing amount of fuzzers, all of which take substantial space on the bots and in chromium build archives. This CL improves that situation by allowing component (shared library) builds for almost all fuzzers. The parser fuzzer is handled as an exception since it would require exporting a large number of additional functions. A component build results in about a 50-100x improvement in file size for each fuzzer (~50M-100M to around 1.1M). BUG=chromium:648864 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2360983002 Cr-Commit-Position: refs/heads/master@{#39709}
-
- 12 Aug, 2016 1 commit
-
-
jkummerow authored
The hand-written KeyedLoadIC_Megamorphic stub didn't care about JSArray lengths, which made it lenient towards said lengths being wrong, but it will soon fix that bug and thereby become more strict. LiveEdit: factory->NewJSArray(capacity) doesn't set a length, so set it manually. RegExp: to avoid having to take care of array length updating in the RegExpExecStub, just use a JSObject instead. Review-Url: https://codereview.chromium.org/2244673002 Cr-Commit-Position: refs/heads/master@{#38624}
-
- 15 Jun, 2016 1 commit
-
-
jgruber authored
Named capture groups may be specified using the /(?<name>pattern)/u syntax, with named backreferences specified as /\k<name>/u. They're hidden behind the --harmony-regexp-named-captures flag, and are only enabled for unicode regexps. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2050343002 Cr-Commit-Position: refs/heads/master@{#36986}
-
- 07 Mar, 2016 1 commit
-
-
yangguo authored
Character ranges starting at 1 are not correctly negated. R=jkummerow@chromium.org BUG=chromium:592343 LOG=Y Review URL: https://codereview.chromium.org/1768093002 Cr-Commit-Position: refs/heads/master@{#34528}
-
- 02 Feb, 2016 2 commits
-
-
yangguo authored
Revert of [regexp] implement /ui to mirror the implementation for /i. (patchset #2 id:20001 of https://codereview.chromium.org/1641613002/ ) Reason for revert: This test fails: assertEquals(["as"], /^a[\u017F]/ui.exec("as")); The reason is that we end up with a character class that is not stand alone, so we do not perform case folding on it correctly (with unicode flag). Original issue's description: > [regexp] implement /ui to mirror the implementation for /i. > > R=erik.corry@gmail.com, erikcorry@chromium.org > > Committed: https://crrev.com/eea1a4c003c559c99bcc9f08aa7eadf931975aad > Cr-Commit-Position: refs/heads/master@{#33655} TBR=erik.corry@gmail.com,erikcorry@chromium.org,erikcorry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1661483002 Cr-Commit-Position: refs/heads/master@{#33676}
-
yangguo authored
R=erik.corry@gmail.com, erikcorry@chromium.org Review URL: https://codereview.chromium.org/1641613002 Cr-Commit-Position: refs/heads/master@{#33655}
-
- 27 Jan, 2016 3 commits
-
-
yangguo authored
R=erik.corry@gmail.com BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1630633002 Cr-Commit-Position: refs/heads/master@{#33550}
-
yangguo authored
R=littledan@chromium.org BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1601653006 Cr-Commit-Position: refs/heads/master@{#33540}
-
yangguo authored
BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1599303002 Cr-Commit-Position: refs/heads/master@{#33538}
-
- 21 Jan, 2016 3 commits
-
-
yangguo authored
We divide character ranges into - BMP, matched normally. - non-BMP, matched as alternatives of surrogate pair ranges. - lone surrogates, matched with lookaround assertion that its indeed lone. R=erik.corry@gmail.com BUG=v8:2952 LOG=N Committed: https://crrev.com/ea820ad5fa282a323a86fe20e64f83ee67ba5f04 Cr-Commit-Position: refs/heads/master@{#33432} Review URL: https://codereview.chromium.org/1578253005 Cr-Commit-Position: refs/heads/master@{#33437}
-
yangguo authored
Revert of [regexp] implement character classes for unicode regexps. (patchset #11 id:220001 of https://codereview.chromium.org/1578253005/ ) Reason for revert: Compile failure on arm. https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7341/steps/compile/logs/stdio Original issue's description: > [regexp] implement character classes for unicode regexps. > > We divide character ranges into > - BMP, matched normally. > - non-BMP, matched as alternatives of surrogate pair ranges. > - lone surrogates, matched with lookaround assertion that its indeed lone. > > R=erik.corry@gmail.com > BUG=v8:2952 > LOG=N > > Committed: https://crrev.com/ea820ad5fa282a323a86fe20e64f83ee67ba5f04 > Cr-Commit-Position: refs/heads/master@{#33432} TBR=littledan@chromium.org,erik.corry@gmail.com,erikcorry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2952 Review URL: https://codereview.chromium.org/1618753002 Cr-Commit-Position: refs/heads/master@{#33434}
-
yangguo authored
We divide character ranges into - BMP, matched normally. - non-BMP, matched as alternatives of surrogate pair ranges. - lone surrogates, matched with lookaround assertion that its indeed lone. R=erik.corry@gmail.com BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1578253005 Cr-Commit-Position: refs/heads/master@{#33432}
-
- 08 Jan, 2016 1 commit
-
-
yangguo authored
R=rossberg@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/1565183002 Cr-Commit-Position: refs/heads/master@{#33169}
-
- 16 Dec, 2015 1 commit
-
-
yangguo authored
R=erik.corry@gmail.com BUG=chromium:570241 LOG=N Review URL: https://codereview.chromium.org/1528333002 Cr-Commit-Position: refs/heads/master@{#32898}
-
- 19 Nov, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1448933002 Cr-Commit-Position: refs/heads/master@{#32120}
-
- 17 Nov, 2015 3 commits
-
-
yangguo authored
R=erikcorry@chromium.org, littledan@chromium.org BUG=v8:4545 LOG=N Committed: https://crrev.com/37632606bbce1418238b13fd90cb6ef6705871cd Cr-Commit-Position: refs/heads/master@{#32029} Review URL: https://codereview.chromium.org/1418963009 Cr-Commit-Position: refs/heads/master@{#32043}
-
yangguo authored
Revert of Experimental support for RegExp lookbehind. (patchset #18 id:340001 of https://codereview.chromium.org/1418963009/ ) Reason for revert: gc stress breaks due to string_start_minus_one not being set correctly. Original issue's description: > Experimental support for RegExp lookbehind. > > R=erikcorry@chromium.org, littledan@chromium.org > BUG=v8:4545 > LOG=N > > Committed: https://crrev.com/37632606bbce1418238b13fd90cb6ef6705871cd > Cr-Commit-Position: refs/heads/master@{#32029} TBR=littledan@chromium.org,erikcorry@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4545 Review URL: https://codereview.chromium.org/1451373003 Cr-Commit-Position: refs/heads/master@{#32032}
-
yangguo authored
R=erikcorry@chromium.org, littledan@chromium.org BUG=v8:4545 LOG=N Review URL: https://codereview.chromium.org/1418963009 Cr-Commit-Position: refs/heads/master@{#32029}
-
- 27 Oct, 2015 1 commit
-
-
yangguo authored
With ES6 21.2.5.8, step 13, we no longer have to keep up the illusion that matching and calling replace function is interleaved. This is observable through unspec'ed static properties such as RegExp.$1. Last match info not working yet. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1418703003 Cr-Commit-Position: refs/heads/master@{#31593}
-
- 21 Aug, 2015 1 commit
-
-
mstarzinger authored
R=yangguo@chromium.org,hpayer@chromium.org Review URL: https://codereview.chromium.org/1306053003 Cr-Commit-Position: refs/heads/master@{#30300}
-