Skip to content

V
V8
Switch branch/tag
  1. 21 Jan, 2015 1 commit
  3. 08 Jan, 2015 1 commit
  5. 18 Dec, 2014 1 commit
  7. 15 Dec, 2014 1 commit
  9. 27 Nov, 2014 1 commit
  11. 26 Nov, 2014 1 commit
    • dslomov's avatar
      harmony-scoping: make assignment to 'const' a late error. · 6ac4de87
      dslomov authored 
      Per TC39 Nov 2014 decision.

This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications.
That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst.

BUG=v8:3713,v8:2243
LOG=N

Review URL: https://codereview.chromium.org/749633002

Cr-Commit-Position: refs/heads/master@{#25516}
      6ac4de87
  13. 21 Nov, 2014 1 commit
  15. 17 Oct, 2014 1 commit
  17. 20 Aug, 2014 1 commit
  19. 07 Aug, 2014 2 commits
  21. 06 Aug, 2014 2 commits
  23. 04 Aug, 2014 1 commit
  25. 22 Jul, 2014 1 commit
  27. 16 Jul, 2014 1 commit
  29. 22 May, 2014 1 commit
  31. 02 May, 2014 1 commit
  33. 29 Apr, 2014 1 commit
  35. 02 Apr, 2014 2 commits
  37. 18 Mar, 2014 1 commit
  39. 17 Mar, 2014 2 commits
  41. 13 Mar, 2014 1 commit
  43. 11 Mar, 2014 1 commit
  45. 10 Mar, 2014 1 commit
  47. 08 Mar, 2014 1 commit
  49. 05 Feb, 2014 1 commit
    • marja@chromium.org's avatar
      Make strict more error messages about "eval" and "arguments" less specific. · 81504642
      marja@chromium.org authored 
      We used to have error messages which provide context, like "Variable name may
not be eval or arguments in strict mode", but for other illegal words we only
have non-context specific error messages like "Unexpected reserved word".

Providing the context makes the code unnecessarily complex, since every
individual place must remember to check for eval or arguments. This CL produces
a unified error message ("Unexpected eval or arguments in strict mode"), and puts
the error reporting to (Pre)Parser::ParseIdentifier.

Notes:

- The module feature is so experimental, that I decided to not allow "eval" or
"arguments" as module-related identifiers in the strict mode (even though this
check wasn't there before).

- Unfortunately, there were some inconsistencies, since it was the
responsibility of the caller of ParseIdentifier to check "eval" and "arguments"
and some places didn't have the check for no good reason. This CL is supposed to
keep backward compatibility and *not* introduce any new errors.

- ECMA allows "eval" and "arguments" as labels even in strict mode. (Syntax:
"LabelledStatement: Identifier : Statement", and no strict mode restrictions on
Identifier are listed.)

- Tests which compare error message strings will fail, and need to be updated.

BUG=3126
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/152813005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      81504642
  51. 04 Feb, 2014 1 commit
  53. 31 Jan, 2014 2 commits
  55. 22 Jan, 2014 1 commit
  57. 08 Jan, 2014 1 commit
  59. 22 Nov, 2013 1 commit
  61. 06 Nov, 2013 1 commit
  63. 30 Jul, 2013 2 commits
  65. 26 Jul, 2013 1 commit
  67. 25 Jul, 2013 1 commit
    • machenbach@chromium.org's avatar
      Migrate more tests from blink repository. · 3c9efdee
      machenbach@chromium.org authored 
      The stand-alone test driver is changed a bit:
- Don't use the errorMessage list. It is used differently in the embedded driver. There it collects parser errors - instead of failure messages.
- Remove html links in description texts. Some test descriptions print a web reference.

The migrated tests fall into 3 categories:
1. Tests outside fast/js
2. Tests that print FAIL messages (and also expect those) - these tests should be examined later if they make sense at all
3. Tests with html links in the test description

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/20280003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3c9efdee