1. 23 Jun, 2017 1 commit
  2. 23 Dec, 2016 2 commits
  3. 22 Dec, 2016 3 commits
    • mlippautz's avatar
      Reland "[heap] Ensure progress when incrementally marking wrappers" · 61a55548
      mlippautz authored
      1) Alternate between processing v8 and wrappers
      2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers
      3) After that, finalize once v8 marking deque is empty again
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2591383004
      Cr-Commit-Position: refs/heads/master@{#41932}
      61a55548
    • mlippautz's avatar
      Revert of [heap] Ensure progress when incrementally marking wrappers (patchset... · 73036fb6
      mlippautz authored
      Revert of [heap] Ensure progress when incrementally marking wrappers (patchset #3 id:60001 of https://codereview.chromium.org/2592403002/ )
      
      Reason for revert:
      This won't work because the finalization still checks whether both marking deques are empty, also calling into blink. So we never proceed there.
      
      Original issue's description:
      > [heap] Ensure progress when incrementally marking wrappers
      >
      > The problem here is estimating the marking step size for wrapper tracing. If the
      > steps are too small, we cannot keep up with the mutator creating new wrappers.
      > The result is an endless stream of incremental marking steps, alternating v8 and
      > wrappers tracing, without ever finalizing in a GC.
      >
      > The mitigation here is to abort finding the fix point after 10 incremental
      > iterations.
      >
      > A proper solution would track newly created wrappers on the blink side during
      > wrapper tracing. Will give this more thought after the holidays.
      >
      > BUG=chromium:668164, chromium:468240
      >
      > Review-Url: https://codereview.chromium.org/2592403002
      > Cr-Commit-Position: refs/heads/master@{#41923}
      > Committed: https://chromium.googlesource.com/v8/v8/+/a47417b89373c615f9256800cfc803d84ba58378
      
      TBR=ulan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:668164, chromium:468240
      
      Review-Url: https://codereview.chromium.org/2602433002
      Cr-Commit-Position: refs/heads/master@{#41924}
      73036fb6
    • mlippautz's avatar
      [heap] Ensure progress when incrementally marking wrappers · a47417b8
      mlippautz authored
      The problem here is estimating the marking step size for wrapper tracing. If the
      steps are too small, we cannot keep up with the mutator creating new wrappers.
      The result is an endless stream of incremental marking steps, alternating v8 and
      wrappers tracing, without ever finalizing in a GC.
      
      The mitigation here is to abort finding the fix point after 10 incremental
      iterations.
      
      A proper solution would track newly created wrappers on the blink side during
      wrapper tracing. Will give this more thought after the holidays.
      
      BUG=chromium:668164, chromium:468240
      
      Review-Url: https://codereview.chromium.org/2592403002
      Cr-Commit-Position: refs/heads/master@{#41923}
      a47417b8
  4. 20 Dec, 2016 1 commit