- 04 Oct, 2021 18 commits
-
-
Milad Fa authored
This reverts commit d7c9b31a. Reason for revert: investigating intermittent failures on `test/mjsunit/wasm/parallel_compilation.js` Original change's description: > ppc: [liftoff] implement DropStackSlotsAndRet > > Change-Id: I05bcba3ad27b46b7c7888940895605ad463fc960 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155302 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/main@{#76774} Change-Id: I19452e75aad78b446ac6e2cd8b80cec4d792671f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3202471Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77221}
-
Clemens Backes authored
This reverts commit 4fb3eae7. Reason for revert: Fails to link on chromium, blocking the roll: https://cr-buildbucket.appspot.com/build/8834293599516974577 Original change's description: > Turn on v8_enable_virtual_memory_cage for Chromium builds > > This CL enables the virtual memory cage at compile time by default for > Chromium builds on x64 and arm64. However, the cage will only be used at > runtime if the correpsonding Chromium feature is enabled as well. > > Bug: chromium:1218005 > Change-Id: I5a452d299ac950f8ec0f741f6b9a153e57b2a666 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200081 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77212} Bug: chromium:1218005 Change-Id: Id17946641b7b4e0d377d4e211aab929bb39ec341 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3201998 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77220}
-
Clemens Backes authored
This reenables a test which is passing, independent of missing accounting for shared memory. This is because we repeatedly trigger a GC explicitly in all workers. R=dinfuehr@chromium.org Bug: v8:12278 Change-Id: I73d1513d809787284af0be4956018806719acd50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3201995Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77219}
-
Mike Stanton authored
The field in JSFunction uses acquire-release semantics, therefore the read is store-ordered. Bug: v8:7790, v8:12282 Change-Id: Ic6e9d02e7aca1ca68c74502c3afed6eb6e964975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3201992Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/main@{#77218}
-
Maria Tîmbur authored
Add the array.get and struct.get functions to GenerateOptRef. Bug: v8:11954 Change-Id: I39b03f909abfd19d89d7d6a76cdef5f0d5219b8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197689Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77217}
-
Michael Lippautz authored
This CL allows aborting of compaction on a page based on an Address instead of a HeapObject. Bug: v8:12251 Change-Id: Ib928ace9aa24a0ff1ab5f44026d5b287f7cdcdb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199881 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77216}
-
Manos Koukoutos authored
This is needed in case of 'let', where OpcodeLength transitively calls {read_value_type()}. Bug: v8:9495 Change-Id: I8aebffabc7ba1c47418d363dc9257f132fac33df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200074Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77215}
-
Michael Lippautz authored
No functional changes. Bug: v8:12251 Change-Id: I155524875032e553b48e358ec7ecd562d177b27f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199880Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77214}
-
Mike Stanton authored
1. In ElementAccessFeedback::HasOnlyStringMaps - we can assume the map is safe to read because it was read earlier from the feedback vector and passed the gc predicate then. 2. In JSHeapBroker::GetPropertyAccessInfo - we can assume that the feedback vector in a FeedbackSource is store-ordered/safe to read. Bug: v8:7790, v8:12282 Change-Id: Ie09acdfaac3d5e767ffe74e4bad941d4eeb47f9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200082 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77213}
-
Samuel Groß authored
This CL enables the virtual memory cage at compile time by default for Chromium builds on x64 and arm64. However, the cage will only be used at runtime if the correpsonding Chromium feature is enabled as well. Bug: chromium:1218005 Change-Id: I5a452d299ac950f8ec0f741f6b9a153e57b2a666 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200081Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77212}
-
Manos Koukoutos authored
Trying to optimize in such case breaks down the optimization, as we end up with potentially non-eliminatable nodes that depend on the dead IfTrue/IfFalse node. Drive-by: Clean up dead nodes with {Kill()}. Bug: v8:11510, chromium:1255354 Change-Id: Ia89fe6c243974c3c2abac6ad80bd4677a935f637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200073Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77211}
-
Victor Gomes authored
This reverts commit b65e72c6. Reason for revert: CFs issues Original change's description: > [TurboFan] Change representation of NumberConstant in 32-bit arch > > Smi constants in 32 bit machines are guaranteed to be 31 bits. > > Bug: chromium:1254189 > Change-Id: I4ea296a7212c5e6ea14119fbd71cfb5789762b55 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195874 > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77185} Bug: chromium:1254189, chromium:1255213, chromium:1255330 Change-Id: Idd9a6e76a44612d1ab9aada0d8ee093b9aab34a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200079 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77210}
-
Mike Stanton authored
Since we are reading an Object field, it could be that the gc predicate fails. Therefore, this CL changes to TryMakeRef, and makes the return value of length_unsafe() optional. Bug: v8:7790, v8:12282 Change-Id: I86a8bcc6649d5e8121e52f8947b8331fcf242887 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200078Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/main@{#77209}
-
Omer Katz authored
The checks for assignemnts to member during prefinalizers assumed the slot has to live. It was assumed that if a slot is dead then we would not be updating it. Prefinalizers are allowed to touch dead objects and thus are techincally allowed to write to dead slots. Such writes are usually redundant (the object will be swept soon anyway) but are not always easy to get rid of. Bug: chromium:1255152, v8:11749 Change-Id: I57e143abd53d434c3198616909c506eb70d8944b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199800Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77208}
-
Jakob Gruber authored
Bug: v8:7790,v8:12282 Change-Id: Id6a129c21648bb7919b1d162b47bb24c5d6b432a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200077 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/main@{#77207}
-
Jakob Gruber authored
MapRef::GetConstructor and GetBackPointer are immutable after initialization. Bug: v8:7790, v8:12282 Change-Id: I1059aabdd85a08af5f6d570a2eee206bda4f7ac3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200076 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/main@{#77206}
-
Manos Koukoutos authored
Since the WasmStackGuard build-in is not kNoThrow, it needs to be inserted in the control chain between the IfFalse and Merge nodes of the stack check. Change-Id: I5ad1c4f01e079c0c9079ea129f8e3363ade80217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199798Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77205}
-
Patrick Thier authored
When scanning for capture groups, we have to consider the case that the current state is inside a character class. In that case skip everything until the end of the current character class. Otherwise we would wrongly count open brackets inside the character class as start of a capture group. Bug: chromium:1254704 Change-Id: I91d2177c464f7e507413d96216fe570253f17676 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199871 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#77204}
-
- 02 Oct, 2021 2 commits
-
-
Milad Fa authored
Port 098f31f4 Original Commit Message: This CL adds support for handling calls to C functions with arbitrary signatures on native arm64. It introduces a new ExternalReference type FAST_C_CALL. The CL also splits the 10 bits used by kArchCallCFunction instruction to store the total number of parameters into two 5-bit values, representing the number of general purpose and floating point parameters. Design doc: https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit This CL is partially based on the previous attempt: https://chromium-review.googlesource.com/c/v8/v8/+/2343072 R=mslekova@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I3da5a9ef01f8de050a377e120ffcfbef6f2d31b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3198748Reviewed-by: Junliang Yan <junyan@redhat.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77203}
-
Yolanda Chen authored
Bug: v8:12228 Change-Id: Ie1f569c450f84a862c754b844e36349b1533872d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194633Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Yolanda Chen <yolanda.chen@intel.com> Cr-Commit-Position: refs/heads/main@{#77202}
-
- 01 Oct, 2021 20 commits
-
-
Ng Zhi An authored
Bug: chromium:1254675 Change-Id: I8c24d3956752a367a4fa60827ee47a589c48e699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197700Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77201}
-
Yuki Shiino authored
There is a demand of access to %Array.prototype% in Blink in order to implement Web IDL observable array type. Bug: chromium:1201744 Change-Id: I31ca5cd746f3a2eab8bd291741408a1dea17c122 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194025 Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77200}
-
Milad Fa authored
This reverts commit 3600aabf. Reason for revert: Causes test failures on AIX and PPC Linux. Original change's description: > ppc: [liftoff] implement AtomicExch and AtomicCmpExch > > Change-Id: Ida66b9c42cfb9bd5b59a83188a2dfa0d602d4036 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192427 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/main@{#77148} Change-Id: If6ee4b050945b706c36a344abb844c7b73b2aba1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3198736Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77199}
-
Maya Lekova authored
This CL adds support for handling calls to C functions with arbitrary signatures on native arm64. It introduces a new ExternalReference type FAST_C_CALL. The CL also splits the 10 bits used by kArchCallCFunction instruction to store the total number of parameters into two 5-bit values, representing the number of general purpose and floating point parameters. Design doc: https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit This CL is partially based on the previous attempt: https://chromium-review.googlesource.com/c/v8/v8/+/2343072 Bug: chromium:1052746 Change-Id: Ib508626d57da26ec3c9186ee8fc46356e3c87f3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182232Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77198}
-
Omer Katz authored
If processing the marking worklists found new ephemeron pairs, but processing the existing ephemeron pairs didn't mark new objects, marking would stop and the newly discovered ephemeron pairs would not be processed. This can lead to a marked key with an unmarked value. Bug: chromium:1252878 Change-Id: I0f158f6f64490f1f06961520b4ba57fa204bd867 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199872 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77197}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: Ib508e996bd714077ca49aa9496b7630c23d02836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199879 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77196}
-
Seth Brenith authored
This is mostly just whitespace tweaks, plus removing a redundant public access specifier. Bug: v8:7793 Change-Id: Ic8b3efe4f707108d29dc2dfd55c46d9a47c48058 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199603Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77195}
-
Michael Achenbach authored
This is a reland of da35064b Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ecb990f..ebad853 > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/50e90b8..9959b06 > > Rolling v8/third_party/aemu-linux-x64: e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC..FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6e5dc9a..7a11b79 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5afc365..c0b9d25 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/764c927..0e2fb33 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/ab36804..3b49be0 > > Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/eb740e9..5df06a4 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/278dd91..c06edd1 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: Ifafd7fe3250976867f35c4d709b0220a23930c3f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199830 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77190} Bug: v8:12277 Cq-Include-Trybots: luci.v8.try.triggered:v8_linux64_msan_rel_ng_triggered Change-Id: Ie5bd6b01d0acbe836b8881717b09280e782c8827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199876Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77194}
-
Victor Gomes authored
Bug: chromium:1245634 Change-Id: I48eb590fa8c75fe2eded6b85dab6680efb751fd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199873 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77193}
-
Maya Lekova authored
This reverts commit da35064b. Reason for revert: Still failing on MSAN, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/40662/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ecb990f..ebad853 > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/50e90b8..9959b06 > > Rolling v8/third_party/aemu-linux-x64: e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC..FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6e5dc9a..7a11b79 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5afc365..c0b9d25 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/764c927..0e2fb33 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/ab36804..3b49be0 > > Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/eb740e9..5df06a4 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/278dd91..c06edd1 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: Ifafd7fe3250976867f35c4d709b0220a23930c3f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199830 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77190} Change-Id: Icf6b30f4c09d9604e25bfacbf7e844147a105c09 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199875 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Maya Lekova <mslekova@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77192}
-
Al Muthanna Athamina authored
Bug: v8:11826 Change-Id: I7f93b4bfeccc47c1a4e6c2b3a72d2595b4af8bfb Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197716 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77191}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ecb990f..ebad853 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/50e90b8..9959b06 Rolling v8/third_party/aemu-linux-x64: e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC..FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6e5dc9a..7a11b79 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5afc365..c0b9d25 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/764c927..0e2fb33 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/ab36804..3b49be0 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/eb740e9..5df06a4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/278dd91..c06edd1 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifafd7fe3250976867f35c4d709b0220a23930c3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199830Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77190}
-
Camillo Bruni authored
It's not always easy to spot what exact configuration of V8 is run within embedders. With --print-flag-values we can easily compare different configurations. Drive-by-fix: - Use new FlagValue and FlagName helpers for printing - Remove unused FlagList::argv helper Change-Id: Ic8a25479d7b1e72f714b22ae7d2e56e06e810556 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197713Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77189}
-
Toon Verwaest authored
By changing AllocationFlag from enum to enum class Bug: v8:12244, v8:12245 Change-Id: Ifdd04bb12026619f6422a98ee0890bd557f0e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181536 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77188}
-
Maria Tîmbur authored
When we generate identical signatures in the fuzzer, we generate one function for each of the copies. However, when these functions are added to WasmModulBuilder, all will be assigned the same signature index. Therefore, when ref.func tries to find a function corresponding to a signature index, it will fail, despite a matching signature existing in the module. This CL fixes this issue by looking up functions by signature over signature index. Bug: v8:11954, chromium:1254387 Change-Id: Iac8d5444d4914d993da63d0630ca4d95e671630c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197711Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Maria Tîmbur <mtimbur@google.com> Cr-Commit-Position: refs/heads/main@{#77187}
-
Benedikt Meurer authored
The logic to locate the correct function to set a breakpoint in based on script position was treating SharedFunctionInfo::EndPosition() as inclusive rather than exclusive. There are various assumptions all over the Debugger that seem to demand this treatment for the toplevel script. But it's definitely wrong for function literals. Fixed: chromium:1253277 Change-Id: I3421703673f4d78aee28e923e03e2fca24bc06ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197715 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77186}
-
Victor Gomes authored
Smi constants in 32 bit machines are guaranteed to be 31 bits. Bug: chromium:1254189 Change-Id: I4ea296a7212c5e6ea14119fbd71cfb5789762b55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195874 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77185}
-
Maya Lekova authored
This CL adds a getStorageIfAligned method to obtaining a typed pointer to the underlying TypedArray data, if the pointer to it is properly aligned. Bug: chromium:1052746 Change-Id: Ie8cb3438135b0da060e2b42ec71bba0e72ae4f5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195875Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77184}
-
Benedikt Meurer authored
Previously we'd treat %_AsyncFunctionReject (and %AsyncFunctionReject) as side-effect free (in async functions), but that's not correct, since promise rejections have side-effects (at the very least triggering the unhandled promise rejection machinery in the browser). This required a minor refactoring as previously we'd classify functions as side-effecting or not depending on whether they contain any calls to side-effecting intrinsics, no matter whether this call is actually executed or not. That would break REPL mode however if we'd generally treat all async functions with %_AsyncFunctionReject intrinsic calls as side-effecting, so instead of performing the intrinsic checks ahead of time, we now perform the test at execution time. Before: https://imgur.com/5BvJP9d.png After: https://imgur.com/10FanNr.png Fixed: chromium:1249275 Change-Id: Ib06f945ba21f1e06ee9b13a1363fad342464fd9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197712 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#77183}
-
Benedikt Meurer authored
Fixed: chromium:1073804 Change-Id: Idb8b4b5558bb243eb1cbe70b2de1c22d8dd07f9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3198152 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#77182}
-