- 24 Jan, 2022 1 commit
-
-
Andrey Kosyakov authored
Change-Id: I4da78ec0f309c72007ee30336d77a77205f3e3fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406597 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78729}
-
- 11 Nov, 2021 1 commit
-
-
Ng Zhi An authored
This fixes a -Wshadow warning for NO_FLAG. The other option is to make it an enum class, which makes test-conversions.cc a bit verbose. Bug: v8:12244,v8:12245 Change-Id: I3ea429eb45e31b25d4c6658ceb86c33ba280ae51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3274015Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77860}
-
- 18 Jun, 2021 1 commit
-
-
Dan Elphick authored
The adding of base:: was mostly prepared using git grep and sed: git grep -l <pattern> | grep -v base/vector.h | \ xargs sed -i 's/\b<pattern>\b/base::<pattern>/ with lots of manual clean-ups due to the resulting v8::internal::base::Vectors. #includes were fixed using: git grep -l "src/utils/vector.h" | \ axargs sed -i 's!src/utils/vector.h!src/base/vector.h!' Bug: v8:11879 Change-Id: I3e6d622987fee4478089c40539724c19735bd625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968412Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#75243}
-
- 15 May, 2021 1 commit
-
-
Andrey Kosyakov authored
Change-Id: I81ff7fca841015ebc8cee66546ab40efb3065731 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2892842Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#74575}
-
- 09 Dec, 2020 1 commit
-
-
Andrey Kosyakov authored
This includes a fix to issue 1156334. BUG: chromium:1156334 Change-Id: I27a97436d7a1ed567077495846dc6260ca3f2340 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2580408Reviewed-by:
-
- 02 Jul, 2020 2 commits
-
-
Milad Farazmand authored
Fix GCC build because of missing header: template argument deduction/substitution failed: ../../third_party/inspector_protocol/crdtp/protocol_core.cc:123:8: note: candidate expects 3 arguments, 4 provided }); Change-Id: If977c6afc3f20c2faf40e02672b04e9679c1fda7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280243Reviewed-by: -
Andrey Kosyakov authored
Note that changes in test expectation come from a more verbose error diagnostics for expected errors around input parameter validation. Original change: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2270757 Bug: chromium:1099809 Change-Id: I4fc2efc9c89d0af645dad937d719fa36e1d33489 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277142Reviewed-by:
-
- 20 Mar, 2020 1 commit
-
-
Johannes Henkel authored
Upstream PR: "Introduce a crdtp/dispatch.{h,cc} library." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680 "For the shallow parse of a DevTools message, allow "params": null." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2109466 New Revision: c69cdc36200992d21a17bf4e5c2f3a95b8860ddf Change-Id: Icc447ff9ce408b24f5245c643dd2f1843da9255f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076215 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
- 29 Feb, 2020 1 commit
-
-
Johannes Henkel authored
"Tweaks for emitting JSON" https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2071518 Change-Id: Ie05ff1390a5340e15c21788c58e8171cb442da10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2073205Reviewed-by:
-
- 09 Feb, 2020 1 commit
-
-
Johannes Henkel authored
Upstream PR: "Drop && from Serializable::TakeSerialized() &&." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2029933 New Rev: 75c465e8d425f2e0b5297245c7eb058411af493a Change-Id: I11dafc589c8f0c5a7e158b9cc5ad5202ba8237e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029335Reviewed-by:
-
- 07 Feb, 2020 1 commit
-
-
Johannes Henkel authored
Upstream PR: "Implement crdtp::ErrorSupport, replacing the jinja2 template." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2036608 In addition; this PR includes removal of now unused routines in string-util.h (StringBuilder and number conversions). New Rev: e4ffb7288a17b2bbe2f7b7cd62abcb1d1e55681a Change-Id: Iae14c001c1f468466a42cb1b842c0ded766fccc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2037959Reviewed-by:
-
- 24 Jan, 2020 1 commit
-
-
Johannes Henkel authored
Fixes edge cases for parsing / serializing codepoint 0xffff in JSON with UTF16. New Rev: 0213a8545f6362cd1cd5091cedf29747736552e8 Change-Id: I48b174cf1bd9263ace002996094f7143a1248766 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020502 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
- 23 Jan, 2020 1 commit
-
-
Johannes Henkel authored
Upstream Reviews: "Remove writeJSON / toJSONString from generated protocol types." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2013082 Also, remove builderAppendQuotedString from string-util.h in v8 since it's unused now and it relies on the jinja template code I'm deleting. "Upon encountering a byte that's unexpectedly not ..." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2013764 New Rev: a84e91f6696a0b76e1a73286c9c2765154de9889 Change-Id: I26805c47950d880b5be2cfb9bdcb41a3f51218b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2013561Reviewed-by:
-
- 17 Jan, 2020 1 commit
-
-
Johannes Henkel authored
This adds a DCHECK into v8-inspector-session-impl.cc, covering what we previously checked within ConvertCBORToJSON. Upstream reviews: "Separate the lightweight check for CBOR messages from ParseCBOR." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2001536 "Remove Exported::writeBinary." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2005797 New Rev: ac6919eb836521a96cc18931f0bf270d8c1b53a1 Change-Id: I52076a8f77b27c24c3afb35c40afbbe94e0ca05c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002935Reviewed-by:
-
- 08 Jan, 2020 1 commit
-
-
Johannes Henkel authored
Upstream PR: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1989575 Remove support for emitting cbor into an std::string. New Revision: b29d8a5d2bb56b3e555bb27a0e035a9d571c5f28 Change-Id: I6bf63822c4c6551db30f5902d1f27f6933b209a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989973 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
- 19 Dec, 2019 1 commit
-
-
Johannes Henkel authored
New revision: 3b0551d3904f7fc067e78905ce697002187fa7a5 Upstream reviews: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1972474 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1967550 Change-Id: Ie9cec5faf410cc80ddb178da30cda66d801196f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972404Reviewed-by:
-
- 13 Dec, 2019 1 commit
-
-
Johannes Henkel authored
New revision: 726836d7317a4031f48af9960bab51d7a2ab2867 The gist is that serialization is direct from protocol objects to CBOR, no more detour via protocol::Value. Upstream PRs: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1956388 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1966418 Also: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1941035 Change-Id: I89f742a4fd47b5eb8ebd98ce6e10ecba0501cf66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958956Reviewed-by:
-
- 12 Dec, 2019 1 commit
-
-
Johannes Henkel authored
Add Exported::AppendSerialized (consistency with Serialized interface). Deprecate Exported::writeBinary. Upstream PRs: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1958506 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1941035 Change-Id: I50d6db05ea7c1336022b0b63e5ec2c69488ab525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958575Reviewed-by:
-
- 05 Dec, 2019 1 commit
-
-
Johannes Henkel authored
New revision: f5a3199a3f37c7e48a9ffdbee04aa5c8f38d2889 Use crdtp::span<uint8_t> instead of const ProtocolMessage&. (V8) Also includes a PR which moves Serializable into the crdtp library and adds a simple test. Hadn't rolled this yet. Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1952196 Change-Id: If78bc8f11be8fb248dd66babc0190870312f7ec4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1952158 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
- 27 Nov, 2019 1 commit
-
-
Johannes Henkel authored
New revision: 7a44a37f66b58358dd8ab85ccde1998fafa95e53 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1899564 Previously, we used a wrapper library, v8-inspector-protocol-encoding.h to inject the string<->number conversion into the cbor parser. This meant that the unittests, in third_party/inspector_protocol/crdtp/json_test.cc inadvertently did not run with the same string<->number conversion code. Thus, we missed that the production implementation would return INF for out of range double literals, as opposed to rejecting the incoming JSON. When switching the library to the build dependency on json_platform_v8.cc as it's in this change, the test immediately failed which made it trivial to fix the implementation. Old implementation: https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/src/inspector/v8-inspector-protocol-encoding.cc New implementation (checks std::isfinite): https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/third_party/inspector_protocol/crdtp/json_platform_v8.cc Change-Id: Ia48fe1f4e359eea47d0ede9ceadea1fd635292e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1913424Reviewed-by:
-
- 21 Nov, 2019 1 commit
-
-
Johannes Henkel authored
New revision: 4c2a3acaea9f2e7958081dd361f81e20e9eff5e7 This cleanup cl does not change any behavior, it just cleans up some headers and does a class rename (StreamingParserHandler->ParserHandler). It was reviewed upstream https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1924792 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1925679 and does not touch V8 code. Would like to get this in to make it easier to review subsequent changes. Thanks! Change-Id: Ie9fe1434bafeb4f5090244f823d1e482ff805dd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925721 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
- 12 Nov, 2019 1 commit
-
-
Johannes Henkel authored
This decomposes the crdtp library into multiple files. Since it wasn't previously rolled it's a bit more than just that. Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1907115 New Revision: d020a9e614d4a5116a7c71f288c0340e282e1a6e Change-Id: I5c588469654bec3e933804ac706fa967c6fe57bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1907973 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
