- 21 Dec, 2017 4 commits
-
-
Sergiy Byelozyorov authored
Also disable all but one mac experiment. Having too many experiments causes large pending queues to be generated and the builds fail to apply the patch since they run after the CL has landed. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I1cd21798a17c857d4275d0f15a2b98e13fe9c367 Reviewed-on: https://chromium-review.googlesource.com/839141 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50256}
-
Deepti Gandluri authored
When shared memory is defined in the module bytes, and not imported/exported underlying memory should be a SharedArrayBuffer. This was missing in the allocate flow during instantiation. Fixed to use a SharedArrayBuffer. BUG=v8:6532 Change-Id: Ic62ed3fd578a0e03124ee40b273e6a4ea474bba4 Reviewed-on: https://chromium-review.googlesource.com/835348Reviewed-by:
Eric Holk <eholk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#50255}
-
Brad Nelson authored
R=eholk@chromium.org,mlippautz@chromium.org B=https://bugs.chromium.org/p/chromium/issues/detail?id=775047 Change-Id: Ia3b2f51d6cb4dabbf0f1f9ec78ecb8935775f53a Reviewed-on: https://chromium-review.googlesource.com/809165 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Mircea Trofin authored
Bug: v8:7232 Change-Id: I1eed337749686ec749b970b4af56413c5614b980 Reviewed-on: https://chromium-review.googlesource.com/837646 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#50253}
-
- 20 Dec, 2017 32 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@google.com Bug: chromium:747960 Change-Id: I9846b955d34d2bbdf28f0d0903ef3fef5d9ba524 Reviewed-on: https://chromium-review.googlesource.com/837980 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: Id191feb257f1e1154cce2f76427b4ddb4d0883fb Reviewed-on: https://chromium-review.googlesource.com/837760Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I69363b9e636fee99c6a602b3dfe73d0dd2ee903b Reviewed-on: https://chromium-review.googlesource.com/836711 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This is safe to enable multiple mac/win builders because we've migrated all non-experimental builders to LUCI, hence pending queues won't affect CQ. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I561c97ac52db0de042fb196f4430b65de562c0de Reviewed-on: https://chromium-review.googlesource.com/836710 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Eugene Ostroukhov authored
Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8ca7bf33fb848caedce101876316832a1e9cf58f Reviewed-on: https://chromium-review.googlesource.com/836735Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#50248}
-
Ali Ijaz Sheikh authored
* NewSpace::UpdateInlineAllocationInfo and PagedSpace::ComputeLimit were closely related methods. Refactor these into a shared method in the super class. * refactor UpdateInlineAllocationInfo into SpaceWithLinearArea * refactor StartNextInlineAllocationStep * refactor PauseAllocationObservers Bug: Change-Id: I898906d6228ff48e427367ef74e6dc77fb7a1837 Reviewed-on: https://chromium-review.googlesource.com/825591 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50247}
-
Clemens Hammacher authored
And add a helper method to convert an uint32 value to uintptr (e.g. a noop on 32 bit and Uint32ToUint64 conversion on 64 bit). R=ahaas@chromium.org Change-Id: Ibc6731bc7ddaf8ceaa27e9e8fbec916d184d9ad4 Reviewed-on: https://chromium-review.googlesource.com/836618 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50246}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:747960 Change-Id: I6718ef1a53439d4d443156c3ec7c269b72a39c36 Reviewed-on: https://chromium-review.googlesource.com/836870 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Mircea Trofin authored
Bug: chromium:796584 Change-Id: Ib6a62d616d36344f35cad0b0a177f8f07c7fd2ac Reviewed-on: https://chromium-review.googlesource.com/836849Reviewed-by:
-
Sergiy Byelozyorov authored
This is now ready to proceed since we've got additional 6 Windows and 24 Linux bots in our luci.v8.try pool. TBR=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: Ib718599e5657fcb709acd563f7eaa9bbd2790fbb Reviewed-on: https://chromium-review.googlesource.com/836898 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I36ab28500742ae1b906f806e0afb477059eb0380 Reviewed-on: https://chromium-review.googlesource.com/836548 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I8783192268cc0860b553af418d56f1117817d747 Reviewed-on: https://chromium-review.googlesource.com/836609 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Georg Neis authored
In a benchmark that I'm looking at, the numbers quickly overflow our current limit. This patch increases kMaxLength to the greatest value that's possible without requiring further code changes. Bug: v8:6791 Change-Id: I7a0d126dcd566d536375a294fa4dcf10b8823ed7 Reviewed-on: https://chromium-review.googlesource.com/833876 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#50240}
-
Ali Ijaz Sheikh authored
Doing an allocation step before the limit is picked is more correct, but it causes the idle scavenger and incremental marking to run more frequently, which causes a regression on certain thread_time benchmarks. This CL fixes the regression by reverting the behaviour. A proper fix can be implemented in a follow-on. Bug: chromium:795323 Change-Id: Ic62eab1ddfd1da4c5904e11eba7d5d71cee38f12 Reviewed-on: https://chromium-review.googlesource.com/835287 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
-
Georgia Kouveli authored
This is a reland of bcf11729 The test was timing out in no snapshot builds, as each CodeAssemblerTester creates a new Context. Reduced the random iterations significantly. Original change's description: > [arm64] Preparation for padding of arguments > > As part of JSSP removal, we need to align the arguments passed to functions > on the stack, by adding a padding slot when the total number of arguments > is odd. > > This patch introduces the kPadArguments flag (which is currently set to > false for all architectures), which will control padding of arguments in > architecture-independent parts of the code (deoptimizer, instruction > selector). > > It also adds some executable tests for tail calls with various stack > parameter counts on the caller and callee sides. > > This will be turned on for arm64 together with arm64-specific changes to > the code generator, the MacroAsembler and the builtins, in a later patch. > > Bug: v8:6644 > Change-Id: I79a5c149123fe8130cedd1ccffec3d9b50361e08 > Reviewed-on: https://chromium-review.googlesource.com/806554 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50134} TBR=jarin@chromium.org Bug: v8:6644 Change-Id: I795877ed9791e126ffac6841dbbb65189e95d207 Reviewed-on: https://chromium-review.googlesource.com/833046 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50238}
-
Andreas Haas authored
This is the implementation of crrev.com/c/766371 for arm. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=v8-arm-ports@googlegroups.com Change-Id: I7d61424a184d5778baf1d1270013f4e0c7ec68b4 Reviewed-on: https://chromium-review.googlesource.com/836608Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50237}
-
Camillo Bruni authored
- Make sure scripts have line end data - Make sure initial class maps are logged - Log map creation independently from details - Properly escape commas in the v8 logger Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I583c784cf75e884673e46bfb263da3bc20e6ac41 Reviewed-on: https://chromium-review.googlesource.com/822333Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50236}
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I8920ed24699ab5e6e4ed82f38bd7c8d8548fddfe Reviewed-on: https://chromium-review.googlesource.com/834131 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Camillo Bruni authored
From the log data generated with --log-function-events we can create a detailed model of a function's lifetime. The parse processor displays several stats at a given time (percent and count) on a per function or byte basis: - preparsing - parsing - eager/lazy compiling - execution Bug: chromium:757467 Change-Id: I0ad5c9369c6a0628704e3caffb3920444ea603a9 Reviewed-on: https://chromium-review.googlesource.com/758641 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#50234}
-
Hannes Payer authored
Bug: Change-Id: I53b68e8a4200a87d9f14b9540b52cab316678b2d Reviewed-on: https://chromium-review.googlesource.com/836593 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50233}
-
Camillo Bruni authored
- GrowArrayElementsStub is no longer needed - Use JSObject::kMinAddedElementsCapacity constant in CSA Change-Id: Iafa34fa32394d2fda013b230b66af984f2715278 Reviewed-on: https://chromium-review.googlesource.com/834128Reviewed-by:
-
Jaroslav Sevcik authored
Bug: Change-Id: Idf3829f59cebe5c68b011ab6a0fa766ca2bad359 Reviewed-on: https://chromium-review.googlesource.com/832448 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50231}
-
Yang Guo authored
We have tools/release/mergeinfo.py R=verwaest@chromium.org Change-Id: I9afb104f5c67be5f29ef33824c1ae5a4584ea1ad Reviewed-on: https://chromium-review.googlesource.com/836610Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50230}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:747960 Change-Id: I45990490545827e7c36b2fccd89f37c34ab228a1 Reviewed-on: https://chromium-review.googlesource.com/822393 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Michal Majewski authored
First CL moving parsing output to a separate class. Following CLs will move (and deduplicate) code from testcases by sharing common features like comparing stdout to the expected output. Bug: v8:6917 Change-Id: I1174a985949a0b946cefbf7e7c91e8815cbb4f15 Reviewed-on: https://chromium-review.googlesource.com/834130 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Hannes Payer authored
Bug: Change-Id: I7b085f89f22de7ea55156d2942f3437bbf9c5af8 Reviewed-on: https://chromium-review.googlesource.com/836588Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50227}
-
Clemens Hammacher authored
We were passing a pointer to an object allocated as {InterpretedFrameImpl} in an {std::unique_ptr<InterpretedFrame>}. The default deleter then called {delete ptr;} on a ptr of type {InterpretedFrame*}, even though that object was allocated as {InterpretedFrameImpl}. This error might caught by validators. Fix this by passing a custom deleter on the unique_ptr. R=ahaas@chromium.org, ulan@chromium.org Bug: v8:7231 Change-Id: Ia18114236384813c4878319209ae4535fda56c41 Reviewed-on: https://chromium-review.googlesource.com/834510Reviewed-by:Jakob Gruber <jgruber@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50226}
-
Andreas Haas authored
R=clemensh@chromium.org Change-Id: Id2978d2c37a5fb4191db285f4660e22472b70f9d Reviewed-on: https://chromium-review.googlesource.com/836427Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50225}
-
jgruber authored
This reduces reduces code size by 16 KB while keeping the fast path (in which the given argument is already a smi) inlined and extracting remaining logic to a stub call. Change-Id: I531999c990519eef1247cc3785ad4b16164f7a5e Reviewed-on: https://chromium-review.googlesource.com/833912Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50224}
-
Yang Guo authored
We used to frequently break the ABI when we introduced new instance types because some instance types are hard-coded in v8.h. Now that we have more instance types available, we can leave some room to anticipate future new instance types. Also take this opportunity to reorder some instance types. Also see: https://github.com/nodejs/node/issues/17754 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9b59eeab9dfcdf11d779f0b700fc5dce30d3eebe Reviewed-on: https://chromium-review.googlesource.com/833874Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
SharedFunctionInfo::GetSourceCodeHarmony uses whitespaces between arguments. This CL adds whitespaces for JSFunction::ToString for wrapped functions as well. Bug: v8:7172 Change-Id: I8fde1842735aa35a427dfe5150a209f9cb640bf3 Reviewed-on: https://chromium-review.googlesource.com/832476Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50222}
-
Caitlin Potter authored
Previously, FrameFunctionIterator::next() assumed that the frame summary was non-empty. It's now possible for the list not to be empty, if the JS microtask pump invokes a builtin function which uses FrameFunctionIterator directly. While this is unlikely to show up in real world code, it is necessary to handle it to prevent crashes. BUG=chromium:794744 R=mstarzinger@chromium.org, cbruni@chromium.org, verwaest@chromium.org Change-Id: Ie95c2228544f57730d1c6c1ff955b2c94ff1c06b Reviewed-on: https://chromium-review.googlesource.com/833266Reviewed-by:
-
- 19 Dec, 2017 4 commits
-
-
Alexey Kozyatinskiy authored
If object contains undefined property then JSON.stringify will skip it, if array contains undefined as property then JSON.stringify will censor it to null. [1] [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify R=alph@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafa9d2828d264d89b26675b0e194ad0bfc4621fc Reviewed-on: https://chromium-review.googlesource.com/834669Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50220}
-
peterwmwong authored
Bug: Change-Id: If86c51b428f254ffce68d295f9e8001cee27b9ce Reviewed-on: https://chromium-review.googlesource.com/833236Reviewed-by:
-
peterwmwong authored
This is a reland of ab38b03d Original change's description: > [builtins] Port Object.p.toLocaleString to CSA from JS > > - Added ObjectPrototypeToLocaleString TFJ > - Remove v8natives.js > - Move GetMethod and GetIterator into prologue.js > > TBR=adamk@chromium.org > > Bug: v8:6005 > Change-Id: I2b5b65892304e62bf64375458f8ffb9473b2c9b7 > Reviewed-on: https://chromium-review.googlesource.com/826479 > Reviewed-by: Peter Wong <peter.wm.wong@gmail.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> > Cr-Commit-Position: refs/heads/master@{#50120} Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng TBR=adamk@chromium.org Bug: v8:6005 Change-Id: Ie8c8810c5231e933e61ea8babe963e58bb6dcaed Reviewed-on: https://chromium-review.googlesource.com/831156Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Max Moroz authored
R=ahaas@chromium.org, clemensh@chromium.org, mathias@chromium.org Bug: chromium:754124, chromium:787723 Change-Id: I7eafee50a47ca0ad56a5458f1f232e3ed07c1cca Reviewed-on: https://chromium-review.googlesource.com/834457Reviewed-by:
-
