- 26 Jun, 2015 15 commits
-
-
machenbach authored
This reverts commit e93e4dad. BUG=chromium:502176 LOG=n NOTRY=true TBR=ulan@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1213803002 Cr-Commit-Position: refs/heads/master@{#29323}
-
oth authored
v8 builds with --no-snap were hitting handle limits compiling natives for handle count unit tests that run with --check_handle_count. Patch now has higher handle limits (~4k more than required for failing natives compilation). Original issue: https://codereview.chromium.org/1185633002/ Original issue's description: > Additional HandleScopes to limit Handle consumption. > > erikcorry@chromium.org suggested digging into v8 handle usage. Found potential scopes in ast.cc and runtime-literals.cc and added tests. > > The runtime-literals.cc change reduces peak handles in imaging-darkroom.js from 1,282,610 to 428,218. The ast.cc change reduces the peak handles in string-t agcloud.js from 80,738 to 8,176. > > No significant handle count issues found with major websites, but substantial savings on some benchmarks and demos: > > Kraken's imaging-darkroom.js down from 1,282,610 to 428,218 due to runtime-literals.cc scope. > SunSpider's string-tagcloud.js down from 80,738 to 8.176 due to ast.cc > > http://www.flohofwoe.net/demos/dragons_asmjs.html (738,906 -> 478,296) > http://www.flohofwoe.net/demos/instancing_asmjs.html (737,884 -> 477,274) > https://dl.dropboxusercontent.com/u/16662598/Ports/DOSBox-web/doom.html?engine=dosbox-growth.js (1,724,114 -> 1,087,408) > https://kripken.github.io/ammo.js/examples/new/ammo.html (175,784 -> 142,058) > > BUG= > > Committed: https://crrev.com/3a4c7538839186aa38910c66c986abb563f4ccd2 > Cr-Commit-Position: refs/heads/master@{#29155} BUG= Review URL: https://codereview.chromium.org/1192743005 Cr-Commit-Position: refs/heads/master@{#29322}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1215643002 Cr-Commit-Position: refs/heads/master@{#29321}
-
hpayer authored
Revert of Re-land new insertion write barrier. (patchset #1 id:1 of https://codereview.chromium.org/1211513002/) Reason for revert: Still crashing in the wild. Original issue's description: > Re-land new insertion write barrier. > > BUG= > > Committed: https://crrev.com/6e6af7e7c70050cdd5ce56cdbaee3b6e8a7caa89 > Cr-Commit-Position: refs/heads/master@{#29258} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1217443002 Cr-Commit-Position: refs/heads/master@{#29320}
-
machenbach authored
Revert of Reland [android] Migrate more configs to gyp. (patchset #2 id:20001 of https://codereview.chromium.org/1210393003/) Reason for revert: [Sheriff] Fails runhooks. Original issue's description: > Reland [android] Migrate more configs to gyp. > > This reverts commit 3e8892b5. > > BUG=chromium:502176 > LOG=n > NOTRY=true > TBR=ulan@chromium.org, jochen@chromium.org > > Committed: https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041 > Cr-Commit-Position: refs/heads/master@{#29317} TBR=ulan@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502176 Review URL: https://codereview.chromium.org/1215593004 Cr-Commit-Position: refs/heads/master@{#29319}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1208573002 Cr-Commit-Position: refs/heads/master@{#29318}
-
machenbach authored
This reverts commit 3e8892b5. BUG=chromium:502176 LOG=n NOTRY=true TBR=ulan@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1210393003 Cr-Commit-Position: refs/heads/master@{#29317}
-
bmeurer authored
Revert of [android] Migrate more configs to gyp. (patchset #4 id:60001 of https://codereview.chromium.org/1207693004/) Reason for revert: Breaks arm64 bots. Original issue's description: > [android] Migrate more configs to gyp. > > BUG=chromium:502176 > LOG=n > > Committed: https://crrev.com/174869573e42c999da1489c264b9c4602b98ba31 > Cr-Commit-Position: refs/heads/master@{#29314} TBR=jochen@chromium.org,ulan@chromium.org,dusan.milosavljevic@imgtec.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502176 Review URL: https://codereview.chromium.org/1211383002 Cr-Commit-Position: refs/heads/master@{#29316}
-
bmeurer authored
This optimization is already implemented in fullcodegen, and basically makes sure that we do not unecessarily blow up the code with duplicated return sequences everywhere. R=danno@chromium.org Review URL: https://codereview.chromium.org/1211373002 Cr-Commit-Position: refs/heads/master@{#29315}
-
machenbach authored
BUG=chromium:502176 LOG=n Review URL: https://codereview.chromium.org/1207693004 Cr-Commit-Position: refs/heads/master@{#29314}
-
mstarzinger authored
This allows context-independent code generated by TurboFan to be cached in the optimized code map and reused across native contexts. Note that currently this cache is still flushed at GC time. R=bmeurer@chromium.org,mvstanton@chromium.org TEST=cctest/test-compiler/OptimizedCodeSharing Review URL: https://codereview.chromium.org/1208013002 Cr-Commit-Position: refs/heads/master@{#29313}
-
machenbach authored
Revert of Debugger: use list to find shared function info in a script. (patchset #2 id:20001 of https://codereview.chromium.org/1206573004/) Reason for revert: [Sheriff] Breaks layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/682 Original issue's description: > Debugger: use list to find shared function info in a script. > > Now that we keep tabs on shared function infos from a script, we can speed up finding shared function infos for debugging. However, in case we have to compile a function that cannot be lazily compiled without context, we fall back to the slow heap iteration. > > R=mstarzinger@chromium.org > BUG=v8:4132,v8:4052 > LOG=N > > Committed: https://crrev.com/cfe89a71a332ef9ed481c8210bc3ad6d2822034b > Cr-Commit-Position: refs/heads/master@{#29296} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4132,v8:4052 Review URL: https://codereview.chromium.org/1210393002 Cr-Commit-Position: refs/heads/master@{#29312}
-
bmeurer authored
This will enable tail call optimization even across inlining. Plus it might enable some other interesting optimizations as well. In order to avoid blowing up the generated code, we can still canonicalize the epilogue in the CodeGenerator, similar to what fullcodegen does. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1215623002 Cr-Commit-Position: refs/heads/master@{#29311}
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1209903003 Cr-Commit-Position: refs/heads/master@{#29310}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1210863002 Cr-Commit-Position: refs/heads/master@{#29309}
-
- 25 Jun, 2015 25 commits
-
-
yangguo authored
Reserving space for deserialization can cause GC, which can evict entries from the string table. Having more deleted entries now, StringTable::EnsureCapacity could cause a GC later during deserialization even when we actually still have enough capacity. Instead, we now keep new internalized strings in a separate list and commit them to the string table at the end. R=ulan@chromium.org BUG=chromium:502085 LOG=N Review URL: https://codereview.chromium.org/1204863006 Cr-Commit-Position: refs/heads/master@{#29308}
-
mbrandy authored
StoreP to a tagged object pointer requires a scratch register. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1207323002 Cr-Commit-Position: refs/heads/master@{#29307}
-
binji authored
The issue is that Worker.prototype.terminate was deleting the C++ Worker object, and then Worker.prototype.getMessage was trying to read messages from the queue. The simplest solution is to keep workers in a zombie state when they have been terminated. They won't be reaped until Shell::CleanupWorkers is called. I've also fixed some threading issues with Workers: * Workers can be created by another Worker, so the Shell::workers_ variable must be protected by a mutex. * An individual Worker can typically only be accessed by the isolate that created it, but the main thread can always terminate it, so the Worker::state_ must be accessed in a thread-safe way. BUG=chromium:504136 R=jochen@chromium.org LOG=n Review URL: https://codereview.chromium.org/1208733002 Cr-Commit-Position: refs/heads/master@{#29306}
-
balazs.kilvady authored
Port d783b763 Original commit message: ARM64's `fmin` and `fmax` instructions don't have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions. BUG=4206 LOG=N Review URL: https://codereview.chromium.org/1204903004 Cr-Commit-Position: refs/heads/master@{#29305}
-
mbrandy authored
Port a58ba8d8 Original commit message: This introduces some initial building blocks for calling out to C/C++ functions directly from TurboFan generated code objects. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1206343002 Cr-Commit-Position: refs/heads/master@{#29304}
-
mbrandy authored
Port c1a4f747 Original commit message: The idea is that TurboFan can use this information for more intelligent inlining. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1208093002 Cr-Commit-Position: refs/heads/master@{#29303}
-
mbrandy authored
Port 9e7af9ef Original commit message: It's useful for the megamorphic keyed store case to not require a vector and slot as input. Analogous to the load case, we have a dummy one-ic-slot vector to aid. Since the only kind of MISS is for megamorphic cache stub failures, we don't need the real vector. The reason is that megamorphic cache stub failures don't result in any change to the type feedback vector state. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1212493002 Cr-Commit-Position: refs/heads/master@{#29302}
-
mbrandy authored
R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1210083002 Cr-Commit-Position: refs/heads/master@{#29301}
-
mbrandy authored
R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1209703002 Cr-Commit-Position: refs/heads/master@{#29300}
-
wingo authored
BUG=v8:4213 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/1210003003 Cr-Commit-Position: refs/heads/master@{#29299}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1211833002 Cr-Commit-Position: refs/heads/master@{#29298}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1209983002 Cr-Commit-Position: refs/heads/master@{#29297}
-
yangguo authored
Now that we keep tabs on shared function infos from a script, we can speed up finding shared function infos for debugging. However, in case we have to compile a function that cannot be lazily compiled without context, we fall back to the slow heap iteration. R=mstarzinger@chromium.org BUG=v8:4132,v8:4052 LOG=N Review URL: https://codereview.chromium.org/1206573004 Cr-Commit-Position: refs/heads/master@{#29296}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1205913002 Cr-Commit-Position: refs/heads/master@{#29295}
-
vogelheim authored
This is a follow-on to https://code.google.com/p/v8/source/detail?r=22431 This will remove the compatibility logic, so that the API as described in r22431 is the only API. I'll let this CL will sit around for a while to give embedders a chance to update their code. R=yangguo@chromium.org, ulan@chromium.org BUG=chromium:399580 LOG=Y Review URL: https://codereview.chromium.org/392263002 Cr-Commit-Position: refs/heads/master@{#29294}
-
wingo authored
Originally applied in https://codereview.chromium.org/1202963005 BUG=v8:4214 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel LOG=N R=arv@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1208873002 Cr-Commit-Position: refs/heads/master@{#29293}
-
arv authored
The stack layout was different for different ports. BUG=v8:3887 LOG=N R=dslomov@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1203103003 Cr-Commit-Position: refs/heads/master@{#29292}
-
yangguo authored
BUG=v8:4132 LOG=N Review URL: https://codereview.chromium.org/1211803002 Cr-Commit-Position: refs/heads/master@{#29291}
-
erikcorry authored
Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1204123003 Cr-Commit-Position: refs/heads/master@{#29290}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1207613005 Cr-Commit-Position: refs/heads/master@{#29289}
-
bmeurer authored
Also remove the weird work-around for this missing optimization in CHECK_DATE in macros.py. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1205353002 Cr-Commit-Position: refs/heads/master@{#29288}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1194023004 Cr-Commit-Position: refs/heads/master@{#29287}
-
yangguo authored
Currently DebugInfo objects can be created independently from whether the debugger is active. When tearing down the isolate, we would go through DebugInfo objects and iterate through break locations, causing this assertion to fail. R=ulan@chromium.org BUG=v8:4241 LOG=N Review URL: https://codereview.chromium.org/1210813002 Cr-Commit-Position: refs/heads/master@{#29286}
-
yangguo authored
Revert of Reland "Keep a canonical list of shared function infos." (patchset #3 id:40001 of https://codereview.chromium.org/1211453002/) Reason for revert: proxies test failing https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/903/steps/Mjsunit/logs/proxies Original issue's description: > Reland "Keep a canonical list of shared function infos." > > This reverts commit 3164aa74. > > Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 > Cr-Commit-Position: refs/heads/master@{#29282} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1206263002 Cr-Commit-Position: refs/heads/master@{#29285}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1206803003 Cr-Commit-Position: refs/heads/master@{#29284}
-