- 15 Aug, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/016397a..3ae3c03 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/501bed8..fc13545 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6a4e31b..1164342 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d299f06..45de59d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic025445fd38a217fc6b12cbf80b8113102228a44 Reviewed-on: https://chromium-review.googlesource.com/1175460 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55135}
-
- 14 Aug, 2018 33 commits
-
-
Alexey Kozyatinskiy authored
R=pfeldman@chromium.org Change-Id: I6ffa0aa357bc296a5b6fc2b20fb10e2e806dae56 Reviewed-on: https://chromium-review.googlesource.com/1175080Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55134}
-
Andrey Lushnikov authored
This is a follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/1173718 R=kozy, pfeldman TBR=pfeldman Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I48b4ca5589505d03773477623654fa54703f0714 Reviewed-on: https://chromium-review.googlesource.com/1175061 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55133}
-
Junliang Yan authored
Port 5fecd146 Original Commit Message: This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia9aad21713a2ad76ce3ef2b816fc20e9a27fe4c9 Reviewed-on: https://chromium-review.googlesource.com/1174936Reviewed-by:
John Barboza <jbarboza@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55132}
-
Andrey Lushnikov authored
This is a pre-requisite for https://chromium-review.googlesource.com/c/chromium/src/+/1134430 R=kozy Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic437eaffd0870e1ce6b16e4992e9232515e091ec Reviewed-on: https://chromium-review.googlesource.com/1173718Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
This increases the size of a Collator instance by a word to store the bound compare function. The instance to be bound is stored on the context of this builtin function. Bug: v8:7800 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie7581ab59fdfe4efff6d960e07ed2164fa6d9959 Reviewed-on: https://chromium-review.googlesource.com/1171967Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55130}
-
Sathya Gunasekaran authored
Revert "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This reverts commit ba735dde. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21991 Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} TBR=ulan@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iaf65227c65c11effa11662ac7d7bd7736f4d7846 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1174858Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b Reviewed-on: https://chromium-review.googlesource.com/1160162 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55128}
-
Leszek Swirski authored
This reverts commit c8376b00. Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 Original change's description: > [cleanup] Reland: Remove deprecated functions > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > with no changes since the break in chromium for ChromeOS is now fixed. > > Removes all V8_DEPRECATED functions that weren't recently marked as well > any V8_DEPRECATE_SOON function that relied on using using the address of > an object to get hold of the Isolate. > > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 > Reviewed-on: https://chromium-review.googlesource.com/1172350 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55119} TBR=yangguo@chromium.org,delphick@chromium.org Change-Id: Id1308a694092acfc90a3e7183d66c002feb63999 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1174751Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55127}
-
Dan Elphick authored
Remove part of comment about returning a boolean from ReadData since the function doesn't return anything (and hasn't for more than 8 years). R=yangguo Change-Id: Ie38d68ef36077d08faecc8540c5de050472142ba Reviewed-on: https://chromium-review.googlesource.com/1174535Reviewed-by:
-
Bret Sepulveda authored
Previously, when given a log with few ticks, the timeline would lump them all into one or two buckets. This patch allows ticks to be assigned to buckets more sparsely. This patch also fixes a bug where there was a gap on the right side of the timeline, which also caused the function tick marks to be slightly misaligned. This was more noticable with fewer buckets. Bug: v8:6240 Change-Id: Ib7353c0420caec8591590815271d329ea1a030fb Reviewed-on: https://chromium-review.googlesource.com/1174440 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55125}
-
Stephan Herhut authored
Data object for tick collection are now created in a thread save way and the block ids for counters use the same numbers as the printed schedule. Change-Id: I7a35088cb2fcd94a81067b16ad12b01d380fefa5 Reviewed-on: https://chromium-review.googlesource.com/1152923 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55124}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Id05fe2480d7cda8038740aaae949cc707686171f Reviewed-on: https://chromium-review.googlesource.com/1174439Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: If46556bde7fdc49023425d90fb1b68634d9b1ad9 Reviewed-on: https://chromium-review.googlesource.com/1174434Reviewed-by:
-
Georgia Kouveli authored
* Perform the lookups into the builtins constant table and external reference table in the generic version of Mov that accepts an Operand source. This makes sure we do not miss looking up constants and external references when the generic Mov is called. * Remove Mov(ExternalReference) as ExternalReference can be implicitly converted to an Operand. * Remove two Move functions that are unused in architecture-independent code. Replace their uses in arm64-specific code with the generic Mov, which does all the necessary work now. Change-Id: Ibbcee6ba22f661984cd830717e14c9b35a1fba0a Reviewed-on: https://chromium-review.googlesource.com/1172351 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55121}
-
Benedikt Meurer authored
We don't need to keep JSToObject operations in the graph if there's some preceeding map check that already provides information that the input is indeed already a receiver. Change-Id: I2d04895831ff561624fbe91a2fe03bb6e5d918a5 Reviewed-on: https://chromium-review.googlesource.com/1174259Reviewed-by:
-
Dan Elphick authored
This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 with no changes since the break in chromium for ChromeOS is now fixed. Removes all V8_DEPRECATED functions that weren't recently marked as well any V8_DEPRECATE_SOON function that relied on using using the address of an object to get hold of the Isolate. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 Reviewed-on: https://chromium-review.googlesource.com/1172350Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I6792bbbf015c7ba43ddaf373803c0afdf140eb76 Reviewed-on: https://chromium-review.googlesource.com/1174269Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:861668 Change-Id: I099b2ff007bed8b35e13d7f52eb5d0ae390a230e Reviewed-on: https://chromium-review.googlesource.com/1174267 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55117}
-
Sigurd Schneider authored
Bug: v8:8015 Change-Id: I8099c66108d5cc1596cb9b0a00c0ecd30765cf24 Reviewed-on: https://chromium-review.googlesource.com/1174266Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55116}
-
Jaroslav Sevcik authored
Bug: v8:8042 Change-Id: If667f1aba335d8e296052ff94e99900d446c3b29 Reviewed-on: https://chromium-review.googlesource.com/1172772Reviewed-by:
-
Leszek Swirski authored
This reverts commit 5a389395. Reason for revert: Breaks some chromium tests. Not your fault, but it's blocking the roll so we have to fix those first -- then you can reland without changes: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727 Original change's description: > [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort > > This CL changes the sorting algorithm used in Array.p.sort from > QuickSort to TimSort (implemented in Torque). > > Detailed performance results can be found here: https://goo.gl/4E733J > > To save on code space, fast-paths are implemented as sets of > function pointers instead of specializing generics. > > R=cbruni@chromium.org, jgruber@chromium.org > > Bug: v8:7382, v8:7624 > Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de > Reviewed-on: https://chromium-review.googlesource.com/1151199 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55003} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7382, v8:7624 Change-Id: Id4002d8080648c418639d35e7b82487fa43f463d Reviewed-on: https://chromium-review.googlesource.com/1174231 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55114}
-
Andreas Haas authored
The streaming compilation cctests test streaming compilation over the public API, as far as possible. It is not required that a HandleScope is open when the API is used. Therefore the cctest should also not open a global HandleScope for a whole test but as fine-grained as possible. R=clemensh@chromium.org Bug: v8:8055 v8:8015 Change-Id: Id5e2145f2a8ba66e8d5d9021c47806aa80fc463f Reviewed-on: https://chromium-review.googlesource.com/1174258Reviewed-by:
-
Dan Elphick authored
Rather than having GDB always stop on the line containing V8_IMMEDIATE_CRASH(), walk up the stack looking for V8_Dcheck and select the frame above it. This will be the frame containing DCHECK (including related macros like DCHECK_EQ). Change-Id: I9760e7a4dd78b567dfa77ff12569d287d80ca873 Reviewed-on: https://chromium-review.googlesource.com/1172780Reviewed-by:
-
Benedikt Meurer authored
This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. Bug: chromium:225811 Change-Id: I7c1ec826faf46a144a5a9068f8f815a5fd040997 Reviewed-on: https://chromium-review.googlesource.com/1174252Reviewed-by:
-
Georg Neis authored
In order to know which labels are valid continue targets, we must track the labels that immediately prefix an iteration statement. Also document some things that I had to figure out. Bug: v8:8033 Change-Id: Ia8288fd0e553a547aa0f9d1b4381bb103325bc3a Reviewed-on: https://chromium-review.googlesource.com/1172292Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55110}
-
Benedikt Meurer authored
This reverts commit 6c7c81e0. Reason for revert: Dependent CL was reverted. Original change's description: > [turbofan] Properly zero-extend indices on 64-bit architectures. > > This was an oversight from the previous CL. It doesn't really matter > with the current code generation pattern, since the upper bits of the > index will always be zero, but that might change in the future. > > Bug: chromium:225811 > Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 > Reviewed-on: https://chromium-review.googlesource.com/1174111 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55104} TBR=jarin@chromium.org,bmeurer@chromium.org Change-Id: Ib344609b0c4734c6512e6be287a5b7f80bc3f603 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174232Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55109}
-
jgruber authored
Follow-up to 17ad3ae4. Another try at exposing embedded builtin symbols on chromecrash. Bug: v8:6666, v8:7722 Change-Id: Ie715251797134be0618c0bc496ec10958f7545c3 Reviewed-on: https://chromium-review.googlesource.com/1174112Reviewed-by:
-
Leszek Swirski authored
This reverts commit c46915b9. Reason for revert: Disasm failures https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727 Original change's description: > [turbofan] Further optimize DataView accesses. > > This adds support for unaligned load/store access to the DataView > backing store and uses byteswap operations to fix up the endianess > when necessary. This changes the Word32ReverseBytes operator to be > a required operator and adds the missing support on the Intel and > ARM platforms (on 64-bit platforms the Word64ReverseBytes operator > is also mandatory now). > > This further improves the performance on the dataviewperf.js test > mentioned in the tracking bug by up to 40%, and at the same time > reduces the code complexity in the EffectControlLinearizer. > > Bug: chromium:225811 > Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 > Reviewed-on: https://chromium-review.googlesource.com/1172777 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55099} TBR=sigurds@chromium.org,bmeurer@chromium.org Change-Id: If7a62e3a1a4ad26823fcbd2ab6eb4c053ad11c49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174171Reviewed-by:
-
Andreas Haas authored
The problem was that in AsyncCompileJob::FinishModule we allocate a handle, but when this function is called from streaming compilation, then there was no HandleScope around AsyncCompileJob::FinishModule. This issue was fixed in another CL, https://crrev.com/c/1172357. This CL is just a rebase of the original CL. Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. R=starzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib0cb25488654d2b325b4f529d33b76b846c64436 Reviewed-on: https://chromium-review.googlesource.com/1172429Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I310d9453be8b90a82856c0d394442aad5527a3ae Reviewed-on: https://chromium-review.googlesource.com/1169167 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55105}
-
Benedikt Meurer authored
This was an oversight from the previous CL. It doesn't really matter with the current code generation pattern, since the upper bits of the index will always be zero, but that might change in the future. Bug: chromium:225811 Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 Reviewed-on: https://chromium-review.googlesource.com/1174111 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Hai Dang authored
This affects map, filter, every, some, indexOf and includes. Tests for those cases and more are also added. Bug: v8:8049 Change-Id: I196abd8e7e2419a2bb465f44caf4de52990ffced Reviewed-on: https://chromium-review.googlesource.com/1172346Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6705895..016397a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/21cd5a3..501bed8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6fa51528cc992f2656812baec91089543cb62e50 Reviewed-on: https://chromium-review.googlesource.com/1173758Reviewed-by:
-
- 13 Aug, 2018 6 commits
-
-
Camillo Bruni authored
Drive-by-fix: - Remove obsolete mark_shared_functions_for_tier_up flag Bug: chromium:873728 Change-Id: I6c18b2e55068be913a3fc16932a9be0f9f02b635 Reviewed-on: https://chromium-review.googlesource.com/1173232 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Creddy authored
Word32Not was used instead of Word32BinaryNot which caused unecssary runtime lookup. This CL fixed the performance regression https://crrev.com/c/1145438. Bug: chromium:868799 Change-Id: I9e070de6155797e52dd9b461a9660cb003509a57 Reviewed-on: https://chromium-review.googlesource.com/1169808 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. Bug: chromium:225811 Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 Reviewed-on: https://chromium-review.googlesource.com/1172777 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6922 Change-Id: I641f654f0548c2da24cdea3ffd275461ae8ce9b0 Reviewed-on: https://chromium-review.googlesource.com/1172776Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55098}
-
Benedikt Meurer authored
The DataView access methods can use the neutering protector to avoid introducing an explicit check into the optimized code to see if the backing store was neutered. Instead the optimized code has an implicit dependency on the global neutering protector which gets invalidated when the first array buffer is neutered (globally). We use the same trick for typed arrays already. Bug: chromium:225811 Change-Id: I9b3c95b3113b8fa00dcbba216ef29c84c0056951 Reviewed-on: https://chromium-review.googlesource.com/1172779 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
[scanner] Explicitly add one-byte characters to a one-byte literal buffer when scanning ascii identifiers Change-Id: Ia8337506d9f442d6887b6fa3c2ed17210ffd3c28 Reviewed-on: https://chromium-review.googlesource.com/1172789Reviewed-by:
-
