Commits · 779af439ec6c709162acde76a0a0d4aabbf9318c · Linshizhi / V8

05 Nov, 2008 4 commits

Backport the changes from the readability review. · 779af439

iposva@chromium.org authored Nov 05, 2008

Review URL: http://codereview.chromium.org/8939

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@700 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

779af439

Removed some unsafe uses of StringShape. · b4e7335c

erik.corry@gmail.com authored Nov 05, 2008

Simplified some uses of StringShape.
Removed unused function SlicedStringFlatten.
Review URL: http://codereview.chromium.org/9408

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4e7335c

Initial port of VirtualFrame to the ARM architecture. To reduce the · 47e55a77

kmillikin@chromium.org authored Nov 05, 2008

size of the change, the initial implementation provides read access to
the frame (eg, locals, parameters, and expression stack elements) but
no mutation.
Review URL: http://codereview.chromium.org/7302

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

47e55a77

Removed a comment that is no longer valid. · 31520bc3

olehougaard authored Nov 05, 2008

Review URL: http://codereview.chromium.org/8960

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31520bc3

04 Nov, 2008 5 commits

Do not put failures in handles. · 439f3e67

ager@chromium.org authored Nov 04, 2008

Assert in the Handle constructor that the object is not a failure.

I have run our own tests in debug mode and the WebKit layout tests in
debug mode and there are no regressions.
Review URL: http://codereview.chromium.org/9114

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

439f3e67

Use 1 byte push REG instructions instead of the 2 byte ModRM version. · a62c6788
deanm@chromium.org authored Nov 04, 2008
```
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
```
a62c6788
Remove duplicated code, the two emit_operand were basically identical. · 44fe15db
deanm@chromium.org authored Nov 04, 2008
```
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
```
44fe15db

Code cleanup & simplification. · eb9c7f32

whessev8 authored Nov 04, 2008

Moves the calls to tracer and UpdateLiveObjectCount inside the call to
(inlined) SetMark.  Removes global object counter.
Review URL: http://codereview.chromium.org/8910

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb9c7f32

Prepare push to trunk. Now working on version 0.4.4. · 801e168d

ager@chromium.org authored Nov 04, 2008

Review URL: http://codereview.chromium.org/9324

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@686 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

801e168d

03 Nov, 2008 7 commits

Make buildbots green. StringShapes can change during GC when we · af16174b

ager@chromium.org authored Nov 03, 2008

shortcut cons strings.
Review URL: http://codereview.chromium.org/9245

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af16174b

Smi ranges are not symmetrical. -kMinSmiValue is not a Smi. · 240d818b

ager@chromium.org authored Nov 03, 2008

Review URL: http://codereview.chromium.org/9041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

240d818b

If a HeapNumber is the incoming value, it must be converted to Smi before · 4e3bbd82

lrn@chromium.org authored Nov 03, 2008

checking. This is not done in a fast way.


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e3bbd82

Fix place where linter complains about lonely { · c3904850

erik.corry@gmail.com authored Nov 03, 2008

Fix place where ARM compiler loses track of whether variables were initialized.
Review URL: http://codereview.chromium.org/9244

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c3904850

fuzz natives times out on some machines due to DebugReferencedBy · 6951059c

erik.corry@gmail.com authored Nov 03, 2008

Review URL: http://codereview.chromium.org/9039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6951059c

Add file accidentally omitted from last change. · ed8d093e

erik.corry@gmail.com authored Nov 03, 2008


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed8d093e

Create an abstraction for the string type flags so that they can be cached. · eca89dc7

erik.corry@gmail.com authored Nov 03, 2008

Read the objects.h change first to understand what's going on here.
Review URL: http://codereview.chromium.org/9038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eca89dc7

31 Oct, 2008 10 commits

Reverted 671. · ec3c4ced

kmillikin@chromium.org authored Oct 31, 2008


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec3c4ced

Change the test status file parser to fail if the line contains unparsed tokens. · 84170eeb

sgjesse@chromium.org authored Oct 31, 2008

Refactor the platform.system() tests and use macos when running on Mac.
Review URL: http://codereview.chromium.org/8763

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@672 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

84170eeb

Simplify the way we materialize boolean values that are not yet pushed · 67ae89e4

kmillikin@chromium.org authored Oct 31, 2008

on the stack frame.
Review URL: http://codereview.chromium.org/8764

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

67ae89e4

Fixing propertyIsEnumerable for properties that are *both* enumerable and read-only. · bf3efa1c

olehougaard authored Oct 31, 2008

Review URL: http://codereview.chromium.org/8962

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@670 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf3efa1c

Reverting patch on wrong branch. · 2da0c255

lrn@chromium.org authored Oct 31, 2008


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2da0c255

Fixed some details in GetPropertyAttributeWithFailedAccessCheck · 2a6c90e6

olehougaard authored Oct 31, 2008

Review URL: http://codereview.chromium.org/8959

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2a6c90e6

We still compile with JSCRE immediately, instead of at the first use. · b9a251a9
lrn@chromium.org authored Oct 31, 2008
```
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
```
b9a251a9

Introduce access control in propertyIsEnumerable. · 77a92988

olehougaard authored Oct 31, 2008

Also, fix JSObject::getPropertyAttribute() so it deals correctly with access control modifiers.
Review URL: http://codereview.chromium.org/8834

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77a92988

Fix natives fuzzing: Let the StringIndexOf runtime function · 744aedd2

kasperl@chromium.org authored Oct 31, 2008

deal with start indexes that are out of range.
Review URL: http://codereview.chromium.org/8762

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@663 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

744aedd2

Changed the parsing a conditional expression in a test status file to look for... · 7cf09d88

sgjesse@chromium.org authored Oct 31, 2008

Changed the parsing a conditional expression in a test status file to look for 'if' and not 'IF' as all the status files use 'if'.

This change catches the regression from r646.
Review URL: http://codereview.chromium.org/8739

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7cf09d88

30 Oct, 2008 10 commits

Ignore result of calling Heap::CollectGarbage and continue · 25421c9c

kasperl@chromium.org authored Oct 30, 2008

to try the next allocation. This is consistent with how we
handle it when calling from JavaScript to C++.
Review URL: http://codereview.chromium.org/8916

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25421c9c

Extend test case to cover calling runtime functions · 95e880ad

kasperl@chromium.org authored Oct 30, 2008

from JavaScript.
Review URL: http://codereview.chromium.org/8915

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@658 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95e880ad

Add support for API accessors that prohibit overwriting by accessors · 20134218

ager@chromium.org authored Oct 30, 2008

defined in JavaScript code by using __defineGetter__ and
__defineSetter__.

Also, disable access checks when configuring objects created from
templates.
Review URL: http://codereview.chromium.org/8914

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@656 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

20134218

Move assertion that might cause garbage collections to before · 69e80606

ager@chromium.org authored Oct 30, 2008

extracting raw pointers.
Review URL: http://codereview.chromium.org/8913

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

69e80606

Silly pointer thinko. · 128c1ab8

erik.corry@gmail.com authored Oct 30, 2008

Review URL: http://codereview.chromium.org/8912

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@653 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

128c1ab8

Prepare for pushing version 0.4.2. · 3a296601

kasperl@chromium.org authored Oct 30, 2008

Review URL: http://codereview.chromium.org/8911

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3a296601

Fix lint issue. · ff1088d6

kasperl@chromium.org authored Oct 30, 2008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff1088d6

Fix 3 places where we were doing retry after GC without using the macros that · 8a8a2487

erik.corry@gmail.com authored Oct 30, 2008

were defined for that purpose.
Review URL: http://codereview.chromium.org/8734

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8a8a2487

Added some missing initialization checks to the debugger API. · 52b2a126

sgjesse@chromium.org authored Oct 30, 2008

BUG=3723 (Chromium)
Review URL: http://codereview.chromium.org/8909

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@648 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52b2a126

Make sure that allocations through CALL_HEAP_FUNCTION · a2be3b6f

kasperl@chromium.org authored Oct 30, 2008

and runtime calls from JavaScript will always succeed
eventually if we have enough memory.
Review URL: http://codereview.chromium.org/8700

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a2be3b6f

29 Oct, 2008 4 commits

Fix Chromium issue 3607. · 24cb757a

feng@chromium.org authored Oct 29, 2008

Make Date::toLocaleDateString output be the same format as Safari.

Someone famililar with Date builtin object should check other functions.

Review URL: http://codereview.chromium.org/8875

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24cb757a

Fix out-of-date comment. · 156c1323

iposva@chromium.org authored Oct 29, 2008

TBR=ager

Review URL: http://codereview.chromium.org/8708

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@644 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

156c1323

Most of the crashing ARM tests failed in debug mode. · 4717ed1d

sgjesse@chromium.org authored Oct 29, 2008

TBR=kasperl
Review URL: http://codereview.chromium.org/8698

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@643 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4717ed1d

Skip the tests which currently crash on the ARM simulator. · 10e38040

sgjesse@chromium.org authored Oct 29, 2008

Review URL: http://codereview.chromium.org/8696

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10e38040