- 30 Sep, 2015 24 commits
-
-
littledan authored
The ES2015 spec is missing an extension of sloppy-mode block-scoped function behavior to the global scope in scripts, as well as to eval. This patch brings that hoisting to those two areas. The behavior is not perfectly spec-compliant since properties created on the global scope should be set as enumerable even if they are non-enumerable previously, but the attributes will not be modified if the property already exists under this patch. BUG=v8:4441 LOG=Y R=adamk TEST=reddit comment functionality seems to be fixed Review URL: https://codereview.chromium.org/1376623002 Cr-Commit-Position: refs/heads/master@{#31037}
-
mbrandy authored
Port c90c60ba Original commit message: Make sure to always reference it indirectly. This allows us to make the vector native-context dependent should we wish. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1381803002 Cr-Commit-Position: refs/heads/master@{#31036}
-
mbrandy authored
Port d8cdd695 Original commit message: The LiteralsArray will soon hold a type feedback vector. Code treats it as an ordinary fixed array, and needs to stop that. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1373823003 Cr-Commit-Position: refs/heads/master@{#31035}
-
mbrandy authored
Port 09626525 R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1377133005 Cr-Commit-Position: refs/heads/master@{#31034}
-
mbrandy authored
Port 9b12ec9a Original commit message: This lowers JSCreateArgument nodes to call the ArgumentsAccessStub for help with materializing arguments objects when possible. Along the way this changes the calling convention of said stub to take parameters in registers instead of on the stack. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1376303002 Cr-Commit-Position: refs/heads/master@{#31033}
-
adamk authored
- No need to call AsVariableProxy() on a VariableProxy - Reduce AST visitor boilerplate using pre-existing macro (and re-alphabetize the list of non-patterns). R=littledan@chromium.org Review URL: https://codereview.chromium.org/1376633005 Cr-Commit-Position: refs/heads/master@{#31032}
-
adamk authored
Arrow functions have been enabled by default since the 4.5 branch. Review URL: https://codereview.chromium.org/1373633002 Cr-Commit-Position: refs/heads/master@{#31031}
-
adamk authored
Besides matching the spec, this matches the behavior of Firefox and Edge. BUG=v8:3699 LOG=n CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1377603006 Cr-Commit-Position: refs/heads/master@{#31030}
-
adamk authored
The current implemention breaks sloppy mode code that uses function declarations inside blocks at top-level. Work is ongoing on a patch to fix this issue, but in the meantime it seems reasonable to move the feature out of staging. Manual revert of commit 6e07f5a7. R=littledan@chromium.org BUG=chromium:535836 LOG=y Review URL: https://codereview.chromium.org/1375213005 Cr-Commit-Position: refs/heads/master@{#31029}
-
kozyatinskiy authored
Added ScopeDetails.name field for closure scopes. It contains function's debug name of current context of scope. BUG=493156 LOG=Y R=yurys@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1375813002 Cr-Commit-Position: refs/heads/master@{#31028}
-
mbrandy authored
Port 8fe3ac07 Original commit message: There was already a bit on the Map named "function with prototype", which basically meant that the Map was a map for a JSFunction that could be used as a constructor. Now this CL generalizes that bit to IsConstructor, which says that whatever (Heap)Object you are looking at can be used as a constructor (i.e. the bit is also set for bound functions that can be used as constructors and proxies that have a [[Construct]] internal method). This way we have a single chokepoint for IsConstructor checking, which allows us to get rid of the various ways in which we tried to guess whether something could be used as a constructor or not. Drive-by-fix: Renamed IsConstructor on FunctionKind to IsClassConstructor to resolve the weird name clash, and the IsClassConstructor name also matches the spec. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413, v8:4430 LOG=n Review URL: https://codereview.chromium.org/1382673002 Cr-Commit-Position: refs/heads/master@{#31027}
-
mbrandy authored
Port 556b522a Original commit message: We somehow try to push some stuff on the stack when we detect a stack overflow, that we don't need. Even worse we might access outside the valid stack bounds. Since we don't need this, it's gone. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:534881 LOG=n Review URL: https://codereview.chromium.org/1382633002 Cr-Commit-Position: refs/heads/master@{#31026}
-
mbrandy authored
Port 634d1d86 Original commit message: Now both Execution::Call and Execution::New can deal with any kind of target and will raise a proper exception if the target is not callable (which is not yet spec compliant for New, as we would have to check IsConstructor instead, which we don't have yet). Now we no longer need to do any of these weird call/construct delegate gymnastics in C++, and we finally have a single true bottleneck for Call/Construct abstract operations in the code base, with only a few special handlings left in the compilers to optimize the JSFunction case. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4430, v8:4413 LOG=n Review URL: https://codereview.chromium.org/1374683006 Cr-Commit-Position: refs/heads/master@{#31025}
-
jkummerow authored
No users of that functionality yet, those will come separately. Review URL: https://codereview.chromium.org/1375003002 Cr-Commit-Position: refs/heads/master@{#31024}
-
jkummerow authored
Continuing unification of properties/elements handling, the new LookupIterator::PropertyOrElement(..., Handle<Object> key, ...) takes any Object and does the required ToPrimitive/ToName/ToArrayIndex conversions on it. Review URL: https://codereview.chromium.org/1375943002 Cr-Commit-Position: refs/heads/master@{#31023}
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1383553002 Cr-Commit-Position: refs/heads/master@{#31022}
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1377833002 Cr-Commit-Position: refs/heads/master@{#31021}
-
machenbach authored
BUG=chromium:535160,chromium:537247 LOG=n Review URL: https://codereview.chromium.org/1383473002 Cr-Commit-Position: refs/heads/master@{#31020}
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
cbruni authored
BUG= Committed: https://crrev.com/a00d47c802f93cf9835eafce4c9da2dd10b44f6a Cr-Commit-Position: refs/heads/master@{#30946} Review URL: https://codereview.chromium.org/1363293002 Cr-Commit-Position: refs/heads/master@{#31018}
-
mstarzinger authored
This moves some methods of IncrementalMarking from the inlined header into the compilation unit. The methods in question are either not hot or are being called through a non-inline function already. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1380523002 Cr-Commit-Position: refs/heads/master@{#31017}
-
ofrobots authored
Previous debug refactoring changes removed uses of has_break_points_, but omitted removing the field itself. This is not necessary anymore. R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1382443002 Cr-Commit-Position: refs/heads/master@{#31016}
-
chunyang.dai authored
port d8cdd695 (r31000). original commit message: The LiteralsArray will soon hold a type feedback vector. Code treats it as an ordinary fixed array, and needs to stop that. BUG= Review URL: https://codereview.chromium.org/1378793003 Cr-Commit-Position: refs/heads/master@{#31015}
-
v8-autoroll authored
Rolling v8/tools/clang to 0150e39a3112dbc7e4c7a3ab25276b8d7781f3b6 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1375053003 Cr-Commit-Position: refs/heads/master@{#31014}
-
- 29 Sep, 2015 16 commits
-
-
akos.palfi authored
This flag is not understood correctly by GCC and breaks the GCC ARM and MIPS optdebug builds. Patch from Brendan Kirby <brendan.kirby@imgtec.com> BUG= Review URL: https://codereview.chromium.org/1369273003 Cr-Commit-Position: refs/heads/master@{#31013}
-
mlippautz authored
See bug description. BUG=chromium:536231 LOG=N Review URL: https://codereview.chromium.org/1378693002 Cr-Commit-Position: refs/heads/master@{#31012}
-
dusan.m.milosavljevic authored
TEST= BUG= Review URL: https://codereview.chromium.org/1334793004 Cr-Commit-Position: refs/heads/master@{#31011}
-
mstarzinger authored
This prevents the internal incremental-marking.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1374203002 Cr-Commit-Position: refs/heads/master@{#31010}
-
mstarzinger authored
This changes the operators for JSCreate[Block|Script]Context to take their ScopeInfo as a static parameter as opposed to a value input and in turn allows for easier access to that parameter during lowerings. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1379593002 Cr-Commit-Position: refs/heads/master@{#31009}
-
jacob.bramley authored
It is not safe to access memory below sp, and this is also forbidden by the ABI. When pushing, we must either use an atomic operation (such as vstm+db_w) or move sp before writing the data. This patch fixes one stack access, and also adds vpush and vpop helpers to simplify similar code. BUG= Review URL: https://codereview.chromium.org/1378563002 Cr-Commit-Position: refs/heads/master@{#31008}
-
mstarzinger authored
The NodeProperties helpers are here to stay and won't go away anytime soon. This removes a TODO from the graph verifier in that regard. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1375923002 Cr-Commit-Position: refs/heads/master@{#31007}
-
jarin authored
BUG=v8:4446 LOG=n Review URL: https://codereview.chromium.org/1369313004 Cr-Commit-Position: refs/heads/master@{#31006}
-
jarin authored
This is necessary because these operators can read heap (equality can actually write heap when flattening strings). BUG=v8:4446 LOG=n Review URL: https://codereview.chromium.org/1374683002 Cr-Commit-Position: refs/heads/master@{#31005}
-
mlippautz authored
- Remove the hack the resets the new space top pointer from SeqString::Truncate. - Remove NewSpace::set_top completely as there are no callers (and there should be no!) R=hpayer@chromium.org BUG=chromium:536163 LOG=N Review URL: https://codereview.chromium.org/1376753002 Cr-Commit-Position: refs/heads/master@{#31004}
-
ishell authored
It was broken by https://codereview.chromium.org/1376443002. Review URL: https://codereview.chromium.org/1374923002 Cr-Commit-Position: refs/heads/master@{#31003}
-
vogelheim authored
(This is somewhat experimental; hence protected by #ifdef.) R=epertoso@chromium.org, jochen@chromium.org BUG=chromium:508898 LOG=N Review URL: https://codereview.chromium.org/1367953002 Cr-Commit-Position: refs/heads/master@{#31002}
-
hablich authored
NOTRY=true NOPRESUBMIT=true R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1373223003 Cr-Commit-Position: refs/heads/master@{#31001}
-
mvstanton authored
The LiteralsArray will soon hold a type feedback vector. Code treats it as an ordinary fixed array, and needs to stop that. BUG= Review URL: https://codereview.chromium.org/1374723002 Cr-Commit-Position: refs/heads/master@{#31000}
-
hablich authored
R=machenbach@chromium.org NOPRESUBMIT=true NOTRY=true Review URL: https://codereview.chromium.org/1375533003 Cr-Commit-Position: refs/heads/master@{#30999}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1374163002 Cr-Commit-Position: refs/heads/master@{#30998}
-