- 13 Jul, 2015 2 commits
-
-
danno authored
Until now, TF-generated code stubs piggy-backed off of the builtin context. Since generation of code stubs is lazy, stubs generated at different times in different native contexts would contain embedded pointers different builtin contexts, leading to cross-context references and memory leaks. After this CL, all TF-generated code stubs are generated inside a internal thinned-out, native context that lives solely for the purpose of hosting generated code stubs. Review URL: https://codereview.chromium.org/1213203007 Cr-Commit-Position: refs/heads/master@{#29593}
-
bmeurer authored
Optimize string "length" property access based on static type information if possible, but also optimistically optimize the access based on type feedback from the LoadIC. R=jarin@chromium.org Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 Cr-Commit-Position: refs/heads/master@{#29543} Review URL: https://codereview.chromium.org/1216593003 Cr-Commit-Position: refs/heads/master@{#29588}
-
- 08 Jul, 2015 5 commits
-
-
adamk authored
Revert of [turbofan] Optimize string "length" property access based on types. (patchset #2 id:20001 of https://codereview.chromium.org/1216593003/) Reason for revert: Causes crash when running benchmarks/octane/regexp.js on ARM: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp Original issue's description: > [turbofan] Optimize string "length" property access based on types. > > Optimize string "length" property access based on static type > information if possible, but also optimistically optimize the access > based on type feedback from the LoadIC. > > R=jarin@chromium.org > > Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 > Cr-Commit-Position: refs/heads/master@{#29543} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1224083002 Cr-Commit-Position: refs/heads/master@{#29544}
-
bmeurer authored
Optimize string "length" property access based on static type information if possible, but also optimistically optimize the access based on type feedback from the LoadIC. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1216593003 Cr-Commit-Position: refs/heads/master@{#29543}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 Cr-Commit-Position: refs/heads/master@{#29534} Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29539}
-
danno authored
Revert of Add unoptimized/optimized variants of MathFloor TF code stub (patchset #4 id:60001 of https://codereview.chromium.org/1225943002/) Reason for revert: Failure on compiling runtime.js on windows Original issue's description: > Add unoptimized/optimized variants of MathFloor TF code stub > > - Add a TurboFanIC class, derived from TurboFanCodeStub, that > automatically distinguishes between versions of the IC called from > optimized and unoptimized code. > - Add appropriate InterfaceDescriptors for both the versions of the > stub called from unoptimized and optimized code > - Change the MathFloor TF stub generator to output either the > for-optimized or for-unoptimized version based on the minor_key > parameter. > > Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 > Cr-Commit-Position: refs/heads/master@{#29534} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1220783006 Cr-Commit-Position: refs/heads/master@{#29535}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29534}
-
- 03 Jul, 2015 1 commit
-
-
bmeurer authored
Currently we lower shifts directly to machine operators, and add an appropriate Word32And to implement the & 0x1F operation on the right hand side required by the specification. However for Word32And we assume Int32 in simplified lowering, which is basically changes the right hand side bit interpretation for the shifts from Uint32 to Int32, which is obviously wrong. So now we represent that explicitly by proper simplified operators for the shifts, which are lowered to machine in simplified lowering. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1213803008 Cr-Commit-Position: refs/heads/master@{#29465}
-
- 23 Jun, 2015 3 commits
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1199053011 Cr-Commit-Position: refs/heads/master@{#29239}
-
bmeurer authored
BUG=v8:4207 LOG=y R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1198993009 Cr-Commit-Position: refs/heads/master@{#29230}
-
jacob.bramley authored
ARM64's `fmin` and `fmax` instructions don't have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions. BUG=4206 LOG=N Review URL: https://codereview.chromium.org/1200123004 Cr-Commit-Position: refs/heads/master@{#29229}
-
- 15 Jun, 2015 1 commit
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1183123002 Cr-Commit-Position: refs/heads/master@{#29018}
-
- 12 Jun, 2015 1 commit
-
-
mstarzinger authored
This fixes the graph wiring of implicit JSToNumber nodes inserted by JSTypedLowering, to be correctly hooked into a surrounding exceptional continuation. R=bmeurer@chromium.org TEST=mjsunit/compiler/try-binop,test262 Review URL: https://codereview.chromium.org/1178153004 Cr-Commit-Position: refs/heads/master@{#28975}
-
- 09 Jun, 2015 1 commit
-
-
mstarzinger authored
This adds some basic tests of the interaction between try-catch and try-finally statements and OSR in TurboFan. The try-osr test suite follows the structure of try-deopt closely. R=titzer@chromium.org TEST=mjsunit/compiler/try-osr Review URL: https://codereview.chromium.org/1165103003 Cr-Commit-Position: refs/heads/master@{#28855}
-
- 08 Jun, 2015 1 commit
-
-
mstarzinger authored
This allows try-catch and try-finally constructs to be separately enabled and disabled. We plan to stage try-catch support soon. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1157863015 Cr-Commit-Position: refs/heads/master@{#28848}
-
- 26 May, 2015 2 commits
-
-
bmeurer authored
BUG=chromium:491578 LOG=n R=jarin@chromium.org Review URL: https://codereview.chromium.org/1161583002 Cr-Commit-Position: refs/heads/master@{#28621}
-
yangguo authored
Revert of Revert of Hook up more import/exports in natives. (patchset #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
-
- 22 May, 2015 5 commits
-
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}
-
svenpanne authored
First steps only, the TurboFan compilation is still triggered from C++ land. Includes some simplifications/cleanups, too. Review URL: https://codereview.chromium.org/1150263002 Cr-Commit-Position: refs/heads/master@{#28581}
-
yangguo authored
R=jkummerow@chromium.org Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573} Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28578}
-
machenbach authored
Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154793003 Cr-Commit-Position: refs/heads/master@{#28574}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1154483002 Cr-Commit-Position: refs/heads/master@{#28573}
-
- 21 May, 2015 1 commit
-
-
jarin authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1148133002 Cr-Commit-Position: refs/heads/master@{#28536}
-
- 19 May, 2015 1 commit
-
-
titzer authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/1133113004 Cr-Commit-Position: refs/heads/master@{#28465}
-
- 13 May, 2015 2 commits
-
-
bmeurer authored
This was already done for other binary operations, so it's basically copying the existing functionality to shift left and shift right logical/arithmetic. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1140883003 Cr-Commit-Position: refs/heads/master@{#28389}
-
bmeurer authored
Use these check points to optimize comparisons where we already know that one side cannot be a String (or turn into a string via ToPrimitive). Also remove bunch of useless DoNotCrash tests for the scheduler that are painful to maintain and add almost no value. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1140583004 Cr-Commit-Position: refs/heads/master@{#28383}
-
- 11 May, 2015 1 commit
-
-
danno authored
This stub will be used as the basis of a Math.floor-specific CallIC to detect and track calls to floor that return -0. Along the way: - Create a TurboFanCodeStub super class from which the StringLength and MathRound TF stubs derive. - Fix the ugly hack that passes the first stub parameter as the "this" pointer in the the TF-compiled JS function. - Fix bugs in the ia32/x64 disassembler. Review URL: https://codereview.chromium.org/1137703002 Cr-Commit-Position: refs/heads/master@{#28339}
-
- 05 May, 2015 1 commit
-
-
yangguo authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1127693006 Cr-Commit-Position: refs/heads/master@{#28217}
-
- 04 May, 2015 2 commits
-
-
machenbach authored
Revert of Reland "Wrap v8natives.js into a function." (patchset #2 id:20001 of https://codereview.chromium.org/1123703002/) Reason for revert: [Sheriff] Speculative revert for braking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 (reverted already titzer's CL which didn't help) Original issue's description: > Reland "Wrap v8natives.js into a function." > > Committed: https://crrev.com/72ab42172979b60a1b784ea0c6a495d7ee2bba67 > Cr-Commit-Position: refs/heads/master@{#28193} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1127543003 Cr-Commit-Position: refs/heads/master@{#28208}
-
yangguo authored
Review URL: https://codereview.chromium.org/1123703002 Cr-Commit-Position: refs/heads/master@{#28193}
-
- 30 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Wrap v8natives.js into a function. (patchset #2 id:20001 of https://codereview.chromium.org/1109343004/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2682 See. e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/3130/layout-test-results/http/tests/websocket/workers/worker-reload-diff.txt Original issue's description: > Wrap v8natives.js into a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/ee1b39b4303829e6c6805fe8b2f2602b13f6463a > Cr-Commit-Position: refs/heads/master@{#28174} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1121453003 Cr-Commit-Position: refs/heads/master@{#28182}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1109343004 Cr-Commit-Position: refs/heads/master@{#28174}
-
- 28 Apr, 2015 1 commit
-
-
yangguo authored
The goal is to port all of error stack trace formatting to C++. We will do this bottom up, by first porting helper functions. Eventually, CallSite methods will only be used when a custom error stack trace formatter is defined via Error.prepareStackTrace. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1060583008 Cr-Commit-Position: refs/heads/master@{#28095}
-
- 27 Apr, 2015 4 commits
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1110503002 Cr-Commit-Position: refs/heads/master@{#28073}
-
machenbach authored
Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. (patchset #10 id:180001 of https://codereview.chromium.org/1063513003/) Reason for revert: [sheriff] Breaks nosnap debug: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/156 Original issue's description: > [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. > > Uses lazy deoptimization and code dependencies to introduce loads > from property cells and also to promote globals to constants. > > R=mstarzinger@chromium.org > BUG= > > Committed: https://crrev.com/aae4a62d07e839455b1d0ad4fa512cc5d48a1a68 > Cr-Commit-Position: refs/heads/master@{#28057} TBR=mstarzinger@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1084533003 Cr-Commit-Position: refs/heads/master@{#28063}
-
titzer authored
Uses lazy deoptimization and code dependencies to introduce loads from property cells and also to promote globals to constants. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1063513003 Cr-Commit-Position: refs/heads/master@{#28057}
-
jarin authored
BUG= Review URL: https://codereview.chromium.org/1095203005 Cr-Commit-Position: refs/heads/master@{#28055}
-
- 22 Apr, 2015 1 commit
-
-
titzer authored
R=jarin@chromium.org,mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1100113002 Cr-Commit-Position: refs/heads/master@{#28013}
-
- 21 Apr, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1095313002 Cr-Commit-Position: refs/heads/master@{#27972}
-
- 14 Apr, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/1086923002 Cr-Commit-Position: refs/heads/master@{#27822}
-