- 08 Jul, 2019 1 commit
-
-
Irina Yatsenko authored
The current integration of crash keys into v8 got the dependencies wrong: it introduced into v8 a dependency on components and base. This change will allow moving the implementation into "gin" (via Platform's abstraction), which is ok to depend on components and base, while providing the default noop implementation for the embedders that don't care to collect crash keys. Gin's side: https://chromium-review.googlesource.com/c/chromium/src/+/1690003. Bug: v8:9323 Change-Id: I7b6e3e2cdc4b5f14f61ad20d2c362344d53896c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1689834 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62579}
-
- 27 Jun, 2019 1 commit
-
-
Sigurd Schneider authored
The macro pn ensures that TurboFan nodes can be easily printed in gdb, even in release builds where Node::Print is sometimes not available (because all uses have been inlined). This CL also modifies the print function to deal gracefully with nullptr input nodes, which is helpful for debugging. Change-Id: Ib5f58aa13b719c8390826bc89dfe21cf58586de5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672941Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62422}
-
- 21 Jun, 2019 1 commit
-
-
Irina Yatsenko authored
This is a reland of 02103b27 Fix for the original build break: build android with noop crashkeys for now Original change's description: > Add Crash Keys support > > This adds crash keys containing the isolate address and addresses of > the read_only, map, and code spaces to crash report minidumps. > When not compiling V8 with Chrome, a noop implementation is used. > > Bug: v8:9323 > Change-Id: I8523630e7a4ff792855163c06bf76dab35b1b9e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1641326 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#62059} Bug: v8:9323 Change-Id: I6bb115ad14b2ce5865f4d8fb255245c38fb0cd14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658505 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62320}
-
- 11 Jun, 2019 1 commit
-
-
Maya Lekova authored
This reverts commit 02103b27. Reason for revert: Speculative revert for breakage on roll: https://chromium-review.googlesource.com/c/chromium/src/+/1650264 Failing build in breakpad: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/298512 Original change's description: > Add Crash Keys support > > This adds crash keys containing the isolate address and addresses of > the read_only, map, and code spaces to crash report minidumps. > When not compiling V8 with Chrome, a noop implementation is used. > > Bug: v8:9323 > Change-Id: I8523630e7a4ff792855163c06bf76dab35b1b9e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1641326 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#62059} TBR=jkummerow@chromium.org,tmrts@chromium.org,irinayat@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9323 Change-Id: I29138292dd474cf60e2bf3cc9b0629a085abd31c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649787Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#62077}
-
- 07 Jun, 2019 1 commit
-
-
Irina Yatsenko authored
This adds crash keys containing the isolate address and addresses of the read_only, map, and code spaces to crash report minidumps. When not compiling V8 with Chrome, a noop implementation is used. Bug: v8:9323 Change-Id: I8523630e7a4ff792855163c06bf76dab35b1b9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1641326Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62059}
-