Skip to content

V
V8
Switch branch/tag
  1. 29 Jan, 2016 1 commit
    • jkummerow's avatar
      Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS · f4872f74
      jkummerow authored 
      String wrappers (new String("foo")) are special objects: their string
characters are accessed like elements, and they also have an elements
backing store. This used to require a bunch of explicit checks like:

if (obj->IsJSValue() && JSValue::cast(obj)->value()->IsString()) {
  /* Handle string characters */
}
// Handle regular elements (for string wrappers and other objects)
obj->GetElementsAccessor()->Whatever(...);

This CL introduces new ElementsKinds for string wrapper objects (one for
fast elements, one for dictionary elements), which allow folding the
special-casing into new StringWrapperElementsAccessors.

No observable change in behavior is intended.

Review URL: https://codereview.chromium.org/1612323003

Cr-Commit-Position: refs/heads/master@{#33616}
      f4872f74
  3. 30 Sep, 2015 1 commit
  5. 07 Sep, 2015 1 commit
  7. 31 Aug, 2015 1 commit
  9. 28 Jul, 2015 1 commit
  11. 27 Jul, 2015 2 commits
  13. 23 Jul, 2015 1 commit
  15. 02 Jul, 2015 1 commit
  17. 22 Sep, 2014 1 commit
  19. 04 Aug, 2014 1 commit
  21. 30 Jul, 2014 1 commit
  23. 18 Jul, 2014 1 commit
  25. 07 Jul, 2014 1 commit
  27. 30 Jun, 2014 1 commit
  29. 03 Jun, 2014 1 commit
  31. 22 May, 2014 1 commit
  33. 29 Apr, 2014 1 commit
  35. 26 Mar, 2014 1 commit
  37. 25 Mar, 2014 4 commits
  39. 11 Mar, 2014 1 commit
  41. 24 Jan, 2014 1 commit
  43. 16 Jan, 2014 5 commits
  45. 15 Nov, 2013 1 commit
  47. 14 Nov, 2013 1 commit
    • mvstanton@chromium.org's avatar
      Inline zero argument array constructor. · 3cf157b4
      mvstanton@chromium.org authored 
      patch from issue 54583003 (dependent code).

Zero arguments - very easy

1 argument - three special cases:
  a) If length is a constant in valid array length range,
     no need to check it at runtime.
  b) respect DoNotInline feedback on the AllocationSite for
     cases that the argument is not a smi or is an integer
     with a length that should create a dictionary.
  c) if kind feedback is non-holey, and length is non-constant,
     we'd have to generate a lot of code to be correct.
     Don't inline this case.

N arguments - one special case:
  a) If a deopt ever occurs because an input argument isn't
     compatible with the elements kind, then set the
     DoNotInline flag.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/55933002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17741 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3cf157b4
  49. 15 Jul, 2013 1 commit
  51. 11 Jul, 2013 1 commit
  53. 28 Mar, 2013 1 commit
  55. 02 Nov, 2012 1 commit
  57. 08 Jun, 2012 1 commit
  59. 25 May, 2012 1 commit
  61. 23 May, 2012 1 commit